From: David Daney <ddaney@caviumnetworks.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: "Steven J. Hill" <steven.hill@cavium.com>,
linux-mmc <linux-mmc@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
linux-mips@linux-mips.org, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH V8 2/2] mmc: OCTEON: Add host driver for OCTEON MMC controller.
Date: Tue, 23 Aug 2016 12:59:35 -0700 [thread overview]
Message-ID: <57BCAB27.8060502@caviumnetworks.com> (raw)
In-Reply-To: <CAPDyKFp047jKEZngegTxk1grvwPivqj+tqAX1ekF82s1zDE53Q@mail.gmail.com>
On 08/23/2016 12:46 PM, Ulf Hansson wrote:
> On 23 August 2016 at 19:41, David Daney <ddaney@caviumnetworks.com> wrote:
>> On 08/23/2016 07:53 AM, Ulf Hansson wrote:
>>>
>>> On 12 July 2016 at 20:18, Steven J. Hill <steven.hill@cavium.com> wrote:
>>
>> [...]
>>
>>>> +#include <asm/byteorder.h>
>>>> +#include <asm/octeon/octeon.h>
>>>
>>>
>>
>> OK, we will duplicate any needed definitions from octeon.h into the driver
>> source file.
>
> Why can't you share it via a platfrom data header at
> include/linux/platform_data/* ?
>
It isn't "platform_data", it is register layout definitions (thousands
of lines of them), so I don't think it it appropriate to place in
include/linux.
I think the cleanest approach is to put the register definitions in the
driver file, which is the only user, and delete the definition header
files in arch/mips/include/...
David.
WARNING: multiple messages have this Message-ID (diff)
From: David Daney <ddaney@caviumnetworks.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: "Steven J. Hill" <steven.hill@cavium.com>,
linux-mmc <linux-mmc@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
<linux-mips@linux-mips.org>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH V8 2/2] mmc: OCTEON: Add host driver for OCTEON MMC controller.
Date: Tue, 23 Aug 2016 12:59:35 -0700 [thread overview]
Message-ID: <57BCAB27.8060502@caviumnetworks.com> (raw)
In-Reply-To: <CAPDyKFp047jKEZngegTxk1grvwPivqj+tqAX1ekF82s1zDE53Q@mail.gmail.com>
On 08/23/2016 12:46 PM, Ulf Hansson wrote:
> On 23 August 2016 at 19:41, David Daney <ddaney@caviumnetworks.com> wrote:
>> On 08/23/2016 07:53 AM, Ulf Hansson wrote:
>>>
>>> On 12 July 2016 at 20:18, Steven J. Hill <steven.hill@cavium.com> wrote:
>>
>> [...]
>>
>>>> +#include <asm/byteorder.h>
>>>> +#include <asm/octeon/octeon.h>
>>>
>>>
>>
>> OK, we will duplicate any needed definitions from octeon.h into the driver
>> source file.
>
> Why can't you share it via a platfrom data header at
> include/linux/platform_data/* ?
>
It isn't "platform_data", it is register layout definitions (thousands
of lines of them), so I don't think it it appropriate to place in
include/linux.
I think the cleanest approach is to put the register definitions in the
driver file, which is the only user, and delete the definition header
files in arch/mips/include/...
David.
next prev parent reply other threads:[~2016-08-23 19:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-12 18:18 [PATCH V8 2/2] mmc: OCTEON: Add host driver for OCTEON MMC controller Steven J. Hill
2016-07-19 18:31 ` Steven J. Hill
2016-07-19 18:31 ` Steven J. Hill
2016-07-19 21:19 ` Ulf Hansson
2016-07-21 13:46 ` Ralf Baechle
2016-08-23 14:56 ` Ulf Hansson
2016-08-12 5:41 ` Steven J. Hill
2016-08-22 14:05 ` Ulf Hansson
2016-08-23 14:53 ` Ulf Hansson
2016-08-23 17:41 ` David Daney
2016-08-23 17:41 ` David Daney
[not found] ` <57BC8ACA.1040506-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org>
2016-08-23 19:46 ` Ulf Hansson
2016-08-23 19:46 ` Ulf Hansson
2016-08-23 19:59 ` David Daney [this message]
2016-08-23 19:59 ` David Daney
2016-08-24 7:32 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57BCAB27.8060502@caviumnetworks.com \
--to=ddaney@caviumnetworks.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=ralf@linux-mips.org \
--cc=robh+dt@kernel.org \
--cc=steven.hill@cavium.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.