All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Steven J. Hill" <Steven.Hill@cavium.com>
To: Aaro Koskinen <aaro.koskinen@iki.fi>,
	David Daney <ddaney@caviumnetworks.com>,
	Jon Hunter <jonathanh@nvidia.com>, Rob Herring <robh@kernel.org>
Cc: <devicetree@vger.kernel.org>, <linux-mips@linux-mips.org>,
	<linux-kernel@vger.kernel.org>,
	Thorsten Leemhuis <regressions@leemhuis.info>
Subject: Re: [BISECTED REGRESSION] v4.8-rc: gpio-leds broken on OCTEON
Date: Wed, 24 Aug 2016 11:42:00 -0500	[thread overview]
Message-ID: <57BDCE58.20200@cavium.com> (raw)
In-Reply-To: <20160823203605.GA12169@raspberrypi.musicnaut.iki.fi>

On 08/23/2016 03:36 PM, Aaro Koskinen wrote:
> Hi,
>
> gpio-leds fails to probe on OCTEON with v4.8-rc3 and when using
> arch/mips/boot/dts/cavium-octeon/dlink_dsr-1000n.dts. Leds still
> worked with v4.7.
>
> I bisected this to:
>
> 	commit 15cc2ed6dcf91a8658e084be4e140147161819d7
> 	Author: Jon Hunter <jonathanh@nvidia.com>
> 	Date:   Mon Jun 20 14:49:18 2016 +0100
>
> 	of/irq: Mark initialised interrupt controllers as populated
>
> I have no idea how this is related to gpio-leds, except that on OCTEON
> DTBs the gpio node is also interrupt controller...
>
Hey Aaro.

It is actually two patches that cause the breakage. The other is:

    commit e55aeb6ba4e8cc3549bff1e75ea1d029324bce21
    of/irq: Mark interrupt controllers as populated before initialisation

I needed to revert both of these in order to get MMC working on our 71xx 
and 78xx boards. For our MMC, I got error messages from the MMC core of 
"Invalid POWER GPIO" until I applied the second patch. I will have a fix 
worthy of upstreaming today which will be posted today.

Steve

WARNING: multiple messages have this Message-ID (diff)
From: "Steven J. Hill" <Steven.Hill@cavium.com>
To: Aaro Koskinen <aaro.koskinen@iki.fi>,
	David Daney <ddaney@caviumnetworks.com>,
	Jon Hunter <jonathanh@nvidia.com>, Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org, linux-mips@linux-mips.org,
	linux-kernel@vger.kernel.org,
	Thorsten Leemhuis <regressions@leemhuis.info>
Subject: Re: [BISECTED REGRESSION] v4.8-rc: gpio-leds broken on OCTEON
Date: Wed, 24 Aug 2016 11:42:00 -0500	[thread overview]
Message-ID: <57BDCE58.20200@cavium.com> (raw)
In-Reply-To: <20160823203605.GA12169@raspberrypi.musicnaut.iki.fi>

On 08/23/2016 03:36 PM, Aaro Koskinen wrote:
> Hi,
>
> gpio-leds fails to probe on OCTEON with v4.8-rc3 and when using
> arch/mips/boot/dts/cavium-octeon/dlink_dsr-1000n.dts. Leds still
> worked with v4.7.
>
> I bisected this to:
>
> 	commit 15cc2ed6dcf91a8658e084be4e140147161819d7
> 	Author: Jon Hunter <jonathanh@nvidia.com>
> 	Date:   Mon Jun 20 14:49:18 2016 +0100
>
> 	of/irq: Mark initialised interrupt controllers as populated
>
> I have no idea how this is related to gpio-leds, except that on OCTEON
> DTBs the gpio node is also interrupt controller...
>
Hey Aaro.

It is actually two patches that cause the breakage. The other is:

    commit e55aeb6ba4e8cc3549bff1e75ea1d029324bce21
    of/irq: Mark interrupt controllers as populated before initialisation

I needed to revert both of these in order to get MMC working on our 71xx 
and 78xx boards. For our MMC, I got error messages from the MMC core of 
"Invalid POWER GPIO" until I applied the second patch. I will have a fix 
worthy of upstreaming today which will be posted today.

Steve

  reply	other threads:[~2016-08-24 20:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-23 20:36 [BISECTED REGRESSION] v4.8-rc: gpio-leds broken on OCTEON Aaro Koskinen
2016-08-24 16:42 ` Steven J. Hill [this message]
2016-08-24 16:42   ` Steven J. Hill
2016-08-25 18:24   ` Aaro Koskinen
2016-09-11 12:41     ` Thorsten Leemhuis
2016-09-11 22:13       ` Aaro Koskinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57BDCE58.20200@cavium.com \
    --to=steven.hill@cavium.com \
    --cc=aaro.koskinen@iki.fi \
    --cc=ddaney@caviumnetworks.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jonathanh@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=regressions@leemhuis.info \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.