[PATCH 0/1] bash: fix interpreter of ptest script

[PATCH 0/1] bash: fix interpreter of ptest script

[kai.kang]

From: Kai Kang <kai.kang@windriver.com>

The following changes since commit 94646f4828c2aa11a89996763edaa2e9d57106a9:

  oeqa/buildiptables: Switch from netfilter.org to yoctoproject.org mirror (2016-08-23 17:59:43 +0100)

are available in the git repository at:

  git://git.pokylinux.org/poky-contrib kangkai/bash
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=kangkai/bash

Kai Kang (1):
  bash: fix interpreter of ptest script

 meta/recipes-extended/bash/bash.inc | 2 ++
 1 file changed, 2 insertions(+)

-- 
2.9.3

[PATCH 1/1] bash: fix interpreter of ptest script

[kai.kang]

From: Kai Kang <kai.kang@windriver.com>

The interpreter of bash ptest script tests/getopts5.sub is
/local/bin/bash which is not suitable for oe. Use /bin/bash instead.

Signed-off-by: Kai Kang <kai.kang@windriver.com>
---
 meta/recipes-extended/bash/bash.inc | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/recipes-extended/bash/bash.inc b/meta/recipes-extended/bash/bash.inc
index 1d08526..d299a4a 100644
--- a/meta/recipes-extended/bash/bash.inc
+++ b/meta/recipes-extended/bash/bash.inc
@@ -54,6 +54,8 @@ do_install_ptest () {
 	cp ${B}/Makefile ${D}${PTEST_PATH}
         sed -i -e 's/^Makefile/_Makefile/' -e "s,--sysroot=${STAGING_DIR_TARGET},,g" \
 	    -e "s,${S},,g" -e "s,${B},,g" -e "s,${STAGING_DIR_NATIVE},,g" ${D}${PTEST_PATH}/Makefile
+
+	sed -i -e 's:/local\(/bin/bash\):\1:' ${D}${PTEST_PATH}/tests/getopts5.sub
 }
 
 pkg_postinst_${PN} () {
-- 
2.9.3

Re: [PATCH 1/1] bash: fix interpreter of ptest script

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 300 bytes --]

On 24 August 2016 at 10:26, <kai.kang@windriver.com> wrote:

> The interpreter of bash ptest script tests/getopts5.sub is
> /local/bin/bash which is not suitable for oe. Use /bin/bash instead.
>

Presumably this test is executed under bash explicitly, so is this really
worth fixing?

Ross

[-- Attachment #2: Type: text/html, Size: 711 bytes --]

Re: [PATCH 1/1] bash: fix interpreter of ptest script

[Kang Kai]

[-- Attachment #1: Type: text/plain, Size: 554 bytes --]

On 2016年08月25日 04:17, Burton, Ross wrote:
>
> On 24 August 2016 at 10:26, <kai.kang@windriver.com 
> <mailto:kai.kang@windriver.com>> wrote:
>
>     The interpreter of bash ptest script tests/getopts5.sub is
>     /local/bin/bash which is not suitable for oe. Use /bin/bash instead.
>
>
> Presumably this test is executed under bash explicitly, so is this 
> really worth fixing?

I sent the patch to bash maillist and it is not accepted too.
So please ignore it. Thanks.


--Kai

>
> Ross


-- 
Regards,
Neil | Kai Kang


[-- Attachment #2: Type: text/html, Size: 1931 bytes --]