* [PATCH][RESEND] pps: kc: fix non-tickless system config dependency
@ 2016-09-21 16:38 Maciej S. Szmigiero
2016-09-21 16:54 ` Rodolfo Giometti
0 siblings, 1 reply; 3+ messages in thread
From: Maciej S. Szmigiero @ 2016-09-21 16:38 UTC (permalink / raw)
To: Rodolfo Giometti; +Cc: linux-kernel, Alexander Gordeev, Andrew Morton
CONFIG_NO_HZ currently only sets the default value
of dynticks config so if PPS kernel consumer needs
periodic timer ticks it should depend on
!CONFIG_NO_HZ_COMMON instead of !CONFIG_NO_HZ.
Otherwise it is possible to enable it even on
tickless system which has CONFIG_NO_HZ not set and
CONFIG_NO_HZ_IDLE (or CONFIG_NO_HZ_FULL) set.
Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
---
This is a resend without functional changes since previous
submission and resubmission weren't picked up.
@Rodolfo: Could you ack this, please?
drivers/pps/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pps/Kconfig b/drivers/pps/Kconfig
index 7512e98e9311..564a51abeece 100644
--- a/drivers/pps/Kconfig
+++ b/drivers/pps/Kconfig
@@ -31,7 +31,7 @@ config PPS_DEBUG
config NTP_PPS
bool "PPS kernel consumer support"
- depends on !NO_HZ
+ depends on !NO_HZ_COMMON
help
This option adds support for direct in-kernel time
synchronization using an external PPS signal.
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH][RESEND] pps: kc: fix non-tickless system config dependency
2016-09-21 16:38 [PATCH][RESEND] pps: kc: fix non-tickless system config dependency Maciej S. Szmigiero
@ 2016-09-21 16:54 ` Rodolfo Giometti
0 siblings, 0 replies; 3+ messages in thread
From: Rodolfo Giometti @ 2016-09-21 16:54 UTC (permalink / raw)
To: Maciej S. Szmigiero; +Cc: linux-kernel, Alexander Gordeev, Andrew Morton
On 09/21/16 18:38, Maciej S. Szmigiero wrote:
> CONFIG_NO_HZ currently only sets the default value
> of dynticks config so if PPS kernel consumer needs
> periodic timer ticks it should depend on
> !CONFIG_NO_HZ_COMMON instead of !CONFIG_NO_HZ.
>
> Otherwise it is possible to enable it even on
> tickless system which has CONFIG_NO_HZ not set and
> CONFIG_NO_HZ_IDLE (or CONFIG_NO_HZ_FULL) set.
>
> Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
> ---
> This is a resend without functional changes since previous
> submission and resubmission weren't picked up.
>
> @Rodolfo: Could you ack this, please?
Acked-by: Rodolfo Giometti <giometti@enneenne.com>
--
HCE Engineering e-mail: giometti@hce-engineering.com
GNU/Linux Solutions giometti@enneenne.com
Linux Device Driver giometti@linux.it
Embedded Systems phone: +39 349 2432127
UNIX programming skype: rodolfo.giometti
Cosino Project - the quick prototyping embedded system - www.cosino.io
Freelance ICT Italia - Consulente ICT Italia - www.consulenti-ict.it
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH][RESEND] pps: kc: fix non-tickless system config dependency
@ 2016-07-02 20:30 Maciej S. Szmigiero
0 siblings, 0 replies; 3+ messages in thread
From: Maciej S. Szmigiero @ 2016-07-02 20:30 UTC (permalink / raw)
To: Rodolfo Giometti; +Cc: linux-kernel, Alexander Gordeev, Andrew Morton
CONFIG_NO_HZ currently only sets the default value
of dynticks config so if PPS kernel consumer needs
periodic timer ticks it should depend on
!CONFIG_NO_HZ_COMMON instead of !CONFIG_NO_HZ.
Otherwise it is possible to enable it even on
tickless system which has CONFIG_NO_HZ not set and
CONFIG_NO_HZ_IDLE (or CONFIG_NO_HZ_FULL) set.
Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
---
This is a resend without functional changes since previous
submission wasn't picked up.
drivers/pps/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pps/Kconfig b/drivers/pps/Kconfig
index 7512e98e9311..564a51abeece 100644
--- a/drivers/pps/Kconfig
+++ b/drivers/pps/Kconfig
@@ -31,7 +31,7 @@ config PPS_DEBUG
config NTP_PPS
bool "PPS kernel consumer support"
- depends on !NO_HZ
+ depends on !NO_HZ_COMMON
help
This option adds support for direct in-kernel time
synchronization using an external PPS signal.
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-21 17:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-21 16:38 [PATCH][RESEND] pps: kc: fix non-tickless system config dependency Maciej S. Szmigiero
2016-09-21 16:54 ` Rodolfo Giometti
-- strict thread matches above, loose matches on Subject: below --
2016-07-02 20:30 Maciej S. Szmigiero
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.