All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <marc.zyngier@arm.com>
To: Vladimir Murzin <vladimir.murzin@arm.com>, kvmarm@lists.cs.columbia.edu
Cc: andre.przywara@arm.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 05/10] KVM: arm: vgic: Fix compiler warnings when built for 32-bit
Date: Thu, 22 Sep 2016 11:01:40 +0100	[thread overview]
Message-ID: <57E3AC04.1070101@arm.com> (raw)
In-Reply-To: <1473691764-29424-6-git-send-email-vladimir.murzin@arm.com>

On 12/09/16 15:49, Vladimir Murzin wrote:
> Well, this patch is looking ahead of time, but we'll get following
> compiler warnings as soon as we introduce vgic-v3 to 32-bit world
> 
>   CC      arch/arm/kvm/../../../virt/kvm/arm/vgic/vgic-mmio-v3.o
> arch/arm/kvm/../../../virt/kvm/arm/vgic/vgic-mmio-v3.c: In function 'vgic_mmio_read_v3r_typer':
> arch/arm/kvm/../../../virt/kvm/arm/vgic/vgic-mmio-v3.c:184:35: warning: left shift count >= width of type [-Wshift-count-overflow]
>   value = (mpidr & GENMASK(23, 0)) << 32;
>                                    ^
> In file included from ./include/linux/kernel.h:10:0,
>                  from ./include/asm-generic/bug.h:13,
>                  from ./arch/arm/include/asm/bug.h:59,
>                  from ./include/linux/bug.h:4,
>                  from ./include/linux/io.h:23,
>                  from ./arch/arm/include/asm/arch_gicv3.h:23,
>                  from ./include/linux/irqchip/arm-gic-v3.h:411,
>                  from arch/arm/kvm/../../../virt/kvm/arm/vgic/vgic-mmio-v3.c:14:
> arch/arm/kvm/../../../virt/kvm/arm/vgic/vgic-mmio-v3.c: In function 'vgic_v3_dispatch_sgi':
> ./include/linux/bitops.h:6:24: warning: left shift count >= width of type [-Wshift-count-overflow]
>  #define BIT(nr)   (1UL << (nr))
>                         ^
> arch/arm/kvm/../../../virt/kvm/arm/vgic/vgic-mmio-v3.c:614:20: note: in expansion of macro 'BIT'
>   broadcast = reg & BIT(ICC_SGI1R_IRQ_ROUTING_MODE_BIT);
>                     ^
> Let's fix them now.
> 
> Signed-off-by: Vladimir Murzin <vladimir.murzin@arm.com>
> ---
>  virt/kvm/arm/vgic/vgic-mmio-v3.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Acked-by: Marc Zyngier <marc.zyngier@arm.com>

	M.
-- 
Jazz is not dead. It just smells funny...

WARNING: multiple messages have this Message-ID (diff)
From: marc.zyngier@arm.com (Marc Zyngier)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 05/10] KVM: arm: vgic: Fix compiler warnings when built for 32-bit
Date: Thu, 22 Sep 2016 11:01:40 +0100	[thread overview]
Message-ID: <57E3AC04.1070101@arm.com> (raw)
In-Reply-To: <1473691764-29424-6-git-send-email-vladimir.murzin@arm.com>

On 12/09/16 15:49, Vladimir Murzin wrote:
> Well, this patch is looking ahead of time, but we'll get following
> compiler warnings as soon as we introduce vgic-v3 to 32-bit world
> 
>   CC      arch/arm/kvm/../../../virt/kvm/arm/vgic/vgic-mmio-v3.o
> arch/arm/kvm/../../../virt/kvm/arm/vgic/vgic-mmio-v3.c: In function 'vgic_mmio_read_v3r_typer':
> arch/arm/kvm/../../../virt/kvm/arm/vgic/vgic-mmio-v3.c:184:35: warning: left shift count >= width of type [-Wshift-count-overflow]
>   value = (mpidr & GENMASK(23, 0)) << 32;
>                                    ^
> In file included from ./include/linux/kernel.h:10:0,
>                  from ./include/asm-generic/bug.h:13,
>                  from ./arch/arm/include/asm/bug.h:59,
>                  from ./include/linux/bug.h:4,
>                  from ./include/linux/io.h:23,
>                  from ./arch/arm/include/asm/arch_gicv3.h:23,
>                  from ./include/linux/irqchip/arm-gic-v3.h:411,
>                  from arch/arm/kvm/../../../virt/kvm/arm/vgic/vgic-mmio-v3.c:14:
> arch/arm/kvm/../../../virt/kvm/arm/vgic/vgic-mmio-v3.c: In function 'vgic_v3_dispatch_sgi':
> ./include/linux/bitops.h:6:24: warning: left shift count >= width of type [-Wshift-count-overflow]
>  #define BIT(nr)   (1UL << (nr))
>                         ^
> arch/arm/kvm/../../../virt/kvm/arm/vgic/vgic-mmio-v3.c:614:20: note: in expansion of macro 'BIT'
>   broadcast = reg & BIT(ICC_SGI1R_IRQ_ROUTING_MODE_BIT);
>                     ^
> Let's fix them now.
> 
> Signed-off-by: Vladimir Murzin <vladimir.murzin@arm.com>
> ---
>  virt/kvm/arm/vgic/vgic-mmio-v3.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Acked-by: Marc Zyngier <marc.zyngier@arm.com>

	M.
-- 
Jazz is not dead. It just smells funny...

  parent reply	other threads:[~2016-09-22  9:52 UTC|newest]

Thread overview: 80+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-12 14:49 [PATCH v4 00/10] ARM: KVM: Support for vgic-v3 Vladimir Murzin
2016-09-12 14:49 ` Vladimir Murzin
2016-09-12 14:49 ` [PATCH v4 01/10] arm64: KVM: Use static keys for selecting the GIC backend Vladimir Murzin
2016-09-12 14:49   ` Vladimir Murzin
2016-09-13  8:20   ` Christoffer Dall
2016-09-13  8:20     ` Christoffer Dall
2016-09-13  9:11     ` Marc Zyngier
2016-09-13  9:11       ` Marc Zyngier
2016-09-13  9:22       ` Christoffer Dall
2016-09-13  9:22         ` Christoffer Dall
2016-09-14 15:20         ` Vladimir Murzin
2016-09-14 15:20           ` Vladimir Murzin
2016-09-14 15:47           ` Marc Zyngier
2016-09-14 15:47             ` Marc Zyngier
2016-09-15  9:03           ` Christoffer Dall
2016-09-15  9:03             ` Christoffer Dall
2016-09-22 10:01   ` Marc Zyngier
2016-09-22 10:01     ` Marc Zyngier
2016-09-12 14:49 ` [PATCH v4 02/10] arm64: KVM: Move GIC accessors to arch_gicv3.h Vladimir Murzin
2016-09-12 14:49   ` Vladimir Murzin
2016-09-12 14:49 ` [PATCH v4 03/10] arm64: KVM: Move vgic-v3 save/restore to virt/kvm/arm/hyp Vladimir Murzin
2016-09-12 14:49   ` Vladimir Murzin
2016-09-13  8:51   ` Christoffer Dall
2016-09-13  8:51     ` Christoffer Dall
2016-09-12 14:49 ` [PATCH v4 04/10] KVM: arm64: vgic-its: Introduce config option to guard ITS specific code Vladimir Murzin
2016-09-12 14:49   ` Vladimir Murzin
2016-09-13  8:51   ` Christoffer Dall
2016-09-13  8:51     ` Christoffer Dall
2016-09-12 14:49 ` [PATCH v4 05/10] KVM: arm: vgic: Fix compiler warnings when built for 32-bit Vladimir Murzin
2016-09-12 14:49   ` Vladimir Murzin
2016-09-13  8:51   ` Christoffer Dall
2016-09-13  8:51     ` Christoffer Dall
2016-09-22 10:01   ` Marc Zyngier [this message]
2016-09-22 10:01     ` Marc Zyngier
2016-09-12 14:49 ` [PATCH v4 06/10] KVM: arm: vgic: Support 64-bit data manipulation on 32-bit host systems Vladimir Murzin
2016-09-12 14:49   ` Vladimir Murzin
2016-09-13  8:51   ` Christoffer Dall
2016-09-13  8:51     ` Christoffer Dall
2016-09-22 10:00   ` Marc Zyngier
2016-09-22 10:00     ` Marc Zyngier
2016-09-12 14:49 ` [PATCH v4 07/10] ARM: Introduce MPIDR_LEVEL_SHIFT macro Vladimir Murzin
2016-09-12 14:49   ` Vladimir Murzin
2016-09-13  8:38   ` Christoffer Dall
2016-09-13  8:38     ` Christoffer Dall
2016-09-13  9:04     ` Vladimir Murzin
2016-09-13  9:04       ` Vladimir Murzin
2016-09-13 10:12       ` Marc Zyngier
2016-09-13 10:12         ` Marc Zyngier
2016-09-13 10:32         ` Vladimir Murzin
2016-09-13 10:32           ` Vladimir Murzin
2016-09-13 10:44           ` Marc Zyngier
2016-09-13 10:44             ` Marc Zyngier
2016-09-14 15:21             ` Vladimir Murzin
2016-09-14 15:21               ` Vladimir Murzin
2016-09-14 15:50               ` Marc Zyngier
2016-09-14 15:50                 ` Marc Zyngier
2016-09-22  9:59   ` Marc Zyngier
2016-09-22  9:59     ` Marc Zyngier
2016-09-12 14:49 ` [PATCH v4 08/10] ARM: Move system register accessors to asm/cp15.h Vladimir Murzin
2016-09-12 14:49   ` Vladimir Murzin
2016-09-13  8:52   ` Christoffer Dall
2016-09-13  8:52     ` Christoffer Dall
2016-09-22  9:59   ` Marc Zyngier
2016-09-22  9:59     ` Marc Zyngier
2016-09-12 14:49 ` [PATCH v4 09/10] ARM: gic-v3: Introduce 32-to-64-bit mappings for GICv3 cpu registers Vladimir Murzin
2016-09-12 14:49   ` Vladimir Murzin
2016-09-13  8:52   ` Christoffer Dall
2016-09-13  8:52     ` Christoffer Dall
2016-09-22  9:57   ` Marc Zyngier
2016-09-22  9:57     ` Marc Zyngier
2016-09-12 14:49 ` [PATCH v4 10/10] ARM: KVM: Support vgic-v3 Vladimir Murzin
2016-09-12 14:49   ` Vladimir Murzin
2016-09-13  8:52   ` Christoffer Dall
2016-09-13  8:52     ` Christoffer Dall
2016-09-22  9:58   ` Marc Zyngier
2016-09-22  9:58     ` Marc Zyngier
2016-09-15  9:13 ` [PATCH v4 00/10] ARM: KVM: Support for vgic-v3 Christoffer Dall
2016-09-15  9:13   ` Christoffer Dall
2016-09-15 10:33   ` Vladimir Murzin
2016-09-15 10:33     ` Vladimir Murzin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57E3AC04.1070101@arm.com \
    --to=marc.zyngier@arm.com \
    --cc=andre.przywara@arm.com \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=vladimir.murzin@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.