* [PATCH] x86: replace redundant MTRR MSR definitions
@ 2016-10-10 8:11 Jan Beulich
2016-10-10 8:59 ` Andrew Cooper
0 siblings, 1 reply; 2+ messages in thread
From: Jan Beulich @ 2016-10-10 8:11 UTC (permalink / raw)
To: xen-devel; +Cc: Andrew Cooper
[-- Attachment #1: Type: text/plain, Size: 935 bytes --]
We really should have only one set of #define-s for them.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/arch/x86/e820.c
+++ b/xen/arch/x86/e820.c
@@ -419,8 +419,6 @@ static void __init clip_to_limit(uint64_
}
/* Conservative estimate of top-of-RAM by looking for MTRR WB regions. */
-#define MSR_MTRRphysBase(reg) (0x200 + 2 * (reg))
-#define MSR_MTRRphysMask(reg) (0x200 + 2 * (reg) + 1)
static uint64_t __init mtrr_top_of_ram(void)
{
uint32_t eax, ebx, ecx, edx;
@@ -477,8 +475,8 @@ static uint64_t __init mtrr_top_of_ram(v
top = 0;
for ( i = 0; i < (uint8_t)mtrr_cap; i++ )
{
- rdmsrl(MSR_MTRRphysBase(i), base);
- rdmsrl(MSR_MTRRphysMask(i), mask);
+ rdmsrl(MSR_IA32_MTRR_PHYSBASE(i), base);
+ rdmsrl(MSR_IA32_MTRR_PHYSMASK(i), mask);
if ( e820_verbose )
printk(" MTRR[%d]: base %"PRIx64" mask %"PRIx64"\n",
[-- Attachment #2: x86-e820-MTRR-names.patch --]
[-- Type: text/plain, Size: 976 bytes --]
x86: replace redundant MTRR MSR definitions
We really should have only one set of #define-s for them.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/arch/x86/e820.c
+++ b/xen/arch/x86/e820.c
@@ -419,8 +419,6 @@ static void __init clip_to_limit(uint64_
}
/* Conservative estimate of top-of-RAM by looking for MTRR WB regions. */
-#define MSR_MTRRphysBase(reg) (0x200 + 2 * (reg))
-#define MSR_MTRRphysMask(reg) (0x200 + 2 * (reg) + 1)
static uint64_t __init mtrr_top_of_ram(void)
{
uint32_t eax, ebx, ecx, edx;
@@ -477,8 +475,8 @@ static uint64_t __init mtrr_top_of_ram(v
top = 0;
for ( i = 0; i < (uint8_t)mtrr_cap; i++ )
{
- rdmsrl(MSR_MTRRphysBase(i), base);
- rdmsrl(MSR_MTRRphysMask(i), mask);
+ rdmsrl(MSR_IA32_MTRR_PHYSBASE(i), base);
+ rdmsrl(MSR_IA32_MTRR_PHYSMASK(i), mask);
if ( e820_verbose )
printk(" MTRR[%d]: base %"PRIx64" mask %"PRIx64"\n",
[-- Attachment #3: Type: text/plain, Size: 127 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] x86: replace redundant MTRR MSR definitions
2016-10-10 8:11 [PATCH] x86: replace redundant MTRR MSR definitions Jan Beulich
@ 2016-10-10 8:59 ` Andrew Cooper
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Cooper @ 2016-10-10 8:59 UTC (permalink / raw)
To: Jan Beulich, xen-devel
On 10/10/16 09:11, Jan Beulich wrote:
> We really should have only one set of #define-s for them.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Agreed. Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-10-10 9:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-10 8:11 [PATCH] x86: replace redundant MTRR MSR definitions Jan Beulich
2016-10-10 8:59 ` Andrew Cooper
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.