All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Lin Ma" <lma@suse.com>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org, armbru@redhat.com, pbonzini@redhat.com,
	afaerber@suse.de
Subject: [Qemu-devel] 答复: Re:  [PATCH v3 3/3] object: Add 'help' option for all available backends and properties
Date: Mon, 10 Oct 2016 08:38:40 -0600	[thread overview]
Message-ID: <57FC187002000062000A268D@prv-mh.provo.novell.com> (raw)
In-Reply-To: <20160926104144.GH18393@redhat.com>



>>> "Daniel P. Berrange" <berrange@redhat.com> 2016/9/26 星期一 下午 6:41 >>>
>On Mon, Sep 26, 2016 at 06:16:27PM +0800, Lin Ma wrote:
>> '-object help' prints available user creatable backends.
>> '-object $typename,help' prints relevant properties.
>> 
>> Signed-off-by: Lin Ma <lma@suse.com>
>> ---
>>  backends/hostmem.c   		   |  4 ++++
>>  crypto/secret.c   			  |  4 ++++
>>  crypto/tlscreds.c   		    |  4 ++++
>>  include/qom/object_interfaces.h |  2 ++
>>  net/filter.c   				 |  4 ++++
>>  qemu-options.hx   			  |  7 +++++-
>>  qom/object_interfaces.c   	  | 48 +++++++++++++++++++++++++++++++++++++++++
>>  vl.c   						 |  5 +++++
>>  8 files changed, 77 insertions(+), 1 deletion(-)
>> 
>> diff --git a/backends/hostmem.c b/backends/hostmem.c
>> index b7a208d..eea9dce 100644
>> --- a/backends/hostmem.c
>> +++ b/backends/hostmem.c
>> @@ -261,6 +261,10 @@ static void host_memory_backend_init(Object *obj)
>>							   HostMemPolicy_lookup,
>>							   host_memory_backend_get_policy,
>>							   host_memory_backend_set_policy, NULL);
>> +    object_property_set_description(obj, "policy",
>> +								    "Data format: one of "
>> +								    HostMemPolicy_value_str,
>> +								    &error_abort);
>>  }
>>
>
>Adding descriptions to properties should be done separately from
>your impl of help printing, as they're independant concepts.
>
Sorry for the late reply, I was on vacation.
Ok , I'll seprate them to another patch.
 
Thanks,
Lin

  reply	other threads:[~2016-10-10 14:41 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-26 10:16 [Qemu-devel] [PATCH v3 0/3] object: Add 'help' option for all available backends and properties Lin Ma
2016-09-26 10:16 ` [Qemu-devel] [PATCH v3 1/3] qom: make base type user-creatable abstract Lin Ma
2016-09-26 10:37   ` Daniel P. Berrange
2016-10-10 14:32     ` [Qemu-devel] 答复: " Lin Ma
2016-10-10 14:45       ` Paolo Bonzini
2016-10-10 15:01         ` Daniel P. Berrange
2016-10-10 16:37           ` Paolo Bonzini
2016-09-26 10:16 ` [Qemu-devel] [PATCH v3 2/3] qapi: auto generate enum value strings Lin Ma
2016-09-26 10:38   ` Daniel P. Berrange
2016-09-26 20:17     ` Eric Blake
2016-10-10 15:09       ` [Qemu-devel] 答复: " Lin Ma
2016-10-10 19:00         ` Eric Blake
2016-10-11  6:56           ` Markus Armbruster
2016-10-13 10:02             ` Lin Ma
2016-09-26 10:16 ` [Qemu-devel] [PATCH v3 3/3] object: Add 'help' option for all available backends and properties Lin Ma
2016-09-26 10:41   ` Daniel P. Berrange
2016-10-10 14:38     ` Lin Ma [this message]
2016-09-26 10:34 ` [Qemu-devel] [PATCH v3 0/3] " no-reply
2016-09-26 10:39 ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57FC187002000062000A268D@prv-mh.provo.novell.com \
    --to=lma@suse.com \
    --cc=afaerber@suse.de \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.