From: Paolo Bonzini <pbonzini@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: Lin Ma <lma@suse.com>,
qemu-devel@nongnu.org, armbru@redhat.com, afaerber@suse.de
Subject: Re: [Qemu-devel] 答复： Re: [PATCH v3 1/3] qom: make base type user-creatable abstract
Date: Mon, 10 Oct 2016 18:37:50 +0200 [thread overview]
Message-ID: <cdfc14d2-fbf4-19d6-4a32-008e6d887e64@redhat.com> (raw)
In-Reply-To: <20161010150152.GJ15488@redhat.com>
On 10/10/2016 17:01, Daniel P. Berrange wrote:
> On Mon, Oct 10, 2016 at 04:45:56PM +0200, Paolo Bonzini wrote:
>>
>>
>> On 10/10/2016 16:32, Lin Ma wrote:
>>>> This doesn't make any conceptual sense. UserCreatable is an inteface and
>>>> by definition all interfaces are abstract.
>>>
>>> Sorry for the late reply, I was on vacation.
>>> oh...indeed, add '.abstract = true' for an interface is not a good idea.
>>
>> Perhaps Lin Ma's patch actually made some sense. If all interfaces are
>> abstract, why shouldn't object_class_is_abstract say so?
>
> object_class_is_abstract() should say so, but we should not have to
> express that manually when defining the interface - anything that is
> define as an interface should be automatically abstract
Yes, of course, see my suggestion right after that line. :)
Paolo
next prev parent reply other threads:[~2016-10-10 16:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-26 10:16 [Qemu-devel] [PATCH v3 0/3] object: Add 'help' option for all available backends and properties Lin Ma
2016-09-26 10:16 ` [Qemu-devel] [PATCH v3 1/3] qom: make base type user-creatable abstract Lin Ma
2016-09-26 10:37 ` Daniel P. Berrange
2016-10-10 14:32 ` [Qemu-devel] 答复： " Lin Ma
2016-10-10 14:45 ` Paolo Bonzini
2016-10-10 15:01 ` Daniel P. Berrange
2016-10-10 16:37 ` Paolo Bonzini [this message]
2016-09-26 10:16 ` [Qemu-devel] [PATCH v3 2/3] qapi: auto generate enum value strings Lin Ma
2016-09-26 10:38 ` Daniel P. Berrange
2016-09-26 20:17 ` Eric Blake
2016-10-10 15:09 ` [Qemu-devel] 答复： " Lin Ma
2016-10-10 19:00 ` Eric Blake
2016-10-11 6:56 ` Markus Armbruster
2016-10-13 10:02 ` Lin Ma
2016-09-26 10:16 ` [Qemu-devel] [PATCH v3 3/3] object: Add 'help' option for all available backends and properties Lin Ma
2016-09-26 10:41 ` Daniel P. Berrange
2016-10-10 14:38 ` [Qemu-devel] 答复： " Lin Ma
2016-09-26 10:34 ` [Qemu-devel] [PATCH v3 0/3] " no-reply
2016-09-26 10:39 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cdfc14d2-fbf4-19d6-4a32-008e6d887e64@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=lma@suse.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.