All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: wei.liu2@citrix.com, andrew.cooper3@citrix.com,
	ian.jackson@eu.citrix.com, xen-devel@lists.xen.org,
	julien.grall@arm.com, zhaoshenglong@huawei.com,
	roger.pau@citrix.com
Subject: Re: [PATCH v3 09/19] acpi/hvmloader: Include file/paths adjustments
Date: Thu, 8 Sep 2016 14:29:53 -0400	[thread overview]
Message-ID: <57aba7fd-8dc1-f46a-2c22-29fbf54fef22@oracle.com> (raw)
In-Reply-To: <57D18C38020000780010D2E2@prv-mh.provo.novell.com>

On 09/08/2016 10:05 AM, Jan Beulich wrote:
>>
>> diff --git a/tools/firmware/hvmloader/acpi/libacpi.h 
>> b/tools/firmware/hvmloader/acpi/libacpi.h
>> index 3bcd226..d803139 100644
>> --- a/tools/firmware/hvmloader/acpi/libacpi.h
>> +++ b/tools/firmware/hvmloader/acpi/libacpi.h
>> @@ -84,6 +84,13 @@ struct acpi_config {
>>  
>>      /* RSDP address */
>>      unsigned int rsdp;
>> +
>> +    /* x86-specific parameters */
>> +    uint16_t (*lapic_id)(unsigned cpu);
> Why uint16_t? Legacy APIC IDs in MADT are in an 8-bit field, and
> x2APIC IDs require 32 bits. Depending on whether we want to be
> able to re-use the same function for x2APIC support (once that
> gets added) the return type should change accordingly. (But if we
> were to re-use it, I guess a second parameter would then also be
> needed.)

No good reason for uint16_t, should be uint8_t.

I think deciding on how interface will look for x2APIC should be
deferred until when we support it.

>
> And then - down the road you're not planning to build a shared
> library using this interface? Otherwise we'd need to consider some
> compatibility aspects.

No specific plans for now, the objects are expected to be built and
linked directly to whoever wants to use this (so libacpi is somewhat of
a misnomer, similar to libelf).


-boris


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2016-09-08 18:29 UTC|newest]

Thread overview: 71+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-07 18:59 [PATCH v3 00/19] Make ACPI builder available to components other than hvmloader Boris Ostrovsky
2016-09-07 18:59 ` [PATCH v3 01/19] acpi: Re-license ACPI builder files from GPLv2 to LGPLv2.1 Boris Ostrovsky
2016-09-07 19:48   ` Boris Ostrovsky
2016-09-07 18:59 ` [PATCH v3 02/19] acpi/hvmloader: Collect processor and NUMA info in hvmloader Boris Ostrovsky
2016-09-08 13:41   ` Jan Beulich
2016-09-07 18:59 ` [PATCH v3 03/19] acpi/hvmloader: Set TIS header address " Boris Ostrovsky
2016-09-07 18:59 ` [PATCH v3 04/19] acpi/hvmloader: Make providing IOAPIC in MADT optional Boris Ostrovsky
2016-09-07 18:59 ` [PATCH v3 05/19] acpi/hvmloader: Build WAET optionally Boris Ostrovsky
2016-09-07 18:59 ` [PATCH v3 06/19] acpi/hvmloader: Replace mem_alloc() and virt_to_phys() with memory ops Boris Ostrovsky
2016-09-08 13:54   ` Jan Beulich
2016-09-07 18:59 ` [PATCH v3 07/19] acpi/hvmloader: Translate all addresses when assigning addresses in ACPI tables Boris Ostrovsky
2016-09-07 18:59 ` [PATCH v3 08/19] acpi/hvmloader: Link ACPI object files directly Boris Ostrovsky
2016-09-08 13:56   ` Jan Beulich
2016-09-07 18:59 ` [PATCH v3 09/19] acpi/hvmloader: Include file/paths adjustments Boris Ostrovsky
2016-09-08 14:05   ` Jan Beulich
2016-09-08 18:29     ` Boris Ostrovsky [this message]
2016-09-07 18:59 ` [PATCH v3 10/19] acpi: Move ACPI code to tools/libacpi Boris Ostrovsky
2016-09-07 18:59 ` [PATCH v3 11/19] x86: Allow LAPIC-only emulation_flags for HVM guests Boris Ostrovsky
2016-09-07 18:59 ` [PATCH v3 12/19] libacpi: Build DSDT for PVH guests Boris Ostrovsky
2016-09-08 14:09   ` Jan Beulich
2016-09-14  4:13   ` Shannon Zhao
2016-09-14 12:47     ` Boris Ostrovsky
2016-09-07 18:59 ` [PATCH v3 13/19] acpi: Makefile should better tolerate interrupts Boris Ostrovsky
2016-09-08 14:15   ` Jan Beulich
2016-09-08 18:51     ` Boris Ostrovsky
2016-09-09  8:03       ` Jan Beulich
2016-09-09 13:07         ` Boris Ostrovsky
2016-09-09 13:29           ` Jan Beulich
2016-09-09 13:56             ` Boris Ostrovsky
2016-09-09 14:13               ` Ian Jackson
2016-09-09 14:31                 ` Boris Ostrovsky
2016-09-09 14:33                   ` Ian Jackson
2016-09-09 14:38                     ` Boris Ostrovsky
2016-09-09 15:20               ` Jan Beulich
2016-09-09 16:05                 ` Boris Ostrovsky
2016-09-09 16:11                   ` Jan Beulich
2016-09-07 18:59 ` [PATCH v3 14/19] libxc/libxl: Allow multiple ACPI modules Boris Ostrovsky
2016-09-15 10:13   ` Wei Liu
2016-09-07 18:59 ` [PATCH v3 15/19] libxl/acpi: Add ACPI e820 entry Boris Ostrovsky
2016-09-15 10:13   ` Wei Liu
2016-09-07 18:59 ` [PATCH v3 16/19] libxl/pvhv2: Include APIC page in MMIO hole for PVHv2 guests Boris Ostrovsky
2016-09-15 10:13   ` Wei Liu
2016-09-07 18:59 ` [PATCH v3 17/19] ilibxl: Initialize domain build info before calling libxl__domain_make Boris Ostrovsky
2016-09-15 10:13   ` Wei Liu
2016-09-07 18:59 ` [PATCH v3 18/19] libxl/acpi: Build ACPI tables for HVMlite guests Boris Ostrovsky
2016-09-08 14:20   ` Jan Beulich
2016-09-08 18:53     ` Boris Ostrovsky
2016-09-09  8:05       ` Jan Beulich
2016-09-09 13:11         ` Boris Ostrovsky
2016-09-09 13:50           ` Ian Jackson
2016-09-09 14:02             ` Boris Ostrovsky
2016-09-07 18:59 ` [PATCH v3 19/19] libxc/xc_dom_core: Copy ACPI tables to guest space Boris Ostrovsky
2016-09-15 10:13   ` Wei Liu
2016-09-14 15:21 ` [PATCH v3 00/19] Make ACPI builder available to components other than hvmloader Boris Ostrovsky
2016-09-15 10:18   ` Wei Liu
2016-09-15 10:20     ` Julien Grall
2016-09-15 10:22       ` Wei Liu
2016-09-15 12:39         ` Boris Ostrovsky
2016-09-15 13:48           ` Julien Grall
2016-09-15 14:07             ` Boris Ostrovsky
2016-09-15 14:21               ` Jan Beulich
2016-09-15 15:28                 ` Boris Ostrovsky
2016-09-15 16:05                   ` Jan Beulich
2016-09-15 16:40                     ` Boris Ostrovsky
2016-09-16  6:45                       ` Jan Beulich
2016-09-16 12:41                         ` Boris Ostrovsky
2016-09-16 15:22                           ` Lars Kurth
2016-09-16 15:53                             ` Boris Ostrovsky
2016-09-19 15:30                               ` Ian Jackson
2016-09-19 15:42                                 ` Boris Ostrovsky
2016-09-19 15:49                                   ` Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57aba7fd-8dc1-f46a-2c22-29fbf54fef22@oracle.com \
    --to=boris.ostrovsky@oracle.com \
    --cc=JBeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=julien.grall@arm.com \
    --cc=roger.pau@citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    --cc=zhaoshenglong@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.