Re: [PATCH v3 12/19] libacpi: Build DSDT for PVH guests

From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Shannon Zhao <zhaoshenglong@huawei.com>, xen-devel@lists.xen.org
Cc: wei.liu2@citrix.com, andrew.cooper3@citrix.com,
	ian.jackson@eu.citrix.com, julien.grall@arm.com,
	jbeulich@suse.com, roger.pau@citrix.com
Subject: Re: [PATCH v3 12/19] libacpi: Build DSDT for PVH guests
Date: Wed, 14 Sep 2016 08:47:57 -0400	[thread overview]
Message-ID: <d35d7daf-010d-c87e-bd7e-9e447a8abbf1@oracle.com> (raw)
In-Reply-To: <57D8CE73.20501@huawei.com>

On 09/14/2016 12:13 AM, Shannon Zhao wrote:
>
> On 2016/9/8 2:59, Boris Ostrovsky wrote:
>> PVH guests require DSDT with only ACPI INFO (Xen-specific) and Processor
>> objects. We separate ASL's ACPI INFO definition into dsdt_acpi_info.asl so
>> that it can be included in ASLs for both HVM and PVH2.
>>
>> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
>> ---
>> Changes in v3:
>> * Added comment to dsdt_acpi_info.asl indicating that the structure
>>   there must match struct acpi_info
>> * Use QEMU_NONE in mk_dsdt.c
>> * Makefile tweaks
>>
>>  tools/libacpi/Makefile           | 13 ++++++++++---
>>  tools/libacpi/dsdt.asl           | 20 --------------------
>>  tools/libacpi/dsdt_acpi_info.asl | 26 ++++++++++++++++++++++++++
>>  tools/libacpi/mk_dsdt.c          |  8 ++++++++
>>  4 files changed, 44 insertions(+), 23 deletions(-)
>>  create mode 100644 tools/libacpi/dsdt_acpi_info.asl
>>
>> diff --git a/tools/libacpi/Makefile b/tools/libacpi/Makefile
>> index 6325cd0..12b081e 100644
>> --- a/tools/libacpi/Makefile
>> +++ b/tools/libacpi/Makefile
>> @@ -18,7 +18,7 @@ include $(XEN_ROOT)/tools/firmware/Rules.mk
>>  MK_DSDT = $(ACPI_BUILD_DIR)/mk_dsdt
>>  
>>  # Sources to be generated
>> -C_SRC = $(addprefix $(ACPI_BUILD_DIR)/, dsdt_anycpu.c dsdt_15cpu.c  dsdt_anycpu_qemu_xen.c)
>> +C_SRC = $(addprefix $(ACPI_BUILD_DIR)/, dsdt_anycpu.c dsdt_15cpu.c  dsdt_anycpu_qemu_xen.c dsdt_pvh.c)
>>  H_SRC = $(addprefix $(ACPI_BUILD_DIR)/, ssdt_s3.h ssdt_s4.h ssdt_pm.h ssdt_tpm.h)
>>  
> Hi Bros,
>
> It looks like you forgot to add 'C_SRC-$(CONFIG_X86)' here. Will you add
> it in your next version?

I know I said that I'd do it but then I realized that it would probably
make more sense to add this macro when a non-x86 target is first
introduced (which I believe is patch 3 in your series). It's a one-line
change IIRC so it shouldn't be too disruptive to your series.

I should have mentioned it when I posted v3 of my patches, I apologize
for forgetting it.

-boris

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel