* [PATCH] raw-format: drop WRITE and RESIZE child perms when possible
@ 2021-07-26 12:28 Stefan Hajnoczi
2021-07-26 14:41 ` Vladimir Sementsov-Ogievskiy
2021-08-19 13:37 ` Hanna Reitz
0 siblings, 2 replies; 5+ messages in thread
From: Stefan Hajnoczi @ 2021-07-26 12:28 UTC (permalink / raw)
To: qemu-devel
Cc: Kevin Wolf, qemu-block, afrosi, Max Reitz, Stefan Hajnoczi,
Philippe Mathieu-Daudé
The following command-line fails due to a permissions conflict:
$ qemu-storage-daemon \
--blockdev driver=nvme,node-name=nvme0,device=0000:08:00.0,namespace=1 \
--blockdev driver=raw,node-name=l1-1,file=nvme0,offset=0,size=1073741824 \
--blockdev driver=raw,node-name=l1-2,file=nvme0,offset=1073741824,size=1073741824 \
--nbd-server addr.type=unix,addr.path=/tmp/nbd.sock,max-connections=2 \
--export type=nbd,id=nbd-l1-1,node-name=l1-1,name=l1-1,writable=on \
--export type=nbd,id=nbd-l1-2,node-name=l1-2,name=l1-2,writable=on
qemu-storage-daemon: --export type=nbd,id=nbd-l1-1,node-name=l1-1,name=l1-1,writable=on: Permission conflict on node 'nvme0': permissions 'resize' are both required by node 'l1-1' (uses node 'nvme0' as 'file' child) and unshared by node 'l1-2' (uses node 'nvme0' as 'file' child).
The problem is that block/raw-format.c relies on bdrv_default_perms() to
set permissions on the nvme node. The default permissions add RESIZE in
anticipation of a format driver like qcow2 that needs to grow the image
file. This fails because RESIZE is unshared, so we cannot get the RESIZE
permission.
Max Reitz pointed out that block/crypto.c already handles this case by
implementing a custom ->bdrv_child_perm() function that adjusts the
result of bdrv_default_perms().
This patch takes the same approach in block/raw-format.c so that RESIZE
is only required if it's actually necessary (e.g. the parent is qcow2).
Cc: Max Reitz <mreitz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
This is not a bug fix, so I didn't mark it for QEMU 6.1. It's new
behavior that hasn't been supported before. I want to split an NVMe
drive using the raw format's offset=/size= feature.
---
block/raw-format.c | 21 ++++++++++++++++++++-
1 file changed, 20 insertions(+), 1 deletion(-)
diff --git a/block/raw-format.c b/block/raw-format.c
index 7717578ed6..c26f493688 100644
--- a/block/raw-format.c
+++ b/block/raw-format.c
@@ -580,6 +580,25 @@ static void raw_cancel_in_flight(BlockDriverState *bs)
bdrv_cancel_in_flight(bs->file->bs);
}
+static void raw_child_perm(BlockDriverState *bs, BdrvChild *c,
+ BdrvChildRole role,
+ BlockReopenQueue *reopen_queue,
+ uint64_t parent_perm, uint64_t parent_shared,
+ uint64_t *nperm, uint64_t *nshared)
+{
+ bdrv_default_perms(bs, c, role, reopen_queue, parent_perm,
+ parent_shared, nperm, nshared);
+
+ /*
+ * bdrv_default_perms() may add WRITE and/or RESIZE (see comment in
+ * bdrv_default_perms_for_storage() for an explanation) but we only need
+ * them if they are in parent_perm. Drop WRITE and RESIZE whenever possible
+ * to avoid permission conflicts.
+ */
+ *nperm &= ~(BLK_PERM_WRITE | BLK_PERM_RESIZE);
+ *nperm |= parent_perm & (BLK_PERM_WRITE | BLK_PERM_RESIZE);
+}
+
BlockDriver bdrv_raw = {
.format_name = "raw",
.instance_size = sizeof(BDRVRawState),
@@ -588,7 +607,7 @@ BlockDriver bdrv_raw = {
.bdrv_reopen_commit = &raw_reopen_commit,
.bdrv_reopen_abort = &raw_reopen_abort,
.bdrv_open = &raw_open,
- .bdrv_child_perm = bdrv_default_perms,
+ .bdrv_child_perm = raw_child_perm,
.bdrv_co_create_opts = &raw_co_create_opts,
.bdrv_co_preadv = &raw_co_preadv,
.bdrv_co_pwritev = &raw_co_pwritev,
--
2.31.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] raw-format: drop WRITE and RESIZE child perms when possible
2021-07-26 12:28 [PATCH] raw-format: drop WRITE and RESIZE child perms when possible Stefan Hajnoczi
@ 2021-07-26 14:41 ` Vladimir Sementsov-Ogievskiy
2021-07-26 15:42 ` Kevin Wolf
2021-08-19 13:37 ` Hanna Reitz
1 sibling, 1 reply; 5+ messages in thread
From: Vladimir Sementsov-Ogievskiy @ 2021-07-26 14:41 UTC (permalink / raw)
To: Stefan Hajnoczi, qemu-devel
Cc: Kevin Wolf, qemu-block, afrosi, Max Reitz, Philippe Mathieu-Daudé
26.07.2021 15:28, Stefan Hajnoczi wrote:
> The following command-line fails due to a permissions conflict:
>
> $ qemu-storage-daemon \
> --blockdev driver=nvme,node-name=nvme0,device=0000:08:00.0,namespace=1 \
> --blockdev driver=raw,node-name=l1-1,file=nvme0,offset=0,size=1073741824 \
> --blockdev driver=raw,node-name=l1-2,file=nvme0,offset=1073741824,size=1073741824 \
> --nbd-server addr.type=unix,addr.path=/tmp/nbd.sock,max-connections=2 \
> --export type=nbd,id=nbd-l1-1,node-name=l1-1,name=l1-1,writable=on \
> --export type=nbd,id=nbd-l1-2,node-name=l1-2,name=l1-2,writable=on
>
> qemu-storage-daemon: --export type=nbd,id=nbd-l1-1,node-name=l1-1,name=l1-1,writable=on: Permission conflict on node 'nvme0': permissions 'resize' are both required by node 'l1-1' (uses node 'nvme0' as 'file' child) and unshared by node 'l1-2' (uses node 'nvme0' as 'file' child).
>
> The problem is that block/raw-format.c relies on bdrv_default_perms() to
> set permissions on the nvme node. The default permissions add RESIZE in
> anticipation of a format driver like qcow2 that needs to grow the image
> file. This fails because RESIZE is unshared, so we cannot get the RESIZE
> permission.
>
> Max Reitz pointed out that block/crypto.c already handles this case by
> implementing a custom ->bdrv_child_perm() function that adjusts the
> result of bdrv_default_perms().
>
> This patch takes the same approach in block/raw-format.c so that RESIZE
> is only required if it's actually necessary (e.g. the parent is qcow2).
>
> Cc: Max Reitz <mreitz@redhat.com>
> Cc: Kevin Wolf <kwolf@redhat.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> This is not a bug fix, so I didn't mark it for QEMU 6.1. It's new
> behavior that hasn't been supported before. I want to split an NVMe
> drive using the raw format's offset=/size= feature.
> ---
> block/raw-format.c | 21 ++++++++++++++++++++-
> 1 file changed, 20 insertions(+), 1 deletion(-)
>
> diff --git a/block/raw-format.c b/block/raw-format.c
> index 7717578ed6..c26f493688 100644
> --- a/block/raw-format.c
> +++ b/block/raw-format.c
> @@ -580,6 +580,25 @@ static void raw_cancel_in_flight(BlockDriverState *bs)
> bdrv_cancel_in_flight(bs->file->bs);
> }
>
> +static void raw_child_perm(BlockDriverState *bs, BdrvChild *c,
> + BdrvChildRole role,
> + BlockReopenQueue *reopen_queue,
> + uint64_t parent_perm, uint64_t parent_shared,
> + uint64_t *nperm, uint64_t *nshared)
> +{
> + bdrv_default_perms(bs, c, role, reopen_queue, parent_perm,
> + parent_shared, nperm, nshared);
> +
> + /*
> + * bdrv_default_perms() may add WRITE and/or RESIZE (see comment in
> + * bdrv_default_perms_for_storage() for an explanation) but we only need
> + * them if they are in parent_perm. Drop WRITE and RESIZE whenever possible
> + * to avoid permission conflicts.
> + */
> + *nperm &= ~(BLK_PERM_WRITE | BLK_PERM_RESIZE);
> + *nperm |= parent_perm & (BLK_PERM_WRITE | BLK_PERM_RESIZE);
> +}
> +
> BlockDriver bdrv_raw = {
> .format_name = "raw",
> .instance_size = sizeof(BDRVRawState),
> @@ -588,7 +607,7 @@ BlockDriver bdrv_raw = {
> .bdrv_reopen_commit = &raw_reopen_commit,
> .bdrv_reopen_abort = &raw_reopen_abort,
> .bdrv_open = &raw_open,
> - .bdrv_child_perm = bdrv_default_perms,
> + .bdrv_child_perm = raw_child_perm,
> .bdrv_co_create_opts = &raw_co_create_opts,
> .bdrv_co_preadv = &raw_co_preadv,
> .bdrv_co_pwritev = &raw_co_pwritev,
>
I think it's OK:
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Still, did you consider an alternative of making bdrv_filter_default_perm() function public and just do ".bdrv_child_perm = bdrv_filter_default_perm," here?
raw_format is not considered to be filter, but for it's permissions I think it works exactly like filter.
--
Best regards,
Vladimir
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] raw-format: drop WRITE and RESIZE child perms when possible
2021-07-26 14:41 ` Vladimir Sementsov-Ogievskiy
@ 2021-07-26 15:42 ` Kevin Wolf
2021-07-26 15:59 ` Stefan Hajnoczi
0 siblings, 1 reply; 5+ messages in thread
From: Kevin Wolf @ 2021-07-26 15:42 UTC (permalink / raw)
To: Vladimir Sementsov-Ogievskiy
Cc: qemu-block, afrosi, qemu-devel, Max Reitz, Stefan Hajnoczi,
Philippe Mathieu-Daudé
Am 26.07.2021 um 16:41 hat Vladimir Sementsov-Ogievskiy geschrieben:
> 26.07.2021 15:28, Stefan Hajnoczi wrote:
> > The following command-line fails due to a permissions conflict:
> >
> > $ qemu-storage-daemon \
> > --blockdev driver=nvme,node-name=nvme0,device=0000:08:00.0,namespace=1 \
> > --blockdev driver=raw,node-name=l1-1,file=nvme0,offset=0,size=1073741824 \
> > --blockdev driver=raw,node-name=l1-2,file=nvme0,offset=1073741824,size=1073741824 \
> > --nbd-server addr.type=unix,addr.path=/tmp/nbd.sock,max-connections=2 \
> > --export type=nbd,id=nbd-l1-1,node-name=l1-1,name=l1-1,writable=on \
> > --export type=nbd,id=nbd-l1-2,node-name=l1-2,name=l1-2,writable=on
> >
> > qemu-storage-daemon: --export type=nbd,id=nbd-l1-1,node-name=l1-1,name=l1-1,writable=on: Permission conflict on node 'nvme0': permissions 'resize' are both required by node 'l1-1' (uses node 'nvme0' as 'file' child) and unshared by node 'l1-2' (uses node 'nvme0' as 'file' child).
> >
> > The problem is that block/raw-format.c relies on bdrv_default_perms() to
> > set permissions on the nvme node. The default permissions add RESIZE in
> > anticipation of a format driver like qcow2 that needs to grow the image
> > file. This fails because RESIZE is unshared, so we cannot get the RESIZE
> > permission.
> >
> > Max Reitz pointed out that block/crypto.c already handles this case by
> > implementing a custom ->bdrv_child_perm() function that adjusts the
> > result of bdrv_default_perms().
> >
> > This patch takes the same approach in block/raw-format.c so that RESIZE
> > is only required if it's actually necessary (e.g. the parent is qcow2).
> >
> > Cc: Max Reitz <mreitz@redhat.com>
> > Cc: Kevin Wolf <kwolf@redhat.com>
> > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> > ---
> > This is not a bug fix, so I didn't mark it for QEMU 6.1. It's new
> > behavior that hasn't been supported before. I want to split an NVMe
> > drive using the raw format's offset=/size= feature.
> > ---
> > block/raw-format.c | 21 ++++++++++++++++++++-
> > 1 file changed, 20 insertions(+), 1 deletion(-)
> >
> > diff --git a/block/raw-format.c b/block/raw-format.c
> > index 7717578ed6..c26f493688 100644
> > --- a/block/raw-format.c
> > +++ b/block/raw-format.c
> > @@ -580,6 +580,25 @@ static void raw_cancel_in_flight(BlockDriverState *bs)
> > bdrv_cancel_in_flight(bs->file->bs);
> > }
> > +static void raw_child_perm(BlockDriverState *bs, BdrvChild *c,
> > + BdrvChildRole role,
> > + BlockReopenQueue *reopen_queue,
> > + uint64_t parent_perm, uint64_t parent_shared,
> > + uint64_t *nperm, uint64_t *nshared)
> > +{
> > + bdrv_default_perms(bs, c, role, reopen_queue, parent_perm,
> > + parent_shared, nperm, nshared);
> > +
> > + /*
> > + * bdrv_default_perms() may add WRITE and/or RESIZE (see comment in
> > + * bdrv_default_perms_for_storage() for an explanation) but we only need
> > + * them if they are in parent_perm. Drop WRITE and RESIZE whenever possible
> > + * to avoid permission conflicts.
> > + */
> > + *nperm &= ~(BLK_PERM_WRITE | BLK_PERM_RESIZE);
> > + *nperm |= parent_perm & (BLK_PERM_WRITE | BLK_PERM_RESIZE);
> > +}
> > +
> > BlockDriver bdrv_raw = {
> > .format_name = "raw",
> > .instance_size = sizeof(BDRVRawState),
> > @@ -588,7 +607,7 @@ BlockDriver bdrv_raw = {
> > .bdrv_reopen_commit = &raw_reopen_commit,
> > .bdrv_reopen_abort = &raw_reopen_abort,
> > .bdrv_open = &raw_open,
> > - .bdrv_child_perm = bdrv_default_perms,
> > + .bdrv_child_perm = raw_child_perm,
> > .bdrv_co_create_opts = &raw_co_create_opts,
> > .bdrv_co_preadv = &raw_co_preadv,
> > .bdrv_co_pwritev = &raw_co_pwritev,
> >
>
> I think it's OK:
>
> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>
>
> Still, did you consider an alternative of making
> bdrv_filter_default_perm() function public and just do
> ".bdrv_child_perm = bdrv_filter_default_perm," here?
>
> raw_format is not considered to be filter, but for it's permissions I
> think it works exactly like filter.
I had the same thought, but then commit 69dca43d6b6 explicitly made the
opposite change. I seem to remember that Max never liked raw being
treated like a filter much.
Kevin
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] raw-format: drop WRITE and RESIZE child perms when possible
2021-07-26 15:42 ` Kevin Wolf
@ 2021-07-26 15:59 ` Stefan Hajnoczi
0 siblings, 0 replies; 5+ messages in thread
From: Stefan Hajnoczi @ 2021-07-26 15:59 UTC (permalink / raw)
To: Kevin Wolf
Cc: Vladimir Sementsov-Ogievskiy, qemu-block, afrosi, qemu-devel,
Max Reitz, Philippe Mathieu-Daudé
[-- Attachment #1: Type: text/plain, Size: 5428 bytes --]
On Mon, Jul 26, 2021 at 05:42:47PM +0200, Kevin Wolf wrote:
> Am 26.07.2021 um 16:41 hat Vladimir Sementsov-Ogievskiy geschrieben:
> > 26.07.2021 15:28, Stefan Hajnoczi wrote:
> > > The following command-line fails due to a permissions conflict:
> > >
> > > $ qemu-storage-daemon \
> > > --blockdev driver=nvme,node-name=nvme0,device=0000:08:00.0,namespace=1 \
> > > --blockdev driver=raw,node-name=l1-1,file=nvme0,offset=0,size=1073741824 \
> > > --blockdev driver=raw,node-name=l1-2,file=nvme0,offset=1073741824,size=1073741824 \
> > > --nbd-server addr.type=unix,addr.path=/tmp/nbd.sock,max-connections=2 \
> > > --export type=nbd,id=nbd-l1-1,node-name=l1-1,name=l1-1,writable=on \
> > > --export type=nbd,id=nbd-l1-2,node-name=l1-2,name=l1-2,writable=on
> > >
> > > qemu-storage-daemon: --export type=nbd,id=nbd-l1-1,node-name=l1-1,name=l1-1,writable=on: Permission conflict on node 'nvme0': permissions 'resize' are both required by node 'l1-1' (uses node 'nvme0' as 'file' child) and unshared by node 'l1-2' (uses node 'nvme0' as 'file' child).
> > >
> > > The problem is that block/raw-format.c relies on bdrv_default_perms() to
> > > set permissions on the nvme node. The default permissions add RESIZE in
> > > anticipation of a format driver like qcow2 that needs to grow the image
> > > file. This fails because RESIZE is unshared, so we cannot get the RESIZE
> > > permission.
> > >
> > > Max Reitz pointed out that block/crypto.c already handles this case by
> > > implementing a custom ->bdrv_child_perm() function that adjusts the
> > > result of bdrv_default_perms().
> > >
> > > This patch takes the same approach in block/raw-format.c so that RESIZE
> > > is only required if it's actually necessary (e.g. the parent is qcow2).
> > >
> > > Cc: Max Reitz <mreitz@redhat.com>
> > > Cc: Kevin Wolf <kwolf@redhat.com>
> > > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> > > ---
> > > This is not a bug fix, so I didn't mark it for QEMU 6.1. It's new
> > > behavior that hasn't been supported before. I want to split an NVMe
> > > drive using the raw format's offset=/size= feature.
> > > ---
> > > block/raw-format.c | 21 ++++++++++++++++++++-
> > > 1 file changed, 20 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/block/raw-format.c b/block/raw-format.c
> > > index 7717578ed6..c26f493688 100644
> > > --- a/block/raw-format.c
> > > +++ b/block/raw-format.c
> > > @@ -580,6 +580,25 @@ static void raw_cancel_in_flight(BlockDriverState *bs)
> > > bdrv_cancel_in_flight(bs->file->bs);
> > > }
> > > +static void raw_child_perm(BlockDriverState *bs, BdrvChild *c,
> > > + BdrvChildRole role,
> > > + BlockReopenQueue *reopen_queue,
> > > + uint64_t parent_perm, uint64_t parent_shared,
> > > + uint64_t *nperm, uint64_t *nshared)
> > > +{
> > > + bdrv_default_perms(bs, c, role, reopen_queue, parent_perm,
> > > + parent_shared, nperm, nshared);
> > > +
> > > + /*
> > > + * bdrv_default_perms() may add WRITE and/or RESIZE (see comment in
> > > + * bdrv_default_perms_for_storage() for an explanation) but we only need
> > > + * them if they are in parent_perm. Drop WRITE and RESIZE whenever possible
> > > + * to avoid permission conflicts.
> > > + */
> > > + *nperm &= ~(BLK_PERM_WRITE | BLK_PERM_RESIZE);
> > > + *nperm |= parent_perm & (BLK_PERM_WRITE | BLK_PERM_RESIZE);
> > > +}
> > > +
> > > BlockDriver bdrv_raw = {
> > > .format_name = "raw",
> > > .instance_size = sizeof(BDRVRawState),
> > > @@ -588,7 +607,7 @@ BlockDriver bdrv_raw = {
> > > .bdrv_reopen_commit = &raw_reopen_commit,
> > > .bdrv_reopen_abort = &raw_reopen_abort,
> > > .bdrv_open = &raw_open,
> > > - .bdrv_child_perm = bdrv_default_perms,
> > > + .bdrv_child_perm = raw_child_perm,
> > > .bdrv_co_create_opts = &raw_co_create_opts,
> > > .bdrv_co_preadv = &raw_co_preadv,
> > > .bdrv_co_pwritev = &raw_co_pwritev,
> > >
> >
> > I think it's OK:
> >
> > Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> >
> >
> > Still, did you consider an alternative of making
> > bdrv_filter_default_perm() function public and just do
> > ".bdrv_child_perm = bdrv_filter_default_perm," here?
> >
> > raw_format is not considered to be filter, but for it's permissions I
> > think it works exactly like filter.
>
> I had the same thought, but then commit 69dca43d6b6 explicitly made the
> opposite change. I seem to remember that Max never liked raw being
> treated like a filter much.
Additionally:
static int raw_open(BlockDriverState *bs, QDict *options, int flags,
Error **errp)
{
...
/*
* Without offset and a size limit, this driver behaves very much
* like a filter. With any such limit, it does not.
*/
if (offset || has_size) {
file_role = BDRV_CHILD_DATA | BDRV_CHILD_PRIMARY;
} else {
file_role = BDRV_CHILD_FILTERED | BDRV_CHILD_PRIMARY;
}
Whether the raw child node acts as FILTERED or DATA depends on whether
offset=/size= were given.
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] raw-format: drop WRITE and RESIZE child perms when possible
2021-07-26 12:28 [PATCH] raw-format: drop WRITE and RESIZE child perms when possible Stefan Hajnoczi
2021-07-26 14:41 ` Vladimir Sementsov-Ogievskiy
@ 2021-08-19 13:37 ` Hanna Reitz
1 sibling, 0 replies; 5+ messages in thread
From: Hanna Reitz @ 2021-08-19 13:37 UTC (permalink / raw)
To: Stefan Hajnoczi, qemu-devel
Cc: Kevin Wolf, afrosi, Philippe Mathieu-Daudé, qemu-block, Max Reitz
On 26.07.21 14:28, Stefan Hajnoczi wrote:
> The following command-line fails due to a permissions conflict:
>
> $ qemu-storage-daemon \
> --blockdev driver=nvme,node-name=nvme0,device=0000:08:00.0,namespace=1 \
> --blockdev driver=raw,node-name=l1-1,file=nvme0,offset=0,size=1073741824 \
> --blockdev driver=raw,node-name=l1-2,file=nvme0,offset=1073741824,size=1073741824 \
> --nbd-server addr.type=unix,addr.path=/tmp/nbd.sock,max-connections=2 \
> --export type=nbd,id=nbd-l1-1,node-name=l1-1,name=l1-1,writable=on \
> --export type=nbd,id=nbd-l1-2,node-name=l1-2,name=l1-2,writable=on
>
> qemu-storage-daemon: --export type=nbd,id=nbd-l1-1,node-name=l1-1,name=l1-1,writable=on: Permission conflict on node 'nvme0': permissions 'resize' are both required by node 'l1-1' (uses node 'nvme0' as 'file' child) and unshared by node 'l1-2' (uses node 'nvme0' as 'file' child).
>
> The problem is that block/raw-format.c relies on bdrv_default_perms() to
> set permissions on the nvme node. The default permissions add RESIZE in
> anticipation of a format driver like qcow2 that needs to grow the image
> file. This fails because RESIZE is unshared, so we cannot get the RESIZE
> permission.
>
> Max Reitz pointed out that block/crypto.c already handles this case by
> implementing a custom ->bdrv_child_perm() function that adjusts the
> result of bdrv_default_perms().
>
> This patch takes the same approach in block/raw-format.c so that RESIZE
> is only required if it's actually necessary (e.g. the parent is qcow2).
>
> Cc: Max Reitz <mreitz@redhat.com>
> Cc: Kevin Wolf <kwolf@redhat.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> This is not a bug fix, so I didn't mark it for QEMU 6.1. It's new
> behavior that hasn't been supported before. I want to split an NVMe
> drive using the raw format's offset=/size= feature.
> ---
> block/raw-format.c | 21 ++++++++++++++++++++-
> 1 file changed, 20 insertions(+), 1 deletion(-)
Thanks, applied to my block-next branch:
https://github.com/XanClic/qemu/commits/block-next
Hanna
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-08-19 13:39 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-26 12:28 [PATCH] raw-format: drop WRITE and RESIZE child perms when possible Stefan Hajnoczi
2021-07-26 14:41 ` Vladimir Sementsov-Ogievskiy
2021-07-26 15:42 ` Kevin Wolf
2021-07-26 15:59 ` Stefan Hajnoczi
2021-08-19 13:37 ` Hanna Reitz
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.