All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH nf] netfilter: set again FLOWI_FLAG_KNOWN_NH at flowi6_flags
@ 2016-05-26 17:08 Paolo Abeni
  2016-05-30  9:33 ` Pablo Neira Ayuso
  0 siblings, 1 reply; 2+ messages in thread
From: Paolo Abeni @ 2016-05-26 17:08 UTC (permalink / raw)
  To: netfilter-devel; +Cc: Pablo Neira Ayuso, Florian Westphal

With the commit 48e8aa6e3137 ("ipv6: Set FLOWI_FLAG_KNOWN_NH at
flowi6_flags") ip6_pol_route() callers were asked to to set the
FLOWI_FLAG_KNOWN_NH properly and xt_TEE was updated accordingly,
but with the later refactor in commit bbde9fc1824a ("netfilter:
factor out packet duplication for IPv4/IPv6") the flowi6_flags
update was lost.
This commit re-add it just before the routing decision.

Fixes: bbde9fc1824a ("netfilter: factor out packet duplication for IPv4/IPv6")
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
---
 net/ipv6/netfilter/nf_dup_ipv6.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/ipv6/netfilter/nf_dup_ipv6.c b/net/ipv6/netfilter/nf_dup_ipv6.c
index 6989c70..4a84b5a 100644
--- a/net/ipv6/netfilter/nf_dup_ipv6.c
+++ b/net/ipv6/netfilter/nf_dup_ipv6.c
@@ -33,6 +33,7 @@ static bool nf_dup_ipv6_route(struct net *net, struct sk_buff *skb,
 	fl6.daddr = *gw;
 	fl6.flowlabel = (__force __be32)(((iph->flow_lbl[0] & 0xF) << 16) |
 			(iph->flow_lbl[1] << 8) | iph->flow_lbl[2]);
+	fl6.flowi6_flags = FLOWI_FLAG_KNOWN_NH;
 	dst = ip6_route_output(net, NULL, &fl6);
 	if (dst->error) {
 		dst_release(dst);
-- 
1.8.3.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH nf] netfilter: set again FLOWI_FLAG_KNOWN_NH at flowi6_flags
  2016-05-26 17:08 [PATCH nf] netfilter: set again FLOWI_FLAG_KNOWN_NH at flowi6_flags Paolo Abeni
@ 2016-05-30  9:33 ` Pablo Neira Ayuso
  0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2016-05-30  9:33 UTC (permalink / raw)
  To: Paolo Abeni; +Cc: netfilter-devel, Florian Westphal

On Thu, May 26, 2016 at 07:08:10PM +0200, Paolo Abeni wrote:
> With the commit 48e8aa6e3137 ("ipv6: Set FLOWI_FLAG_KNOWN_NH at
> flowi6_flags") ip6_pol_route() callers were asked to to set the
> FLOWI_FLAG_KNOWN_NH properly and xt_TEE was updated accordingly,
> but with the later refactor in commit bbde9fc1824a ("netfilter:
> factor out packet duplication for IPv4/IPv6") the flowi6_flags
> update was lost.
> This commit re-add it just before the routing decision.

Applied, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-05-30  9:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-26 17:08 [PATCH nf] netfilter: set again FLOWI_FLAG_KNOWN_NH at flowi6_flags Paolo Abeni
2016-05-30  9:33 ` Pablo Neira Ayuso

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.