From: Robin Murphy <robin.murphy@arm.com>
To: srinivas.kandagatla@linaro.org, will.deacon@arm.com,
bjorn.andersson@linaro.org
Cc: joro@8bytes.org, ohad@wizery.com,
linux-arm-kernel@lists.infradead.org,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
linux-remoteproc@vger.kernel.org
Subject: Re: [PATCH 3/3] iommu: armsmmu: set iommu ops for rpmsg bus
Date: Fri, 2 Mar 2018 16:59:12 +0000 [thread overview]
Message-ID: <57fc5480-c57e-dfd3-e6af-5e5bba296430@arm.com> (raw)
In-Reply-To: <20180302145531.20463-4-srinivas.kandagatla@linaro.org>
On 02/03/18 14:55, srinivas.kandagatla@linaro.org wrote:
> From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>
> On Qualcomm SoCs, ADSP exposes many functions like audio and
> others. These services need iommu access to allocate any
> memory for the DSP. As these drivers are childeren of
> rpmsg bus, able to allocate memory from iommus is basic
> requirement. So set arm smmu iommu ops for this bus type.
Documentation/rpmsg.txt: "Every rpmsg device is a communication channel
with a remote processor (thus rpmsg devices are called channels)."
I'd instinctively assume that a remote processor already has its own
memory, and that a communication channel doesn't somehow go directly
through an IOMMU, so that "basic requirement" seems like a pretty big
assumption.
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
> drivers/iommu/arm-smmu.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c
> index e6920d32ac9e..9b63489af15c 100644
> --- a/drivers/iommu/arm-smmu.c
> +++ b/drivers/iommu/arm-smmu.c
> @@ -53,6 +53,7 @@
> #include <linux/spinlock.h>
>
> #include <linux/amba/bus.h>
> +#include <linux/rpmsg.h>
>
> #include "io-pgtable.h"
> #include "arm-smmu-regs.h"
> @@ -2168,6 +2169,10 @@ static void arm_smmu_bus_init(void)
> bus_set_iommu(&pci_bus_type, &arm_smmu_ops);
> }
> #endif
> +#ifdef CONFIG_RPMSG
Ah, so this will at least build OK with RPMSG=m, but I doubt it does
what you want it to in that case.
Robin.
> + if (!iommu_present(&rpmsg_bus))
> + bus_set_iommu(&rpmsg_bus, &arm_smmu_ops);
> +#endif
> }
>
> static int arm_smmu_device_probe(struct platform_device *pdev)
>
WARNING: multiple messages have this Message-ID (diff)
From: Robin Murphy <robin.murphy-5wv7dgnIgG8@public.gmane.org>
To: srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
will.deacon-5wv7dgnIgG8@public.gmane.org,
bjorn.andersson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org
Cc: ohad-Ix1uc/W3ht7QT0dZR+AlfA@public.gmane.org,
linux-remoteproc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 3/3] iommu: armsmmu: set iommu ops for rpmsg bus
Date: Fri, 2 Mar 2018 16:59:12 +0000 [thread overview]
Message-ID: <57fc5480-c57e-dfd3-e6af-5e5bba296430@arm.com> (raw)
In-Reply-To: <20180302145531.20463-4-srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
On 02/03/18 14:55, srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org wrote:
> From: Srinivas Kandagatla <srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>
> On Qualcomm SoCs, ADSP exposes many functions like audio and
> others. These services need iommu access to allocate any
> memory for the DSP. As these drivers are childeren of
> rpmsg bus, able to allocate memory from iommus is basic
> requirement. So set arm smmu iommu ops for this bus type.
Documentation/rpmsg.txt: "Every rpmsg device is a communication channel
with a remote processor (thus rpmsg devices are called channels)."
I'd instinctively assume that a remote processor already has its own
memory, and that a communication channel doesn't somehow go directly
through an IOMMU, so that "basic requirement" seems like a pretty big
assumption.
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> ---
> drivers/iommu/arm-smmu.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c
> index e6920d32ac9e..9b63489af15c 100644
> --- a/drivers/iommu/arm-smmu.c
> +++ b/drivers/iommu/arm-smmu.c
> @@ -53,6 +53,7 @@
> #include <linux/spinlock.h>
>
> #include <linux/amba/bus.h>
> +#include <linux/rpmsg.h>
>
> #include "io-pgtable.h"
> #include "arm-smmu-regs.h"
> @@ -2168,6 +2169,10 @@ static void arm_smmu_bus_init(void)
> bus_set_iommu(&pci_bus_type, &arm_smmu_ops);
> }
> #endif
> +#ifdef CONFIG_RPMSG
Ah, so this will at least build OK with RPMSG=m, but I doubt it does
what you want it to in that case.
Robin.
> + if (!iommu_present(&rpmsg_bus))
> + bus_set_iommu(&rpmsg_bus, &arm_smmu_ops);
> +#endif
> }
>
> static int arm_smmu_device_probe(struct platform_device *pdev)
>
WARNING: multiple messages have this Message-ID (diff)
From: robin.murphy@arm.com (Robin Murphy)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] iommu: armsmmu: set iommu ops for rpmsg bus
Date: Fri, 2 Mar 2018 16:59:12 +0000 [thread overview]
Message-ID: <57fc5480-c57e-dfd3-e6af-5e5bba296430@arm.com> (raw)
In-Reply-To: <20180302145531.20463-4-srinivas.kandagatla@linaro.org>
On 02/03/18 14:55, srinivas.kandagatla at linaro.org wrote:
> From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>
> On Qualcomm SoCs, ADSP exposes many functions like audio and
> others. These services need iommu access to allocate any
> memory for the DSP. As these drivers are childeren of
> rpmsg bus, able to allocate memory from iommus is basic
> requirement. So set arm smmu iommu ops for this bus type.
Documentation/rpmsg.txt: "Every rpmsg device is a communication channel
with a remote processor (thus rpmsg devices are called channels)."
I'd instinctively assume that a remote processor already has its own
memory, and that a communication channel doesn't somehow go directly
through an IOMMU, so that "basic requirement" seems like a pretty big
assumption.
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
> drivers/iommu/arm-smmu.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c
> index e6920d32ac9e..9b63489af15c 100644
> --- a/drivers/iommu/arm-smmu.c
> +++ b/drivers/iommu/arm-smmu.c
> @@ -53,6 +53,7 @@
> #include <linux/spinlock.h>
>
> #include <linux/amba/bus.h>
> +#include <linux/rpmsg.h>
>
> #include "io-pgtable.h"
> #include "arm-smmu-regs.h"
> @@ -2168,6 +2169,10 @@ static void arm_smmu_bus_init(void)
> bus_set_iommu(&pci_bus_type, &arm_smmu_ops);
> }
> #endif
> +#ifdef CONFIG_RPMSG
Ah, so this will at least build OK with RPMSG=m, but I doubt it does
what you want it to in that case.
Robin.
> + if (!iommu_present(&rpmsg_bus))
> + bus_set_iommu(&rpmsg_bus, &arm_smmu_ops);
> +#endif
> }
>
> static int arm_smmu_device_probe(struct platform_device *pdev)
>
next prev parent reply other threads:[~2018-03-02 16:59 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-02 14:55 [PATCH 0/3] drivers: rpmsg: make rpmsg bus DMA capable srinivas.kandagatla
2018-03-02 14:55 ` srinivas.kandagatla at linaro.org
2018-03-02 14:55 ` srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A
2018-03-02 14:55 ` [PATCH 1/3] rpmsg: core: export rpmsg bus type srinivas.kandagatla
2018-03-02 14:55 ` srinivas.kandagatla at linaro.org
2018-03-02 14:55 ` srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A
2018-03-02 15:25 ` Robin Murphy
2018-03-02 15:25 ` Robin Murphy
2018-03-02 15:25 ` Robin Murphy
2018-03-02 14:55 ` [PATCH 2/3] rpmsg: core: make rpmsg bus DMA capable srinivas.kandagatla
2018-03-02 14:55 ` srinivas.kandagatla at linaro.org
2018-03-02 14:55 ` srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A
2018-03-02 16:14 ` Robin Murphy
2018-03-02 16:14 ` Robin Murphy
2018-03-02 16:14 ` Robin Murphy
2018-03-02 16:40 ` Srinivas Kandagatla
2018-03-02 16:40 ` Srinivas Kandagatla
2018-03-18 22:47 ` Bjorn Andersson
2018-03-18 22:47 ` Bjorn Andersson
2018-03-18 22:47 ` Bjorn Andersson
2018-03-02 14:55 ` [PATCH 3/3] iommu: armsmmu: set iommu ops for rpmsg bus srinivas.kandagatla
2018-03-02 14:55 ` srinivas.kandagatla at linaro.org
2018-03-02 14:55 ` srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A
2018-03-02 16:59 ` Robin Murphy [this message]
2018-03-02 16:59 ` Robin Murphy
2018-03-02 16:59 ` Robin Murphy
2018-05-07 19:28 ` Bjorn Andersson
2018-05-07 19:28 ` Bjorn Andersson
2018-05-07 19:28 ` Bjorn Andersson
2018-05-11 18:24 ` Robin Murphy
2018-05-11 18:24 ` Robin Murphy
2018-05-11 18:24 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57fc5480-c57e-dfd3-e6af-5e5bba296430@arm.com \
--to=robin.murphy@arm.com \
--cc=bjorn.andersson@linaro.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.