All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] x86/vmx: Print the problematic MSR if a vmentry fails
@ 2016-10-13 11:15 Andrew Cooper
  2016-10-13 11:15 ` [PATCH 2/2] x86/vmx: Reduce the verbosity of the vmentry failure error reporting Andrew Cooper
                   ` (2 more replies)
  0 siblings, 3 replies; 12+ messages in thread
From: Andrew Cooper @ 2016-10-13 11:15 UTC (permalink / raw)
  To: Xen-devel; +Cc: Andrew Cooper, Kevin Tian, Jun Nakajima, Jan Beulich

Sample error looks like:

  (XEN) Failed vm entry (exit reason 0x80000022) caused by MSR loading (entry 13).
  (XEN)   msr 0000068a, val 1fff800000102af0, (mbz 0)
  (XEN) ************* VMCS Area **************

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Jun Nakajima <jun.nakajima@intel.com>
CC: Kevin Tian <kevin.tian@intel.com>
---
 xen/arch/x86/hvm/vmx/vmx.c | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)

diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c
index b9102ce..38cbcea 100644
--- a/xen/arch/x86/hvm/vmx/vmx.c
+++ b/xen/arch/x86/hvm/vmx/vmx.c
@@ -3104,8 +3104,23 @@ static void vmx_failed_vmentry(unsigned int exit_reason,
         printk("caused by invalid guest state (%ld).\n", exit_qualification);
         break;
     case EXIT_REASON_MSR_LOADING:
-        printk("caused by MSR entry %ld loading.\n", exit_qualification);
+    {
+        unsigned long idx = exit_qualification - 1;
+        struct vmx_msr_entry *msr;
+
+        printk("caused by MSR loading (entry %ld).\n", idx);
+
+        if ( idx > (PAGE_SIZE / sizeof(*msr)) )
+            printk("  Entry out of range\n");
+        else
+        {
+            msr = &curr->arch.hvm_vmx.msr_area[idx];
+
+            printk("  msr %08x, val %016"PRIx64", (mbz %#x)\n",
+                   msr->index, msr->data, msr->mbz);
+        }
         break;
+    }
     case EXIT_REASON_MCE_DURING_VMENTRY:
         printk("caused by machine check.\n");
         HVMTRACE_0D(MCE);
-- 
2.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [PATCH 2/2] x86/vmx: Reduce the verbosity of the vmentry failure error reporting
  2016-10-13 11:15 [PATCH 1/2] x86/vmx: Print the problematic MSR if a vmentry fails Andrew Cooper
@ 2016-10-13 11:15 ` Andrew Cooper
  2016-10-13 11:41   ` Jan Beulich
  2016-10-13 11:38 ` [PATCH 1/2] x86/vmx: Print the problematic MSR if a vmentry fails Jan Beulich
  2016-10-13 13:46 ` [PATCH v2 " Andrew Cooper
  2 siblings, 1 reply; 12+ messages in thread
From: Andrew Cooper @ 2016-10-13 11:15 UTC (permalink / raw)
  To: Xen-devel; +Cc: Andrew Cooper, Kevin Tian, Jun Nakajima, Jan Beulich

Identify the affected vcpu at the start of the message.  While tweaking this
area, add extra newlines between cases.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Jun Nakajima <jun.nakajima@intel.com>
CC: Kevin Tian <kevin.tian@intel.com>
---
 xen/arch/x86/hvm/vmx/vmx.c | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c
index 38cbcea..554f9e8 100644
--- a/xen/arch/x86/hvm/vmx/vmx.c
+++ b/xen/arch/x86/hvm/vmx/vmx.c
@@ -3096,19 +3096,20 @@ static void vmx_failed_vmentry(unsigned int exit_reason,
     unsigned long exit_qualification;
     struct vcpu *curr = current;
 
-    printk("Failed vm entry (exit reason %#x) ", exit_reason);
+    printk("%pv vmentry failure (reason %#x): ", curr, exit_reason);
     __vmread(EXIT_QUALIFICATION, &exit_qualification);
     switch ( failed_vmentry_reason )
     {
     case EXIT_REASON_INVALID_GUEST_STATE:
-        printk("caused by invalid guest state (%ld).\n", exit_qualification);
+        printk("Invalid guest state (%ld)\n", exit_qualification);
         break;
+
     case EXIT_REASON_MSR_LOADING:
     {
         unsigned long idx = exit_qualification - 1;
         struct vmx_msr_entry *msr;
 
-        printk("caused by MSR loading (entry %ld).\n", idx);
+        printk("MSR loading (entry %ld)\n", idx);
 
         if ( idx > (PAGE_SIZE / sizeof(*msr)) )
             printk("  Entry out of range\n");
@@ -3121,13 +3122,15 @@ static void vmx_failed_vmentry(unsigned int exit_reason,
         }
         break;
     }
+
     case EXIT_REASON_MCE_DURING_VMENTRY:
-        printk("caused by machine check.\n");
+        printk("MCE\n");
         HVMTRACE_0D(MCE);
         /* Already handled. */
         break;
+
     default:
-        printk("reason not known yet!");
+        printk("Unknown\n");
         break;
     }
 
-- 
2.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply related	[flat|nested] 12+ messages in thread

* Re: [PATCH 1/2] x86/vmx: Print the problematic MSR if a vmentry fails
  2016-10-13 11:15 [PATCH 1/2] x86/vmx: Print the problematic MSR if a vmentry fails Andrew Cooper
  2016-10-13 11:15 ` [PATCH 2/2] x86/vmx: Reduce the verbosity of the vmentry failure error reporting Andrew Cooper
@ 2016-10-13 11:38 ` Jan Beulich
  2016-10-13 11:52   ` Andrew Cooper
  2016-10-13 13:46 ` [PATCH v2 " Andrew Cooper
  2 siblings, 1 reply; 12+ messages in thread
From: Jan Beulich @ 2016-10-13 11:38 UTC (permalink / raw)
  To: Andrew Cooper; +Cc: Kevin Tian, Jun Nakajima, Xen-devel

>>> On 13.10.16 at 13:15, <andrew.cooper3@citrix.com> wrote:
> Sample error looks like:
> 
>   (XEN) Failed vm entry (exit reason 0x80000022) caused by MSR loading (entry 13).
>   (XEN)   msr 0000068a, val 1fff800000102af0, (mbz 0)
>   (XEN) ************* VMCS Area **************
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>
with

> --- a/xen/arch/x86/hvm/vmx/vmx.c
> +++ b/xen/arch/x86/hvm/vmx/vmx.c
> @@ -3104,8 +3104,23 @@ static void vmx_failed_vmentry(unsigned int exit_reason,
>          printk("caused by invalid guest state (%ld).\n", exit_qualification);
>          break;
>      case EXIT_REASON_MSR_LOADING:
> -        printk("caused by MSR entry %ld loading.\n", exit_qualification);
> +    {
> +        unsigned long idx = exit_qualification - 1;
> +        struct vmx_msr_entry *msr;

... preferably const here (and the declaration perhaps moved into
the more narrow scope it's needed in), ...

> +        printk("caused by MSR loading (entry %ld).\n", idx);

... %lu (plus ideally the full stop dropped) here, and ...

> +        if ( idx > (PAGE_SIZE / sizeof(*msr)) )

... >= here.

> +            printk("  Entry out of range\n");
> +        else
> +        {
> +            msr = &curr->arch.hvm_vmx.msr_area[idx];
> +
> +            printk("  msr %08x, val %016"PRIx64", (mbz %#x)\n",

I'm also unsure about the usefulness of the commas here - at least
the second one seems a little strange with the value in parentheses.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 2/2] x86/vmx: Reduce the verbosity of the vmentry failure error reporting
  2016-10-13 11:15 ` [PATCH 2/2] x86/vmx: Reduce the verbosity of the vmentry failure error reporting Andrew Cooper
@ 2016-10-13 11:41   ` Jan Beulich
  0 siblings, 0 replies; 12+ messages in thread
From: Jan Beulich @ 2016-10-13 11:41 UTC (permalink / raw)
  To: Andrew Cooper; +Cc: Kevin Tian, Jun Nakajima, Xen-devel

>>> On 13.10.16 at 13:15, <andrew.cooper3@citrix.com> wrote:
> Identify the affected vcpu at the start of the message.  While tweaking this
> area, add extra newlines between cases.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>
with ...

> --- a/xen/arch/x86/hvm/vmx/vmx.c
> +++ b/xen/arch/x86/hvm/vmx/vmx.c
> @@ -3096,19 +3096,20 @@ static void vmx_failed_vmentry(unsigned int exit_reason,
>      unsigned long exit_qualification;
>      struct vcpu *curr = current;
>  
> -    printk("Failed vm entry (exit reason %#x) ", exit_reason);
> +    printk("%pv vmentry failure (reason %#x): ", curr, exit_reason);
>      __vmread(EXIT_QUALIFICATION, &exit_qualification);
>      switch ( failed_vmentry_reason )
>      {
>      case EXIT_REASON_INVALID_GUEST_STATE:
> -        printk("caused by invalid guest state (%ld).\n", exit_qualification);
> +        printk("Invalid guest state (%ld)\n", exit_qualification);

... %lu here.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 1/2] x86/vmx: Print the problematic MSR if a vmentry fails
  2016-10-13 11:38 ` [PATCH 1/2] x86/vmx: Print the problematic MSR if a vmentry fails Jan Beulich
@ 2016-10-13 11:52   ` Andrew Cooper
  0 siblings, 0 replies; 12+ messages in thread
From: Andrew Cooper @ 2016-10-13 11:52 UTC (permalink / raw)
  To: Jan Beulich; +Cc: Kevin Tian, Jun Nakajima, Xen-devel

On 13/10/16 12:38, Jan Beulich wrote:
>>>> On 13.10.16 at 13:15, <andrew.cooper3@citrix.com> wrote:
>> Sample error looks like:
>>
>>   (XEN) Failed vm entry (exit reason 0x80000022) caused by MSR loading (entry 13).
>>   (XEN)   msr 0000068a, val 1fff800000102af0, (mbz 0)
>>   (XEN) ************* VMCS Area **************
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Reviewed-by: Jan Beulich <jbeulich@suse.com>
> with
>
>> --- a/xen/arch/x86/hvm/vmx/vmx.c
>> +++ b/xen/arch/x86/hvm/vmx/vmx.c
>> @@ -3104,8 +3104,23 @@ static void vmx_failed_vmentry(unsigned int exit_reason,
>>          printk("caused by invalid guest state (%ld).\n", exit_qualification);
>>          break;
>>      case EXIT_REASON_MSR_LOADING:
>> -        printk("caused by MSR entry %ld loading.\n", exit_qualification);
>> +    {
>> +        unsigned long idx = exit_qualification - 1;
>> +        struct vmx_msr_entry *msr;
> ... preferably const here

Will do.

>  (and the declaration perhaps moved into
> the more narrow scope it's needed in), ...

Cant, due to its use in the sizeof() expression.  (I tried that first)

>
>> +        printk("caused by MSR loading (entry %ld).\n", idx);
> ... %lu (plus ideally the full stop dropped) here, and ...

Ok for %lu.  The full stop is dealt with in the following patch, so will
leave this as-is for consistency of both patches.

>
>> +        if ( idx > (PAGE_SIZE / sizeof(*msr)) )
> ... >= here.
>
>> +            printk("  Entry out of range\n");
>> +        else
>> +        {
>> +            msr = &curr->arch.hvm_vmx.msr_area[idx];
>> +
>> +            printk("  msr %08x, val %016"PRIx64", (mbz %#x)\n",
> I'm also unsure about the usefulness of the commas here - at least
> the second one seems a little strange with the value in parentheses.

Ok.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [PATCH v2 1/2] x86/vmx: Print the problematic MSR if a vmentry fails
  2016-10-13 11:15 [PATCH 1/2] x86/vmx: Print the problematic MSR if a vmentry fails Andrew Cooper
  2016-10-13 11:15 ` [PATCH 2/2] x86/vmx: Reduce the verbosity of the vmentry failure error reporting Andrew Cooper
  2016-10-13 11:38 ` [PATCH 1/2] x86/vmx: Print the problematic MSR if a vmentry fails Jan Beulich
@ 2016-10-13 13:46 ` Andrew Cooper
  2016-10-13 13:46   ` [PATCH v2 2/2] x86/vmx: Reduce the verbosity of the vmentry failure error reporting Andrew Cooper
  2016-10-14  6:39   ` [PATCH v2 1/2] x86/vmx: Print the problematic MSR if a vmentry fails Jan Beulich
  2 siblings, 2 replies; 12+ messages in thread
From: Andrew Cooper @ 2016-10-13 13:46 UTC (permalink / raw)
  To: Xen-devel; +Cc: Andrew Cooper, Kevin Tian, Jun Nakajima

Sample error looks like:

  (XEN) Failed vm entry (exit reason 0x80000022) caused by MSR loading (entry 13).
  (XEN)   msr 0000068a, val 1fff800000102af0, (mbz 0)
  (XEN) ************* VMCS Area **************

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Jan Beulich <JBeulich@suse.com>
---
CC: Jun Nakajima <jun.nakajima@intel.com>
CC: Kevin Tian <kevin.tian@intel.com>

v2:
 * const, %lu, remove some commas, boundary check
---
 xen/arch/x86/hvm/vmx/vmx.c | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)

diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c
index b9102ce..b406989 100644
--- a/xen/arch/x86/hvm/vmx/vmx.c
+++ b/xen/arch/x86/hvm/vmx/vmx.c
@@ -3104,8 +3104,23 @@ static void vmx_failed_vmentry(unsigned int exit_reason,
         printk("caused by invalid guest state (%ld).\n", exit_qualification);
         break;
     case EXIT_REASON_MSR_LOADING:
-        printk("caused by MSR entry %ld loading.\n", exit_qualification);
+    {
+        unsigned long idx = exit_qualification - 1;
+        const struct vmx_msr_entry *msr;
+
+        printk("caused by MSR loading (entry %lu).\n", idx);
+
+        if ( idx >= (PAGE_SIZE / sizeof(*msr)) )
+            printk("  Entry out of range\n");
+        else
+        {
+            msr = &curr->arch.hvm_vmx.msr_area[idx];
+
+            printk("  msr %08x val %016"PRIx64" (mbz %#x)\n",
+                   msr->index, msr->data, msr->mbz);
+        }
         break;
+    }
     case EXIT_REASON_MCE_DURING_VMENTRY:
         printk("caused by machine check.\n");
         HVMTRACE_0D(MCE);
-- 
2.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [PATCH v2 2/2] x86/vmx: Reduce the verbosity of the vmentry failure error reporting
  2016-10-13 13:46 ` [PATCH v2 " Andrew Cooper
@ 2016-10-13 13:46   ` Andrew Cooper
  2016-10-20  9:41     ` Tian, Kevin
  2016-10-14  6:39   ` [PATCH v2 1/2] x86/vmx: Print the problematic MSR if a vmentry fails Jan Beulich
  1 sibling, 1 reply; 12+ messages in thread
From: Andrew Cooper @ 2016-10-13 13:46 UTC (permalink / raw)
  To: Xen-devel; +Cc: Andrew Cooper, Kevin Tian, Jun Nakajima

Identify the affected vcpu at the start of the message.  While tweaking this
area, add extra newlines between cases.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Jan Beulich <JBeulich@suse.com>
---
CC: Jun Nakajima <jun.nakajima@intel.com>
CC: Kevin Tian <kevin.tian@intel.com>

v2:
 * %lu
---
 xen/arch/x86/hvm/vmx/vmx.c | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c
index b406989..db12cdb 100644
--- a/xen/arch/x86/hvm/vmx/vmx.c
+++ b/xen/arch/x86/hvm/vmx/vmx.c
@@ -3096,19 +3096,20 @@ static void vmx_failed_vmentry(unsigned int exit_reason,
     unsigned long exit_qualification;
     struct vcpu *curr = current;
 
-    printk("Failed vm entry (exit reason %#x) ", exit_reason);
+    printk("%pv vmentry failure (reason %#x): ", curr, exit_reason);
     __vmread(EXIT_QUALIFICATION, &exit_qualification);
     switch ( failed_vmentry_reason )
     {
     case EXIT_REASON_INVALID_GUEST_STATE:
-        printk("caused by invalid guest state (%ld).\n", exit_qualification);
+        printk("Invalid guest state (%lu)\n", exit_qualification);
         break;
+
     case EXIT_REASON_MSR_LOADING:
     {
         unsigned long idx = exit_qualification - 1;
         const struct vmx_msr_entry *msr;
 
-        printk("caused by MSR loading (entry %lu).\n", idx);
+        printk("MSR loading (entry %lu)\n", idx);
 
         if ( idx >= (PAGE_SIZE / sizeof(*msr)) )
             printk("  Entry out of range\n");
@@ -3121,13 +3122,15 @@ static void vmx_failed_vmentry(unsigned int exit_reason,
         }
         break;
     }
+
     case EXIT_REASON_MCE_DURING_VMENTRY:
-        printk("caused by machine check.\n");
+        printk("MCE\n");
         HVMTRACE_0D(MCE);
         /* Already handled. */
         break;
+
     default:
-        printk("reason not known yet!");
+        printk("Unknown\n");
         break;
     }
 
-- 
2.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply related	[flat|nested] 12+ messages in thread

* Re: [PATCH v2 1/2] x86/vmx: Print the problematic MSR if a vmentry fails
  2016-10-13 13:46 ` [PATCH v2 " Andrew Cooper
  2016-10-13 13:46   ` [PATCH v2 2/2] x86/vmx: Reduce the verbosity of the vmentry failure error reporting Andrew Cooper
@ 2016-10-14  6:39   ` Jan Beulich
  2016-10-14  9:29     ` Andrew Cooper
  1 sibling, 1 reply; 12+ messages in thread
From: Jan Beulich @ 2016-10-14  6:39 UTC (permalink / raw)
  To: Andrew Cooper; +Cc: Kevin Tian, Jun Nakajima, Xen-devel

>>> On 13.10.16 at 15:46, <andrew.cooper3@citrix.com> wrote:
> Sample error looks like:
> 
>   (XEN) Failed vm entry (exit reason 0x80000022) caused by MSR loading (entry 13).
>   (XEN)   msr 0000068a, val 1fff800000102af0, (mbz 0)

A _really_ minor remark: This is no longer in line with what gets
actually logged.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v2 1/2] x86/vmx: Print the problematic MSR if a vmentry fails
  2016-10-14  6:39   ` [PATCH v2 1/2] x86/vmx: Print the problematic MSR if a vmentry fails Jan Beulich
@ 2016-10-14  9:29     ` Andrew Cooper
  2016-10-20  9:40       ` Tian, Kevin
  0 siblings, 1 reply; 12+ messages in thread
From: Andrew Cooper @ 2016-10-14  9:29 UTC (permalink / raw)
  To: Jan Beulich; +Cc: Kevin Tian, Jun Nakajima, Xen-devel

On 14/10/16 07:39, Jan Beulich wrote:
>>>> On 13.10.16 at 15:46, <andrew.cooper3@citrix.com> wrote:
>> Sample error looks like:
>>
>>   (XEN) Failed vm entry (exit reason 0x80000022) caused by MSR loading (entry 13).
>>   (XEN)   msr 0000068a, val 1fff800000102af0, (mbz 0)
> A _really_ minor remark: This is no longer in line with what gets
> actually logged.

Oops yes.  Fixed locally.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v2 1/2] x86/vmx: Print the problematic MSR if a vmentry fails
  2016-10-14  9:29     ` Andrew Cooper
@ 2016-10-20  9:40       ` Tian, Kevin
  2016-10-20 10:41         ` Andrew Cooper
  0 siblings, 1 reply; 12+ messages in thread
From: Tian, Kevin @ 2016-10-20  9:40 UTC (permalink / raw)
  To: Andrew Cooper, Jan Beulich; +Cc: Nakajima, Jun, Xen-devel

> From: Andrew Cooper [mailto:andrew.cooper3@citrix.com]
> Sent: Friday, October 14, 2016 5:29 PM
> 
> On 14/10/16 07:39, Jan Beulich wrote:
> >>>> On 13.10.16 at 15:46, <andrew.cooper3@citrix.com> wrote:
> >> Sample error looks like:
> >>
> >>   (XEN) Failed vm entry (exit reason 0x80000022) caused by MSR loading (entry 13).
> >>   (XEN)   msr 0000068a, val 1fff800000102af0, (mbz 0)
> > A _really_ minor remark: This is no longer in line with what gets
> > actually logged.
> 
> Oops yes.  Fixed locally.
> 
> ~Andrew

Sorry overlooked this patch. If still required,

Acked-by: Kevin Tian <kevin.tian@intel.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v2 2/2] x86/vmx: Reduce the verbosity of the vmentry failure error reporting
  2016-10-13 13:46   ` [PATCH v2 2/2] x86/vmx: Reduce the verbosity of the vmentry failure error reporting Andrew Cooper
@ 2016-10-20  9:41     ` Tian, Kevin
  0 siblings, 0 replies; 12+ messages in thread
From: Tian, Kevin @ 2016-10-20  9:41 UTC (permalink / raw)
  To: Andrew Cooper, Xen-devel; +Cc: Nakajima, Jun

> From: Andrew Cooper [mailto:andrew.cooper3@citrix.com]
> Sent: Thursday, October 13, 2016 9:46 PM
> 
> Identify the affected vcpu at the start of the message.  While tweaking this
> area, add extra newlines between cases.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Reviewed-by: Jan Beulich <JBeulich@suse.com>
> ---
> CC: Jun Nakajima <jun.nakajima@intel.com>
> CC: Kevin Tian <kevin.tian@intel.com>
> 

Acked-by: Kevin Tian <kevin.tian@intel.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v2 1/2] x86/vmx: Print the problematic MSR if a vmentry fails
  2016-10-20  9:40       ` Tian, Kevin
@ 2016-10-20 10:41         ` Andrew Cooper
  0 siblings, 0 replies; 12+ messages in thread
From: Andrew Cooper @ 2016-10-20 10:41 UTC (permalink / raw)
  To: Tian, Kevin, Jan Beulich; +Cc: Nakajima, Jun, Xen-devel

On 20/10/16 10:40, Tian, Kevin wrote:
>> From: Andrew Cooper [mailto:andrew.cooper3@citrix.com]
>> Sent: Friday, October 14, 2016 5:29 PM
>>
>> On 14/10/16 07:39, Jan Beulich wrote:
>>>>>> On 13.10.16 at 15:46, <andrew.cooper3@citrix.com> wrote:
>>>> Sample error looks like:
>>>>
>>>>   (XEN) Failed vm entry (exit reason 0x80000022) caused by MSR loading (entry 13).
>>>>   (XEN)   msr 0000068a, val 1fff800000102af0, (mbz 0)
>>> A _really_ minor remark: This is no longer in line with what gets
>>> actually logged.
>> Oops yes.  Fixed locally.
>>
>> ~Andrew
> Sorry overlooked this patch. If still required,
>
> Acked-by: Kevin Tian <kevin.tian@intel.com>

Thanks.  (I was about to get around to pinging you)

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2016-10-20 10:41 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-13 11:15 [PATCH 1/2] x86/vmx: Print the problematic MSR if a vmentry fails Andrew Cooper
2016-10-13 11:15 ` [PATCH 2/2] x86/vmx: Reduce the verbosity of the vmentry failure error reporting Andrew Cooper
2016-10-13 11:41   ` Jan Beulich
2016-10-13 11:38 ` [PATCH 1/2] x86/vmx: Print the problematic MSR if a vmentry fails Jan Beulich
2016-10-13 11:52   ` Andrew Cooper
2016-10-13 13:46 ` [PATCH v2 " Andrew Cooper
2016-10-13 13:46   ` [PATCH v2 2/2] x86/vmx: Reduce the verbosity of the vmentry failure error reporting Andrew Cooper
2016-10-20  9:41     ` Tian, Kevin
2016-10-14  6:39   ` [PATCH v2 1/2] x86/vmx: Print the problematic MSR if a vmentry fails Jan Beulich
2016-10-14  9:29     ` Andrew Cooper
2016-10-20  9:40       ` Tian, Kevin
2016-10-20 10:41         ` Andrew Cooper

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.