* [U-Boot] [PATCH 1/6] travis-ci: Use = not : when writing ~/.buildman
@ 2016-10-26 17:05 Stephen Warren
2016-10-26 17:05 ` [U-Boot] [PATCH 2/6] travis-ci: use correct exit code on errors Stephen Warren
` (6 more replies)
0 siblings, 7 replies; 21+ messages in thread
From: Stephen Warren @ 2016-10-26 17:05 UTC (permalink / raw)
To: u-boot
From: Stephen Warren <swarren@nvidia.com>
Travis CI seems to be confused when there's a colon in an echo command,
and this is currently worked around using a variable that contains the
text we want to echo. Use = syntax instead so that we can remove the
work-around; it's rather confusing until you find out what it's for.
Signed-off-by: Stephen Warren <swarren@nvidia.com>
---
.travis.yml | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/.travis.yml b/.travis.yml
index 00be5ff20396..f91e1bc271fe 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -38,8 +38,7 @@ install:
- ln -s travis-ci /tmp/uboot-test-hooks/bin/`hostname`
- ln -s travis-ci /tmp/uboot-test-hooks/py/`hostname`
# prepare buildman environment
- - export BUILDMAN_ROOT="root:"
- - echo -e "[toolchain]\n${BUILDMAN_ROOT} /usr" > ~/.buildman
+ - echo -e "[toolchain]\nroot = /usr" > ~/.buildman
- echo -e "\n[toolchain-alias]\nblackfin = bfin\nsh = sh4\nopenrisc = or32" >> ~/.buildman
- cat ~/.buildman
- virtualenv /tmp/venv
@@ -105,8 +104,7 @@ matrix:
- BUILDMAN="sandbox x86"
TOOLCHAIN="x86_64"
script:
- - export BUILDMAN_X86="x86:";
- echo -e "\n[toolchain-prefix]\n${BUILDMAN_X86} ${HOME}/.buildman-toolchains/gcc-4.9.0-nolibc/x86_64-linux/bin/x86_64-linux-" >> ~/.buildman
+ - echo -e "\n[toolchain-prefix]\nx86 = ${HOME}/.buildman-toolchains/gcc-4.9.0-nolibc/x86_64-linux/bin/x86_64-linux-" >> ~/.buildman
- env:
- BUILDMAN="kirkwood"
- env:
--
2.10.1
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [U-Boot] [PATCH 2/6] travis-ci: use correct exit code on errors
2016-10-26 17:05 [U-Boot] [PATCH 1/6] travis-ci: Use = not : when writing ~/.buildman Stephen Warren
@ 2016-10-26 17:05 ` Stephen Warren
2016-10-27 4:21 ` Heiko Schocher
2016-10-29 17:41 ` [U-Boot] [U-Boot, " Tom Rini
2016-10-26 17:05 ` [U-Boot] [PATCH 3/6] travis-ci: centralize ~/.buildman editing Stephen Warren
` (5 subsequent siblings)
6 siblings, 2 replies; 21+ messages in thread
From: Stephen Warren @ 2016-10-26 17:05 UTC (permalink / raw)
To: u-boot
From: Stephen Warren <swarren@nvidia.com>
The phrase "if [ $? -ne 0 ]; then exit $?; fi" doesn't work correctly;
by the time the "exit" statement runs, $? has already been over-written
by the result of the [ command. Fix this by explicitly storing $? and
then using that stored value in both the test and the error-case exit
statement.
This change also converts from textual comparison to integer comparison,
since the exit code is an integer and there's no need to convert it to
a string for comparison.
Signed-off-by: Stephen Warren <swarren@nvidia.com>
---
.travis.yml | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/.travis.yml b/.travis.yml
index f91e1bc271fe..33685ce14777 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -70,11 +70,12 @@ script:
- if [[ "${BUILDMAN}" != "" ]]; then
set +e;
tools/buildman/buildman ${BUILDMAN};
- if [[ "$?" == "0" || "$?" == "129" ]]; then
+ ret=$?;
+ if [[ $ret -eq 0 || $ret -eq 129 ]]; then
exit 0;
else
- exit $?;
- fi
+ exit $ret;
+ fi;
fi
matrix:
--
2.10.1
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [U-Boot] [PATCH 3/6] travis-ci: centralize ~/.buildman editing
2016-10-26 17:05 [U-Boot] [PATCH 1/6] travis-ci: Use = not : when writing ~/.buildman Stephen Warren
2016-10-26 17:05 ` [U-Boot] [PATCH 2/6] travis-ci: use correct exit code on errors Stephen Warren
@ 2016-10-26 17:05 ` Stephen Warren
2016-10-27 4:21 ` Heiko Schocher
2016-10-29 17:41 ` [U-Boot] [U-Boot, " Tom Rini
2016-10-26 17:05 ` [U-Boot] [PATCH 4/6] travis-ci: use buildman -P everywhere Stephen Warren
` (4 subsequent siblings)
6 siblings, 2 replies; 21+ messages in thread
From: Stephen Warren @ 2016-10-26 17:05 UTC (permalink / raw)
To: u-boot
From: Stephen Warren <swarren@nvidia.com>
Any time an x86 toolchain is used, we need to edit ~/.buildman to
reference it. Move the editing logic into a central place so that it
doesn't have to be duplicated everywhere that uses the x86 toolchain;
future patches will add additional cases where it's used.
It would be nice if we could unconditionally write all of ~/.buildman at
once. Unfortunately, buildman fails if any toolchain mentioned in a
toolchain-prefix entry doesn't exist, even if it doesn't need to use it
for the current build.
The sandbox/x86 build definition currently does nothing more than edit
~/.buildman; no builds are run. Fix this by not defining a custom script
for this build, and hence preventing that stanza from replacing the
default script.
Signed-off-by: Stephen Warren <swarren@nvidia.com>
---
.travis.yml | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/.travis.yml b/.travis.yml
index 33685ce14777..119dec8df5b2 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -62,7 +62,10 @@ before_script:
- if [[ "${TOOLCHAIN}" == *mips* ]]; then ./tools/buildman/buildman --fetch-arch mips ; fi
- if [[ "${TOOLCHAIN}" == *or32* ]]; then ./tools/buildman/buildman --fetch-arch or32 ; fi
- if [[ "${TOOLCHAIN}" == *sh4* ]]; then ./tools/buildman/buildman --fetch-arch sh4 ; fi
- - if [[ "${TOOLCHAIN}" == *x86_64* ]]; then ./tools/buildman/buildman --fetch-arch x86_64 ; fi
+ - if [[ "${TOOLCHAIN}" == *x86_64* ]]; then
+ ./tools/buildman/buildman --fetch-arch x86_64;
+ echo -e "\n[toolchain-prefix]\nx86 = ${HOME}/.buildman-toolchains/gcc-4.9.0-nolibc/x86_64-linux/bin/x86_64-linux-" >> ~/.buildman;
+ fi
- if [[ "${TOOLCHAIN}" == *xtensa* ]]; then ./tools/buildman/buildman --fetch-arch xtensa ; fi
script:
@@ -104,8 +107,6 @@ matrix:
- env:
- BUILDMAN="sandbox x86"
TOOLCHAIN="x86_64"
- script:
- - echo -e "\n[toolchain-prefix]\nx86 = ${HOME}/.buildman-toolchains/gcc-4.9.0-nolibc/x86_64-linux/bin/x86_64-linux-" >> ~/.buildman
- env:
- BUILDMAN="kirkwood"
- env:
--
2.10.1
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [U-Boot] [PATCH 4/6] travis-ci: use buildman -P everywhere
2016-10-26 17:05 [U-Boot] [PATCH 1/6] travis-ci: Use = not : when writing ~/.buildman Stephen Warren
2016-10-26 17:05 ` [U-Boot] [PATCH 2/6] travis-ci: use correct exit code on errors Stephen Warren
2016-10-26 17:05 ` [U-Boot] [PATCH 3/6] travis-ci: centralize ~/.buildman editing Stephen Warren
@ 2016-10-26 17:05 ` Stephen Warren
2016-10-27 4:22 ` Heiko Schocher
2016-10-29 17:41 ` [U-Boot] [U-Boot,4/6] " Tom Rini
2016-10-26 17:05 ` [U-Boot] [PATCH 5/6] travis-ci: don't invoke exit on success Stephen Warren
` (3 subsequent siblings)
6 siblings, 2 replies; 21+ messages in thread
From: Stephen Warren @ 2016-10-26 17:05 UTC (permalink / raw)
To: u-boot
From: Stephen Warren <swarren@nvidia.com>
This places build results into a board-specific directory rather than a
buildman-thread-specific directory. This is required so that we can
access the directory from test.py, and there's no risk of a particular
build's results being over-written by another build performed by the
same thread.
In theory, this can lead to slower builds when building many different
boards in a single buildman thread, since it removes the possibility of
incremental builds between boards. In practice however I didn't notice
longer build times when when enabling this option; if anything build
times decreased although I suspect that's simply due to general
variations in build performance across different machines within the
Travis CI infra-structure.
Signed-off-by: Stephen Warren <swarren@nvidia.com>
---
.travis.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.travis.yml b/.travis.yml
index 119dec8df5b2..6e72e0bb233f 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -72,7 +72,7 @@ script:
# Exit code 129 means warnings only.
- if [[ "${BUILDMAN}" != "" ]]; then
set +e;
- tools/buildman/buildman ${BUILDMAN};
+ tools/buildman/buildman -P ${BUILDMAN};
ret=$?;
if [[ $ret -eq 0 || $ret -eq 129 ]]; then
exit 0;
--
2.10.1
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [U-Boot] [PATCH 5/6] travis-ci: don't invoke exit on success
2016-10-26 17:05 [U-Boot] [PATCH 1/6] travis-ci: Use = not : when writing ~/.buildman Stephen Warren
` (2 preceding siblings ...)
2016-10-26 17:05 ` [U-Boot] [PATCH 4/6] travis-ci: use buildman -P everywhere Stephen Warren
@ 2016-10-26 17:05 ` Stephen Warren
2016-10-27 6:12 ` Heiko Schocher
2016-10-29 17:41 ` [U-Boot] [U-Boot,5/6] " Tom Rini
2016-10-26 17:05 ` [U-Boot] [PATCH 6/6] travis-ci: compile with buildman when running test/py Stephen Warren
` (2 subsequent siblings)
6 siblings, 2 replies; 21+ messages in thread
From: Stephen Warren @ 2016-10-26 17:05 UTC (permalink / raw)
To: u-boot
From: Stephen Warren <swarren@nvidia.com>
Invoking exit prevents any subsequent build commands from running, and
future patches will add extra commands.
Signed-off-by: Stephen Warren <swarren@nvidia.com>
---
.travis.yml | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/.travis.yml b/.travis.yml
index 6e72e0bb233f..a537f0e34dd3 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -74,9 +74,7 @@ script:
set +e;
tools/buildman/buildman -P ${BUILDMAN};
ret=$?;
- if [[ $ret -eq 0 || $ret -eq 129 ]]; then
- exit 0;
- else
+ if [[ $ret -ne 0 && $ret -ne 129 ]]; then
exit $ret;
fi;
fi
--
2.10.1
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [U-Boot] [PATCH 6/6] travis-ci: compile with buildman when running test/py
2016-10-26 17:05 [U-Boot] [PATCH 1/6] travis-ci: Use = not : when writing ~/.buildman Stephen Warren
` (3 preceding siblings ...)
2016-10-26 17:05 ` [U-Boot] [PATCH 5/6] travis-ci: don't invoke exit on success Stephen Warren
@ 2016-10-26 17:05 ` Stephen Warren
2016-10-26 18:56 ` Stephen Warren
` (3 more replies)
2016-10-27 4:20 ` [U-Boot] [PATCH 1/6] travis-ci: Use = not : when writing ~/.buildman Heiko Schocher
2016-10-29 17:41 ` [U-Boot] [U-Boot, " Tom Rini
6 siblings, 4 replies; 21+ messages in thread
From: Stephen Warren @ 2016-10-26 17:05 UTC (permalink / raw)
To: u-boot
From: Stephen Warren <swarren@nvidia.com>
Use buildman to compile any U-Boot binary tested by test/py. This
re-uses all the work done elsewhere to make buildman work within
Travis-CI, in particular related to toolchain downloading and buildman
config file creation.
Signed-off-by: Stephen Warren <swarren@nvidia.com>
---
.travis.yml | 81 ++++++++++++++++++++++++++++++++++++++++---------------------
1 file changed, 54 insertions(+), 27 deletions(-)
diff --git a/.travis.yml b/.travis.yml
index a537f0e34dd3..0faf03b11011 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -69,6 +69,9 @@ before_script:
- if [[ "${TOOLCHAIN}" == *xtensa* ]]; then ./tools/buildman/buildman --fetch-arch xtensa ; fi
script:
+ # Comments must be outside the command strings below, or the Travis parser
+ # will get confused.
+ #
# Exit code 129 means warnings only.
- if [[ "${BUILDMAN}" != "" ]]; then
set +e;
@@ -78,6 +81,15 @@ script:
exit $ret;
fi;
fi
+ # "not a_test_which_does_not_exist" is a dummy -k parameter which will
+ # never prevent any test from running. That way, we can always pass
+ # "-k something" even when $TEST_PY_TEST_SPEC doesnt need a custom
+ # value.
+ - if [[ "${TEST_PY_BD}" != "" ]]; then
+ ./test/py/test.py --bd ${TEST_PY_BD} ${TEST_PY_ID}
+ -k "${TEST_PY_TEST_SPEC:-not a_test_which_does_not_exist}"
+ --build-dir `cd .. && pwd`/.bm-work/${TEST_PY_BD};
+ fi
matrix:
include:
@@ -178,38 +190,53 @@ matrix:
- JOB="sloccount"
script:
- sloccount .
+
# test/py
- env:
- - JOB="test.py sandbox"
- script:
- - ./test/py/test.py --bd sandbox --build
+ - TEST_PY_BD="sandbox"
+ BUILDMAN="^sandbox$"
+ TOOLCHAIN="x86_64"
- env:
- - JOB="test.py ARM"
- - CROSS_COMPILE="/usr/bin/arm-linux-gnueabihf-"
- script:
- - ./test/py/test.py --bd vexpress_ca15_tc2 --id qemu --build;
- ./test/py/test.py --bd vexpress_ca9x4 --id qemu --build;
- ./test/py/test.py --bd integratorcp_cm926ejs --id qemu --build;
+ - TEST_PY_BD="vexpress_ca15_tc2"
+ TEST_PY_ID="--id qemu"
+ BUILDMAN="^vexpress_ca15_tc2$"
- env:
- - JOB="test.py MIPS"
- - TOOLCHAIN="mips"
- CROSS_COMPILE="${HOME}/.buildman-toolchains/gcc-4.9.0-nolibc/mips-linux/bin/mips-linux-"
- script:
- - ./test/py/test.py --bd qemu_mips --build -k 'not sleep';
- ./test/py/test.py --bd qemu_mipsel --build -k 'not sleep';
- ./test/py/test.py --bd qemu_mips64 --build -k 'not sleep';
- ./test/py/test.py --bd qemu_mips64el --build -k 'not sleep';
+ - TEST_PY_BD="vexpress_ca9x4"
+ TEST_PY_ID="--id qemu"
+ BUILDMAN="^vexpress_ca9x4$"
- env:
- - JOB="test.py PowerPC"
- - CROSS_COMPILE="/usr/bin/powerpc-linux-gnu-"
- script:
- - ./test/py/test.py --bd qemu-ppce500 --build -k 'not sleep'
+ - TEST_PY_BD="integratorcp_cm926ejs"
+ TEST_PY_ID="--id qemu"
+ BUILDMAN="^integratorcp_cm926ejs$"
- env:
- - JOB="test.py x86-64"
- - TOOLCHAIN="x86_64"
- BUILD_ROM=yes
- CROSS_COMPILE="${HOME}/.buildman-toolchains/gcc-4.9.0-nolibc/x86_64-linux/bin/x86_64-linux-"
- script:
- - ./test/py/test.py --bd qemu-x86 --build -k 'not sleep'
+ - TEST_PY_BD="qemu_mips"
+ TEST_PY_TEST_SPEC="not sleep"
+ BUILDMAN="^qemu_mips$"
+ TOOLCHAIN="mips"
+ - env:
+ - TEST_PY_BD="qemu_mipsel"
+ TEST_PY_TEST_SPEC="not sleep"
+ BUILDMAN="^qemu_mipsel$"
+ TOOLCHAIN="mips"
+ - env:
+ - TEST_PY_BD="qemu_mips64"
+ TEST_PY_TEST_SPEC="not sleep"
+ BUILDMAN="^qemu_mips64$"
+ TOOLCHAIN="mips"
+ - env:
+ - TEST_PY_BD="qemu_mips64el"
+ TEST_PY_TEST_SPEC="not sleep"
+ BUILDMAN="^qemu_mips64el$"
+ TOOLCHAIN="mips"
+ - env:
+ - TEST_PY_BD="qemu-ppce500"
+ TEST_PY_TEST_SPEC="not sleep"
+ BUILDMAN="^qemu-ppce500$"
+ - env:
+ - TEST_PY_BD="qemu-x76"
+ TEST_PY_TEST_SPEC="not sleep"
+ BUILDMAN="^qemu-x86$"
+ TOOLCHAIN="x86_64"
+ BUILD_ROM="yes"
# TODO make it perfect ;-r
--
2.10.1
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [U-Boot] [PATCH 6/6] travis-ci: compile with buildman when running test/py
2016-10-26 17:05 ` [U-Boot] [PATCH 6/6] travis-ci: compile with buildman when running test/py Stephen Warren
@ 2016-10-26 18:56 ` Stephen Warren
2016-10-26 18:59 ` Tom Rini
` (2 subsequent siblings)
3 siblings, 0 replies; 21+ messages in thread
From: Stephen Warren @ 2016-10-26 18:56 UTC (permalink / raw)
To: u-boot
On 10/26/2016 11:05 AM, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> Use buildman to compile any U-Boot binary tested by test/py. This
> re-uses all the work done elsewhere to make buildman work within
> Travis-CI, in particular related to toolchain downloading and buildman
> config file creation.
> diff --git a/.travis.yml b/.travis.yml
> + - env:
> + - TEST_PY_BD="qemu-x76"
Oops, that should be "86" not "76". I thought I'd fixed that, but must
have accidentally rebased the fix away:-(
I'll wait for any other comments before reposting.
^ permalink raw reply [flat|nested] 21+ messages in thread
* [U-Boot] [PATCH 6/6] travis-ci: compile with buildman when running test/py
2016-10-26 17:05 ` [U-Boot] [PATCH 6/6] travis-ci: compile with buildman when running test/py Stephen Warren
2016-10-26 18:56 ` Stephen Warren
@ 2016-10-26 18:59 ` Tom Rini
2016-10-26 19:04 ` Stephen Warren
2016-10-27 6:13 ` Heiko Schocher
2016-10-29 17:41 ` [U-Boot] [U-Boot, " Tom Rini
3 siblings, 1 reply; 21+ messages in thread
From: Tom Rini @ 2016-10-26 18:59 UTC (permalink / raw)
To: u-boot
On Wed, Oct 26, 2016 at 11:05:36AM -0600, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> Use buildman to compile any U-Boot binary tested by test/py. This
> re-uses all the work done elsewhere to make buildman work within
> Travis-CI, in particular related to toolchain downloading and buildman
> config file creation.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
> .travis.yml | 81 ++++++++++++++++++++++++++++++++++++++++---------------------
> 1 file changed, 54 insertions(+), 27 deletions(-)
Thanks for fixing all of this so we can use buildman with test.py. My
only real concern with this patch series is that now that we're doing N
jobs for test.py, is the setup/tear-down time for each machine causing
the job to run longer? Or do things like the "big" powerpc/arm jobs run
long enough that they're still going when we hit this?
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161026/6faec8b0/attachment.sig>
^ permalink raw reply [flat|nested] 21+ messages in thread
* [U-Boot] [PATCH 6/6] travis-ci: compile with buildman when running test/py
2016-10-26 18:59 ` Tom Rini
@ 2016-10-26 19:04 ` Stephen Warren
0 siblings, 0 replies; 21+ messages in thread
From: Stephen Warren @ 2016-10-26 19:04 UTC (permalink / raw)
To: u-boot
On 10/26/2016 12:59 PM, Tom Rini wrote:
> On Wed, Oct 26, 2016 at 11:05:36AM -0600, Stephen Warren wrote:
>
>> From: Stephen Warren <swarren@nvidia.com>
>>
>> Use buildman to compile any U-Boot binary tested by test/py. This
>> re-uses all the work done elsewhere to make buildman work within
>> Travis-CI, in particular related to toolchain downloading and buildman
>> config file creation.
>>
>> Signed-off-by: Stephen Warren <swarren@nvidia.com>
>> ---
>> .travis.yml | 81 ++++++++++++++++++++++++++++++++++++++++---------------------
>> 1 file changed, 54 insertions(+), 27 deletions(-)
>
> Thanks for fixing all of this so we can use buildman with test.py. My
> only real concern with this patch series is that now that we're doing N
> jobs for test.py, is the setup/tear-down time for each machine causing
> the job to run longer? Or do things like the "big" powerpc/arm jobs run
> long enough that they're still going when we hit this?
These jobs all take 1-4 minutes each, whereas a number of the build jobs
take over 30 minutes. Since there's some serialization (I've only see 5
jobs at most run in parallel), the extra separate setup probably does
increase the overall build time a tiny amount, but it doesn't seem
significant.
If we want, we could probably make TEST_PY_BD a list, and have the test
script loop over the entries, assuming that extra shell script logic
doesn't confuse Travis YAML parser:-(
^ permalink raw reply [flat|nested] 21+ messages in thread
* [U-Boot] [PATCH 1/6] travis-ci: Use = not : when writing ~/.buildman
2016-10-26 17:05 [U-Boot] [PATCH 1/6] travis-ci: Use = not : when writing ~/.buildman Stephen Warren
` (4 preceding siblings ...)
2016-10-26 17:05 ` [U-Boot] [PATCH 6/6] travis-ci: compile with buildman when running test/py Stephen Warren
@ 2016-10-27 4:20 ` Heiko Schocher
2016-10-29 17:41 ` [U-Boot] [U-Boot, " Tom Rini
6 siblings, 0 replies; 21+ messages in thread
From: Heiko Schocher @ 2016-10-27 4:20 UTC (permalink / raw)
To: u-boot
Hello Stephen,
Am 26.10.2016 um 19:05 schrieb Stephen Warren:
> From: Stephen Warren <swarren@nvidia.com>
>
> Travis CI seems to be confused when there's a colon in an echo command,
> and this is currently worked around using a variable that contains the
> text we want to echo. Use = syntax instead so that we can remove the
> work-around; it's rather confusing until you find out what it's for.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
> .travis.yml | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
Thanks!
Reviewed-by: Heiko Schocher <hs@denx.de>
bye,
Heiko
>
> diff --git a/.travis.yml b/.travis.yml
> index 00be5ff20396..f91e1bc271fe 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -38,8 +38,7 @@ install:
> - ln -s travis-ci /tmp/uboot-test-hooks/bin/`hostname`
> - ln -s travis-ci /tmp/uboot-test-hooks/py/`hostname`
> # prepare buildman environment
> - - export BUILDMAN_ROOT="root:"
> - - echo -e "[toolchain]\n${BUILDMAN_ROOT} /usr" > ~/.buildman
> + - echo -e "[toolchain]\nroot = /usr" > ~/.buildman
> - echo -e "\n[toolchain-alias]\nblackfin = bfin\nsh = sh4\nopenrisc = or32" >> ~/.buildman
> - cat ~/.buildman
> - virtualenv /tmp/venv
> @@ -105,8 +104,7 @@ matrix:
> - BUILDMAN="sandbox x86"
> TOOLCHAIN="x86_64"
> script:
> - - export BUILDMAN_X86="x86:";
> - echo -e "\n[toolchain-prefix]\n${BUILDMAN_X86} ${HOME}/.buildman-toolchains/gcc-4.9.0-nolibc/x86_64-linux/bin/x86_64-linux-" >> ~/.buildman
> + - echo -e "\n[toolchain-prefix]\nx86 = ${HOME}/.buildman-toolchains/gcc-4.9.0-nolibc/x86_64-linux/bin/x86_64-linux-" >> ~/.buildman
> - env:
> - BUILDMAN="kirkwood"
> - env:
>
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
^ permalink raw reply [flat|nested] 21+ messages in thread
* [U-Boot] [PATCH 2/6] travis-ci: use correct exit code on errors
2016-10-26 17:05 ` [U-Boot] [PATCH 2/6] travis-ci: use correct exit code on errors Stephen Warren
@ 2016-10-27 4:21 ` Heiko Schocher
2016-10-29 17:41 ` [U-Boot] [U-Boot, " Tom Rini
1 sibling, 0 replies; 21+ messages in thread
From: Heiko Schocher @ 2016-10-27 4:21 UTC (permalink / raw)
To: u-boot
Hello Stephen,
Am 26.10.2016 um 19:05 schrieb Stephen Warren:
> From: Stephen Warren <swarren@nvidia.com>
>
> The phrase "if [ $? -ne 0 ]; then exit $?; fi" doesn't work correctly;
> by the time the "exit" statement runs, $? has already been over-written
> by the result of the [ command. Fix this by explicitly storing $? and
> then using that stored value in both the test and the error-case exit
> statement.
>
> This change also converts from textual comparison to integer comparison,
> since the exit code is an integer and there's no need to convert it to
> a string for comparison.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
> .travis.yml | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
Thanks!
Reviewed-by: Heiko Schocher <hs@denx.de>
bye,
Heiko
>
> diff --git a/.travis.yml b/.travis.yml
> index f91e1bc271fe..33685ce14777 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -70,11 +70,12 @@ script:
> - if [[ "${BUILDMAN}" != "" ]]; then
> set +e;
> tools/buildman/buildman ${BUILDMAN};
> - if [[ "$?" == "0" || "$?" == "129" ]]; then
> + ret=$?;
> + if [[ $ret -eq 0 || $ret -eq 129 ]]; then
> exit 0;
> else
> - exit $?;
> - fi
> + exit $ret;
> + fi;
> fi
>
> matrix:
>
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
^ permalink raw reply [flat|nested] 21+ messages in thread
* [U-Boot] [PATCH 3/6] travis-ci: centralize ~/.buildman editing
2016-10-26 17:05 ` [U-Boot] [PATCH 3/6] travis-ci: centralize ~/.buildman editing Stephen Warren
@ 2016-10-27 4:21 ` Heiko Schocher
2016-10-29 17:41 ` [U-Boot] [U-Boot, " Tom Rini
1 sibling, 0 replies; 21+ messages in thread
From: Heiko Schocher @ 2016-10-27 4:21 UTC (permalink / raw)
To: u-boot
Hello Stephen,
Am 26.10.2016 um 19:05 schrieb Stephen Warren:
> From: Stephen Warren <swarren@nvidia.com>
>
> Any time an x86 toolchain is used, we need to edit ~/.buildman to
> reference it. Move the editing logic into a central place so that it
> doesn't have to be duplicated everywhere that uses the x86 toolchain;
> future patches will add additional cases where it's used.
>
> It would be nice if we could unconditionally write all of ~/.buildman at
> once. Unfortunately, buildman fails if any toolchain mentioned in a
> toolchain-prefix entry doesn't exist, even if it doesn't need to use it
> for the current build.
>
> The sandbox/x86 build definition currently does nothing more than edit
> ~/.buildman; no builds are run. Fix this by not defining a custom script
> for this build, and hence preventing that stanza from replacing the
> default script.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
> .travis.yml | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
Thanks!
Reviewed-by: Heiko Schocher <hs@denx.de>
bye,
Heiko
>
> diff --git a/.travis.yml b/.travis.yml
> index 33685ce14777..119dec8df5b2 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -62,7 +62,10 @@ before_script:
> - if [[ "${TOOLCHAIN}" == *mips* ]]; then ./tools/buildman/buildman --fetch-arch mips ; fi
> - if [[ "${TOOLCHAIN}" == *or32* ]]; then ./tools/buildman/buildman --fetch-arch or32 ; fi
> - if [[ "${TOOLCHAIN}" == *sh4* ]]; then ./tools/buildman/buildman --fetch-arch sh4 ; fi
> - - if [[ "${TOOLCHAIN}" == *x86_64* ]]; then ./tools/buildman/buildman --fetch-arch x86_64 ; fi
> + - if [[ "${TOOLCHAIN}" == *x86_64* ]]; then
> + ./tools/buildman/buildman --fetch-arch x86_64;
> + echo -e "\n[toolchain-prefix]\nx86 = ${HOME}/.buildman-toolchains/gcc-4.9.0-nolibc/x86_64-linux/bin/x86_64-linux-" >> ~/.buildman;
> + fi
> - if [[ "${TOOLCHAIN}" == *xtensa* ]]; then ./tools/buildman/buildman --fetch-arch xtensa ; fi
>
> script:
> @@ -104,8 +107,6 @@ matrix:
> - env:
> - BUILDMAN="sandbox x86"
> TOOLCHAIN="x86_64"
> - script:
> - - echo -e "\n[toolchain-prefix]\nx86 = ${HOME}/.buildman-toolchains/gcc-4.9.0-nolibc/x86_64-linux/bin/x86_64-linux-" >> ~/.buildman
> - env:
> - BUILDMAN="kirkwood"
> - env:
>
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
^ permalink raw reply [flat|nested] 21+ messages in thread
* [U-Boot] [PATCH 4/6] travis-ci: use buildman -P everywhere
2016-10-26 17:05 ` [U-Boot] [PATCH 4/6] travis-ci: use buildman -P everywhere Stephen Warren
@ 2016-10-27 4:22 ` Heiko Schocher
2016-10-29 17:41 ` [U-Boot] [U-Boot,4/6] " Tom Rini
1 sibling, 0 replies; 21+ messages in thread
From: Heiko Schocher @ 2016-10-27 4:22 UTC (permalink / raw)
To: u-boot
Hello Stephen,
Am 26.10.2016 um 19:05 schrieb Stephen Warren:
> From: Stephen Warren <swarren@nvidia.com>
>
> This places build results into a board-specific directory rather than a
> buildman-thread-specific directory. This is required so that we can
> access the directory from test.py, and there's no risk of a particular
> build's results being over-written by another build performed by the
> same thread.
>
> In theory, this can lead to slower builds when building many different
> boards in a single buildman thread, since it removes the possibility of
> incremental builds between boards. In practice however I didn't notice
> longer build times when when enabling this option; if anything build
> times decreased although I suspect that's simply due to general
> variations in build performance across different machines within the
> Travis CI infra-structure.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
> .travis.yml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks!
Reviewed-by: Heiko Schocher <hs@denx.de>
bye,
Heiko
>
> diff --git a/.travis.yml b/.travis.yml
> index 119dec8df5b2..6e72e0bb233f 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -72,7 +72,7 @@ script:
> # Exit code 129 means warnings only.
> - if [[ "${BUILDMAN}" != "" ]]; then
> set +e;
> - tools/buildman/buildman ${BUILDMAN};
> + tools/buildman/buildman -P ${BUILDMAN};
> ret=$?;
> if [[ $ret -eq 0 || $ret -eq 129 ]]; then
> exit 0;
>
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
^ permalink raw reply [flat|nested] 21+ messages in thread
* [U-Boot] [PATCH 5/6] travis-ci: don't invoke exit on success
2016-10-26 17:05 ` [U-Boot] [PATCH 5/6] travis-ci: don't invoke exit on success Stephen Warren
@ 2016-10-27 6:12 ` Heiko Schocher
2016-10-29 17:41 ` [U-Boot] [U-Boot,5/6] " Tom Rini
1 sibling, 0 replies; 21+ messages in thread
From: Heiko Schocher @ 2016-10-27 6:12 UTC (permalink / raw)
To: u-boot
Hello Stephen,
Am 26.10.2016 um 19:05 schrieb Stephen Warren:
> From: Stephen Warren <swarren@nvidia.com>
>
> Invoking exit prevents any subsequent build commands from running, and
> future patches will add extra commands.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
> .travis.yml | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Thanks!
Reviewed-by: Heiko Schocher <hs@denx.de>
bye,
Heiko
>
> diff --git a/.travis.yml b/.travis.yml
> index 6e72e0bb233f..a537f0e34dd3 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -74,9 +74,7 @@ script:
> set +e;
> tools/buildman/buildman -P ${BUILDMAN};
> ret=$?;
> - if [[ $ret -eq 0 || $ret -eq 129 ]]; then
> - exit 0;
> - else
> + if [[ $ret -ne 0 && $ret -ne 129 ]]; then
> exit $ret;
> fi;
> fi
>
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
^ permalink raw reply [flat|nested] 21+ messages in thread
* [U-Boot] [PATCH 6/6] travis-ci: compile with buildman when running test/py
2016-10-26 17:05 ` [U-Boot] [PATCH 6/6] travis-ci: compile with buildman when running test/py Stephen Warren
2016-10-26 18:56 ` Stephen Warren
2016-10-26 18:59 ` Tom Rini
@ 2016-10-27 6:13 ` Heiko Schocher
2016-10-29 17:41 ` [U-Boot] [U-Boot, " Tom Rini
3 siblings, 0 replies; 21+ messages in thread
From: Heiko Schocher @ 2016-10-27 6:13 UTC (permalink / raw)
To: u-boot
Hello Stephen,
Am 26.10.2016 um 19:05 schrieb Stephen Warren:
> From: Stephen Warren <swarren@nvidia.com>
>
> Use buildman to compile any U-Boot binary tested by test/py. This
> re-uses all the work done elsewhere to make buildman work within
> Travis-CI, in particular related to toolchain downloading and buildman
> config file creation.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
> .travis.yml | 81 ++++++++++++++++++++++++++++++++++++++++---------------------
> 1 file changed, 54 insertions(+), 27 deletions(-)
Thanks!
Reviewed-by: Heiko Schocher <hs@denx.de>
bye,
Heiko
>
> diff --git a/.travis.yml b/.travis.yml
> index a537f0e34dd3..0faf03b11011 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -69,6 +69,9 @@ before_script:
> - if [[ "${TOOLCHAIN}" == *xtensa* ]]; then ./tools/buildman/buildman --fetch-arch xtensa ; fi
>
> script:
> + # Comments must be outside the command strings below, or the Travis parser
> + # will get confused.
> + #
> # Exit code 129 means warnings only.
> - if [[ "${BUILDMAN}" != "" ]]; then
> set +e;
> @@ -78,6 +81,15 @@ script:
> exit $ret;
> fi;
> fi
> + # "not a_test_which_does_not_exist" is a dummy -k parameter which will
> + # never prevent any test from running. That way, we can always pass
> + # "-k something" even when $TEST_PY_TEST_SPEC doesnt need a custom
> + # value.
> + - if [[ "${TEST_PY_BD}" != "" ]]; then
> + ./test/py/test.py --bd ${TEST_PY_BD} ${TEST_PY_ID}
> + -k "${TEST_PY_TEST_SPEC:-not a_test_which_does_not_exist}"
> + --build-dir `cd .. && pwd`/.bm-work/${TEST_PY_BD};
> + fi
>
> matrix:
> include:
> @@ -178,38 +190,53 @@ matrix:
> - JOB="sloccount"
> script:
> - sloccount .
> +
> # test/py
> - env:
> - - JOB="test.py sandbox"
> - script:
> - - ./test/py/test.py --bd sandbox --build
> + - TEST_PY_BD="sandbox"
> + BUILDMAN="^sandbox$"
> + TOOLCHAIN="x86_64"
> - env:
> - - JOB="test.py ARM"
> - - CROSS_COMPILE="/usr/bin/arm-linux-gnueabihf-"
> - script:
> - - ./test/py/test.py --bd vexpress_ca15_tc2 --id qemu --build;
> - ./test/py/test.py --bd vexpress_ca9x4 --id qemu --build;
> - ./test/py/test.py --bd integratorcp_cm926ejs --id qemu --build;
> + - TEST_PY_BD="vexpress_ca15_tc2"
> + TEST_PY_ID="--id qemu"
> + BUILDMAN="^vexpress_ca15_tc2$"
> - env:
> - - JOB="test.py MIPS"
> - - TOOLCHAIN="mips"
> - CROSS_COMPILE="${HOME}/.buildman-toolchains/gcc-4.9.0-nolibc/mips-linux/bin/mips-linux-"
> - script:
> - - ./test/py/test.py --bd qemu_mips --build -k 'not sleep';
> - ./test/py/test.py --bd qemu_mipsel --build -k 'not sleep';
> - ./test/py/test.py --bd qemu_mips64 --build -k 'not sleep';
> - ./test/py/test.py --bd qemu_mips64el --build -k 'not sleep';
> + - TEST_PY_BD="vexpress_ca9x4"
> + TEST_PY_ID="--id qemu"
> + BUILDMAN="^vexpress_ca9x4$"
> - env:
> - - JOB="test.py PowerPC"
> - - CROSS_COMPILE="/usr/bin/powerpc-linux-gnu-"
> - script:
> - - ./test/py/test.py --bd qemu-ppce500 --build -k 'not sleep'
> + - TEST_PY_BD="integratorcp_cm926ejs"
> + TEST_PY_ID="--id qemu"
> + BUILDMAN="^integratorcp_cm926ejs$"
> - env:
> - - JOB="test.py x86-64"
> - - TOOLCHAIN="x86_64"
> - BUILD_ROM=yes
> - CROSS_COMPILE="${HOME}/.buildman-toolchains/gcc-4.9.0-nolibc/x86_64-linux/bin/x86_64-linux-"
> - script:
> - - ./test/py/test.py --bd qemu-x86 --build -k 'not sleep'
> + - TEST_PY_BD="qemu_mips"
> + TEST_PY_TEST_SPEC="not sleep"
> + BUILDMAN="^qemu_mips$"
> + TOOLCHAIN="mips"
> + - env:
> + - TEST_PY_BD="qemu_mipsel"
> + TEST_PY_TEST_SPEC="not sleep"
> + BUILDMAN="^qemu_mipsel$"
> + TOOLCHAIN="mips"
> + - env:
> + - TEST_PY_BD="qemu_mips64"
> + TEST_PY_TEST_SPEC="not sleep"
> + BUILDMAN="^qemu_mips64$"
> + TOOLCHAIN="mips"
> + - env:
> + - TEST_PY_BD="qemu_mips64el"
> + TEST_PY_TEST_SPEC="not sleep"
> + BUILDMAN="^qemu_mips64el$"
> + TOOLCHAIN="mips"
> + - env:
> + - TEST_PY_BD="qemu-ppce500"
> + TEST_PY_TEST_SPEC="not sleep"
> + BUILDMAN="^qemu-ppce500$"
> + - env:
> + - TEST_PY_BD="qemu-x76"
> + TEST_PY_TEST_SPEC="not sleep"
> + BUILDMAN="^qemu-x86$"
> + TOOLCHAIN="x86_64"
> + BUILD_ROM="yes"
>
> # TODO make it perfect ;-r
>
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
^ permalink raw reply [flat|nested] 21+ messages in thread
* [U-Boot] [U-Boot, 1/6] travis-ci: Use = not : when writing ~/.buildman
2016-10-26 17:05 [U-Boot] [PATCH 1/6] travis-ci: Use = not : when writing ~/.buildman Stephen Warren
` (5 preceding siblings ...)
2016-10-27 4:20 ` [U-Boot] [PATCH 1/6] travis-ci: Use = not : when writing ~/.buildman Heiko Schocher
@ 2016-10-29 17:41 ` Tom Rini
6 siblings, 0 replies; 21+ messages in thread
From: Tom Rini @ 2016-10-29 17:41 UTC (permalink / raw)
To: u-boot
On Wed, Oct 26, 2016 at 11:05:31AM -0600, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> Travis CI seems to be confused when there's a colon in an echo command,
> and this is currently worked around using a variable that contains the
> text we want to echo. Use = syntax instead so that we can remove the
> work-around; it's rather confusing until you find out what it's for.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> Reviewed-by: Heiko Schocher <hs@denx.de>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161029/4340b514/attachment.sig>
^ permalink raw reply [flat|nested] 21+ messages in thread
* [U-Boot] [U-Boot, 2/6] travis-ci: use correct exit code on errors
2016-10-26 17:05 ` [U-Boot] [PATCH 2/6] travis-ci: use correct exit code on errors Stephen Warren
2016-10-27 4:21 ` Heiko Schocher
@ 2016-10-29 17:41 ` Tom Rini
1 sibling, 0 replies; 21+ messages in thread
From: Tom Rini @ 2016-10-29 17:41 UTC (permalink / raw)
To: u-boot
On Wed, Oct 26, 2016 at 11:05:32AM -0600, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> The phrase "if [ $? -ne 0 ]; then exit $?; fi" doesn't work correctly;
> by the time the "exit" statement runs, $? has already been over-written
> by the result of the [ command. Fix this by explicitly storing $? and
> then using that stored value in both the test and the error-case exit
> statement.
>
> This change also converts from textual comparison to integer comparison,
> since the exit code is an integer and there's no need to convert it to
> a string for comparison.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> Reviewed-by: Heiko Schocher <hs@denx.de>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161029/2db0863c/attachment.sig>
^ permalink raw reply [flat|nested] 21+ messages in thread
* [U-Boot] [U-Boot, 3/6] travis-ci: centralize ~/.buildman editing
2016-10-26 17:05 ` [U-Boot] [PATCH 3/6] travis-ci: centralize ~/.buildman editing Stephen Warren
2016-10-27 4:21 ` Heiko Schocher
@ 2016-10-29 17:41 ` Tom Rini
1 sibling, 0 replies; 21+ messages in thread
From: Tom Rini @ 2016-10-29 17:41 UTC (permalink / raw)
To: u-boot
On Wed, Oct 26, 2016 at 11:05:33AM -0600, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> Any time an x86 toolchain is used, we need to edit ~/.buildman to
> reference it. Move the editing logic into a central place so that it
> doesn't have to be duplicated everywhere that uses the x86 toolchain;
> future patches will add additional cases where it's used.
>
> It would be nice if we could unconditionally write all of ~/.buildman at
> once. Unfortunately, buildman fails if any toolchain mentioned in a
> toolchain-prefix entry doesn't exist, even if it doesn't need to use it
> for the current build.
>
> The sandbox/x86 build definition currently does nothing more than edit
> ~/.buildman; no builds are run. Fix this by not defining a custom script
> for this build, and hence preventing that stanza from replacing the
> default script.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> Reviewed-by: Heiko Schocher <hs@denx.de>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161029/4b542466/attachment.sig>
^ permalink raw reply [flat|nested] 21+ messages in thread
* [U-Boot] [U-Boot,4/6] travis-ci: use buildman -P everywhere
2016-10-26 17:05 ` [U-Boot] [PATCH 4/6] travis-ci: use buildman -P everywhere Stephen Warren
2016-10-27 4:22 ` Heiko Schocher
@ 2016-10-29 17:41 ` Tom Rini
1 sibling, 0 replies; 21+ messages in thread
From: Tom Rini @ 2016-10-29 17:41 UTC (permalink / raw)
To: u-boot
On Wed, Oct 26, 2016 at 11:05:34AM -0600, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> This places build results into a board-specific directory rather than a
> buildman-thread-specific directory. This is required so that we can
> access the directory from test.py, and there's no risk of a particular
> build's results being over-written by another build performed by the
> same thread.
>
> In theory, this can lead to slower builds when building many different
> boards in a single buildman thread, since it removes the possibility of
> incremental builds between boards. In practice however I didn't notice
> longer build times when when enabling this option; if anything build
> times decreased although I suspect that's simply due to general
> variations in build performance across different machines within the
> Travis CI infra-structure.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> Reviewed-by: Heiko Schocher <hs@denx.de>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161029/e013b926/attachment.sig>
^ permalink raw reply [flat|nested] 21+ messages in thread
* [U-Boot] [U-Boot,5/6] travis-ci: don't invoke exit on success
2016-10-26 17:05 ` [U-Boot] [PATCH 5/6] travis-ci: don't invoke exit on success Stephen Warren
2016-10-27 6:12 ` Heiko Schocher
@ 2016-10-29 17:41 ` Tom Rini
1 sibling, 0 replies; 21+ messages in thread
From: Tom Rini @ 2016-10-29 17:41 UTC (permalink / raw)
To: u-boot
On Wed, Oct 26, 2016 at 11:05:35AM -0600, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> Invoking exit prevents any subsequent build commands from running, and
> future patches will add extra commands.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> Reviewed-by: Heiko Schocher <hs@denx.de>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161029/d21163c4/attachment.sig>
^ permalink raw reply [flat|nested] 21+ messages in thread
* [U-Boot] [U-Boot, 6/6] travis-ci: compile with buildman when running test/py
2016-10-26 17:05 ` [U-Boot] [PATCH 6/6] travis-ci: compile with buildman when running test/py Stephen Warren
` (2 preceding siblings ...)
2016-10-27 6:13 ` Heiko Schocher
@ 2016-10-29 17:41 ` Tom Rini
3 siblings, 0 replies; 21+ messages in thread
From: Tom Rini @ 2016-10-29 17:41 UTC (permalink / raw)
To: u-boot
On Wed, Oct 26, 2016 at 11:05:36AM -0600, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> Use buildman to compile any U-Boot binary tested by test/py. This
> re-uses all the work done elsewhere to make buildman work within
> Travis-CI, in particular related to toolchain downloading and buildman
> config file creation.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> Reviewed-by: Heiko Schocher <hs@denx.de>
Fixed the typo for qemu-x86 and applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161029/547e91b1/attachment.sig>
^ permalink raw reply [flat|nested] 21+ messages in thread
end of thread, other threads:[~2016-10-29 17:41 UTC | newest]
Thread overview: 21+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-26 17:05 [U-Boot] [PATCH 1/6] travis-ci: Use = not : when writing ~/.buildman Stephen Warren
2016-10-26 17:05 ` [U-Boot] [PATCH 2/6] travis-ci: use correct exit code on errors Stephen Warren
2016-10-27 4:21 ` Heiko Schocher
2016-10-29 17:41 ` [U-Boot] [U-Boot, " Tom Rini
2016-10-26 17:05 ` [U-Boot] [PATCH 3/6] travis-ci: centralize ~/.buildman editing Stephen Warren
2016-10-27 4:21 ` Heiko Schocher
2016-10-29 17:41 ` [U-Boot] [U-Boot, " Tom Rini
2016-10-26 17:05 ` [U-Boot] [PATCH 4/6] travis-ci: use buildman -P everywhere Stephen Warren
2016-10-27 4:22 ` Heiko Schocher
2016-10-29 17:41 ` [U-Boot] [U-Boot,4/6] " Tom Rini
2016-10-26 17:05 ` [U-Boot] [PATCH 5/6] travis-ci: don't invoke exit on success Stephen Warren
2016-10-27 6:12 ` Heiko Schocher
2016-10-29 17:41 ` [U-Boot] [U-Boot,5/6] " Tom Rini
2016-10-26 17:05 ` [U-Boot] [PATCH 6/6] travis-ci: compile with buildman when running test/py Stephen Warren
2016-10-26 18:56 ` Stephen Warren
2016-10-26 18:59 ` Tom Rini
2016-10-26 19:04 ` Stephen Warren
2016-10-27 6:13 ` Heiko Schocher
2016-10-29 17:41 ` [U-Boot] [U-Boot, " Tom Rini
2016-10-27 4:20 ` [U-Boot] [PATCH 1/6] travis-ci: Use = not : when writing ~/.buildman Heiko Schocher
2016-10-29 17:41 ` [U-Boot] [U-Boot, " Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.