All of lore.kernel.org
 help / color / mirror / Atom feed
* [merged] mm-list_lruc-avoid-error-path-null-pointer-deref.patch removed from -mm tree
@ 2016-10-28 18:30 akpm
  0 siblings, 0 replies; 2+ messages in thread
From: akpm @ 2016-10-28 18:30 UTC (permalink / raw)
  To: apolyakov, stable, vdavydov.dev, viro, mm-commits


The patch titled
     Subject: mm/list_lru.c: avoid error-path NULL pointer deref
has been removed from the -mm tree.  Its filename was
     mm-list_lruc-avoid-error-path-null-pointer-deref.patch

This patch was dropped because it was merged into mainline or a subsystem tree

------------------------------------------------------
From: Alexander Polakov <apolyakov@beget.ru>
Subject: mm/list_lru.c: avoid error-path NULL pointer deref

As described in https://bugzilla.kernel.org/show_bug.cgi?id=177821:

After some analysis it seems to be that the problem is in alloc_super(). 
In case list_lru_init_memcg() fails it goes into destroy_super(), which
calls list_lru_destroy().

And in list_lru_init() we see that in case memcg_init_list_lru() fails,
lru->node is freed, but not set NULL, which then leads list_lru_destroy()
to believe it is initialized and call memcg_destroy_list_lru(). 
memcg_destroy_list_lru() in turn can access lru->node[i].memcg_lrus, which
is NULL.

[akpm@linux-foundation.org: add comment]
Signed-off-by: Alexander Polakov <apolyakov@beget.ru>
Acked-by: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 mm/list_lru.c |    2 ++
 1 file changed, 2 insertions(+)

diff -puN mm/list_lru.c~mm-list_lruc-avoid-error-path-null-pointer-deref mm/list_lru.c
--- a/mm/list_lru.c~mm-list_lruc-avoid-error-path-null-pointer-deref
+++ a/mm/list_lru.c
@@ -554,6 +554,8 @@ int __list_lru_init(struct list_lru *lru
 	err = memcg_init_list_lru(lru, memcg_aware);
 	if (err) {
 		kfree(lru->node);
+		/* Do this so a list_lru_destroy() doesn't crash: */
+		lru->node = NULL;
 		goto out;
 	}
 
_

Patches currently in -mm which might be from apolyakov@beget.ru are



^ permalink raw reply	[flat|nested] 2+ messages in thread

* [merged] mm-list_lruc-avoid-error-path-null-pointer-deref.patch removed from -mm tree
@ 2016-10-28 18:30 akpm
  0 siblings, 0 replies; 2+ messages in thread
From: akpm @ 2016-10-28 18:30 UTC (permalink / raw)
  To: apolyakov, stable, vdavydov.dev, viro, mm-commits


The patch titled
     Subject: mm/list_lru.c: avoid error-path NULL pointer deref
has been removed from the -mm tree.  Its filename was
     mm-list_lruc-avoid-error-path-null-pointer-deref.patch

This patch was dropped because it was merged into mainline or a subsystem tree

------------------------------------------------------
From: Alexander Polakov <apolyakov@beget.ru>
Subject: mm/list_lru.c: avoid error-path NULL pointer deref

As described in https://bugzilla.kernel.org/show_bug.cgi?id=177821:

After some analysis it seems to be that the problem is in alloc_super(). 
In case list_lru_init_memcg() fails it goes into destroy_super(), which
calls list_lru_destroy().

And in list_lru_init() we see that in case memcg_init_list_lru() fails,
lru->node is freed, but not set NULL, which then leads list_lru_destroy()
to believe it is initialized and call memcg_destroy_list_lru(). 
memcg_destroy_list_lru() in turn can access lru->node[i].memcg_lrus, which
is NULL.

[akpm@linux-foundation.org: add comment]
Signed-off-by: Alexander Polakov <apolyakov@beget.ru>
Acked-by: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 mm/list_lru.c |    2 ++
 1 file changed, 2 insertions(+)

diff -puN mm/list_lru.c~mm-list_lruc-avoid-error-path-null-pointer-deref mm/list_lru.c
--- a/mm/list_lru.c~mm-list_lruc-avoid-error-path-null-pointer-deref
+++ a/mm/list_lru.c
@@ -554,6 +554,8 @@ int __list_lru_init(struct list_lru *lru
 	err = memcg_init_list_lru(lru, memcg_aware);
 	if (err) {
 		kfree(lru->node);
+		/* Do this so a list_lru_destroy() doesn't crash: */
+		lru->node = NULL;
 		goto out;
 	}
 
_

Patches currently in -mm which might be from apolyakov@beget.ru are



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-10-28 18:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-28 18:30 [merged] mm-list_lruc-avoid-error-path-null-pointer-deref.patch removed from -mm tree akpm
2016-10-28 18:30 akpm

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.