Issue with dt_to_config with dts files that include headers from dt-bindings

Issue with dt_to_config with dts files that include headers from dt-bindings

[Peter Robinson]

Hi Gaurav, Rob and Frank,

I've just discovered the dt_to_config script (awesome thanks!) but it
errors out when a dts(i) includes a header file from dt-bindings. EG

./scripts/dtc/dt_to_config arch/arm/boot/dts/am335x-boneblack.dts
In file included from arch/arm/boot/dts/am335x-boneblack.dts:10:0:
arch/arm/boot/dts/am33xx.dtsi:11:35: error: no include path in which
to search for dt-bindings/gpio/gpio.h
 #include <dt-bindings/gpio/gpio.h>
                                   ^
arch/arm/boot/dts/am33xx.dtsi:12:40: error: no include path in which
to search for dt-bindings/pinctrl/am33xx.h
 #include <dt-bindings/pinctrl/am33xx.h>
                                        ^
arch/arm/boot/dts/am335x-boneblack.dts:12:41: error: no include path
in which to search for dt-bindings/display/tda998x.h
 #include <dt-bindings/display/tda998x.h>
                                         ^
Error: arch/arm/boot/dts/am335x-bone-common.dtsi:33.23-24 syntax error
FATAL ERROR: Unable to parse input tree


Regards,
Peter
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Issue with dt_to_config with dts files that include headers from dt-bindings

[Gaurav Minocha]

[-- Attachment #1: Type: text/plain, Size: 1174 bytes --]

On Nov 4, 2016 1:19 PM, "Peter Robinson" <pbrobinson@gmail.com> wrote:
>
> Hi Gaurav, Rob and Frank,
>
> I've just discovered the dt_to_config script (awesome thanks!) but it
> errors out when a dts(i) includes a header file from dt-bindings. EG
>
> ./scripts/dtc/dt_to_config arch/arm/boot/dts/am335x-boneblack.dts
> In file included from arch/arm/boot/dts/am335x-boneblack.dts:10:0:
> arch/arm/boot/dts/am33xx.dtsi:11:35: error: no include path in which
> to search for dt-bindings/gpio/gpio.h
>  #include <dt-bindings/gpio/gpio.h>
>                                    ^
> arch/arm/boot/dts/am33xx.dtsi:12:40: error: no include path in which
> to search for dt-bindings/pinctrl/am33xx.h
>  #include <dt-bindings/pinctrl/am33xx.h>
>                                         ^
> arch/arm/boot/dts/am335x-boneblack.dts:12:41: error: no include path
> in which to search for dt-bindings/display/tda998x.h
>  #include <dt-bindings/display/tda998x.h>
>                                          ^
> Error: arch/arm/boot/dts/am335x-bone-common.dtsi:33.23-24 syntax error
> FATAL ERROR: Unable to parse input tree
>

In bash do, export ARCH=arm

Works for me!

>
> Regards,
> Peter

[-- Attachment #2: Type: text/html, Size: 1611 bytes --]

Re: Issue with dt_to_config with dts files that include headers from dt-bindings

[Gaurav Minocha]

On Sat, Nov 5, 2016 at 2:56 PM, Gaurav Minocha
<gaurav.minocha.os-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> On Nov 4, 2016 1:19 PM, "Peter Robinson" <pbrobinson-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>>
>> Hi Gaurav, Rob and Frank,
>>
>> I've just discovered the dt_to_config script (awesome thanks!) but it
>> errors out when a dts(i) includes a header file from dt-bindings. EG
>>
>> ./scripts/dtc/dt_to_config arch/arm/boot/dts/am335x-boneblack.dts
>> In file included from arch/arm/boot/dts/am335x-boneblack.dts:10:0:
>> arch/arm/boot/dts/am33xx.dtsi:11:35: error: no include path in which
>> to search for dt-bindings/gpio/gpio.h
>>  #include <dt-bindings/gpio/gpio.h>
>>                                    ^
>> arch/arm/boot/dts/am33xx.dtsi:12:40: error: no include path in which
>> to search for dt-bindings/pinctrl/am33xx.h
>>  #include <dt-bindings/pinctrl/am33xx.h>
>>                                         ^
>> arch/arm/boot/dts/am335x-boneblack.dts:12:41: error: no include path
>> in which to search for dt-bindings/display/tda998x.h
>>  #include <dt-bindings/display/tda998x.h>
>>                                          ^
>> Error: arch/arm/boot/dts/am335x-bone-common.dtsi:33.23-24 syntax error
>> FATAL ERROR: Unable to parse input tree
>>
>
> In bash do, export ARCH=arm
>
> Works for me!
>
>>
>> Regards,
>> Peter
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Issue with dt_to_config with dts files that include headers from dt-bindings

[Frank Rowand]

On 11/05/16 13:56, Gaurav Minocha wrote:
> On Nov 4, 2016 1:19 PM, "Peter Robinson" <pbrobinson-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>>
>> Hi Gaurav, Rob and Frank,
>>
>> I've just discovered the dt_to_config script (awesome thanks!) but it
>> errors out when a dts(i) includes a header file from dt-bindings. EG
>>
>> ./scripts/dtc/dt_to_config arch/arm/boot/dts/am335x-boneblack.dts
>> In file included from arch/arm/boot/dts/am335x-boneblack.dts:10:0:
>> arch/arm/boot/dts/am33xx.dtsi:11:35: error: no include path in which
>> to search for dt-bindings/gpio/gpio.h
>>  #include <dt-bindings/gpio/gpio.h>
>>                                    ^
>> arch/arm/boot/dts/am33xx.dtsi:12:40: error: no include path in which
>> to search for dt-bindings/pinctrl/am33xx.h
>>  #include <dt-bindings/pinctrl/am33xx.h>
>>                                         ^
>> arch/arm/boot/dts/am335x-boneblack.dts:12:41: error: no include path
>> in which to search for dt-bindings/display/tda998x.h
>>  #include <dt-bindings/display/tda998x.h>
>>                                          ^
>> Error: arch/arm/boot/dts/am335x-bone-common.dtsi:33.23-24 syntax error
>> FATAL ERROR: Unable to parse input tree
>>
> 
> In bash do, export ARCH=arm
> 
> Works for me!
> 
>>
>> Regards,
>> Peter
> 

Were there any other error messages reported? There should have
been a message suggesting that $ARCH was not set (if it wasn't)
and that it did not have the value of "arm".

If that message did not exist, I would like to understand why.

If the message did exist, but was not clear, how could the
message change to be more helpful?

-Frank
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Issue with dt_to_config with dts files that include headers from dt-bindings

[Chris Wyse]

On 11/07/16 10:51, Frank Rowand wrote:
> On 11/05/16 13:56, Gaurav Minocha wrote:
>> On Nov 4, 2016 1:19 PM, "Peter Robinson" <pbrobinson@xxxxxxxxx> wrote:
>>>
>>> Hi Gaurav, Rob and Frank,
>>>
>>> I've just discovered the dt_to_config script (awesome thanks!) but it
>>> errors out when a dts(i) includes a header file from dt-bindings. EG
>>>
>>> ./scripts/dtc/dt_to_config arch/arm/boot/dts/am335x-boneblack.dts
>>> In file included from arch/arm/boot/dts/am335x-boneblack.dts:10:0:
>>> arch/arm/boot/dts/am33xx.dtsi:11:35: error: no include path in which
>>> to search for dt-bindings/gpio/gpio.h
>>>  #include <dt-bindings/gpio/gpio.h>
>>>                                    ^
>>> arch/arm/boot/dts/am33xx.dtsi:12:40: error: no include path in which
>>> to search for dt-bindings/pinctrl/am33xx.h
>>>  #include <dt-bindings/pinctrl/am33xx.h>
>>>                                         ^
>>> arch/arm/boot/dts/am335x-boneblack.dts:12:41: error: no include path
>>> in which to search for dt-bindings/display/tda998x.h
>>>  #include <dt-bindings/display/tda998x.h>
>>>                                          ^
>>> Error: arch/arm/boot/dts/am335x-bone-common.dtsi:33.23-24 syntax error
>>> FATAL ERROR: Unable to parse input tree
>>>
>> 
>> In bash do, export ARCH=arm
>> 
>> Works for me!
>> 
>>>
>>> Regards,
>>> Peter
>> 
>
>Were there any other error messages reported? There should have
>been a message suggesting that $ARCH was not set (if it wasn't)
>and that it did not have the value of "arm".
>
>If that message did not exist, I would like to understand why.
>
>If the message did exist, but was not clear, how could the
>message change to be more helpful?
>
>-Frank
>--

I just tried using this utility from inside a Yocto devshell, with a 4.1.15 kernel.  
It didn't have dtx_diff or dt_to_config, so I copied them from the master branch.
I received the same errors about the missing include path.  The ARCH environment
variable was properly defined as 'arm'.  I resolved the problem by modifying the 
dtx_diff script to use ${srctree}/include in its include path when using both dtc
and gcc.

>From dtx_diff:
    cpp_flags="\
            -nostdinc                                  \
            -I${srctree}/scripts/dtc/include-prefixes  \
            -I${srctree}/include                       \
            -undef -D__DTS__"

    DTC="\
            ${DTC}                                     \
            -i ${srctree}/scripts/dtc/include-prefixes \
            -I${srctree}/include                       \
            -O dts -qq -f ${dtc_sort} -o -"

Chris