From: Frank Rowand <frowand.list@gmail.com>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] of: base: add support to get machine model name
Date: Mon, 21 Nov 2016 12:49:08 -0800 [thread overview]
Message-ID: <58335DC4.1030905@gmail.com> (raw)
In-Reply-To: <58334A06.103@gmail.com>
On 11/21/16 11:24, Frank Rowand wrote:
> On 11/21/16 08:23, Sudeep Holla wrote:
>>
>>
>> On 21/11/16 16:05, Frank Rowand wrote:
>>> Hi Sudeep,
>>>
>>> On 11/18/16 12:22, Frank Rowand wrote:
>>>> On 11/18/16 02:41, Sudeep Holla wrote:
>>>>>
>>>>>
>>>>> On 17/11/16 21:00, Frank Rowand wrote:
>>>>>> On 11/17/16 07:32, Sudeep Holla wrote:
>>>>>>> Currently platforms/drivers needing to get the machine model name are
>>>>>>> replicating the same snippet of code. In some case, the OF reference
>>>>>>> counting is either missing or incorrect.
>>>>>>>
>>>>>>> This patch adds support to read the machine model name either using
>>>>>>> the "model" or the "compatible" property in the device tree root node
>>>>>>> to the core OF/DT code.
>>>>>>>
>>>>>>> This can be used to remove all the duplicate code snippets doing exactly
>>>>>>> same thing later.
>>>>>>
>>>>>> I find five instances of reading only property "model":
>>>>>>
>>>>>> arch/arm/mach-imx/cpu.c
>>>>>> arch/arm/mach-mxs/mach-mxs.c
>>>>>> arch/c6x/kernel/setup.c
>>>>>> arch/mips/cavium-octeon/setup.c
>>>>>> arch/sh/boards/of-generic.c
>>>>>>
>>>>>
>>>>> Ah sorry you were not Cc-ed in 2/2, but that shows all the instances
>>>>> that this will be used for.
>>>>
>>>> I have not seen 2/2. I do not see it on the devicetree list or on lkml.
>>>
>>> Can you please re-send patch 2/2?
>>>
>>
>> Since it is based on -next, I would prefer to wait until next merge
>> window to resend. You should be able to check in the link I sent if
>> that's OK.
>
> I am missing or misunderstanding something.
>
> I do not know what "the link I sent" means.
Ah, the links were in the email you sent before this one, but I read this
one first. Got it now.
>
> For some reason, the devicetree mail list and lmkl mail failed to send
> me a copy of patch 2/2. Or my mail server failed to receive them. That
> is why I asked you to resend the patch. I just now looked in the devicetree
> archive and found it there.
>
> So I now can see how you plan to use the new function.
>
> -Frank
>
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Frank Rowand <frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Sudeep Holla <sudeep.holla-5wv7dgnIgG8@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/2] of: base: add support to get machine model name
Date: Mon, 21 Nov 2016 12:49:08 -0800 [thread overview]
Message-ID: <58335DC4.1030905@gmail.com> (raw)
In-Reply-To: <58334A06.103-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On 11/21/16 11:24, Frank Rowand wrote:
> On 11/21/16 08:23, Sudeep Holla wrote:
>>
>>
>> On 21/11/16 16:05, Frank Rowand wrote:
>>> Hi Sudeep,
>>>
>>> On 11/18/16 12:22, Frank Rowand wrote:
>>>> On 11/18/16 02:41, Sudeep Holla wrote:
>>>>>
>>>>>
>>>>> On 17/11/16 21:00, Frank Rowand wrote:
>>>>>> On 11/17/16 07:32, Sudeep Holla wrote:
>>>>>>> Currently platforms/drivers needing to get the machine model name are
>>>>>>> replicating the same snippet of code. In some case, the OF reference
>>>>>>> counting is either missing or incorrect.
>>>>>>>
>>>>>>> This patch adds support to read the machine model name either using
>>>>>>> the "model" or the "compatible" property in the device tree root node
>>>>>>> to the core OF/DT code.
>>>>>>>
>>>>>>> This can be used to remove all the duplicate code snippets doing exactly
>>>>>>> same thing later.
>>>>>>
>>>>>> I find five instances of reading only property "model":
>>>>>>
>>>>>> arch/arm/mach-imx/cpu.c
>>>>>> arch/arm/mach-mxs/mach-mxs.c
>>>>>> arch/c6x/kernel/setup.c
>>>>>> arch/mips/cavium-octeon/setup.c
>>>>>> arch/sh/boards/of-generic.c
>>>>>>
>>>>>
>>>>> Ah sorry you were not Cc-ed in 2/2, but that shows all the instances
>>>>> that this will be used for.
>>>>
>>>> I have not seen 2/2. I do not see it on the devicetree list or on lkml.
>>>
>>> Can you please re-send patch 2/2?
>>>
>>
>> Since it is based on -next, I would prefer to wait until next merge
>> window to resend. You should be able to check in the link I sent if
>> that's OK.
>
> I am missing or misunderstanding something.
>
> I do not know what "the link I sent" means.
Ah, the links were in the email you sent before this one, but I read this
one first. Got it now.
>
> For some reason, the devicetree mail list and lmkl mail failed to send
> me a copy of patch 2/2. Or my mail server failed to receive them. That
> is why I asked you to resend the patch. I just now looked in the devicetree
> archive and found it there.
>
> So I now can see how you plan to use the new function.
>
> -Frank
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-11-21 20:49 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-17 15:32 [PATCH 1/2] of: base: add support to get machine model name Sudeep Holla
2016-11-17 15:32 ` Sudeep Holla
2016-11-17 15:32 ` [PATCH 2/2] of: base: replace all duplicate code with of_machine_get_model_name Sudeep Holla
2016-11-17 21:00 ` [PATCH 1/2] of: base: add support to get machine model name Frank Rowand
2016-11-17 21:00 ` Frank Rowand
2016-11-17 22:12 ` Frank Rowand
2016-11-17 22:12 ` Frank Rowand
2016-11-18 10:41 ` Sudeep Holla
2016-11-18 10:41 ` Sudeep Holla
2016-11-18 20:22 ` Frank Rowand
2016-11-18 20:22 ` Frank Rowand
2016-11-21 16:05 ` Frank Rowand
2016-11-21 16:05 ` Frank Rowand
2016-11-21 16:23 ` Sudeep Holla
2016-11-21 16:23 ` Sudeep Holla
2016-11-21 19:24 ` Frank Rowand
2016-11-21 19:24 ` Frank Rowand
2016-11-21 20:49 ` Frank Rowand [this message]
2016-11-21 20:49 ` Frank Rowand
2016-11-21 16:20 ` Sudeep Holla
2016-11-21 20:21 ` Frank Rowand
2016-11-21 20:21 ` Frank Rowand
2016-11-18 14:46 ` Rob Herring
2016-11-18 20:00 ` Frank Rowand
2016-11-18 20:00 ` Frank Rowand
2016-11-22 18:44 ` Frank Rowand
2016-11-22 18:44 ` Frank Rowand
2016-11-22 21:35 ` Rob Herring
2016-11-23 10:25 ` Sudeep Holla
2016-12-09 16:03 ` Rob Herring
2016-12-09 23:54 ` Frank Rowand
2016-12-09 23:54 ` Frank Rowand
2016-12-12 15:17 ` Rob Herring
2016-12-12 15:17 ` Rob Herring
2016-11-23 10:23 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58335DC4.1030905@gmail.com \
--to=frowand.list@gmail.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.