All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: Julien Grall <julien.grall@arm.com>
Cc: ian.jackson@eu.citrix.com, xen-devel@lists.xen.org,
	sstabellini@kernel.org, wei.liu2@citrix.com,
	Andrii Anisov <andrii.anisov@gmail.com>
Subject: Re: [PATCH for-4.8] tools/libacpi: Fix compilation when cross building the tools
Date: Mon, 28 Nov 2016 01:10:56 -0700	[thread overview]
Message-ID: <583BF4A00200007800122A81@prv-mh.provo.novell.com> (raw)
In-Reply-To: <1480100781-2915-1-git-send-email-julien.grall@arm.com>

>>> On 25.11.16 at 20:06, <julien.grall@arm.com> wrote:
> --- a/tools/libacpi/Makefile
> +++ b/tools/libacpi/Makefile
> @@ -27,6 +27,11 @@ DSDT_FILES ?= $(C_SRC-y)
>  C_SRC = $(addprefix $(ACPI_BUILD_DIR)/, $(DSDT_FILES))
>  H_SRC = $(addprefix $(ACPI_BUILD_DIR)/, ssdt_s3.h ssdt_s4.h ssdt_pm.h ssdt_tpm.h)
>  
> +MKDSDT_CFLAGS-$(CONFIG_ARM_64) = -DCONFIG_ARM_64
> +MKDSDT_CFLAGS-$(CONFIG_X86) = -DCONFIG_X86
> +
> +MKDSDT_CFLAGS = $(MKDSDT_CFLAGS-y)

On top of what Andrew has said, I don't think this variable is really
needed at this point anyway. Simply use the -y tagged one below
right away.

> --- a/tools/libacpi/mk_dsdt.c
> +++ b/tools/libacpi/mk_dsdt.c
> @@ -17,9 +17,9 @@
>  #include <getopt.h>
>  #include <stdlib.h>
>  #include <stdbool.h>
> -#if defined(__i386__) || defined(__x86_64__)
> +#ifdef CONFIG_X86
>  #include <xen/hvm/hvm_info_table.h>
> -#elif defined(__aarch64__)
> +#elif CONFIG_ARM_64

#elif defined()

Also, for thing to look consistent, please also use #if defined()
in favor of #ifdef then (unless, like in a few cases further down)
there's no such "else".

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  parent reply	other threads:[~2016-11-28  8:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-25 19:06 [PATCH for-4.8] tools/libacpi: Fix compilation when cross building the tools Julien Grall
2016-11-25 19:12 ` Andrew Cooper
2016-11-28 13:00   ` Julien Grall
2016-11-28 13:01     ` Andrew Cooper
2016-11-28  8:10 ` Jan Beulich [this message]
2016-11-28 12:53   ` Julien Grall
2016-11-28 12:53 ` Jungseok Lee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=583BF4A00200007800122A81@prv-mh.provo.novell.com \
    --to=jbeulich@suse.com \
    --cc=andrii.anisov@gmail.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=julien.grall@arm.com \
    --cc=sstabellini@kernel.org \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.