From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Julien Grall <julien.grall@arm.com>, xen-devel@lists.xen.org
Cc: ian.jackson@eu.citrix.com, sstabellini@kernel.org,
wei.liu2@citrix.com, jbeulich@suse.com,
Andrii Anisov <andrii.anisov@gmail.com>
Subject: Re: [PATCH for-4.8] tools/libacpi: Fix compilation when cross building the tools
Date: Mon, 28 Nov 2016 13:01:13 +0000 [thread overview]
Message-ID: <bff4105c-2175-f22f-712c-56aae9a674f9@citrix.com> (raw)
In-Reply-To: <4ef434f3-2867-8a68-078c-1cd4d2efe643@arm.com>
On 28/11/16 13:00, Julien Grall wrote:
> Hi Andrew,
>
> On 25/11/16 19:12, Andrew Cooper wrote:
>> On 25/11/16 19:06, Julien Grall wrote:
>>> The tools (such as mk_dsdt) can be cross-built when it may not be
>>> desirable to build them on the target.
>>>
>>> The commit c4ac1077 "libxl/arm: Generate static ACPI DSDT table"
>>> introduced support of ARM64 in mk_dsdt but also break cross-building
>>> tools because the ACPI tables are not correct.
>>>
>>> While mk_dsdt should generate ACPI table for the target
>>> architecture, it
>>> currently generates the one for the host. This is because the source
>>> code contains reference to the host architecture (__aarch64__,
>>> __x86_64__, __i386__) when it should be the target architecture.
>>>
>>> Replace all __aarch64__, __x86_64__, __i386__ by the corresponding
>>> CONFIG_*.
>>>
>>> Also expose the CONFIG_* to the source code as the currently only
>>> exposed to the Makefile.
>>>
>>> Reported-by: Andrii Anisov <andrii.anisov@gmail.com>
>>> Suggested-by: Wei Liu <wei.liu2@citrix.com>
>>> Signed-off-by: Julien Grall <julien.grall@arm.com>
>>
>> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>, with one tweak,
>
> Jan asked few changes in the patch. Can I keep the reviewed-by on the
> next version?
Yes. Fine by me.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-11-28 13:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-25 19:06 [PATCH for-4.8] tools/libacpi: Fix compilation when cross building the tools Julien Grall
2016-11-25 19:12 ` Andrew Cooper
2016-11-28 13:00 ` Julien Grall
2016-11-28 13:01 ` Andrew Cooper [this message]
2016-11-28 8:10 ` Jan Beulich
2016-11-28 12:53 ` Julien Grall
2016-11-28 12:53 ` Jungseok Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bff4105c-2175-f22f-712c-56aae9a674f9@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=andrii.anisov@gmail.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=julien.grall@arm.com \
--cc=sstabellini@kernel.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.