All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH net-next] samples/bpf: fix include path
@ 2016-11-29  6:07 Alexei Starovoitov
  2016-11-29  6:34 ` Daniel Borkmann
  2016-11-30 17:42 ` David Miller
  0 siblings, 2 replies; 4+ messages in thread
From: Alexei Starovoitov @ 2016-11-29  6:07 UTC (permalink / raw)
  To: David S . Miller; +Cc: Daniel Borkmann, netdev

Fix the following build error:
HOSTCC  samples/bpf/test_lru_dist.o
../samples/bpf/test_lru_dist.c:25:22: fatal error: bpf_util.h: No such file or directory

This is due to objtree != srctree.
Use srctree, since that's where bpf_util.h is located.

Fixes: e00c7b216f34 ("bpf: fix multiple issues in selftest suite and samples")
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
---
 samples/bpf/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/samples/bpf/Makefile b/samples/bpf/Makefile
index 22b6407efa4f..3ceb5a9d86df 100644
--- a/samples/bpf/Makefile
+++ b/samples/bpf/Makefile
@@ -91,7 +91,7 @@ always += trace_event_kern.o
 always += sampleip_kern.o
 
 HOSTCFLAGS += -I$(objtree)/usr/include
-HOSTCFLAGS += -I$(objtree)/tools/testing/selftests/bpf/
+HOSTCFLAGS += -I$(srctree)/tools/testing/selftests/bpf/
 
 HOSTCFLAGS_bpf_load.o += -I$(objtree)/usr/include -Wno-unused-variable
 HOSTLOADLIBES_fds_example += -lelf
-- 
2.8.0

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH net-next] samples/bpf: fix include path
  2016-11-29  6:07 [PATCH net-next] samples/bpf: fix include path Alexei Starovoitov
@ 2016-11-29  6:34 ` Daniel Borkmann
  2016-11-29 15:55   ` David Ahern
  2016-11-30 17:42 ` David Miller
  1 sibling, 1 reply; 4+ messages in thread
From: Daniel Borkmann @ 2016-11-29  6:34 UTC (permalink / raw)
  To: Alexei Starovoitov, David S . Miller; +Cc: netdev

On 11/29/2016 07:07 AM, Alexei Starovoitov wrote:
> Fix the following build error:
> HOSTCC  samples/bpf/test_lru_dist.o
> ../samples/bpf/test_lru_dist.c:25:22: fatal error: bpf_util.h: No such file or directory
>
> This is due to objtree != srctree.
> Use srctree, since that's where bpf_util.h is located.
>
> Fixes: e00c7b216f34 ("bpf: fix multiple issues in selftest suite and samples")
> Signed-off-by: Alexei Starovoitov <ast@kernel.org>

Didn't run into this so far, thanks for fixing!

Acked-by: Daniel Borkmann <daniel@iogearbox.net>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH net-next] samples/bpf: fix include path
  2016-11-29  6:34 ` Daniel Borkmann
@ 2016-11-29 15:55   ` David Ahern
  0 siblings, 0 replies; 4+ messages in thread
From: David Ahern @ 2016-11-29 15:55 UTC (permalink / raw)
  To: Daniel Borkmann, Alexei Starovoitov, David S . Miller; +Cc: netdev

On 11/28/16 11:34 PM, Daniel Borkmann wrote:
> On 11/29/2016 07:07 AM, Alexei Starovoitov wrote:
>> Fix the following build error:
>> HOSTCC  samples/bpf/test_lru_dist.o
>> ../samples/bpf/test_lru_dist.c:25:22: fatal error: bpf_util.h: No such file or directory
>>
>> This is due to objtree != srctree.
>> Use srctree, since that's where bpf_util.h is located.
>>
>> Fixes: e00c7b216f34 ("bpf: fix multiple issues in selftest suite and samples")
>> Signed-off-by: Alexei Starovoitov <ast@kernel.org>
> 
> Didn't run into this so far, thanks for fixing!
> 
> Acked-by: Daniel Borkmann <daniel@iogearbox.net>

I have and this fixed it for me.

Tested-by: David Ahern <dsa@cumulusnetworks.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH net-next] samples/bpf: fix include path
  2016-11-29  6:07 [PATCH net-next] samples/bpf: fix include path Alexei Starovoitov
  2016-11-29  6:34 ` Daniel Borkmann
@ 2016-11-30 17:42 ` David Miller
  1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2016-11-30 17:42 UTC (permalink / raw)
  To: ast; +Cc: daniel, netdev

From: Alexei Starovoitov <ast@fb.com>
Date: Mon, 28 Nov 2016 22:07:22 -0800

> Fix the following build error:
> HOSTCC  samples/bpf/test_lru_dist.o
> ../samples/bpf/test_lru_dist.c:25:22: fatal error: bpf_util.h: No such file or directory
> 
> This is due to objtree != srctree.
> Use srctree, since that's where bpf_util.h is located.
> 
> Fixes: e00c7b216f34 ("bpf: fix multiple issues in selftest suite and samples")
> Signed-off-by: Alexei Starovoitov <ast@kernel.org>

Applied, thanks.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-11-30 17:42 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-29  6:07 [PATCH net-next] samples/bpf: fix include path Alexei Starovoitov
2016-11-29  6:34 ` Daniel Borkmann
2016-11-29 15:55   ` David Ahern
2016-11-30 17:42 ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.