* [PATCH bpf-next] libbpf: Add xsk.h to be installed by install_headers
@ 2019-04-12 14:17 Eelco Chaudron
2019-04-12 16:13 ` Song Liu
0 siblings, 1 reply; 5+ messages in thread
From: Eelco Chaudron @ 2019-04-12 14:17 UTC (permalink / raw)
To: netdev; +Cc: ast, daniel, kafai, songliubraving, yhs
The user API file xsk.h was not installed by install_headers, this
change will fix this.
Signed-off-by: Eelco Chaudron <echaudro@redhat.com>
---
tools/lib/bpf/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/lib/bpf/Makefile b/tools/lib/bpf/Makefile
index 008344507700..9b0a0f53d640 100644
--- a/tools/lib/bpf/Makefile
+++ b/tools/lib/bpf/Makefile
@@ -230,6 +230,7 @@ install_headers:
$(call do_install,bpf.h,$(prefix)/include/bpf,644); \
$(call do_install,libbpf.h,$(prefix)/include/bpf,644);
$(call do_install,btf.h,$(prefix)/include/bpf,644);
+ $(call do_install,xsk.h,$(prefix)/include/bpf,644);
install_pkgconfig: $(PC_FILE)
$(call QUIET_INSTALL, $(PC_FILE)) \
--
2.18.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH bpf-next] libbpf: Add xsk.h to be installed by install_headers
2019-04-12 14:17 [PATCH bpf-next] libbpf: Add xsk.h to be installed by install_headers Eelco Chaudron
@ 2019-04-12 16:13 ` Song Liu
2019-04-12 16:31 ` Stanislav Fomichev
0 siblings, 1 reply; 5+ messages in thread
From: Song Liu @ 2019-04-12 16:13 UTC (permalink / raw)
To: Eelco Chaudron
Cc: Networking, Alexei Starovoitov, Daniel Borkmann, Martin Lau,
Yonghong Song, magnus.karlsson
> On Apr 12, 2019, at 7:17 AM, Eelco Chaudron <echaudro@redhat.com> wrote:
>
> The user API file xsk.h was not installed by install_headers, this
> change will fix this.
>
> Signed-off-by: Eelco Chaudron <echaudro@redhat.com>
Cc: Magnus Karlsson <magnus.karlsson@intel.com>
Fixes: 1cad07884239 ("libbpf: add support for using AF_XDP sockets")
Acked-by: Song Liu <songliubraving@fb.com>
> ---
> tools/lib/bpf/Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/lib/bpf/Makefile b/tools/lib/bpf/Makefile
> index 008344507700..9b0a0f53d640 100644
> --- a/tools/lib/bpf/Makefile
> +++ b/tools/lib/bpf/Makefile
> @@ -230,6 +230,7 @@ install_headers:
> $(call do_install,bpf.h,$(prefix)/include/bpf,644); \
> $(call do_install,libbpf.h,$(prefix)/include/bpf,644);
> $(call do_install,btf.h,$(prefix)/include/bpf,644);
> + $(call do_install,xsk.h,$(prefix)/include/bpf,644);
>
> install_pkgconfig: $(PC_FILE)
> $(call QUIET_INSTALL, $(PC_FILE)) \
> --
> 2.18.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH bpf-next] libbpf: Add xsk.h to be installed by install_headers
2019-04-12 16:13 ` Song Liu
@ 2019-04-12 16:31 ` Stanislav Fomichev
2019-04-12 16:58 ` Song Liu
2019-04-12 18:07 ` Eelco Chaudron
0 siblings, 2 replies; 5+ messages in thread
From: Stanislav Fomichev @ 2019-04-12 16:31 UTC (permalink / raw)
To: Song Liu
Cc: Eelco Chaudron, Networking, Alexei Starovoitov, Daniel Borkmann,
Martin Lau, Yonghong Song, magnus.karlsson
On 04/12, Song Liu wrote:
>
>
> > On Apr 12, 2019, at 7:17 AM, Eelco Chaudron <echaudro@redhat.com> wrote:
> >
> > The user API file xsk.h was not installed by install_headers, this
> > change will fix this.
> >
> > Signed-off-by: Eelco Chaudron <echaudro@redhat.com>
>
> Cc: Magnus Karlsson <magnus.karlsson@intel.com>
> Fixes: 1cad07884239 ("libbpf: add support for using AF_XDP sockets")
> Acked-by: Song Liu <songliubraving@fb.com>
Isn't it already in? See commit 379e2014c95b7 ("libbpf: add xsk.h to
install_headers target").
> > ---
> > tools/lib/bpf/Makefile | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/tools/lib/bpf/Makefile b/tools/lib/bpf/Makefile
> > index 008344507700..9b0a0f53d640 100644
> > --- a/tools/lib/bpf/Makefile
> > +++ b/tools/lib/bpf/Makefile
> > @@ -230,6 +230,7 @@ install_headers:
> > $(call do_install,bpf.h,$(prefix)/include/bpf,644); \
> > $(call do_install,libbpf.h,$(prefix)/include/bpf,644);
> > $(call do_install,btf.h,$(prefix)/include/bpf,644);
> > + $(call do_install,xsk.h,$(prefix)/include/bpf,644);
> >
> > install_pkgconfig: $(PC_FILE)
> > $(call QUIET_INSTALL, $(PC_FILE)) \
> > --
> > 2.18.1
> >
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH bpf-next] libbpf: Add xsk.h to be installed by install_headers
2019-04-12 16:31 ` Stanislav Fomichev
@ 2019-04-12 16:58 ` Song Liu
2019-04-12 18:07 ` Eelco Chaudron
1 sibling, 0 replies; 5+ messages in thread
From: Song Liu @ 2019-04-12 16:58 UTC (permalink / raw)
To: Stanislav Fomichev
Cc: Eelco Chaudron, Networking, Alexei Starovoitov, Daniel Borkmann,
Martin Lau, Yonghong Song, magnus.karlsson
> On Apr 12, 2019, at 9:31 AM, Stanislav Fomichev <sdf@fomichev.me> wrote:
>
> On 04/12, Song Liu wrote:
>>
>>
>>> On Apr 12, 2019, at 7:17 AM, Eelco Chaudron <echaudro@redhat.com> wrote:
>>>
>>> The user API file xsk.h was not installed by install_headers, this
>>> change will fix this.
>>>
>>> Signed-off-by: Eelco Chaudron <echaudro@redhat.com>
>>
>> Cc: Magnus Karlsson <magnus.karlsson@intel.com>
>> Fixes: 1cad07884239 ("libbpf: add support for using AF_XDP sockets")
>> Acked-by: Song Liu <songliubraving@fb.com>
> Isn't it already in? See commit 379e2014c95b7 ("libbpf: add xsk.h to
> install_headers target").
Good catch!
Thanks Stanislav!
Song
>>> ---
>>> tools/lib/bpf/Makefile | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/tools/lib/bpf/Makefile b/tools/lib/bpf/Makefile
>>> index 008344507700..9b0a0f53d640 100644
>>> --- a/tools/lib/bpf/Makefile
>>> +++ b/tools/lib/bpf/Makefile
>>> @@ -230,6 +230,7 @@ install_headers:
>>> $(call do_install,bpf.h,$(prefix)/include/bpf,644); \
>>> $(call do_install,libbpf.h,$(prefix)/include/bpf,644);
>>> $(call do_install,btf.h,$(prefix)/include/bpf,644);
>>> + $(call do_install,xsk.h,$(prefix)/include/bpf,644);
>>>
>>> install_pkgconfig: $(PC_FILE)
>>> $(call QUIET_INSTALL, $(PC_FILE)) \
>>> --
>>> 2.18.1
>>>
>>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH bpf-next] libbpf: Add xsk.h to be installed by install_headers
2019-04-12 16:31 ` Stanislav Fomichev
2019-04-12 16:58 ` Song Liu
@ 2019-04-12 18:07 ` Eelco Chaudron
1 sibling, 0 replies; 5+ messages in thread
From: Eelco Chaudron @ 2019-04-12 18:07 UTC (permalink / raw)
To: Stanislav Fomichev
Cc: Song Liu, Networking, Alexei Starovoitov, Daniel Borkmann,
Martin Lau, Yonghong Song, magnus.karlsson
Sorry messed it up :( Did a pull in the wrong directory to verify the
patch was not existing…
//Eelco
On 12 Apr 2019, at 18:31, Stanislav Fomichev wrote:
> On 04/12, Song Liu wrote:
>>
>>
>>> On Apr 12, 2019, at 7:17 AM, Eelco Chaudron <echaudro@redhat.com>
>>> wrote:
>>>
>>> The user API file xsk.h was not installed by install_headers, this
>>> change will fix this.
>>>
>>> Signed-off-by: Eelco Chaudron <echaudro@redhat.com>
>>
>> Cc: Magnus Karlsson <magnus.karlsson@intel.com>
>> Fixes: 1cad07884239 ("libbpf: add support for using AF_XDP sockets")
>> Acked-by: Song Liu <songliubraving@fb.com>
> Isn't it already in? See commit 379e2014c95b7 ("libbpf: add xsk.h to
> install_headers target").
>
>>> ---
>>> tools/lib/bpf/Makefile | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/tools/lib/bpf/Makefile b/tools/lib/bpf/Makefile
>>> index 008344507700..9b0a0f53d640 100644
>>> --- a/tools/lib/bpf/Makefile
>>> +++ b/tools/lib/bpf/Makefile
>>> @@ -230,6 +230,7 @@ install_headers:
>>> $(call do_install,bpf.h,$(prefix)/include/bpf,644); \
>>> $(call do_install,libbpf.h,$(prefix)/include/bpf,644);
>>> $(call do_install,btf.h,$(prefix)/include/bpf,644);
>>> + $(call do_install,xsk.h,$(prefix)/include/bpf,644);
>>>
>>> install_pkgconfig: $(PC_FILE)
>>> $(call QUIET_INSTALL, $(PC_FILE)) \
>>> --
>>> 2.18.1
>>>
>>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-04-12 18:07 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-12 14:17 [PATCH bpf-next] libbpf: Add xsk.h to be installed by install_headers Eelco Chaudron
2019-04-12 16:13 ` Song Liu
2019-04-12 16:31 ` Stanislav Fomichev
2019-04-12 16:58 ` Song Liu
2019-04-12 18:07 ` Eelco Chaudron
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.