* [PATCH 1/7] Remove hardcoded strict -Werror checking
2016-12-16 22:56 [PATCH 0/7] General Build Fixes Alistair Francis
@ 2016-12-16 22:56 ` Alistair Francis
2016-12-17 15:51 ` Konrad Rzeszutek Wilk
2016-12-16 22:56 ` [PATCH 2/7] tools/libxl: " Alistair Francis
` (5 subsequent siblings)
6 siblings, 1 reply; 27+ messages in thread
From: Alistair Francis @ 2016-12-16 22:56 UTC (permalink / raw)
To: xen-devel
Cc: wei.liu2, ian.jackson, Alistair Francis, imhy.yang, rshriram, alistair23
Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
---
Config.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Config.mk b/Config.mk
index 3ec7367..e3cda81 100644
--- a/Config.mk
+++ b/Config.mk
@@ -34,7 +34,7 @@ CONFIG_$(XEN_OS) := y
SHELL ?= /bin/sh
# Tools to run on system hosting the build
-HOSTCFLAGS = -Wall -Werror -Wstrict-prototypes -O2 -fomit-frame-pointer
+HOSTCFLAGS = -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer
HOSTCFLAGS += -fno-strict-aliasing
DISTDIR ?= $(XEN_ROOT)/dist
--
2.7.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 27+ messages in thread* Re: [PATCH 1/7] Remove hardcoded strict -Werror checking
2016-12-16 22:56 ` [PATCH 1/7] Remove hardcoded strict -Werror checking Alistair Francis
@ 2016-12-17 15:51 ` Konrad Rzeszutek Wilk
2016-12-19 17:58 ` Alistair Francis
2016-12-20 3:53 ` Doug Goldstein
0 siblings, 2 replies; 27+ messages in thread
From: Konrad Rzeszutek Wilk @ 2016-12-17 15:51 UTC (permalink / raw)
To: Alistair Francis
Cc: wei.liu2, ian.jackson, imhy.yang, alistair23, rshriram, xen-devel
On Fri, Dec 16, 2016 at 02:56:01PM -0800, Alistair Francis wrote:
> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
Why?
Thanks!
> ---
> Config.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Config.mk b/Config.mk
> index 3ec7367..e3cda81 100644
> --- a/Config.mk
> +++ b/Config.mk
> @@ -34,7 +34,7 @@ CONFIG_$(XEN_OS) := y
> SHELL ?= /bin/sh
>
> # Tools to run on system hosting the build
> -HOSTCFLAGS = -Wall -Werror -Wstrict-prototypes -O2 -fomit-frame-pointer
> +HOSTCFLAGS = -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer
> HOSTCFLAGS += -fno-strict-aliasing
>
> DISTDIR ?= $(XEN_ROOT)/dist
> --
> 2.7.4
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> https://lists.xen.org/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH 1/7] Remove hardcoded strict -Werror checking
2016-12-17 15:51 ` Konrad Rzeszutek Wilk
@ 2016-12-19 17:58 ` Alistair Francis
2016-12-20 3:53 ` Doug Goldstein
1 sibling, 0 replies; 27+ messages in thread
From: Alistair Francis @ 2016-12-19 17:58 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk
Cc: wei.liu2, ian.jackson, Alistair Francis, imhy.yang, rshriram, xen-devel
On Sat, Dec 17, 2016 at 7:51 AM, Konrad Rzeszutek Wilk
<konrad.wilk@oracle.com> wrote:
> On Fri, Dec 16, 2016 at 02:56:01PM -0800, Alistair Francis wrote:
>> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
>
>
> Why?
Hey Konrad,
The problem that I have is that we build Xen releases in buildroot. As
things change (GCC version usually) new warnings are generated for
issues that previously never caused any problems. Instead of
constantly fixing these small warnings it is easier to disable Werror.
I understand that for development this isn't what you want. I just
thought it was worth at least sending this up.
Maybe a way to disable Werror when configuring would be the best solution?
Thanks,
Alistair
>
> Thanks!
>> ---
>> Config.mk | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Config.mk b/Config.mk
>> index 3ec7367..e3cda81 100644
>> --- a/Config.mk
>> +++ b/Config.mk
>> @@ -34,7 +34,7 @@ CONFIG_$(XEN_OS) := y
>> SHELL ?= /bin/sh
>>
>> # Tools to run on system hosting the build
>> -HOSTCFLAGS = -Wall -Werror -Wstrict-prototypes -O2 -fomit-frame-pointer
>> +HOSTCFLAGS = -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer
>> HOSTCFLAGS += -fno-strict-aliasing
>>
>> DISTDIR ?= $(XEN_ROOT)/dist
>> --
>> 2.7.4
>>
>>
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@lists.xen.org
>> https://lists.xen.org/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH 1/7] Remove hardcoded strict -Werror checking
2016-12-17 15:51 ` Konrad Rzeszutek Wilk
2016-12-19 17:58 ` Alistair Francis
@ 2016-12-20 3:53 ` Doug Goldstein
2016-12-20 16:05 ` Konrad Rzeszutek Wilk
2016-12-20 17:58 ` Alistair Francis
1 sibling, 2 replies; 27+ messages in thread
From: Doug Goldstein @ 2016-12-20 3:53 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk, Alistair Francis
Cc: wei.liu2, ian.jackson, imhy.yang, alistair23, rshriram, xen-devel
[-- Attachment #1.1.1: Type: text/plain, Size: 529 bytes --]
On 12/17/16 9:51 AM, Konrad Rzeszutek Wilk wrote:
> On Fri, Dec 16, 2016 at 02:56:01PM -0800, Alistair Francis wrote:
>> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
>
>
> Why?
*adjusts his distro maintainer hat* It's considered really bad form for
upstreams to push -Werror in their projects. However I know there's
upstream interest to keep it. The compromise would probably be to get my
rear in gear and get a wider range of distros testing with Travis CI /
GitLab CI.
--
Doug Goldstein
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 959 bytes --]
[-- Attachment #2: Type: text/plain, Size: 127 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH 1/7] Remove hardcoded strict -Werror checking
2016-12-20 3:53 ` Doug Goldstein
@ 2016-12-20 16:05 ` Konrad Rzeszutek Wilk
2016-12-20 17:02 ` Doug Goldstein
2016-12-20 17:58 ` Alistair Francis
1 sibling, 1 reply; 27+ messages in thread
From: Konrad Rzeszutek Wilk @ 2016-12-20 16:05 UTC (permalink / raw)
To: Doug Goldstein
Cc: wei.liu2, ian.jackson, Alistair Francis, imhy.yang, xen-devel,
rshriram, alistair23
On Mon, Dec 19, 2016 at 09:53:02PM -0600, Doug Goldstein wrote:
> On 12/17/16 9:51 AM, Konrad Rzeszutek Wilk wrote:
> > On Fri, Dec 16, 2016 at 02:56:01PM -0800, Alistair Francis wrote:
> >> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
> >
> >
> > Why?
>
> *adjusts his distro maintainer hat* It's considered really bad form for
> upstreams to push -Werror in their projects. However I know there's
> upstream interest to keep it. The compromise would probably be to get my
> rear in gear and get a wider range of distros testing with Travis CI /
> GitLab CI.
So.. why not do something like this:
diff --git a/config/StdGNU.mk b/config/StdGNU.mk
index 6be8233..fd2d5b9 100644
--- a/config/StdGNU.mk
+++ b/config/StdGNU.mk
@@ -39,3 +39,5 @@ ifeq ($(lto),y)
CFLAGS += -flto
LDFLAGS-$(clang) += -plugin LLVMgold.so
endif
+
+CFLAGS += $(EXTRA_CFLAGS)
And have the BuildRoot script do something like:
EXTRA_CFLAGS=$(CFLAGS)
unset CFLAGS
make -C xen
?
>
> --
> Doug Goldstein
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 27+ messages in thread
* Re: [PATCH 1/7] Remove hardcoded strict -Werror checking
2016-12-20 16:05 ` Konrad Rzeszutek Wilk
@ 2016-12-20 17:02 ` Doug Goldstein
2016-12-20 17:21 ` Konrad Rzeszutek Wilk
0 siblings, 1 reply; 27+ messages in thread
From: Doug Goldstein @ 2016-12-20 17:02 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk
Cc: wei.liu2, ian.jackson, Alistair Francis, imhy.yang, xen-devel,
rshriram, alistair23
[-- Attachment #1.1.1: Type: text/plain, Size: 1359 bytes --]
On 12/20/16 10:05 AM, Konrad Rzeszutek Wilk wrote:
> On Mon, Dec 19, 2016 at 09:53:02PM -0600, Doug Goldstein wrote:
>> On 12/17/16 9:51 AM, Konrad Rzeszutek Wilk wrote:
>>> On Fri, Dec 16, 2016 at 02:56:01PM -0800, Alistair Francis wrote:
>>>> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
>>>
>>>
>>> Why?
>>
>> *adjusts his distro maintainer hat* It's considered really bad form for
>> upstreams to push -Werror in their projects. However I know there's
>> upstream interest to keep it. The compromise would probably be to get my
>> rear in gear and get a wider range of distros testing with Travis CI /
>> GitLab CI.
>
> So.. why not do something like this:
>
>
> diff --git a/config/StdGNU.mk b/config/StdGNU.mk
> index 6be8233..fd2d5b9 100644
> --- a/config/StdGNU.mk
> +++ b/config/StdGNU.mk
> @@ -39,3 +39,5 @@ ifeq ($(lto),y)
> CFLAGS += -flto
> LDFLAGS-$(clang) += -plugin LLVMgold.so
> endif
> +
> +CFLAGS += $(EXTRA_CFLAGS)
>
> And have the BuildRoot script do something like:
>
>
> EXTRA_CFLAGS=$(CFLAGS)
> unset CFLAGS
>
> make -C xen
>
> ?
>
This was really to replace patch 3/7 right? Cause I think this would be
an ok change. It'd certainly help me with Yocto where I have to pass in
CFLAGS (need to pass in the sysroot of the target compiler).
--
Doug Goldstein
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 959 bytes --]
[-- Attachment #2: Type: text/plain, Size: 127 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH 1/7] Remove hardcoded strict -Werror checking
2016-12-20 17:02 ` Doug Goldstein
@ 2016-12-20 17:21 ` Konrad Rzeszutek Wilk
2016-12-20 17:57 ` Alistair Francis
0 siblings, 1 reply; 27+ messages in thread
From: Konrad Rzeszutek Wilk @ 2016-12-20 17:21 UTC (permalink / raw)
To: Doug Goldstein
Cc: wei.liu2, ian.jackson, Alistair Francis, imhy.yang, xen-devel,
rshriram, alistair23
On Tue, Dec 20, 2016 at 11:02:15AM -0600, Doug Goldstein wrote:
> On 12/20/16 10:05 AM, Konrad Rzeszutek Wilk wrote:
> > On Mon, Dec 19, 2016 at 09:53:02PM -0600, Doug Goldstein wrote:
> >> On 12/17/16 9:51 AM, Konrad Rzeszutek Wilk wrote:
> >>> On Fri, Dec 16, 2016 at 02:56:01PM -0800, Alistair Francis wrote:
> >>>> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
> >>>
> >>>
> >>> Why?
> >>
> >> *adjusts his distro maintainer hat* It's considered really bad form for
> >> upstreams to push -Werror in their projects. However I know there's
> >> upstream interest to keep it. The compromise would probably be to get my
> >> rear in gear and get a wider range of distros testing with Travis CI /
> >> GitLab CI.
> >
> > So.. why not do something like this:
> >
> >
> > diff --git a/config/StdGNU.mk b/config/StdGNU.mk
> > index 6be8233..fd2d5b9 100644
> > --- a/config/StdGNU.mk
> > +++ b/config/StdGNU.mk
> > @@ -39,3 +39,5 @@ ifeq ($(lto),y)
> > CFLAGS += -flto
> > LDFLAGS-$(clang) += -plugin LLVMgold.so
> > endif
> > +
> > +CFLAGS += $(EXTRA_CFLAGS)
> >
> > And have the BuildRoot script do something like:
> >
> >
> > EXTRA_CFLAGS=$(CFLAGS)
> > unset CFLAGS
> >
> > make -C xen
> >
> > ?
> >
>
> This was really to replace patch 3/7 right? Cause I think this would be
> an ok change. It'd certainly help me with Yocto where I have to pass in
> CFLAGS (need to pass in the sysroot of the target compiler).
Yes sorry.
>
> --
> Doug Goldstein
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH 1/7] Remove hardcoded strict -Werror checking
2016-12-20 17:21 ` Konrad Rzeszutek Wilk
@ 2016-12-20 17:57 ` Alistair Francis
0 siblings, 0 replies; 27+ messages in thread
From: Alistair Francis @ 2016-12-20 17:57 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk
Cc: wei.liu2, ian.jackson, Doug Goldstein, Alistair Francis,
imhy.yang, rshriram, xen-devel
On Tue, Dec 20, 2016 at 9:21 AM, Konrad Rzeszutek Wilk
<konrad.wilk@oracle.com> wrote:
> On Tue, Dec 20, 2016 at 11:02:15AM -0600, Doug Goldstein wrote:
>> On 12/20/16 10:05 AM, Konrad Rzeszutek Wilk wrote:
>> > On Mon, Dec 19, 2016 at 09:53:02PM -0600, Doug Goldstein wrote:
>> >> On 12/17/16 9:51 AM, Konrad Rzeszutek Wilk wrote:
>> >>> On Fri, Dec 16, 2016 at 02:56:01PM -0800, Alistair Francis wrote:
>> >>>> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
>> >>>
>> >>>
>> >>> Why?
>> >>
>> >> *adjusts his distro maintainer hat* It's considered really bad form for
>> >> upstreams to push -Werror in their projects. However I know there's
>> >> upstream interest to keep it. The compromise would probably be to get my
>> >> rear in gear and get a wider range of distros testing with Travis CI /
>> >> GitLab CI.
>> >
>> > So.. why not do something like this:
>> >
>> >
>> > diff --git a/config/StdGNU.mk b/config/StdGNU.mk
>> > index 6be8233..fd2d5b9 100644
>> > --- a/config/StdGNU.mk
>> > +++ b/config/StdGNU.mk
>> > @@ -39,3 +39,5 @@ ifeq ($(lto),y)
>> > CFLAGS += -flto
>> > LDFLAGS-$(clang) += -plugin LLVMgold.so
>> > endif
>> > +
>> > +CFLAGS += $(EXTRA_CFLAGS)
>> >
>> > And have the BuildRoot script do something like:
>> >
>> >
>> > EXTRA_CFLAGS=$(CFLAGS)
>> > unset CFLAGS
>> >
>> > make -C xen
>> >
>> > ?
>> >
>>
>> This was really to replace patch 3/7 right? Cause I think this would be
>> an ok change. It'd certainly help me with Yocto where I have to pass in
>> CFLAGS (need to pass in the sysroot of the target compiler).
>
> Yes sorry.
Yeah, this could work as well (for patch 3).
Should I re-spin with something like that?
Thanks,
Alistair
>>
>> --
>> Doug Goldstein
>>
>
>
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH 1/7] Remove hardcoded strict -Werror checking
2016-12-20 3:53 ` Doug Goldstein
2016-12-20 16:05 ` Konrad Rzeszutek Wilk
@ 2016-12-20 17:58 ` Alistair Francis
1 sibling, 0 replies; 27+ messages in thread
From: Alistair Francis @ 2016-12-20 17:58 UTC (permalink / raw)
To: Doug Goldstein
Cc: wei.liu2, ian.jackson, Alistair Francis, imhy.yang, rshriram, xen-devel
On Mon, Dec 19, 2016 at 7:53 PM, Doug Goldstein <cardoe@cardoe.com> wrote:
> On 12/17/16 9:51 AM, Konrad Rzeszutek Wilk wrote:
>> On Fri, Dec 16, 2016 at 02:56:01PM -0800, Alistair Francis wrote:
>>> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
>>
>>
>> Why?
>
> *adjusts his distro maintainer hat* It's considered really bad form for
> upstreams to push -Werror in their projects. However I know there's
> upstream interest to keep it. The compromise would probably be to get my
> rear in gear and get a wider range of distros testing with Travis CI /
> GitLab CI.
I agree with both points. I understand why upstream wants it there,
but it's a pain.
What about an option to override and remove Werror, so it can still be
enabled by default?
Thanks,
Alistair
>
> --
> Doug Goldstein
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH 2/7] tools/libxl: Remove hardcoded strict -Werror checking
2016-12-16 22:56 [PATCH 0/7] General Build Fixes Alistair Francis
2016-12-16 22:56 ` [PATCH 1/7] Remove hardcoded strict -Werror checking Alistair Francis
@ 2016-12-16 22:56 ` Alistair Francis
2016-12-17 15:52 ` Konrad Rzeszutek Wilk
2016-12-16 22:56 ` [PATCH 3/7] xen/Rules.mk: fix build with CFLAGS from environment Alistair Francis
` (4 subsequent siblings)
6 siblings, 1 reply; 27+ messages in thread
From: Alistair Francis @ 2016-12-16 22:56 UTC (permalink / raw)
To: xen-devel
Cc: wei.liu2, ian.jackson, Alistair Francis, imhy.yang, rshriram, alistair23
Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
---
tools/libxl/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/libxl/Makefile b/tools/libxl/Makefile
index 91e2f97..e8a37ef 100644
--- a/tools/libxl/Makefile
+++ b/tools/libxl/Makefile
@@ -11,7 +11,7 @@ MINOR = 0
XLUMAJOR = 4.9
XLUMINOR = 0
-CFLAGS += -Werror -Wno-format-zero-length -Wmissing-declarations \
+CFLAGS += -Wno-format-zero-length -Wmissing-declarations \
-Wno-declaration-after-statement -Wformat-nonliteral
CFLAGS += -I. -fPIC
--
2.7.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 27+ messages in thread* Re: [PATCH 2/7] tools/libxl: Remove hardcoded strict -Werror checking
2016-12-16 22:56 ` [PATCH 2/7] tools/libxl: " Alistair Francis
@ 2016-12-17 15:52 ` Konrad Rzeszutek Wilk
0 siblings, 0 replies; 27+ messages in thread
From: Konrad Rzeszutek Wilk @ 2016-12-17 15:52 UTC (permalink / raw)
To: Alistair Francis
Cc: wei.liu2, ian.jackson, imhy.yang, alistair23, rshriram, xen-devel
On Fri, Dec 16, 2016 at 02:56:02PM -0800, Alistair Francis wrote:
> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
Why?
If this patch is checked in there is no cover letter description,
just this singular patch - and it is quite unclear why it is
being done this way.
> ---
> tools/libxl/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/libxl/Makefile b/tools/libxl/Makefile
> index 91e2f97..e8a37ef 100644
> --- a/tools/libxl/Makefile
> +++ b/tools/libxl/Makefile
> @@ -11,7 +11,7 @@ MINOR = 0
> XLUMAJOR = 4.9
> XLUMINOR = 0
>
> -CFLAGS += -Werror -Wno-format-zero-length -Wmissing-declarations \
> +CFLAGS += -Wno-format-zero-length -Wmissing-declarations \
> -Wno-declaration-after-statement -Wformat-nonliteral
> CFLAGS += -I. -fPIC
>
> --
> 2.7.4
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> https://lists.xen.org/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH 3/7] xen/Rules.mk: fix build with CFLAGS from environment
2016-12-16 22:56 [PATCH 0/7] General Build Fixes Alistair Francis
2016-12-16 22:56 ` [PATCH 1/7] Remove hardcoded strict -Werror checking Alistair Francis
2016-12-16 22:56 ` [PATCH 2/7] tools/libxl: " Alistair Francis
@ 2016-12-16 22:56 ` Alistair Francis
2016-12-17 15:54 ` Konrad Rzeszutek Wilk
2016-12-19 8:32 ` Jan Beulich
2016-12-16 22:56 ` [PATCH 4/7] tools: Update sys/poll.h to poll.h Alistair Francis
` (3 subsequent siblings)
6 siblings, 2 replies; 27+ messages in thread
From: Alistair Francis @ 2016-12-16 22:56 UTC (permalink / raw)
To: xen-devel
Cc: wei.liu2, ian.jackson, imhy.yang, rshriram, alistair23, Yann E. MORIN
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
When CFLAGS are passed from the environment, the first-level make
invocation will append -D__OBJECT_FILE__ to it, then call a second
make invocation, that will have those new CFLAGS in its environment,
but will also append -D__OBJECT_FILE__ to those.
Then, the compiler fails because __OBEJECT_FILE__ is defined twice.
Just undefine it before defining it again, as a *workaround* to this
issue.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
xen/Rules.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/Rules.mk b/xen/Rules.mk
index 24d13dc..f8b8c2c 100644
--- a/xen/Rules.mk
+++ b/xen/Rules.mk
@@ -49,7 +49,7 @@ endif
CFLAGS += -nostdinc -fno-builtin -fno-common
CFLAGS += -Werror -Wredundant-decls -Wno-pointer-arith
CFLAGS += -pipe -g -D__XEN__ -include $(BASEDIR)/include/xen/config.h
-CFLAGS += '-D__OBJECT_FILE__="$@"'
+CFLAGS += -U__OBJECT_FILE__ '-D__OBJECT_FILE__="$@"'
ifneq ($(clang),y)
# Clang doesn't understand this command line argument, and doesn't appear to
--
2.7.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 27+ messages in thread* Re: [PATCH 3/7] xen/Rules.mk: fix build with CFLAGS from environment
2016-12-16 22:56 ` [PATCH 3/7] xen/Rules.mk: fix build with CFLAGS from environment Alistair Francis
@ 2016-12-17 15:54 ` Konrad Rzeszutek Wilk
2016-12-19 8:32 ` Jan Beulich
1 sibling, 0 replies; 27+ messages in thread
From: Konrad Rzeszutek Wilk @ 2016-12-17 15:54 UTC (permalink / raw)
To: Alistair Francis
Cc: wei.liu2, ian.jackson, imhy.yang, alistair23, rshriram,
xen-devel, Yann E. MORIN
On Fri, Dec 16, 2016 at 02:56:03PM -0800, Alistair Francis wrote:
> From: "Yann E. MORIN" <yann.morin.1998@free.fr>
>
> When CFLAGS are passed from the environment, the first-level make
> invocation will append -D__OBJECT_FILE__ to it, then call a second
> make invocation, that will have those new CFLAGS in its environment,
> but will also append -D__OBJECT_FILE__ to those.
>
> Then, the compiler fails because __OBEJECT_FILE__ is defined twice.
>
> Just undefine it before defining it again, as a *workaround* to this
> issue.
Hm, workaround?
Well that is good, but what if we just fix it in the first place?
I recall hitting this with Fedora Core and the suggested fix was
add in config/StdGNU.mk and 'EXTRA_CFLAGS' or such that would
be utilized by CFLAGS.
The rpmbuild would then use EXTRA_CFLAGS or such to set
the extra flags?
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
> xen/Rules.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/Rules.mk b/xen/Rules.mk
> index 24d13dc..f8b8c2c 100644
> --- a/xen/Rules.mk
> +++ b/xen/Rules.mk
> @@ -49,7 +49,7 @@ endif
> CFLAGS += -nostdinc -fno-builtin -fno-common
> CFLAGS += -Werror -Wredundant-decls -Wno-pointer-arith
> CFLAGS += -pipe -g -D__XEN__ -include $(BASEDIR)/include/xen/config.h
> -CFLAGS += '-D__OBJECT_FILE__="$@"'
> +CFLAGS += -U__OBJECT_FILE__ '-D__OBJECT_FILE__="$@"'
>
> ifneq ($(clang),y)
> # Clang doesn't understand this command line argument, and doesn't appear to
> --
> 2.7.4
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> https://lists.xen.org/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH 3/7] xen/Rules.mk: fix build with CFLAGS from environment
2016-12-16 22:56 ` [PATCH 3/7] xen/Rules.mk: fix build with CFLAGS from environment Alistair Francis
2016-12-17 15:54 ` Konrad Rzeszutek Wilk
@ 2016-12-19 8:32 ` Jan Beulich
1 sibling, 0 replies; 27+ messages in thread
From: Jan Beulich @ 2016-12-19 8:32 UTC (permalink / raw)
To: Alistair Francis
Cc: wei.liu2, ian.jackson, imhy.yang, xen-devel, rshriram,
alistair23, Yann E. MORIN
>>> On 16.12.16 at 23:56, <alistair.francis@xilinx.com> wrote:
> From: "Yann E. MORIN" <yann.morin.1998@free.fr>
>
> When CFLAGS are passed from the environment,
But that's what shouldn't be done.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH 4/7] tools: Update sys/poll.h to poll.h
2016-12-16 22:56 [PATCH 0/7] General Build Fixes Alistair Francis
` (2 preceding siblings ...)
2016-12-16 22:56 ` [PATCH 3/7] xen/Rules.mk: fix build with CFLAGS from environment Alistair Francis
@ 2016-12-16 22:56 ` Alistair Francis
2016-12-17 15:55 ` Konrad Rzeszutek Wilk
2016-12-16 22:56 ` [PATCH 5/7] tools/blktap2: Update sys/signal.h to signal.h Alistair Francis
` (2 subsequent siblings)
6 siblings, 1 reply; 27+ messages in thread
From: Alistair Francis @ 2016-12-16 22:56 UTC (permalink / raw)
To: xen-devel
Cc: wei.liu2, ian.jackson, Alistair Francis, imhy.yang, rshriram, alistair23
To avoid this build error with newer build systems:
error: #warning redirecting incorrect #include <sys/poll.h> to
<poll.h> [-Werror=cpp]
Rename sys/poll.h to poll.h
Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
---
tools/libxl/libxl_internal.h | 2 +-
tools/tests/xen-access/xen-access.c | 2 +-
tools/xenstat/libxenstat/src/xenstat_qmp.c | 2 +-
tools/xentrace/xentrace.c | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h
index 5f46578..acf9ac2 100644
--- a/tools/libxl/libxl_internal.h
+++ b/tools/libxl/libxl_internal.h
@@ -38,7 +38,7 @@
#include <ctype.h>
#include <sys/mman.h>
-#include <sys/poll.h>
+#include <poll.h>
#include <sys/select.h>
#include <sys/stat.h>
#include <sys/time.h>
diff --git a/tools/tests/xen-access/xen-access.c b/tools/tests/xen-access/xen-access.c
index 9d4f957..887bcd9 100644
--- a/tools/tests/xen-access/xen-access.c
+++ b/tools/tests/xen-access/xen-access.c
@@ -36,7 +36,7 @@
#include <signal.h>
#include <unistd.h>
#include <sys/mman.h>
-#include <sys/poll.h>
+#include <poll.h>
#include <xenctrl.h>
#include <xenevtchn.h>
diff --git a/tools/xenstat/libxenstat/src/xenstat_qmp.c b/tools/xenstat/libxenstat/src/xenstat_qmp.c
index a87c937..3fda487 100644
--- a/tools/xenstat/libxenstat/src/xenstat_qmp.c
+++ b/tools/xenstat/libxenstat/src/xenstat_qmp.c
@@ -14,7 +14,7 @@
#include <fcntl.h>
#include <sys/types.h>
#include <sys/socket.h>
-#include <sys/poll.h>
+#include <poll.h>
#include <sys/un.h>
#include <stdlib.h>
#include <string.h>
diff --git a/tools/xentrace/xentrace.c b/tools/xentrace/xentrace.c
index f09fe6c..364a6fd 100644
--- a/tools/xentrace/xentrace.c
+++ b/tools/xentrace/xentrace.c
@@ -24,7 +24,7 @@
#include <getopt.h>
#include <assert.h>
#include <ctype.h>
-#include <sys/poll.h>
+#include <poll.h>
#include <sys/statvfs.h>
#include <xen/xen.h>
--
2.7.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 27+ messages in thread* Re: [PATCH 4/7] tools: Update sys/poll.h to poll.h
2016-12-16 22:56 ` [PATCH 4/7] tools: Update sys/poll.h to poll.h Alistair Francis
@ 2016-12-17 15:55 ` Konrad Rzeszutek Wilk
2016-12-19 18:01 ` Alistair Francis
0 siblings, 1 reply; 27+ messages in thread
From: Konrad Rzeszutek Wilk @ 2016-12-17 15:55 UTC (permalink / raw)
To: Alistair Francis
Cc: wei.liu2, ian.jackson, imhy.yang, alistair23, rshriram, xen-devel
On Fri, Dec 16, 2016 at 02:56:04PM -0800, Alistair Francis wrote:
> To avoid this build error with newer build systems:
And what is newer? GCC 5? 6?
Thanks.
> error: #warning redirecting incorrect #include <sys/poll.h> to
> <poll.h> [-Werror=cpp]
>
> Rename sys/poll.h to poll.h
>
> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
> ---
> tools/libxl/libxl_internal.h | 2 +-
> tools/tests/xen-access/xen-access.c | 2 +-
> tools/xenstat/libxenstat/src/xenstat_qmp.c | 2 +-
> tools/xentrace/xentrace.c | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h
> index 5f46578..acf9ac2 100644
> --- a/tools/libxl/libxl_internal.h
> +++ b/tools/libxl/libxl_internal.h
> @@ -38,7 +38,7 @@
> #include <ctype.h>
>
> #include <sys/mman.h>
> -#include <sys/poll.h>
> +#include <poll.h>
> #include <sys/select.h>
> #include <sys/stat.h>
> #include <sys/time.h>
> diff --git a/tools/tests/xen-access/xen-access.c b/tools/tests/xen-access/xen-access.c
> index 9d4f957..887bcd9 100644
> --- a/tools/tests/xen-access/xen-access.c
> +++ b/tools/tests/xen-access/xen-access.c
> @@ -36,7 +36,7 @@
> #include <signal.h>
> #include <unistd.h>
> #include <sys/mman.h>
> -#include <sys/poll.h>
> +#include <poll.h>
>
> #include <xenctrl.h>
> #include <xenevtchn.h>
> diff --git a/tools/xenstat/libxenstat/src/xenstat_qmp.c b/tools/xenstat/libxenstat/src/xenstat_qmp.c
> index a87c937..3fda487 100644
> --- a/tools/xenstat/libxenstat/src/xenstat_qmp.c
> +++ b/tools/xenstat/libxenstat/src/xenstat_qmp.c
> @@ -14,7 +14,7 @@
> #include <fcntl.h>
> #include <sys/types.h>
> #include <sys/socket.h>
> -#include <sys/poll.h>
> +#include <poll.h>
> #include <sys/un.h>
> #include <stdlib.h>
> #include <string.h>
> diff --git a/tools/xentrace/xentrace.c b/tools/xentrace/xentrace.c
> index f09fe6c..364a6fd 100644
> --- a/tools/xentrace/xentrace.c
> +++ b/tools/xentrace/xentrace.c
> @@ -24,7 +24,7 @@
> #include <getopt.h>
> #include <assert.h>
> #include <ctype.h>
> -#include <sys/poll.h>
> +#include <poll.h>
> #include <sys/statvfs.h>
>
> #include <xen/xen.h>
> --
> 2.7.4
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> https://lists.xen.org/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH 4/7] tools: Update sys/poll.h to poll.h
2016-12-17 15:55 ` Konrad Rzeszutek Wilk
@ 2016-12-19 18:01 ` Alistair Francis
2016-12-20 4:00 ` Doug Goldstein
0 siblings, 1 reply; 27+ messages in thread
From: Alistair Francis @ 2016-12-19 18:01 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk
Cc: wei.liu2, ian.jackson, Alistair Francis, imhy.yang, rshriram, xen-devel
On Sat, Dec 17, 2016 at 7:55 AM, Konrad Rzeszutek Wilk
<konrad.wilk@oracle.com> wrote:
> On Fri, Dec 16, 2016 at 02:56:04PM -0800, Alistair Francis wrote:
>> To avoid this build error with newer build systems:
>
> And what is newer? GCC 5? 6?
In this case it is GCC 5.
Thanks,
Alistair
>
> Thanks.
>> error: #warning redirecting incorrect #include <sys/poll.h> to
>> <poll.h> [-Werror=cpp]
>>
>> Rename sys/poll.h to poll.h
>>
>> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
>> ---
>> tools/libxl/libxl_internal.h | 2 +-
>> tools/tests/xen-access/xen-access.c | 2 +-
>> tools/xenstat/libxenstat/src/xenstat_qmp.c | 2 +-
>> tools/xentrace/xentrace.c | 2 +-
>> 4 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h
>> index 5f46578..acf9ac2 100644
>> --- a/tools/libxl/libxl_internal.h
>> +++ b/tools/libxl/libxl_internal.h
>> @@ -38,7 +38,7 @@
>> #include <ctype.h>
>>
>> #include <sys/mman.h>
>> -#include <sys/poll.h>
>> +#include <poll.h>
>> #include <sys/select.h>
>> #include <sys/stat.h>
>> #include <sys/time.h>
>> diff --git a/tools/tests/xen-access/xen-access.c b/tools/tests/xen-access/xen-access.c
>> index 9d4f957..887bcd9 100644
>> --- a/tools/tests/xen-access/xen-access.c
>> +++ b/tools/tests/xen-access/xen-access.c
>> @@ -36,7 +36,7 @@
>> #include <signal.h>
>> #include <unistd.h>
>> #include <sys/mman.h>
>> -#include <sys/poll.h>
>> +#include <poll.h>
>>
>> #include <xenctrl.h>
>> #include <xenevtchn.h>
>> diff --git a/tools/xenstat/libxenstat/src/xenstat_qmp.c b/tools/xenstat/libxenstat/src/xenstat_qmp.c
>> index a87c937..3fda487 100644
>> --- a/tools/xenstat/libxenstat/src/xenstat_qmp.c
>> +++ b/tools/xenstat/libxenstat/src/xenstat_qmp.c
>> @@ -14,7 +14,7 @@
>> #include <fcntl.h>
>> #include <sys/types.h>
>> #include <sys/socket.h>
>> -#include <sys/poll.h>
>> +#include <poll.h>
>> #include <sys/un.h>
>> #include <stdlib.h>
>> #include <string.h>
>> diff --git a/tools/xentrace/xentrace.c b/tools/xentrace/xentrace.c
>> index f09fe6c..364a6fd 100644
>> --- a/tools/xentrace/xentrace.c
>> +++ b/tools/xentrace/xentrace.c
>> @@ -24,7 +24,7 @@
>> #include <getopt.h>
>> #include <assert.h>
>> #include <ctype.h>
>> -#include <sys/poll.h>
>> +#include <poll.h>
>> #include <sys/statvfs.h>
>>
>> #include <xen/xen.h>
>> --
>> 2.7.4
>>
>>
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@lists.xen.org
>> https://lists.xen.org/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH 4/7] tools: Update sys/poll.h to poll.h
2016-12-19 18:01 ` Alistair Francis
@ 2016-12-20 4:00 ` Doug Goldstein
2016-12-20 17:44 ` Alistair Francis
0 siblings, 1 reply; 27+ messages in thread
From: Doug Goldstein @ 2016-12-20 4:00 UTC (permalink / raw)
To: Alistair Francis, Konrad Rzeszutek Wilk
Cc: rshriram, ian.jackson, wei.liu2, imhy.yang, xen-devel
[-- Attachment #1.1.1: Type: text/plain, Size: 478 bytes --]
On 12/19/16 12:01 PM, Alistair Francis wrote:
> On Sat, Dec 17, 2016 at 7:55 AM, Konrad Rzeszutek Wilk
> <konrad.wilk@oracle.com> wrote:
>> On Fri, Dec 16, 2016 at 02:56:04PM -0800, Alistair Francis wrote:
>>> To avoid this build error with newer build systems:
>>
>> And what is newer? GCC 5? 6?
>
> In this case it is GCC 5.
>
No. Its a libc thing. I wonder what libc you're using because glibc 2.24
still has it at sys/pool.h for me.
--
Doug Goldstein
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 959 bytes --]
[-- Attachment #2: Type: text/plain, Size: 127 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH 4/7] tools: Update sys/poll.h to poll.h
2016-12-20 4:00 ` Doug Goldstein
@ 2016-12-20 17:44 ` Alistair Francis
0 siblings, 0 replies; 27+ messages in thread
From: Alistair Francis @ 2016-12-20 17:44 UTC (permalink / raw)
To: Doug Goldstein
Cc: wei.liu2, ian.jackson, Alistair Francis, imhy.yang, rshriram, xen-devel
On Mon, Dec 19, 2016 at 8:00 PM, Doug Goldstein <cardoe@cardoe.com> wrote:
> On 12/19/16 12:01 PM, Alistair Francis wrote:
>> On Sat, Dec 17, 2016 at 7:55 AM, Konrad Rzeszutek Wilk
>> <konrad.wilk@oracle.com> wrote:
>>> On Fri, Dec 16, 2016 at 02:56:04PM -0800, Alistair Francis wrote:
>>>> To avoid this build error with newer build systems:
>>>
>>> And what is newer? GCC 5? 6?
>>
>> In this case it is GCC 5.
>>
>
> No. Its a libc thing. I wonder what libc you're using because glibc 2.24
> still has it at sys/pool.h for me.
Yeah, you are right. I don't know what I was thinking.
I'm using musl version 1.1.15 which prints a warning every time you
call sys/poll.h.
Looking at the latest glibc master branch glibc supports both and
doesn't have any warnings. This probably isn't the right thing to do
then. I will just have to remove Werror instead.
Thanks,
Alistair
>
> --
> Doug Goldstein
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> https://lists.xen.org/xen-devel
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH 5/7] tools/blktap2: Update sys/signal.h to signal.h
2016-12-16 22:56 [PATCH 0/7] General Build Fixes Alistair Francis
` (3 preceding siblings ...)
2016-12-16 22:56 ` [PATCH 4/7] tools: Update sys/poll.h to poll.h Alistair Francis
@ 2016-12-16 22:56 ` Alistair Francis
2016-12-17 15:56 ` Konrad Rzeszutek Wilk
2016-12-16 22:56 ` [PATCH 6/7] tools/blktap2/vhd: Remove unused struct stat stats Alistair Francis
2016-12-16 22:56 ` [PATCH 7/7] tools/blktap2: Fix missing header file Alistair Francis
6 siblings, 1 reply; 27+ messages in thread
From: Alistair Francis @ 2016-12-16 22:56 UTC (permalink / raw)
To: xen-devel
Cc: wei.liu2, ian.jackson, Alistair Francis, imhy.yang, rshriram, alistair23
To avoid this build error with newer build systems:
error: #warning redirecting incorrect #include <sys/signal.h> to
<signal.h> [-Werror=cpp]
Rename sys/signal.h to signal.h
Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
---
tools/blktap2/drivers/tapdisk-server.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/blktap2/drivers/tapdisk-server.c b/tools/blktap2/drivers/tapdisk-server.c
index eecde3d..71315bb 100644
--- a/tools/blktap2/drivers/tapdisk-server.c
+++ b/tools/blktap2/drivers/tapdisk-server.c
@@ -30,7 +30,7 @@
#include <unistd.h>
#include <stdlib.h>
#include <sys/ioctl.h>
-#include <sys/signal.h>
+#include <signal.h>
#include "tapdisk-utils.h"
#include "tapdisk-server.h"
--
2.7.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 27+ messages in thread* Re: [PATCH 5/7] tools/blktap2: Update sys/signal.h to signal.h
2016-12-16 22:56 ` [PATCH 5/7] tools/blktap2: Update sys/signal.h to signal.h Alistair Francis
@ 2016-12-17 15:56 ` Konrad Rzeszutek Wilk
2016-12-19 18:02 ` Alistair Francis
0 siblings, 1 reply; 27+ messages in thread
From: Konrad Rzeszutek Wilk @ 2016-12-17 15:56 UTC (permalink / raw)
To: Alistair Francis
Cc: wei.liu2, ian.jackson, imhy.yang, alistair23, rshriram, xen-devel
On Fri, Dec 16, 2016 at 02:56:05PM -0800, Alistair Francis wrote:
> To avoid this build error with newer build systems:
> error: #warning redirecting incorrect #include <sys/signal.h> to
> <signal.h> [-Werror=cpp]
And what is the 'newer build system' you speak off?
Thanks!
>
> Rename sys/signal.h to signal.h
>
> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
> ---
> tools/blktap2/drivers/tapdisk-server.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/blktap2/drivers/tapdisk-server.c b/tools/blktap2/drivers/tapdisk-server.c
> index eecde3d..71315bb 100644
> --- a/tools/blktap2/drivers/tapdisk-server.c
> +++ b/tools/blktap2/drivers/tapdisk-server.c
> @@ -30,7 +30,7 @@
> #include <unistd.h>
> #include <stdlib.h>
> #include <sys/ioctl.h>
> -#include <sys/signal.h>
> +#include <signal.h>
>
> #include "tapdisk-utils.h"
> #include "tapdisk-server.h"
> --
> 2.7.4
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> https://lists.xen.org/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH 5/7] tools/blktap2: Update sys/signal.h to signal.h
2016-12-17 15:56 ` Konrad Rzeszutek Wilk
@ 2016-12-19 18:02 ` Alistair Francis
2016-12-20 4:01 ` Doug Goldstein
0 siblings, 1 reply; 27+ messages in thread
From: Alistair Francis @ 2016-12-19 18:02 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk
Cc: wei.liu2, ian.jackson, Alistair Francis, imhy.yang, rshriram, xen-devel
On Sat, Dec 17, 2016 at 7:56 AM, Konrad Rzeszutek Wilk
<konrad.wilk@oracle.com> wrote:
> On Fri, Dec 16, 2016 at 02:56:05PM -0800, Alistair Francis wrote:
>> To avoid this build error with newer build systems:
>> error: #warning redirecting incorrect #include <sys/signal.h> to
>> <signal.h> [-Werror=cpp]
>
> And what is the 'newer build system' you speak off?
Sorry I should have specified more there.
It's GCC 5 that I am seeing the problem on.
Thanks,
Alistair
>
> Thanks!
>>
>> Rename sys/signal.h to signal.h
>>
>> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
>> ---
>> tools/blktap2/drivers/tapdisk-server.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/blktap2/drivers/tapdisk-server.c b/tools/blktap2/drivers/tapdisk-server.c
>> index eecde3d..71315bb 100644
>> --- a/tools/blktap2/drivers/tapdisk-server.c
>> +++ b/tools/blktap2/drivers/tapdisk-server.c
>> @@ -30,7 +30,7 @@
>> #include <unistd.h>
>> #include <stdlib.h>
>> #include <sys/ioctl.h>
>> -#include <sys/signal.h>
>> +#include <signal.h>
>>
>> #include "tapdisk-utils.h"
>> #include "tapdisk-server.h"
>> --
>> 2.7.4
>>
>>
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@lists.xen.org
>> https://lists.xen.org/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH 5/7] tools/blktap2: Update sys/signal.h to signal.h
2016-12-19 18:02 ` Alistair Francis
@ 2016-12-20 4:01 ` Doug Goldstein
0 siblings, 0 replies; 27+ messages in thread
From: Doug Goldstein @ 2016-12-20 4:01 UTC (permalink / raw)
To: Alistair Francis, Konrad Rzeszutek Wilk
Cc: rshriram, ian.jackson, wei.liu2, imhy.yang, xen-devel
[-- Attachment #1.1.1: Type: text/plain, Size: 613 bytes --]
On 12/19/16 12:02 PM, Alistair Francis wrote:
> On Sat, Dec 17, 2016 at 7:56 AM, Konrad Rzeszutek Wilk
> <konrad.wilk@oracle.com> wrote:
>> On Fri, Dec 16, 2016 at 02:56:05PM -0800, Alistair Francis wrote:
>>> To avoid this build error with newer build systems:
>>> error: #warning redirecting incorrect #include <sys/signal.h> to
>>> <signal.h> [-Werror=cpp]
>>
>> And what is the 'newer build system' you speak off?
>
> Sorry I should have specified more there.
>
> It's GCC 5 that I am seeing the problem on.
Same as the last patch. This is your libc.
--
Doug Goldstein
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 959 bytes --]
[-- Attachment #2: Type: text/plain, Size: 127 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH 6/7] tools/blktap2/vhd: Remove unused struct stat stats
2016-12-16 22:56 [PATCH 0/7] General Build Fixes Alistair Francis
` (4 preceding siblings ...)
2016-12-16 22:56 ` [PATCH 5/7] tools/blktap2: Update sys/signal.h to signal.h Alistair Francis
@ 2016-12-16 22:56 ` Alistair Francis
2016-12-17 15:57 ` Konrad Rzeszutek Wilk
2016-12-16 22:56 ` [PATCH 7/7] tools/blktap2: Fix missing header file Alistair Francis
6 siblings, 1 reply; 27+ messages in thread
From: Alistair Francis @ 2016-12-16 22:56 UTC (permalink / raw)
To: xen-devel
Cc: wei.liu2, ian.jackson, Alistair Francis, imhy.yang, rshriram, alistair23
The unsued variable 'struct stat stats' causes build errors in some
situations. As it isn't used just remove it.
Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
---
tools/blktap2/vhd/lib/libvhd-journal.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/blktap2/vhd/lib/libvhd-journal.c b/tools/blktap2/vhd/lib/libvhd-journal.c
index 26e26e7..862890f 100644
--- a/tools/blktap2/vhd/lib/libvhd-journal.c
+++ b/tools/blktap2/vhd/lib/libvhd-journal.c
@@ -1260,7 +1260,6 @@ vhd_journal_create(vhd_journal_t *j, const char *file, const char *jfile)
int i, err;
size_t size;
off_t off;
- struct stat stats;
memset(j, 0, sizeof(vhd_journal_t));
j->jfd = -1;
--
2.7.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 27+ messages in thread* Re: [PATCH 6/7] tools/blktap2/vhd: Remove unused struct stat stats
2016-12-16 22:56 ` [PATCH 6/7] tools/blktap2/vhd: Remove unused struct stat stats Alistair Francis
@ 2016-12-17 15:57 ` Konrad Rzeszutek Wilk
0 siblings, 0 replies; 27+ messages in thread
From: Konrad Rzeszutek Wilk @ 2016-12-17 15:57 UTC (permalink / raw)
To: Alistair Francis
Cc: wei.liu2, ian.jackson, imhy.yang, alistair23, rshriram, xen-devel
On Fri, Dec 16, 2016 at 02:56:06PM -0800, Alistair Francis wrote:
> The unsued variable 'struct stat stats' causes build errors in some
> situations. As it isn't used just remove it.
I think there is an patch that will just rip the blktap2 source
code out altogether..
But if that is not yet in, so
>
> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> ---
> tools/blktap2/vhd/lib/libvhd-journal.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tools/blktap2/vhd/lib/libvhd-journal.c b/tools/blktap2/vhd/lib/libvhd-journal.c
> index 26e26e7..862890f 100644
> --- a/tools/blktap2/vhd/lib/libvhd-journal.c
> +++ b/tools/blktap2/vhd/lib/libvhd-journal.c
> @@ -1260,7 +1260,6 @@ vhd_journal_create(vhd_journal_t *j, const char *file, const char *jfile)
> int i, err;
> size_t size;
> off_t off;
> - struct stat stats;
>
> memset(j, 0, sizeof(vhd_journal_t));
> j->jfd = -1;
> --
> 2.7.4
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> https://lists.xen.org/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH 7/7] tools/blktap2: Fix missing header file
2016-12-16 22:56 [PATCH 0/7] General Build Fixes Alistair Francis
` (5 preceding siblings ...)
2016-12-16 22:56 ` [PATCH 6/7] tools/blktap2/vhd: Remove unused struct stat stats Alistair Francis
@ 2016-12-16 22:56 ` Alistair Francis
6 siblings, 0 replies; 27+ messages in thread
From: Alistair Francis @ 2016-12-16 22:56 UTC (permalink / raw)
To: xen-devel
Cc: wei.liu2, ian.jackson, Alistair Francis, imhy.yang, rshriram, alistair23
To avoid build errors relating to missing delcarations of ssize_t add
the appripriote header file to atomic.h.
Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
---
tools/blktap2/include/atomicio.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/blktap2/include/atomicio.h b/tools/blktap2/include/atomicio.h
index 7eccf20..5a1120e 100644
--- a/tools/blktap2/include/atomicio.h
+++ b/tools/blktap2/include/atomicio.h
@@ -25,6 +25,8 @@
* THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
+#include <sys/types.h>
+
/*
* Ensure all of data on socket comes through. f==read || f==vwrite
*/
--
2.7.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 27+ messages in thread