[PATCH 0/2] More fixes for lto option

[PATCH 0/2] More fixes for lto option

[Wei Liu]

Wei Liu (2):
  config/StdGNU.mk: use CONFIG_LTO
  INSTALL: remove stale lto build instruction

 INSTALL          | 4 ----
 config/StdGNU.mk | 2 +-
 2 files changed, 1 insertion(+), 5 deletions(-)

-- 
2.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

[PATCH 1/2] config/StdGNU.mk: use CONFIG_LTO

[Wei Liu]

The lto symbol is superseded by CONFIG_LTO now.

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
Discovered while reviewing some other patches.

Cc: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Jan Beulich <jbeulich@suse.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>
Cc: Tim Deegan <tim@xen.org>
Cc: Wei Liu <wei.liu2@citrix.com>
---
 config/StdGNU.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/config/StdGNU.mk b/config/StdGNU.mk
index 6be8233..ed8d15e 100644
--- a/config/StdGNU.mk
+++ b/config/StdGNU.mk
@@ -35,7 +35,7 @@ UTIL_LIBS = -lutil
 SONAME_LDFLAG = -soname
 SHLIB_LDFLAGS = -shared
 
-ifeq ($(lto),y)
+ifeq ($(CONFIG_LTO),y)
 CFLAGS += -flto
 LDFLAGS-$(clang) += -plugin LLVMgold.so
 endif
-- 
2.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

[PATCH 2/2] INSTALL: remove stale lto build instruction

[Wei Liu]

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
Cc: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Jan Beulich <jbeulich@suse.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>
Cc: Tim Deegan <tim@xen.org>
Cc: Wei Liu <wei.liu2@citrix.com>
---
 INSTALL | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/INSTALL b/INSTALL
index b8d2ea4..58359da 100644
--- a/INSTALL
+++ b/INSTALL
@@ -225,10 +225,6 @@ XEN_BUILD_TIME=hh:mm:ss
 SMBIOS_REL_DATE=mm/dd/yyyy
 VGABIOS_REL_DATE="dd Mon yyyy"
 
-The following variables can be used to tweak some aspects of the
-hypervisor build.
-lto=y
-
 During tools build external repos will be cloned into the source tree.
 This variable can be used to point to a different git binary to be used.
 GIT=
-- 
2.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH 1/2] config/StdGNU.mk: use CONFIG_LTO

[Jan Beulich]

>>> On 21.12.16 at 17:44, <wei.liu2@citrix.com> wrote:
> The lto symbol is superseded by CONFIG_LTO now.

Considering that this affects both tools and hypervisor build - is that
true for both? Or if it's always been meant for the hypervisor build
only, should is perhaps move out of config/ at once?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH 2/2] INSTALL: remove stale lto build instruction

[Jan Beulich]

>>> On 21.12.16 at 17:44, <wei.liu2@citrix.com> wrote:
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>

Acked-by: Jan Beulich <jbeulich@suse.com>


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH 1/2] config/StdGNU.mk: use CONFIG_LTO

[Wei Liu]

On Thu, Dec 22, 2016 at 01:48:41AM -0700, Jan Beulich wrote:
> >>> On 21.12.16 at 17:44, <wei.liu2@citrix.com> wrote:
> > The lto symbol is superseded by CONFIG_LTO now.
> 
> Considering that this affects both tools and hypervisor build - is that
> true for both? Or if it's always been meant for the hypervisor build
> only, should is perhaps move out of config/ at once?
> 

Did LTO ever work for tools? I'm not sure. I always thought LTO is HV
only.  So maybe moving out of config all together would be a better
thing to do.

I will wait a bit for other people to chime in.

Wei.

> Jan
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel