All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chao Leng <lengchao@huawei.com>
To: Sagi Grimberg <sagi@grimberg.me>, <linux-nvme@lists.infradead.org>
Cc: <kbusch@kernel.org>, <axboe@fb.com>, <hch@lst.de>,
	<linux-block@vger.kernel.org>, <axboe@kernel.dk>
Subject: Re: [PATCH v2 1/6] blk-mq: introduce blk_mq_set_request_complete
Date: Thu, 14 Jan 2021 14:50:36 +0800	[thread overview]
Message-ID: <5868f270-9fda-be39-808d-929e270f52dc@huawei.com> (raw)
In-Reply-To: <6ce3e173-4ac3-e84d-88ca-76057a8d8e1e@grimberg.me>



On 2021/1/14 8:17, Sagi Grimberg wrote:
> 
>> In some scenarios, nvme need setting the state of request to
>> MQ_RQ_COMPLETE. So add an inline function blk_mq_set_request_complete.
>> For details, see the subsequent patches.
> 
> Its kinda difficult to understand the meaning of all of this...
> the cover letter tells us nothing, and patches 1/2 also tells us
> to see subsequent patches.
> 
> This is saved in the git change log history, so please try
> describe what it is you are going with this, even if there are
> overlaps between patches.
ok, thanks for your suggest.
> .

WARNING: multiple messages have this Message-ID (diff)
From: Chao Leng <lengchao@huawei.com>
To: Sagi Grimberg <sagi@grimberg.me>, <linux-nvme@lists.infradead.org>
Cc: kbusch@kernel.org, axboe@fb.com, linux-block@vger.kernel.org,
	hch@lst.de, axboe@kernel.dk
Subject: Re: [PATCH v2 1/6] blk-mq: introduce blk_mq_set_request_complete
Date: Thu, 14 Jan 2021 14:50:36 +0800	[thread overview]
Message-ID: <5868f270-9fda-be39-808d-929e270f52dc@huawei.com> (raw)
In-Reply-To: <6ce3e173-4ac3-e84d-88ca-76057a8d8e1e@grimberg.me>



On 2021/1/14 8:17, Sagi Grimberg wrote:
> 
>> In some scenarios, nvme need setting the state of request to
>> MQ_RQ_COMPLETE. So add an inline function blk_mq_set_request_complete.
>> For details, see the subsequent patches.
> 
> Its kinda difficult to understand the meaning of all of this...
> the cover letter tells us nothing, and patches 1/2 also tells us
> to see subsequent patches.
> 
> This is saved in the git change log history, so please try
> describe what it is you are going with this, even if there are
> overlaps between patches.
ok, thanks for your suggest.
> .

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  reply	other threads:[~2021-01-14  6:51 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-07  3:31 [PATCH v2 0/6] avoid repeated request completion and IO error Chao Leng
2021-01-07  3:31 ` Chao Leng
2021-01-07  3:31 ` [PATCH v2 1/6] blk-mq: introduce blk_mq_set_request_complete Chao Leng
2021-01-07  3:31   ` Chao Leng
2021-01-14  0:17   ` Sagi Grimberg
2021-01-14  0:17     ` Sagi Grimberg
2021-01-14  6:50     ` Chao Leng [this message]
2021-01-14  6:50       ` Chao Leng
2021-01-07  3:31 ` [PATCH v2 2/6] nvme-core: introduce complete failed request Chao Leng
2021-01-07  3:31   ` Chao Leng
2021-01-21  8:14   ` Hannes Reinecke
2021-01-22  1:45     ` Chao Leng
2021-01-07  3:31 ` [PATCH v2 3/6] nvme-fabrics: avoid repeated request completion for nvmf_fail_nonready_command Chao Leng
2021-01-07  3:31   ` Chao Leng
2021-01-07  3:31 ` [PATCH v2 4/6] nvme-rdma: avoid IO error and repeated request completion Chao Leng
2021-01-07  3:31   ` Chao Leng
2021-01-14  0:19   ` Sagi Grimberg
2021-01-14  0:19     ` Sagi Grimberg
2021-01-14  6:55     ` Chao Leng
2021-01-14  6:55       ` Chao Leng
2021-01-14 21:25       ` Sagi Grimberg
2021-01-14 21:25         ` Sagi Grimberg
2021-01-15  2:53         ` Chao Leng
2021-01-15  2:53           ` Chao Leng
2021-01-16  1:18           ` Sagi Grimberg
2021-01-16  1:18             ` Sagi Grimberg
2021-01-18  3:22             ` Chao Leng
2021-01-18  3:22               ` Chao Leng
2021-01-18 17:49               ` Christoph Hellwig
2021-01-18 17:49                 ` Christoph Hellwig
2021-01-19  1:50                 ` Chao Leng
2021-01-19  1:50                   ` Chao Leng
2021-01-20 21:35               ` Sagi Grimberg
2021-01-20 21:35                 ` Sagi Grimberg
2021-01-21  1:34                 ` Chao Leng
2021-01-21  1:34                   ` Chao Leng
2021-01-07  3:31 ` [PATCH v2 5/6] nvme-tcp: " Chao Leng
2021-01-07  3:31   ` Chao Leng
2021-01-07  3:31 ` [PATCH v2 6/6] nvme-fc: " Chao Leng
2021-01-07  3:31   ` Chao Leng
2021-01-14  0:15 ` [PATCH v2 0/6] avoid repeated request completion and IO error Sagi Grimberg
2021-01-14  0:15   ` Sagi Grimberg
2021-01-14  6:50   ` Chao Leng
2021-01-14  6:50     ` Chao Leng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5868f270-9fda-be39-808d-929e270f52dc@huawei.com \
    --to=lengchao@huawei.com \
    --cc=axboe@fb.com \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.