From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> To: John Harrison <john.c.harrison@intel.com>, Michal Wajdeczko <michal.wajdeczko@intel.com>, Intel-GFX@Lists.FreeDesktop.Org Cc: "Ewins, Jon" <jon.ewins@intel.com>, DRI-Devel@Lists.FreeDesktop.Org Subject: Re: [Intel-gfx] [PATCH v2 4/5] drm/i915/guc: Add GuC CT specific debug print wrappers Date: Mon, 9 Jan 2023 09:39:25 +0000 [thread overview] Message-ID: <58691e33-4b69-aa16-42bf-4c2d5ae5b699@linux.intel.com> (raw) In-Reply-To: <127d50a6-b0c4-b87b-ddf5-6bd121d53f3c@intel.com> On 06/01/2023 18:57, John Harrison wrote: > On 12/6/2022 03:06, Tvrtko Ursulin wrote: >> On 05/12/2022 18:44, Michal Wajdeczko wrote: >>> On 05.12.2022 14:16, Tvrtko Ursulin wrote: >>>> On 02/12/2022 20:14, John Harrison wrote: >>>> [snip] >>>> >>>>> Random meaningless (to me) message that is apparently a display thing: >>>>> drm_dbg_kms(&dev_priv->drm, "disabling %s\n", pll->info->name); >>>>> i915 0000:00:02.0: [drm:intel_disable_shared_dpll [i915]] disabling >>>>> PORT PLL B >>>> >>>> Plan is to not touch outside gt/. > For some unexplicable reason that means it is almost impossible to see > the actual problems in most CI dmesg logs because they are swamped with > irrelevant display messages that cannot be filtered out. For example, I > recently manually grep'd out all the display spam from a bug report log. > The dmesg file went from 12MB to 700KB. That is a significant problem > that makes bug triage way harder than it needs to be. I didn't get this part, how it would reduce the amount of spam by adding new macros? Anyway, that's something to split out and discuss with display folks. >> Maybe as a way forward work could be split? If John wants to deal with >> gt_xxx macros, avoid touching GuC (putting his original motivation >> aside) and you want to convert the gt/uc folder? Assuming John you are >> okay with "GuC:" and "CT:" prefixes. > Meaning just repost patch #1 only and expand to more intel_gt_* files? > Sure, if someone will actually reply to that patch with some kind of r-b > first so I know I'm not still wasting my time on a huge re-write that > will to be redone multiple times when someone objects to the use of a > colon or the lack of spaces, braces or whatever. First patch looks good to me (ack in principle) apart that Michal found one potential null pointer dereference if I understood it right. That other comment about the ratelimited call is maybe okay to leave for later, *if* it will be a single instance, otherwise needs a gt logger as well. I can r-b once you re-send with the first issue fixed. Regards, Tvrtko
WARNING: multiple messages have this Message-ID (diff)
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> To: John Harrison <john.c.harrison@intel.com>, Michal Wajdeczko <michal.wajdeczko@intel.com>, Intel-GFX@Lists.FreeDesktop.Org Cc: DRI-Devel@Lists.FreeDesktop.Org Subject: Re: [Intel-gfx] [PATCH v2 4/5] drm/i915/guc: Add GuC CT specific debug print wrappers Date: Mon, 9 Jan 2023 09:39:25 +0000 [thread overview] Message-ID: <58691e33-4b69-aa16-42bf-4c2d5ae5b699@linux.intel.com> (raw) In-Reply-To: <127d50a6-b0c4-b87b-ddf5-6bd121d53f3c@intel.com> On 06/01/2023 18:57, John Harrison wrote: > On 12/6/2022 03:06, Tvrtko Ursulin wrote: >> On 05/12/2022 18:44, Michal Wajdeczko wrote: >>> On 05.12.2022 14:16, Tvrtko Ursulin wrote: >>>> On 02/12/2022 20:14, John Harrison wrote: >>>> [snip] >>>> >>>>> Random meaningless (to me) message that is apparently a display thing: >>>>> drm_dbg_kms(&dev_priv->drm, "disabling %s\n", pll->info->name); >>>>> i915 0000:00:02.0: [drm:intel_disable_shared_dpll [i915]] disabling >>>>> PORT PLL B >>>> >>>> Plan is to not touch outside gt/. > For some unexplicable reason that means it is almost impossible to see > the actual problems in most CI dmesg logs because they are swamped with > irrelevant display messages that cannot be filtered out. For example, I > recently manually grep'd out all the display spam from a bug report log. > The dmesg file went from 12MB to 700KB. That is a significant problem > that makes bug triage way harder than it needs to be. I didn't get this part, how it would reduce the amount of spam by adding new macros? Anyway, that's something to split out and discuss with display folks. >> Maybe as a way forward work could be split? If John wants to deal with >> gt_xxx macros, avoid touching GuC (putting his original motivation >> aside) and you want to convert the gt/uc folder? Assuming John you are >> okay with "GuC:" and "CT:" prefixes. > Meaning just repost patch #1 only and expand to more intel_gt_* files? > Sure, if someone will actually reply to that patch with some kind of r-b > first so I know I'm not still wasting my time on a huge re-write that > will to be redone multiple times when someone objects to the use of a > colon or the lack of spaces, braces or whatever. First patch looks good to me (ack in principle) apart that Michal found one potential null pointer dereference if I understood it right. That other comment about the ratelimited call is maybe okay to leave for later, *if* it will be a single instance, otherwise needs a gt logger as well. I can r-b once you re-send with the first issue fixed. Regards, Tvrtko
next prev parent reply other threads:[~2023-01-09 9:39 UTC|newest] Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-11-18 1:58 [PATCH v2 0/5] Add module oriented dmesg output John.C.Harrison 2022-11-18 1:58 ` [Intel-gfx] " John.C.Harrison 2022-11-18 1:58 ` [PATCH v2 1/5] drm/i915/gt: Start adding " John.C.Harrison 2022-11-18 1:58 ` [Intel-gfx] " John.C.Harrison 2022-11-22 16:47 ` Michal Wajdeczko 2022-11-22 16:47 ` [Intel-gfx] " Michal Wajdeczko 2022-11-18 1:58 ` [PATCH v2 2/5] drm/i915/huc: Add HuC specific debug print wrappers John.C.Harrison 2022-11-18 1:58 ` [Intel-gfx] " John.C.Harrison 2022-11-22 17:17 ` Michal Wajdeczko 2022-11-22 17:17 ` [Intel-gfx] " Michal Wajdeczko 2022-11-18 1:58 ` [PATCH v2 3/5] drm/i915/guc: Add GuC " John.C.Harrison 2022-11-18 1:58 ` [Intel-gfx] " John.C.Harrison 2022-11-22 17:42 ` Michal Wajdeczko 2022-11-22 17:42 ` [Intel-gfx] " Michal Wajdeczko 2022-11-23 0:56 ` John Harrison 2022-11-23 0:56 ` [Intel-gfx] " John Harrison 2022-11-18 1:58 ` [PATCH v2 4/5] drm/i915/guc: Add GuC CT " John.C.Harrison 2022-11-18 1:58 ` [Intel-gfx] " John.C.Harrison 2022-11-22 17:54 ` Michal Wajdeczko 2022-11-23 1:25 ` John Harrison 2022-11-23 20:45 ` Michal Wajdeczko 2022-12-01 0:41 ` John Harrison 2022-12-01 11:56 ` Michal Wajdeczko 2022-12-01 12:01 ` Tvrtko Ursulin 2022-12-02 20:14 ` John Harrison 2022-12-05 13:16 ` Tvrtko Ursulin 2022-12-05 18:44 ` Michal Wajdeczko 2022-12-06 11:06 ` Tvrtko Ursulin 2023-01-06 18:57 ` John Harrison 2023-01-06 18:57 ` John Harrison 2023-01-09 9:38 ` Jani Nikula 2023-01-09 9:38 ` Jani Nikula 2023-01-09 20:33 ` John Harrison 2023-01-09 20:33 ` John Harrison 2023-01-09 9:39 ` Tvrtko Ursulin [this message] 2023-01-09 9:39 ` Tvrtko Ursulin 2023-01-09 20:36 ` John Harrison 2023-01-09 20:36 ` John Harrison 2022-11-18 1:58 ` [PATCH v2 5/5] drm/i915/uc: Update the gt/uc code to use gt_err and friends John.C.Harrison 2022-11-18 1:58 ` [Intel-gfx] " John.C.Harrison 2022-11-18 2:24 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Add module oriented dmesg output Patchwork 2022-11-18 2:24 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork 2022-11-18 2:45 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2022-11-18 10:52 ` [Intel-gfx] [PATCH v2 0/5] " Jani Nikula 2022-11-18 10:52 ` Jani Nikula 2022-11-21 18:21 ` John Harrison 2022-11-21 18:21 ` John Harrison 2022-11-22 8:14 ` Tvrtko Ursulin 2022-11-22 16:35 ` Michal Wajdeczko 2022-11-22 18:21 ` Jani Nikula 2022-11-18 19:37 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=58691e33-4b69-aa16-42bf-4c2d5ae5b699@linux.intel.com \ --to=tvrtko.ursulin@linux.intel.com \ --cc=DRI-Devel@Lists.FreeDesktop.Org \ --cc=Intel-GFX@Lists.FreeDesktop.Org \ --cc=john.c.harrison@intel.com \ --cc=jon.ewins@intel.com \ --cc=michal.wajdeczko@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.