* [PATCH v2] build: move setting LTO options to xen/Rules.mk
@ 2016-12-23 12:12 Wei Liu
2017-01-05 15:09 ` Wei Liu
2017-01-05 16:15 ` Ian Jackson
0 siblings, 2 replies; 7+ messages in thread
From: Wei Liu @ 2016-12-23 12:12 UTC (permalink / raw)
To: Xen-devel
Cc: Stefano Stabellini, Wei Liu, George Dunlap, Andrew Cooper,
Ian Jackson, Tim Deegan, Jan Beulich
Having them in StdGNU.mk would affect both hypervisor and tools build.
However judging from the commit message of e4cdd74f LTO was only meant
to affect hypvervisor build.
Move the relevant bits to xen/Rules.mk.
Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
Cc: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Jan Beulich <jbeulich@suse.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>
Cc: Tim Deegan <tim@xen.org>
Cc: Wei Liu <wei.liu2@citrix.com>
---
config/StdGNU.mk | 4 ----
xen/Rules.mk | 2 ++
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/config/StdGNU.mk b/config/StdGNU.mk
index 6be8233..039274e 100644
--- a/config/StdGNU.mk
+++ b/config/StdGNU.mk
@@ -35,7 +35,3 @@ UTIL_LIBS = -lutil
SONAME_LDFLAG = -soname
SHLIB_LDFLAGS = -shared
-ifeq ($(lto),y)
-CFLAGS += -flto
-LDFLAGS-$(clang) += -plugin LLVMgold.so
-endif
diff --git a/xen/Rules.mk b/xen/Rules.mk
index 24d13dc..77bcd44 100644
--- a/xen/Rules.mk
+++ b/xen/Rules.mk
@@ -120,6 +120,8 @@ $(filter-out %.init.o $(nogcov-y),$(obj-y) $(obj-bin-y) $(extra-y)): CFLAGS += -
endif
ifeq ($(CONFIG_LTO),y)
+CFLAGS += -flto
+LDFLAGS-$(clang) += -plugin LLVMgold.so
# Would like to handle all object files as bitcode, but objects made from
# pure asm are in a different format and have to be collected separately.
# Mirror the directory tree, collecting them as built_in_bin.o.
--
2.1.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2] build: move setting LTO options to xen/Rules.mk
2016-12-23 12:12 [PATCH v2] build: move setting LTO options to xen/Rules.mk Wei Liu
@ 2017-01-05 15:09 ` Wei Liu
2017-01-05 15:23 ` Andrew Cooper
2017-01-05 16:15 ` Ian Jackson
1 sibling, 1 reply; 7+ messages in thread
From: Wei Liu @ 2017-01-05 15:09 UTC (permalink / raw)
To: Xen-devel
Cc: Stefano Stabellini, Wei Liu, George Dunlap, Andrew Cooper,
Ian Jackson, Tim Deegan, Jan Beulich
On Fri, Dec 23, 2016 at 12:12:36PM +0000, Wei Liu wrote:
> Having them in StdGNU.mk would affect both hypervisor and tools build.
> However judging from the commit message of e4cdd74f LTO was only meant
> to affect hypvervisor build.
>
> Move the relevant bits to xen/Rules.mk.
>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Ping?
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] build: move setting LTO options to xen/Rules.mk
2017-01-05 15:09 ` Wei Liu
@ 2017-01-05 15:23 ` Andrew Cooper
2017-01-05 15:37 ` Jan Beulich
0 siblings, 1 reply; 7+ messages in thread
From: Andrew Cooper @ 2017-01-05 15:23 UTC (permalink / raw)
To: Wei Liu, Xen-devel
Cc: Stefano Stabellini, George Dunlap, Ian Jackson, Tim Deegan, Jan Beulich
On 05/01/17 15:09, Wei Liu wrote:
> On Fri, Dec 23, 2016 at 12:12:36PM +0000, Wei Liu wrote:
>> Having them in StdGNU.mk would affect both hypervisor and tools build.
>> However judging from the commit message of e4cdd74f LTO was only meant
>> to affect hypvervisor build.
>>
>> Move the relevant bits to xen/Rules.mk.
>>
>> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> Ping?
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
/me looks at the date and isn't surprised that this patch slipped
through the cracks.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] build: move setting LTO options to xen/Rules.mk
2017-01-05 15:23 ` Andrew Cooper
@ 2017-01-05 15:37 ` Jan Beulich
0 siblings, 0 replies; 7+ messages in thread
From: Jan Beulich @ 2017-01-05 15:37 UTC (permalink / raw)
To: Andrew Cooper, Wei Liu
Cc: Stefano Stabellini, George Dunlap, Ian Jackson, Tim Deegan, Xen-devel
>>> On 05.01.17 at 16:23, <andrew.cooper3@citrix.com> wrote:
> On 05/01/17 15:09, Wei Liu wrote:
>> On Fri, Dec 23, 2016 at 12:12:36PM +0000, Wei Liu wrote:
>>> Having them in StdGNU.mk would affect both hypervisor and tools build.
>>> However judging from the commit message of e4cdd74f LTO was only meant
>>> to affect hypvervisor build.
>>>
>>> Move the relevant bits to xen/Rules.mk.
>>>
>>> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
>> Ping?
>
> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
>
> /me looks at the date and isn't surprised that this patch slipped
> through the cracks.
I don't even have a patch named like this in my inbox; the only
thing I have is a 2-patch series titled "More fixes for lto option"
from Dec 22nd.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] build: move setting LTO options to xen/Rules.mk
2016-12-23 12:12 [PATCH v2] build: move setting LTO options to xen/Rules.mk Wei Liu
2017-01-05 15:09 ` Wei Liu
@ 2017-01-05 16:15 ` Ian Jackson
1 sibling, 0 replies; 7+ messages in thread
From: Ian Jackson @ 2017-01-05 16:15 UTC (permalink / raw)
To: Wei Liu
Cc: Stefano Stabellini, George Dunlap, Andrew Cooper, Tim Deegan,
Jan Beulich, Xen-devel
Wei Liu writes ("[PATCH v2] build: move setting LTO options to xen/Rules.mk"):
> Having them in StdGNU.mk would affect both hypervisor and tools build.
> However judging from the commit message of e4cdd74f LTO was only meant
> to affect hypvervisor build.
>
> Move the relevant bits to xen/Rules.mk.
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
I think -flto is a very bad idea for the tools build and I think we
should backport this change.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] build: move setting LTO options to xen/Rules.mk
2016-12-23 12:24 ` [PATCH v2] build: move setting LTO options to xen/Rules.mk Wei Liu
@ 2016-12-23 12:25 ` Wei Liu
0 siblings, 0 replies; 7+ messages in thread
From: Wei Liu @ 2016-12-23 12:25 UTC (permalink / raw)
To: Xen-devel
Cc: Stefano Stabellini, Wei Liu, George Dunlap, Andrew Cooper,
Ian Jackson, Tim Deegan, Jan Beulich
On Fri, Dec 23, 2016 at 12:24:17PM +0000, Wei Liu wrote:
> Having them in StdGNU.mk would affect both hypervisor and tools build.
> However judging from the commit message of e4cdd74f LTO was only meant
> to affect hypvervisor build.
>
> Move the relevant bits to xen/Rules.mk.
>
Ah, git send-email *.patch -- please ignore this patch in this series.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2] build: move setting LTO options to xen/Rules.mk
2016-12-23 12:24 [PATCH v2 0/2] build: minor adjustment Wei Liu
@ 2016-12-23 12:24 ` Wei Liu
2016-12-23 12:25 ` Wei Liu
0 siblings, 1 reply; 7+ messages in thread
From: Wei Liu @ 2016-12-23 12:24 UTC (permalink / raw)
To: Xen-devel
Cc: Stefano Stabellini, Wei Liu, George Dunlap, Andrew Cooper,
Ian Jackson, Tim Deegan, Jan Beulich
Having them in StdGNU.mk would affect both hypervisor and tools build.
However judging from the commit message of e4cdd74f LTO was only meant
to affect hypvervisor build.
Move the relevant bits to xen/Rules.mk.
Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
Cc: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Jan Beulich <jbeulich@suse.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>
Cc: Tim Deegan <tim@xen.org>
Cc: Wei Liu <wei.liu2@citrix.com>
---
config/StdGNU.mk | 4 ----
xen/Rules.mk | 2 ++
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/config/StdGNU.mk b/config/StdGNU.mk
index 6be8233..039274e 100644
--- a/config/StdGNU.mk
+++ b/config/StdGNU.mk
@@ -35,7 +35,3 @@ UTIL_LIBS = -lutil
SONAME_LDFLAG = -soname
SHLIB_LDFLAGS = -shared
-ifeq ($(lto),y)
-CFLAGS += -flto
-LDFLAGS-$(clang) += -plugin LLVMgold.so
-endif
diff --git a/xen/Rules.mk b/xen/Rules.mk
index 24d13dc..77bcd44 100644
--- a/xen/Rules.mk
+++ b/xen/Rules.mk
@@ -120,6 +120,8 @@ $(filter-out %.init.o $(nogcov-y),$(obj-y) $(obj-bin-y) $(extra-y)): CFLAGS += -
endif
ifeq ($(CONFIG_LTO),y)
+CFLAGS += -flto
+LDFLAGS-$(clang) += -plugin LLVMgold.so
# Would like to handle all object files as bitcode, but objects made from
# pure asm are in a different format and have to be collected separately.
# Mirror the directory tree, collecting them as built_in_bin.o.
--
2.1.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-01-05 16:15 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-23 12:12 [PATCH v2] build: move setting LTO options to xen/Rules.mk Wei Liu
2017-01-05 15:09 ` Wei Liu
2017-01-05 15:23 ` Andrew Cooper
2017-01-05 15:37 ` Jan Beulich
2017-01-05 16:15 ` Ian Jackson
2016-12-23 12:24 [PATCH v2 0/2] build: minor adjustment Wei Liu
2016-12-23 12:24 ` [PATCH v2] build: move setting LTO options to xen/Rules.mk Wei Liu
2016-12-23 12:25 ` Wei Liu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.