All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] xen/x86: Fix CONFIG_CRASH_DEBUG build following c/s 897129dea
@ 2017-01-06 14:34 Andrew Cooper
  2017-01-06 14:39 ` Jan Beulich
  2017-01-06 18:33 ` Elena Ufimtseva
  0 siblings, 2 replies; 4+ messages in thread
From: Andrew Cooper @ 2017-01-06 14:34 UTC (permalink / raw)
  To: Xen-devel; +Cc: Elena Ufimtseva, Andrew Cooper, Jan Beulich

Found by a Travis RANDCONFIG run.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Elena Ufimtseva <elena.ufimtseva@oracle.com>
---
 xen/arch/x86/gdbstub.c        | 8 ++++----
 xen/arch/x86/x86_64/gdbstub.c | 2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/xen/arch/x86/gdbstub.c b/xen/arch/x86/gdbstub.c
index 2a39189..fe69f81 100644
--- a/xen/arch/x86/gdbstub.c
+++ b/xen/arch/x86/gdbstub.c
@@ -66,16 +66,16 @@ gdb_arch_resume(struct cpu_user_regs *regs,
                 struct gdb_context *ctx)
 {
     if ( addr != -1UL )
-        regs->eip = addr;
+        regs->rip = addr;
 
-    regs->eflags &= ~X86_EFLAGS_TF;
+    regs->_eflags &= ~X86_EFLAGS_TF;
 
     /* Set eflags.RF to ensure we do not re-enter. */
-    regs->eflags |= X86_EFLAGS_RF;
+    regs->_eflags |= X86_EFLAGS_RF;
 
     /* Set the trap flag if we are single stepping. */
     if ( type == GDB_STEP )
-        regs->eflags |= X86_EFLAGS_TF;
+        regs->_eflags |= X86_EFLAGS_TF;
 }
 
 /*
diff --git a/xen/arch/x86/x86_64/gdbstub.c b/xen/arch/x86/x86_64/gdbstub.c
index 2626519..2c2ab15 100644
--- a/xen/arch/x86/x86_64/gdbstub.c
+++ b/xen/arch/x86/x86_64/gdbstub.c
@@ -44,7 +44,7 @@ gdb_arch_read_reg_array(struct cpu_user_regs *regs, struct gdb_context *ctx)
     GDB_REG64(regs->r15);
 
     GDB_REG64(regs->rip);
-    GDB_REG32(regs->eflags);
+    GDB_REG32(regs->_eflags);
 
     GDB_REG32(regs->cs);
     GDB_REG32(regs->ss);
-- 
2.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] xen/x86: Fix CONFIG_CRASH_DEBUG build following c/s 897129dea
  2017-01-06 14:34 [PATCH] xen/x86: Fix CONFIG_CRASH_DEBUG build following c/s 897129dea Andrew Cooper
@ 2017-01-06 14:39 ` Jan Beulich
  2017-01-06 18:33 ` Elena Ufimtseva
  1 sibling, 0 replies; 4+ messages in thread
From: Jan Beulich @ 2017-01-06 14:39 UTC (permalink / raw)
  To: Andrew Cooper; +Cc: Elena Ufimtseva, Xen-devel

>>> On 06.01.17 at 15:34, <andrew.cooper3@citrix.com> wrote:
> Found by a Travis RANDCONFIG run.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>

I'm sorry for the breakage.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] xen/x86: Fix CONFIG_CRASH_DEBUG build following c/s 897129dea
  2017-01-06 14:34 [PATCH] xen/x86: Fix CONFIG_CRASH_DEBUG build following c/s 897129dea Andrew Cooper
  2017-01-06 14:39 ` Jan Beulich
@ 2017-01-06 18:33 ` Elena Ufimtseva
  2017-01-06 19:28   ` Andrew Cooper
  1 sibling, 1 reply; 4+ messages in thread
From: Elena Ufimtseva @ 2017-01-06 18:33 UTC (permalink / raw)
  To: Andrew Cooper; +Cc: Jan Beulich, Xen-devel

On Fri, Jan 06, 2017 at 02:34:17PM +0000, Andrew Cooper wrote:
> Found by a Travis RANDCONFIG run.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Acked-by: Elena Ufimtseva <elena.ufimtseva@oracle.com>
> ---
> CC: Jan Beulich <JBeulich@suse.com>
> CC: Elena Ufimtseva <elena.ufimtseva@oracle.com>
> ---
>  xen/arch/x86/gdbstub.c        | 8 ++++----
>  xen/arch/x86/x86_64/gdbstub.c | 2 +-
>  2 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/xen/arch/x86/gdbstub.c b/xen/arch/x86/gdbstub.c
> index 2a39189..fe69f81 100644
> --- a/xen/arch/x86/gdbstub.c
> +++ b/xen/arch/x86/gdbstub.c
> @@ -66,16 +66,16 @@ gdb_arch_resume(struct cpu_user_regs *regs,
>                  struct gdb_context *ctx)
>  {
>      if ( addr != -1UL )
> -        regs->eip = addr;
> +        regs->rip = addr;
>  
> -    regs->eflags &= ~X86_EFLAGS_TF;
> +    regs->_eflags &= ~X86_EFLAGS_TF;
>  
>      /* Set eflags.RF to ensure we do not re-enter. */
> -    regs->eflags |= X86_EFLAGS_RF;
> +    regs->_eflags |= X86_EFLAGS_RF;
>  
>      /* Set the trap flag if we are single stepping. */
>      if ( type == GDB_STEP )
> -        regs->eflags |= X86_EFLAGS_TF;
> +        regs->_eflags |= X86_EFLAGS_TF;
>  }
>  
>  /*
> diff --git a/xen/arch/x86/x86_64/gdbstub.c b/xen/arch/x86/x86_64/gdbstub.c
> index 2626519..2c2ab15 100644
> --- a/xen/arch/x86/x86_64/gdbstub.c
> +++ b/xen/arch/x86/x86_64/gdbstub.c
> @@ -44,7 +44,7 @@ gdb_arch_read_reg_array(struct cpu_user_regs *regs, struct gdb_context *ctx)
>      GDB_REG64(regs->r15);
>  
>      GDB_REG64(regs->rip);
> -    GDB_REG32(regs->eflags);
> +    GDB_REG32(regs->_eflags);
>  
>      GDB_REG32(regs->cs);
>      GDB_REG32(regs->ss);
> -- 
> 2.1.4
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] xen/x86: Fix CONFIG_CRASH_DEBUG build following c/s 897129dea
  2017-01-06 18:33 ` Elena Ufimtseva
@ 2017-01-06 19:28   ` Andrew Cooper
  0 siblings, 0 replies; 4+ messages in thread
From: Andrew Cooper @ 2017-01-06 19:28 UTC (permalink / raw)
  To: Elena Ufimtseva; +Cc: Jan Beulich, Xen-devel

On 06/01/17 18:33, Elena Ufimtseva wrote:
> On Fri, Jan 06, 2017 at 02:34:17PM +0000, Andrew Cooper wrote:
>> Found by a Travis RANDCONFIG run.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Acked-by: Elena Ufimtseva <elena.ufimtseva@oracle.com>

Thanks.  Pushed.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-01-06 19:28 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-06 14:34 [PATCH] xen/x86: Fix CONFIG_CRASH_DEBUG build following c/s 897129dea Andrew Cooper
2017-01-06 14:39 ` Jan Beulich
2017-01-06 18:33 ` Elena Ufimtseva
2017-01-06 19:28   ` Andrew Cooper

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.