From: Zhou Wang <wangzhou1@hisilicon.com> To: "Rafael J. Wysocki" <rafael@kernel.org>, Bjorn Helgaas <bhelgaas@google.com> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>, Len Brown <lenb@kernel.org>, Tomasz Nowicki <tn@semihalf.com>, Jayachandran C <jchandra@broadcom.com>, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>, Dongdong Liu <liudongdong3@huawei.com>, Gabriele Paoloni <gabriele.paoloni@huawei.com>, xuwei5@hisilicon.com, ACPI Devel Maling List <linux-acpi@vger.kernel.org>, Linux PCI <linux-pci@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Subject: Re: [PATCH] ACPI/PCI: Fix bus range comparation in pci_mcfg_lookup Date: Wed, 11 Jan 2017 08:36:13 +0800 [thread overview] Message-ID: <58757DFD.40108@hisilicon.com> (raw) In-Reply-To: <CAJZ5v0iv99MB=Eyw=-s=9RhtxhogTNwk0TdLY=gO46GYsRhZqg@mail.gmail.com> On 2017/1/10 5:45, Rafael J. Wysocki wrote: > On Mon, Jan 9, 2017 at 4:39 AM, Zhou Wang <wangzhou1@hisilicon.com> wrote: >> On 2017/1/4 15:00, Zhou Wang wrote: >>> The configuration data provided by an MCFG region (ie PCI segment and >>> bus range) may span multiple host bridges. >>> >>> Current code in pci_mcfg_lookup() carries out an exact match of host >>> bridge bus range start value against the MCFG region(s) bus range start >>> value which would cause configurations like the following: >>> >>> MCFG region: >>> bus range: 0x00~0xff. >>> segment: 0. >>> >>> PCI host bridges configuration (segment numbers and bus ranges): >>> host bridge 1: >>> bus range: 0x00~0x1f. >>> segment: 0. >>> host bridge 2: >>> bus range: 0x20~0x4f. >>> segment: 0. >>> >>> to fail, in that the bus range start value for host bridge 2 does >>> not match the bus range start value of the respective MCFG region. >>> >>> Relax the bus range check in pci_mcfg_lookup() to cater for >>> PCI configurations with multiple host bridges sharing the same >>> MCFG region. >>> >>> Signed-off-by: Zhou Wang <wangzhou1@hisilicon.com> >>> Reviewed-by: Tomasz Nowicki <tn@semihalf.com> >>> Acked-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> >>> --- >>> drivers/acpi/pci_mcfg.c | 5 ++--- >>> 1 file changed, 2 insertions(+), 3 deletions(-) >>> >>> diff --git a/drivers/acpi/pci_mcfg.c b/drivers/acpi/pci_mcfg.c >>> index a6a4cea..2944353 100644 >>> --- a/drivers/acpi/pci_mcfg.c >>> +++ b/drivers/acpi/pci_mcfg.c >>> @@ -195,11 +195,10 @@ int pci_mcfg_lookup(struct acpi_pci_root *root, struct resource *cfgres, >>> goto skip_lookup; >>> >>> /* >>> - * We expect exact match, unless MCFG entry end bus covers more than >>> - * specified by caller. >>> + * We expect the range in bus_res in the coverage of MCFG bus range. >>> */ >>> list_for_each_entry(e, &pci_mcfg_list, list) { >>> - if (e->segment == seg && e->bus_start == bus_res->start && >>> + if (e->segment == seg && e->bus_start <= bus_res->start && >>> e->bus_end >= bus_res->end) { >>> root->mcfg_addr = e->addr; >>> } >>> >> >> Hi Rafael, >> >> Could you please look into this patch if you have time? > > Well, it makes sense to me, but this is PCI, so Bjorn has to decide here. > > Thanks, > Rafael Many thanks for looking into this patch! Hi Bjorn, Please look at this patch if you have time :) Thanks, Zhou > > . >
WARNING: multiple messages have this Message-ID (diff)
From: Zhou Wang <wangzhou1@hisilicon.com> To: "Rafael J. Wysocki" <rafael@kernel.org>, Bjorn Helgaas <bhelgaas@google.com> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>, Len Brown <lenb@kernel.org>, Tomasz Nowicki <tn@semihalf.com>, Jayachandran C <jchandra@broadcom.com>, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>, Dongdong Liu <liudongdong3@huawei.com>, Gabriele Paoloni <gabriele.paoloni@huawei.com>, <xuwei5@hisilicon.com>, ACPI Devel Maling List <linux-acpi@vger.kernel.org>, Linux PCI <linux-pci@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Subject: Re: [PATCH] ACPI/PCI: Fix bus range comparation in pci_mcfg_lookup Date: Wed, 11 Jan 2017 08:36:13 +0800 [thread overview] Message-ID: <58757DFD.40108@hisilicon.com> (raw) In-Reply-To: <CAJZ5v0iv99MB=Eyw=-s=9RhtxhogTNwk0TdLY=gO46GYsRhZqg@mail.gmail.com> On 2017/1/10 5:45, Rafael J. Wysocki wrote: > On Mon, Jan 9, 2017 at 4:39 AM, Zhou Wang <wangzhou1@hisilicon.com> wrote: >> On 2017/1/4 15:00, Zhou Wang wrote: >>> The configuration data provided by an MCFG region (ie PCI segment and >>> bus range) may span multiple host bridges. >>> >>> Current code in pci_mcfg_lookup() carries out an exact match of host >>> bridge bus range start value against the MCFG region(s) bus range start >>> value which would cause configurations like the following: >>> >>> MCFG region: >>> bus range: 0x00~0xff. >>> segment: 0. >>> >>> PCI host bridges configuration (segment numbers and bus ranges): >>> host bridge 1: >>> bus range: 0x00~0x1f. >>> segment: 0. >>> host bridge 2: >>> bus range: 0x20~0x4f. >>> segment: 0. >>> >>> to fail, in that the bus range start value for host bridge 2 does >>> not match the bus range start value of the respective MCFG region. >>> >>> Relax the bus range check in pci_mcfg_lookup() to cater for >>> PCI configurations with multiple host bridges sharing the same >>> MCFG region. >>> >>> Signed-off-by: Zhou Wang <wangzhou1@hisilicon.com> >>> Reviewed-by: Tomasz Nowicki <tn@semihalf.com> >>> Acked-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> >>> --- >>> drivers/acpi/pci_mcfg.c | 5 ++--- >>> 1 file changed, 2 insertions(+), 3 deletions(-) >>> >>> diff --git a/drivers/acpi/pci_mcfg.c b/drivers/acpi/pci_mcfg.c >>> index a6a4cea..2944353 100644 >>> --- a/drivers/acpi/pci_mcfg.c >>> +++ b/drivers/acpi/pci_mcfg.c >>> @@ -195,11 +195,10 @@ int pci_mcfg_lookup(struct acpi_pci_root *root, struct resource *cfgres, >>> goto skip_lookup; >>> >>> /* >>> - * We expect exact match, unless MCFG entry end bus covers more than >>> - * specified by caller. >>> + * We expect the range in bus_res in the coverage of MCFG bus range. >>> */ >>> list_for_each_entry(e, &pci_mcfg_list, list) { >>> - if (e->segment == seg && e->bus_start == bus_res->start && >>> + if (e->segment == seg && e->bus_start <= bus_res->start && >>> e->bus_end >= bus_res->end) { >>> root->mcfg_addr = e->addr; >>> } >>> >> >> Hi Rafael, >> >> Could you please look into this patch if you have time? > > Well, it makes sense to me, but this is PCI, so Bjorn has to decide here. > > Thanks, > Rafael Many thanks for looking into this patch! Hi Bjorn, Please look at this patch if you have time :) Thanks, Zhou > > . >
next prev parent reply other threads:[~2017-01-11 0:36 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-01-04 7:00 [PATCH] ACPI/PCI: Fix bus range comparation in pci_mcfg_lookup Zhou Wang 2017-01-04 7:00 ` Zhou Wang 2017-01-09 3:39 ` Zhou Wang 2017-01-09 3:39 ` Zhou Wang 2017-01-09 21:45 ` Rafael J. Wysocki 2017-01-11 0:36 ` Zhou Wang [this message] 2017-01-11 0:36 ` Zhou Wang 2017-01-11 21:37 ` Bjorn Helgaas 2017-01-12 0:21 ` Zhou Wang 2017-01-12 0:21 ` Zhou Wang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=58757DFD.40108@hisilicon.com \ --to=wangzhou1@hisilicon.com \ --cc=bhelgaas@google.com \ --cc=gabriele.paoloni@huawei.com \ --cc=jchandra@broadcom.com \ --cc=lenb@kernel.org \ --cc=linux-acpi@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=liudongdong3@huawei.com \ --cc=lorenzo.pieralisi@arm.com \ --cc=rafael@kernel.org \ --cc=rjw@rjwysocki.net \ --cc=tn@semihalf.com \ --cc=xuwei5@hisilicon.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.