All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pramod Kumar <pramod.kumar@broadcom.com>
To: David Miller <davem@davemloft.net>
Cc: robh+dt@kernel.org, catalin.marinas@arm.com, will.deacon@arm.com,
	yamada.masahiro@socionext.com, wens@csie.org,
	bcm-kernel-feedback-list@broadcom.com, pawel.moll@arm.com,
	mark.rutland@arm.com, arnd@arndb.de, suzuki.poulose@arm.com,
	punit.agrawal@arm.com, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	Anup Patel <anup.patel@broadcom.com>
Subject: RE: [PATCH 1/6] bus: Add shared MDIO bus framework
Date: Mon, 25 Apr 2016 09:39:38 +0530	[thread overview]
Message-ID: <5876c521a46dbb4bd1b0c22bc64ec1a5@mail.gmail.com> (raw)
In-Reply-To: <20160424.141806.786009616301278103.davem@davemloft.net>

Hi David,

Thanks for providing input over the patch.  Will address the comment as
described below.

> -----Original Message-----
> From: David Miller [mailto:davem@davemloft.net]
> Sent: 24 April 2016 23:48
> To: pramod.kumar@broadcom.com
> Cc: robh+dt@kernel.org; catalin.marinas@arm.com; will.deacon@arm.com;
> yamada.masahiro@socionext.com; wens@csie.org; bcm-kernel-feedback-
> list@broadcom.com; pawel.moll@arm.com; mark.rutland@arm.com;
> arnd@arndb.de; suzuki.poulose@arm.com; punit.agrawal@arm.com;
> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
> kernel@vger.kernel.org; netdev@vger.kernel.org; anup.patel@broadcom.com
> Subject: Re: [PATCH 1/6] bus: Add shared MDIO bus framework
>
> From: Pramod Kumar <pramod.kumar@broadcom.com>
> Date: Thu, 21 Apr 2016 14:48:38 +0530
>
> > +struct shared_mdio_master *shared_mdio_alloc_master(struct device
> *parent,
> > +						    struct device_node
*node)
> > +{
> > +	int ret = 0;
> > +	struct shared_mdio_master *master;
>
> Always order local variable declarations in reverse christmas tree
(longest to
> shortest line) order.
>

Sure. Next patch will address this.

> > +static int shared_mdio_driver_probe(struct device *dev) {
> > +	int rc;
> > +	struct shared_mdio_master *master = to_shared_mdio_master(dev);
> > +	struct shared_mdio_driver *drv =
to_shared_mdio_driver(dev->driver);
>
> Likewise.

Sure.

> Please audit your entire submission for this issue.

Sure. I'll audit the entire patch set for above issue.

Regards,
Pramod

WARNING: multiple messages have this Message-ID (diff)
From: pramod.kumar@broadcom.com (Pramod Kumar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/6] bus: Add shared MDIO bus framework
Date: Mon, 25 Apr 2016 09:39:38 +0530	[thread overview]
Message-ID: <5876c521a46dbb4bd1b0c22bc64ec1a5@mail.gmail.com> (raw)
In-Reply-To: <20160424.141806.786009616301278103.davem@davemloft.net>

Hi David,

Thanks for providing input over the patch.  Will address the comment as
described below.

> -----Original Message-----
> From: David Miller [mailto:davem at davemloft.net]
> Sent: 24 April 2016 23:48
> To: pramod.kumar at broadcom.com
> Cc: robh+dt at kernel.org; catalin.marinas at arm.com; will.deacon at arm.com;
> yamada.masahiro at socionext.com; wens at csie.org; bcm-kernel-feedback-
> list at broadcom.com; pawel.moll at arm.com; mark.rutland at arm.com;
> arnd at arndb.de; suzuki.poulose at arm.com; punit.agrawal at arm.com;
> devicetree at vger.kernel.org; linux-arm-kernel at lists.infradead.org; linux-
> kernel at vger.kernel.org; netdev at vger.kernel.org; anup.patel at broadcom.com
> Subject: Re: [PATCH 1/6] bus: Add shared MDIO bus framework
>
> From: Pramod Kumar <pramod.kumar@broadcom.com>
> Date: Thu, 21 Apr 2016 14:48:38 +0530
>
> > +struct shared_mdio_master *shared_mdio_alloc_master(struct device
> *parent,
> > +						    struct device_node
*node)
> > +{
> > +	int ret = 0;
> > +	struct shared_mdio_master *master;
>
> Always order local variable declarations in reverse christmas tree
(longest to
> shortest line) order.
>

Sure. Next patch will address this.

> > +static int shared_mdio_driver_probe(struct device *dev) {
> > +	int rc;
> > +	struct shared_mdio_master *master = to_shared_mdio_master(dev);
> > +	struct shared_mdio_driver *drv =
to_shared_mdio_driver(dev->driver);
>
> Likewise.

Sure.

> Please audit your entire submission for this issue.

Sure. I'll audit the entire patch set for above issue.

Regards,
Pramod

  reply	other threads:[~2016-04-25  4:09 UTC|newest]

Thread overview: 69+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-21  9:18 [PATCH 0/6] Add Shared MDIO framework for iProc based SoCs Pramod Kumar
2016-04-21  9:18 ` Pramod Kumar
2016-04-21  9:18 ` Pramod Kumar
2016-04-21  9:18 ` [PATCH 1/6] bus: Add shared MDIO bus framework Pramod Kumar
2016-04-21  9:18   ` Pramod Kumar
2016-04-21  9:18   ` Pramod Kumar
2016-04-24 18:18   ` David Miller
2016-04-24 18:18     ` David Miller
2016-04-24 18:18     ` David Miller
2016-04-25  4:09     ` Pramod Kumar [this message]
2016-04-25  4:09       ` Pramod Kumar
2016-04-25 20:56   ` Andrew Lunn
2016-04-25 20:56     ` Andrew Lunn
2016-04-25 20:56     ` Andrew Lunn
2016-04-26  8:33     ` Pramod Kumar
2016-04-26  8:33       ` Pramod Kumar
2016-04-26 12:13       ` Andrew Lunn
2016-04-26 12:13         ` Andrew Lunn
2016-04-26 12:13         ` Andrew Lunn
2016-04-26 16:26         ` David Miller
2016-04-26 16:26           ` David Miller
2016-04-26 16:26           ` David Miller
2016-04-26 17:23         ` Florian Fainelli
2016-04-26 17:23           ` Florian Fainelli
2016-04-26 17:45           ` Andrew Lunn
2016-04-26 17:45             ` Andrew Lunn
2016-04-26 17:53           ` Arnd Bergmann
2016-04-26 17:53             ` Arnd Bergmann
2016-04-26 17:53             ` Arnd Bergmann
2016-04-26 18:23             ` Andrew Lunn
2016-04-26 18:23               ` Andrew Lunn
2016-04-26 19:24               ` Arnd Bergmann
2016-04-26 19:24                 ` Arnd Bergmann
2016-04-26 19:41                 ` Andrew Lunn
2016-04-26 19:41                   ` Andrew Lunn
2016-04-27  4:46                   ` Anup Patel
2016-04-27  4:46                     ` Anup Patel
2016-04-27  9:28                     ` Arnd Bergmann
2016-04-27  9:28                       ` Arnd Bergmann
2016-04-27  9:28                       ` Arnd Bergmann
2016-04-21  9:18 ` [PATCH 2/6] Documentation: DT binding doc for iProc Shared MDIO Controller Pramod Kumar
2016-04-21  9:18   ` Pramod Kumar
2016-04-22 20:10   ` Rob Herring
2016-04-22 20:10     ` Rob Herring
2016-04-25  4:27     ` Pramod Kumar
2016-04-25  4:27       ` Pramod Kumar
2016-04-25  4:27       ` Pramod Kumar
2016-04-25 15:33   ` Andrew Lunn
2016-04-25 15:33     ` Andrew Lunn
2016-04-25 15:33     ` Andrew Lunn
2016-04-21  9:18 ` [PATCH 3/6] bus: Add platform driver for iProc shared " Pramod Kumar
2016-04-21  9:18   ` Pramod Kumar
2016-04-21  9:18 ` [PATCH 4/6] dt: Add Shared MDIO Controller node for NS2 Pramod Kumar
2016-04-21  9:18   ` Pramod Kumar
2016-04-21  9:18 ` [PATCH 5/6] Documentation: Binding doc for ethernet master in NS2 Pramod Kumar
2016-04-21  9:18   ` Pramod Kumar
2016-04-21  9:18   ` Pramod Kumar
2016-04-22 20:13   ` Rob Herring
2016-04-22 20:13     ` Rob Herring
2016-04-22 20:13     ` Rob Herring
2016-04-25  4:43     ` Pramod Kumar
2016-04-25  4:43       ` Pramod Kumar
2016-04-25  4:43       ` Pramod Kumar
2016-04-21  9:18 ` [PATCH 6/6] net:phy: Add Ethernet Master for iProc Shared MDIO Controller Pramod Kumar
2016-04-21  9:18   ` Pramod Kumar
2016-04-21  9:18   ` Pramod Kumar
2016-04-25 15:20 ` [PATCH 0/6] Add Shared MDIO framework for iProc based SoCs Andrew Lunn
2016-04-25 15:20   ` Andrew Lunn
2016-04-25 15:20   ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5876c521a46dbb4bd1b0c22bc64ec1a5@mail.gmail.com \
    --to=pramod.kumar@broadcom.com \
    --cc=anup.patel@broadcom.com \
    --cc=arnd@arndb.de \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=catalin.marinas@arm.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=netdev@vger.kernel.org \
    --cc=pawel.moll@arm.com \
    --cc=punit.agrawal@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=suzuki.poulose@arm.com \
    --cc=wens@csie.org \
    --cc=will.deacon@arm.com \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.