* [LTP] [PATCH 1/1] network: remove unnecessary check for rsh in scripts
@ 2016-12-19 13:24 Petr Vorel
2017-01-13 11:15 ` Alexey Kodanev
0 siblings, 1 reply; 2+ messages in thread
From: Petr Vorel @ 2016-12-19 13:24 UTC (permalink / raw)
To: ltp
scripts rlogin01 and telnet01 don't use rsh directly, but via
tst_rhost_run. This means that ssh or netns can be used instead of rsh.
IMHO these checks should be done in tst_rhost_run().
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
testcases/network/tcp_cmds/rlogin/rlogin01 | 2 +-
testcases/network/tcp_cmds/telnet/telnet01 | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/testcases/network/tcp_cmds/rlogin/rlogin01 b/testcases/network/tcp_cmds/rlogin/rlogin01
index f53b1a88a..162b8f0d8 100755
--- a/testcases/network/tcp_cmds/rlogin/rlogin01
+++ b/testcases/network/tcp_cmds/rlogin/rlogin01
@@ -24,7 +24,7 @@ TST_TOTAL=1
setup()
{
- tst_check_cmds rlogin expect rsh
+ tst_check_cmds rlogin expect
if [ -z $RUSER ]; then
RUSER=root
diff --git a/testcases/network/tcp_cmds/telnet/telnet01 b/testcases/network/tcp_cmds/telnet/telnet01
index a1609f0f6..f2f2444a8 100755
--- a/testcases/network/tcp_cmds/telnet/telnet01
+++ b/testcases/network/tcp_cmds/telnet/telnet01
@@ -24,7 +24,7 @@ TST_TOTAL=1
setup()
{
- tst_check_cmds telnet expect rsh
+ tst_check_cmds telnet expect
if [ -z $RUSER ]; then
RUSER=root
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [LTP] [PATCH 1/1] network: remove unnecessary check for rsh in scripts
2016-12-19 13:24 [LTP] [PATCH 1/1] network: remove unnecessary check for rsh in scripts Petr Vorel
@ 2017-01-13 11:15 ` Alexey Kodanev
0 siblings, 0 replies; 2+ messages in thread
From: Alexey Kodanev @ 2017-01-13 11:15 UTC (permalink / raw)
To: ltp
Hi,
On 19.12.2016 16:24, Petr Vorel wrote:
> scripts rlogin01 and telnet01 don't use rsh directly, but via
> tst_rhost_run. This means that ssh or netns can be used instead of rsh.
Applied, thanks!
Best regards,
Alexey
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-01-13 11:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-19 13:24 [LTP] [PATCH 1/1] network: remove unnecessary check for rsh in scripts Petr Vorel
2017-01-13 11:15 ` Alexey Kodanev
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.