From: "Jan Beulich" <JBeulich@suse.com>
To: Doug Goldstein <cardoe@cardoe.com>
Cc: Juergen Gross <JGross@suse.com>,
sstabellini@kernel.org, konrad.wilk@oracle.com,
Andrew Cooper <andrew.cooper3@citrix.com>,
Daniel Kiper <daniel.kiper@oracle.com>,
pgnet.dev@gmail.com, ning.sun@intel.com, julien.grall@arm.com,
qiaowei.ren@intel.com, xen-devel@lists.xen.org,
gang.wei@intel.com, fu.wei@linaro.org
Subject: Re: [PATCH 4/4] x86: add multiboot2 protocol support for EFI platforms
Date: Mon, 16 Jan 2017 05:02:05 -0700 [thread overview]
Message-ID: <587CC44D02000078001306B4@prv-mh.provo.novell.com> (raw)
In-Reply-To: <4b42ae6d42d409a44496eb546efe72c5060b1fd9.1484335095.git-series.cardoe@cardoe.com>
>>> On 13.01.17 at 20:21, <cardoe@cardoe.com> wrote:
> Doug v1 - fix incorrect assembly (identified by Andrew Cooper)
> - fix issue where the trampoline size was left as 0 and the
> way the memory is allocated for the trampolines we would go to
> the end of an available section and then subtract off the size
> to decide where to place it. The end result was that we would
> always copy the trampolines and the 32-bit stack into some
> form of reserved memory after the conventional region we
> wanted to put things into. On some systems this did not
> manifest as a crash while on others it did. Reworked the
> changes to always reserve 64kb for both the stack and the size
> of the trampolines. Added an ASSERT to make sure we never blow
> through this size.
Without having looked at the patch in detail, but knowing I did closely
look at earlier versions (and iirc I was mostly fine with v10) the way
the above is written would require me to either inter-diff the patches,
or re-review the whole thing. For a large patch like this it would be
rather helpful to be quite a bit more specific as to where exactly in the
patch changes were made.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-01-16 12:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-13 19:21 [PATCH 0/4] multiboot2 protocol support Doug Goldstein
2017-01-13 19:21 ` [PATCH 1/4] x86: add " Doug Goldstein
2017-01-13 19:21 ` [PATCH 2/4] efi: build xen.gz with EFI code Doug Goldstein
2017-01-13 19:21 ` [PATCH 3/4] efi: create new early memory allocator Doug Goldstein
2017-01-16 11:52 ` Jan Beulich
2017-01-16 13:55 ` Doug Goldstein
2017-01-13 19:21 ` [PATCH 4/4] x86: add multiboot2 protocol support for EFI platforms Doug Goldstein
2017-01-16 12:02 ` Jan Beulich [this message]
2017-01-16 12:50 ` Daniel Kiper
2017-01-16 13:41 ` Doug Goldstein
2017-01-16 14:11 ` Daniel Kiper
2017-01-16 14:28 ` Doug Goldstein
2017-01-16 15:16 ` Daniel Kiper
2017-01-17 12:05 ` George Dunlap
2017-01-17 12:45 ` Daniel Kiper
2017-01-16 13:42 ` Doug Goldstein
2017-01-16 11:56 ` [PATCH 0/4] multiboot2 protocol support Jan Beulich
2017-01-18 17:38 ` George Dunlap
2017-01-19 8:31 ` Jan Beulich
2017-01-19 14:30 ` Doug Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=587CC44D02000078001306B4@prv-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=JGross@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=cardoe@cardoe.com \
--cc=daniel.kiper@oracle.com \
--cc=fu.wei@linaro.org \
--cc=gang.wei@intel.com \
--cc=julien.grall@arm.com \
--cc=konrad.wilk@oracle.com \
--cc=ning.sun@intel.com \
--cc=pgnet.dev@gmail.com \
--cc=qiaowei.ren@intel.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.