Re: [PATCH 4/4] x86: add multiboot2 protocol support for EFI platforms

From: Doug Goldstein <cardoe@cardoe.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Juergen Gross <JGross@suse.com>,
	sstabellini@kernel.org, konrad.wilk@oracle.com,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Daniel Kiper <daniel.kiper@oracle.com>,
	pgnet.dev@gmail.com, ning.sun@intel.com, julien.grall@arm.com,
	qiaowei.ren@intel.com, xen-devel@lists.xen.org,
	gang.wei@intel.com, fu.wei@linaro.org
Subject: Re: [PATCH 4/4] x86: add multiboot2 protocol support for EFI platforms
Date: Mon, 16 Jan 2017 08:42:42 -0500	[thread overview]
Message-ID: <ff41e93d-013d-e78a-e392-8b591e6519d1@cardoe.com> (raw)
In-Reply-To: <587CC44D02000078001306B4@prv-mh.provo.novell.com>

[-- Attachment #1.1.1: Type: text/plain, Size: 1510 bytes --]

On 1/16/17 7:02 AM, Jan Beulich wrote:
>>>> On 13.01.17 at 20:21, <cardoe@cardoe.com> wrote:
>> Doug v1 - fix incorrect assembly (identified by Andrew Cooper)
>>         - fix issue where the trampoline size was left as 0 and the
>>           way the memory is allocated for the trampolines we would go to
>>           the end of an available section and then subtract off the size
>>           to decide where to place it. The end result was that we would
>>           always copy the trampolines and the 32-bit stack into some
>>           form of reserved memory after the conventional region we
>>           wanted to put things into. On some systems this did not
>>           manifest as a crash while on others it did. Reworked the
>>           changes to always reserve 64kb for both the stack and the size
>>           of the trampolines. Added an ASSERT to make sure we never blow
>>           through this size.
> 
> Without having looked at the patch in detail, but knowing I did closely
> look at earlier versions (and iirc I was mostly fine with v10) the way
> the above is written would require me to either inter-diff the patches,
> or re-review the whole thing. For a large patch like this it would be
> rather helpful to be quite a bit more specific as to where exactly in the
> patch changes were made.
> 
> Jan
> 

I'll submit a diff against v11 to help show the difference. I can also
submit a difference against v10 if you want as well.

-- 
Doug Goldstein

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 959 bytes --]

[-- Attachment #2: Type: text/plain, Size: 127 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel