iproute2: using .maxattr = IFLA_VLAN_MAX??

iproute2: using .maxattr = IFLA_VLAN_MAX??

[Murali Karicheri]

Hi iproute2 experts,

Found the below usage of IFLA_VLAN_MAX in ip/iplink_hsr.c

struct link_util hsr_link_util = {
        .id             = "hsr",
        .maxattr        = IFLA_VLAN_MAX, <==== should be IFLA_HSR_MAX
        .parse_opt      = hsr_parse_opt,
        .print_opt      = hsr_print_opt,
        .print_help     = hsr_print_help,
};

This appears to be a cut-n-paste bug as the source is based on 
ip/iplink_vlan.c and should be fixed to IFLA_HSR_MAX. If yes, 
I will send a patch for this.

Thanks.
-- 
Murali Karicheri
Linux Kernel, Keystone

RE: iproute2: using .maxattr = IFLA_VLAN_MAX??

[Rosen, Rami]

Hi, Murali,

> This appears to be a cut-n-paste bug as the source is based on ip/iplink_vlan.c and should be fixed to IFLA_HSR_MAX. 

You are right.
The "HSR section" indeed defines IFLA_HSR_MAX in include/linux/if_link.h of iproute2 as the max attributes number.

And in the top of ip/iplink_hsr.c you will find this comment, which enhances your assumption about the origin of this mistake:

/*
...
     Based on iplink_vlan.c by Patrick McHardy <kaber@trash.net
...
 */

Regards,
Rami Rosen

Re: iproute2: using .maxattr = IFLA_VLAN_MAX??

[Murali Karicheri]

On 01/23/2017 03:45 PM, Rosen, Rami wrote:
> Hi, Murali,
> 
>> This appears to be a cut-n-paste bug as the source is based on ip/iplink_vlan.c and should be fixed to IFLA_HSR_MAX. 
> 
> You are right.
> The "HSR section" indeed defines IFLA_HSR_MAX in include/linux/if_link.h of iproute2 as the max attributes number.
> 
> And in the top of ip/iplink_hsr.c you will find this comment, which enhances your assumption about the origin of this mistake:
> 
> /*
> ...
>      Based on iplink_vlan.c by Patrick McHardy <kaber@trash.net
> ...
>  */
> 
> Regards,
> Rami Rosen
> 
Hi, Rami,

Thanks for confirming. I will send out a patch for fixing this when I get a chance to 
test hsr for my work in the next few days.

-- 
Murali Karicheri
Linux Kernel, Keystone