All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yisheng Xie <ysxie@foxmail.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	n-horiguchi@ah.jp.nec.com, akpm@linux-foundation.org,
	minchan@kernel.org, vbabka@suse.cz, guohanjun@huawei.com,
	qiuxishi@huawei.com
Subject: Re: [PATCH v4 1/2] mm/migration: make isolate_movable_page always defined
Date: Mon, 30 Jan 2017 22:59:52 +0800	[thread overview]
Message-ID: <588F54E8.5040303@foxmail.com> (raw)
In-Reply-To: <20170126091833.GC6590@dhcp22.suse.cz>

Hi， Michal，
Sorry for late reply.

On 01/26/2017 05:18 PM, Michal Hocko wrote:
> On Wed 25-01-17 23:05:37, ysxie@foxmail.com wrote:
>> From: Yisheng Xie <xieyisheng1@huawei.com>
>>
>> Define isolate_movable_page as a static inline function when
>> CONFIG_MIGRATION is not enable. It should return false
>> here which means failed to isolate movable pages.
>>
>> This patch do not have any functional change but prepare for
>> later patch.
> I think it would make more sense to make isolate_movable_page return int
> and have the same semantic as __isolate_lru_page. This would be a better
> preparatory patch for the later work.
Yes, I think you are right, it is better to make isolate_movable_page return int
just as what isolate_lru_page do, to make a better code style.

It seems Andrew had already merged the fixed patch from Arnd Bergmann,
Maybe I can rewrite it in a later patch if it is suitable :)

WARNING: multiple messages have this Message-ID (diff)
From: Yisheng Xie <ysxie@foxmail.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	n-horiguchi@ah.jp.nec.com, akpm@linux-foundation.org,
	minchan@kernel.org, vbabka@suse.cz, guohanjun@huawei.com,
	qiuxishi@huawei.com
Subject: Re: [PATCH v4 1/2] mm/migration: make isolate_movable_page always defined
Date: Mon, 30 Jan 2017 22:59:52 +0800	[thread overview]
Message-ID: <588F54E8.5040303@foxmail.com> (raw)
In-Reply-To: <20170126091833.GC6590@dhcp22.suse.cz>

Hii 1/4 ? Michali 1/4 ?
Sorry for late reply.

On 01/26/2017 05:18 PM, Michal Hocko wrote:
> On Wed 25-01-17 23:05:37, ysxie@foxmail.com wrote:
>> From: Yisheng Xie <xieyisheng1@huawei.com>
>>
>> Define isolate_movable_page as a static inline function when
>> CONFIG_MIGRATION is not enable. It should return false
>> here which means failed to isolate movable pages.
>>
>> This patch do not have any functional change but prepare for
>> later patch.
> I think it would make more sense to make isolate_movable_page return int
> and have the same semantic as __isolate_lru_page. This would be a better
> preparatory patch for the later work.
Yes, I think you are right, it is better to make isolate_movable_page return int
just as what isolate_lru_page do, to make a better code style.

It seems Andrew had already merged the fixed patch from Arnd Bergmann,
Maybe I can rewrite it in a later patch if it is suitable :)


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2017-01-30 15:00 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-25 15:05 [PATCH v4 0/2] HWPOISON: soft offlining for non-lru movable page ysxie
2017-01-25 15:05 ` ysxie
2017-01-25 15:05 ` [PATCH v4 1/2] mm/migration: make isolate_movable_page always defined ysxie
2017-01-25 15:05   ` ysxie
2017-01-26  9:18   ` Michal Hocko
2017-01-26  9:18     ` Michal Hocko
2017-01-30 14:59     ` Yisheng Xie [this message]
2017-01-30 14:59       ` Yisheng Xie
2017-01-30 15:13       ` Michal Hocko
2017-01-30 15:13         ` Michal Hocko
2017-01-25 15:05 ` [PATCH v4 2/2] HWPOISON: soft offlining for non-lru movable page ysxie
2017-01-25 15:05   ` ysxie
2017-01-26  9:27   ` Michal Hocko
2017-01-26  9:27     ` Michal Hocko
2017-01-30 15:04     ` Yisheng Xie
2017-01-30 15:04       ` Yisheng Xie
2017-01-30 16:38       ` Michal Hocko
2017-01-30 16:38         ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=588F54E8.5040303@foxmail.com \
    --to=ysxie@foxmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=guohanjun@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=minchan@kernel.org \
    --cc=n-horiguchi@ah.jp.nec.com \
    --cc=qiuxishi@huawei.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.