From: Geoff Levand <geoff@infradead.org> To: Jakub Kicinski <kuba@kernel.org>, davem@davemloft.net, pabeni@redhat.com Cc: netdev@vger.kernel.org, kou.ishizaki@toshiba.co.jp, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH net-next 13/14] eth: spider: remove a copy of the NAPI_POLL_WEIGHT define Date: Wed, 27 Apr 2022 14:56:46 -0700 [thread overview] Message-ID: <5892767a-bbab-097b-2776-e4cd35abf289@infradead.org> (raw) In-Reply-To: <20220427154111.529975-14-kuba@kernel.org> Hi Jakub, On 4/27/22 08:41, Jakub Kicinski wrote: > Defining local versions of NAPI_POLL_WEIGHT with the same > values in the drivers just makes refactoring harder. > --- a/drivers/net/ethernet/toshiba/spider_net.c > +++ b/drivers/net/ethernet/toshiba/spider_net.c > > netif_napi_add(netdev, &card->napi, > - spider_net_poll, SPIDER_NET_NAPI_WEIGHT); > + spider_net_poll, NAPI_POLL_WEIGHT); This seems fine. Both SPIDER_NET_NAPI_WEIGHT and NAPI_POLL_WEIGHT are defined as 64. Thanks for your contribution. Acked-by: Geoff Levand <geoff@infradead.org>
WARNING: multiple messages have this Message-ID (diff)
From: Geoff Levand <geoff@infradead.org> To: Jakub Kicinski <kuba@kernel.org>, davem@davemloft.net, pabeni@redhat.com Cc: netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH net-next 13/14] eth: spider: remove a copy of the NAPI_POLL_WEIGHT define Date: Wed, 27 Apr 2022 14:56:46 -0700 [thread overview] Message-ID: <5892767a-bbab-097b-2776-e4cd35abf289@infradead.org> (raw) In-Reply-To: <20220427154111.529975-14-kuba@kernel.org> Hi Jakub, On 4/27/22 08:41, Jakub Kicinski wrote: > Defining local versions of NAPI_POLL_WEIGHT with the same > values in the drivers just makes refactoring harder. > --- a/drivers/net/ethernet/toshiba/spider_net.c > +++ b/drivers/net/ethernet/toshiba/spider_net.c > > netif_napi_add(netdev, &card->napi, > - spider_net_poll, SPIDER_NET_NAPI_WEIGHT); > + spider_net_poll, NAPI_POLL_WEIGHT); This seems fine. Both SPIDER_NET_NAPI_WEIGHT and NAPI_POLL_WEIGHT are defined as 64. Thanks for your contribution. Acked-by: Geoff Levand <geoff@infradead.org>
next prev parent reply other threads:[~2022-04-27 21:57 UTC|newest] Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-04-27 15:40 [PATCH net-next 00/14] remove copies of the NAPI_POLL_WEIGHT define Jakub Kicinski 2022-04-27 15:40 ` [PATCH net-next 01/14] eth: " Jakub Kicinski 2022-04-27 15:40 ` Jakub Kicinski 2022-04-27 15:40 ` Jakub Kicinski 2022-05-01 22:10 ` Linus Walleij 2022-05-01 22:10 ` Linus Walleij 2022-05-01 22:10 ` Linus Walleij 2022-04-27 15:40 ` [PATCH net-next 02/14] eth: remove NAPI_WEIGHT defines Jakub Kicinski 2022-04-27 17:41 ` Greg KH 2022-04-27 15:41 ` [PATCH net-next 03/14] eth: cpsw: remove a copy of the NAPI_POLL_WEIGHT define Jakub Kicinski 2022-04-27 15:47 ` Vladimir Oltean 2022-04-27 15:53 ` Jakub Kicinski 2022-04-27 21:06 ` Francois Romieu 2022-04-27 15:41 ` [PATCH net-next 04/14] eth: pch_gbe: " Jakub Kicinski 2022-04-28 9:57 ` Andy Shevchenko 2022-04-27 15:41 ` [PATCH net-next 05/14] eth: mtk_eth_soc: " Jakub Kicinski 2022-04-27 15:41 ` Jakub Kicinski 2022-04-27 15:41 ` Jakub Kicinski 2022-04-27 15:41 ` [PATCH net-next 06/14] usb: lan78xx: " Jakub Kicinski 2022-04-27 15:41 ` [PATCH net-next 07/14] slic: " Jakub Kicinski 2022-04-27 15:41 ` [PATCH net-next 08/14] eth: bgnet: " Jakub Kicinski 2022-04-27 16:09 ` Florian Fainelli 2022-04-27 16:53 ` Jakub Kicinski 2022-04-27 17:32 ` Florian Fainelli 2022-04-27 15:41 ` [PATCH net-next 09/14] eth: atlantic: " Jakub Kicinski 2022-04-27 15:41 ` [PATCH net-next 10/14] eth: benet: " Jakub Kicinski 2022-04-27 15:41 ` [PATCH net-next 11/14] eth: gfar: " Jakub Kicinski 2022-04-27 15:41 ` [PATCH net-next 12/14] eth: vxge: " Jakub Kicinski 2022-04-27 15:41 ` [PATCH net-next 13/14] eth: spider: " Jakub Kicinski 2022-04-27 15:41 ` Jakub Kicinski 2022-04-27 21:56 ` Geoff Levand [this message] 2022-04-27 21:56 ` Geoff Levand 2022-04-27 15:41 ` [PATCH net-next 14/14] eth: velocity: " Jakub Kicinski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5892767a-bbab-097b-2776-e4cd35abf289@infradead.org \ --to=geoff@infradead.org \ --cc=davem@davemloft.net \ --cc=kou.ishizaki@toshiba.co.jp \ --cc=kuba@kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=netdev@vger.kernel.org \ --cc=pabeni@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.