[PATCH 0/2] This patches set cros_ec_keyb as a wakeup source, so the chromeos's powerd

[PATCH 0/2] This patches set cros_ec_keyb as a wakeup source, so the chromeos's powerd

[Jeffy Chen]

can control the keyboard's wakeup ability along with other ec event sources.


Jeffy Chen (2):
  input: cros_ec_keyb: Report wakeup events
  ARM: dts: cros-ec-keyboard: Enable as wakeup source

 arch/arm/boot/dts/cros-ec-keyboard.dtsi | 1 +
 drivers/input/keyboard/cros_ec_keyb.c   | 9 +++++++++
 2 files changed, 10 insertions(+)

-- 
2.1.4

[PATCH 0/2] This patches set cros_ec_keyb as a wakeup source, so the chromeos's powerd

[Jeffy Chen]

can control the keyboard's wakeup ability along with other ec event sources.


Jeffy Chen (2):
  input: cros_ec_keyb: Report wakeup events
  ARM: dts: cros-ec-keyboard: Enable as wakeup source

 arch/arm/boot/dts/cros-ec-keyboard.dtsi | 1 +
 drivers/input/keyboard/cros_ec_keyb.c   | 9 +++++++++
 2 files changed, 10 insertions(+)

-- 
2.1.4


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 0/2] This patches set cros_ec_keyb as a wakeup source, so the chromeos's powerd

[Jeffy Chen]

can control the keyboard's wakeup ability along with other ec event sources.


Jeffy Chen (2):
  input: cros_ec_keyb: Report wakeup events
  ARM: dts: cros-ec-keyboard: Enable as wakeup source

 arch/arm/boot/dts/cros-ec-keyboard.dtsi | 1 +
 drivers/input/keyboard/cros_ec_keyb.c   | 9 +++++++++
 2 files changed, 10 insertions(+)

-- 
2.1.4

[PATCH 1/2] input: cros_ec_keyb: Report wakeup events

[Jeffy Chen]

Report wakeup events when process events.

Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
---

 drivers/input/keyboard/cros_ec_keyb.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/input/keyboard/cros_ec_keyb.c b/drivers/input/keyboard/cros_ec_keyb.c
index 6a250d6..a93d55f 100644
--- a/drivers/input/keyboard/cros_ec_keyb.c
+++ b/drivers/input/keyboard/cros_ec_keyb.c
@@ -286,6 +286,9 @@ static int cros_ec_keyb_work(struct notifier_block *nb,
 		return NOTIFY_DONE;
 	}
 
+	if (device_may_wakeup(ckdev->dev))
+		pm_wakeup_event(ckdev->dev, 0);
+
 	return NOTIFY_OK;
 }
 
@@ -632,6 +635,12 @@ static int cros_ec_keyb_probe(struct platform_device *pdev)
 		return err;
 	}
 
+	err = device_init_wakeup(dev, 1);
+	if (err) {
+		dev_err(dev, "cannot init wakeup: %d\n", err);
+		return err;
+	}
+
 	return 0;
 }
 
-- 
2.1.4

[PATCH 2/2] ARM: dts: cros-ec-keyboard: Enable as wakeup source

[Jeffy Chen]

Enable cros-ec-keyboard as a wakeup source.

Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
---

 arch/arm/boot/dts/cros-ec-keyboard.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/cros-ec-keyboard.dtsi b/arch/arm/boot/dts/cros-ec-keyboard.dtsi
index c0451051..3168a5e 100644
--- a/arch/arm/boot/dts/cros-ec-keyboard.dtsi
+++ b/arch/arm/boot/dts/cros-ec-keyboard.dtsi
@@ -16,6 +16,7 @@
 		keypad,num-rows = <8>;
 		keypad,num-columns = <13>;
 		google,needs-ghost-filter;
+		wakeup-source;
 
 		linux,keymap = <
 			MATRIX_KEY(0x00, 0x01, KEY_LEFTMETA)
-- 
2.1.4

[PATCH 2/2] ARM: dts: cros-ec-keyboard: Enable as wakeup source

[Jeffy Chen]

Enable cros-ec-keyboard as a wakeup source.

Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
---

 arch/arm/boot/dts/cros-ec-keyboard.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/cros-ec-keyboard.dtsi b/arch/arm/boot/dts/cros-ec-keyboard.dtsi
index c0451051..3168a5e 100644
--- a/arch/arm/boot/dts/cros-ec-keyboard.dtsi
+++ b/arch/arm/boot/dts/cros-ec-keyboard.dtsi
@@ -16,6 +16,7 @@
 		keypad,num-rows = <8>;
 		keypad,num-columns = <13>;
 		google,needs-ghost-filter;
+		wakeup-source;
 
 		linux,keymap = <
 			MATRIX_KEY(0x00, 0x01, KEY_LEFTMETA)
-- 
2.1.4

Re: [PATCH 1/2] input: cros_ec_keyb: Report wakeup events

[Dmitry Torokhov]

Hi Jeffy,

On Thu, Mar 30, 2017 at 05:50:49PM +0800, Jeffy Chen wrote:
> Report wakeup events when process events.
> 
> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
> ---
> 
>  drivers/input/keyboard/cros_ec_keyb.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/input/keyboard/cros_ec_keyb.c b/drivers/input/keyboard/cros_ec_keyb.c
> index 6a250d6..a93d55f 100644
> --- a/drivers/input/keyboard/cros_ec_keyb.c
> +++ b/drivers/input/keyboard/cros_ec_keyb.c
> @@ -286,6 +286,9 @@ static int cros_ec_keyb_work(struct notifier_block *nb,
>  		return NOTIFY_DONE;
>  	}
>  
> +	if (device_may_wakeup(ckdev->dev))
> +		pm_wakeup_event(ckdev->dev, 0);
> +
>  	return NOTIFY_OK;
>  }
>  
> @@ -632,6 +635,12 @@ static int cros_ec_keyb_probe(struct platform_device *pdev)
>  		return err;
>  	}
>  
> +	err = device_init_wakeup(dev, 1);

In the other patch you are adding "wakeup-source" to the DT binding, but
here you mark all EC deices as wakeup sources. You need to use
device_property_read_bool(dev, "wakeup-source") and use the result in
call to device_init_wakeup().

> +	if (err) {
> +		dev_err(dev, "cannot init wakeup: %d\n", err);
> +		return err;
> +	}
> +
>  	return 0;
>  }
>  

Thanks.

-- 
Dmitry

Re: [PATCH 1/2] input: cros_ec_keyb: Report wakeup events

[Dmitry Torokhov]

On Sat, Apr 01, 2017 at 10:12:37AM -0700, Dmitry Torokhov wrote:
> Hi Jeffy,
> 
> On Thu, Mar 30, 2017 at 05:50:49PM +0800, Jeffy Chen wrote:
> > Report wakeup events when process events.
> > 
> > Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
> > ---
> > 
> >  drivers/input/keyboard/cros_ec_keyb.c | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> > 
> > diff --git a/drivers/input/keyboard/cros_ec_keyb.c b/drivers/input/keyboard/cros_ec_keyb.c
> > index 6a250d6..a93d55f 100644
> > --- a/drivers/input/keyboard/cros_ec_keyb.c
> > +++ b/drivers/input/keyboard/cros_ec_keyb.c
> > @@ -286,6 +286,9 @@ static int cros_ec_keyb_work(struct notifier_block *nb,
> >  		return NOTIFY_DONE;
> >  	}
> >  
> > +	if (device_may_wakeup(ckdev->dev))
> > +		pm_wakeup_event(ckdev->dev, 0);
> > +
> >  	return NOTIFY_OK;
> >  }
> >  
> > @@ -632,6 +635,12 @@ static int cros_ec_keyb_probe(struct platform_device *pdev)
> >  		return err;
> >  	}
> >  
> > +	err = device_init_wakeup(dev, 1);
> 
> In the other patch you are adding "wakeup-source" to the DT binding, but
> here you mark all EC deices as wakeup sources. You need to use
> device_property_read_bool(dev, "wakeup-source") and use the result in
> call to device_init_wakeup().

And please also update device tree binding doc for the driver.

> 
> > +	if (err) {
> > +		dev_err(dev, "cannot init wakeup: %d\n", err);
> > +		return err;
> > +	}
> > +
> >  	return 0;
> >  }
> >  
> 
> Thanks.
> 
> -- 
> Dmitry

-- 
Dmitry

Re: [PATCH 1/2] input: cros_ec_keyb: Report wakeup events

[jeffy]

Hi Dmitry,

On 04/02/2017 01:14 AM, Dmitry Torokhov wrote:
> On Sat, Apr 01, 2017 at 10:12:37AM -0700, Dmitry Torokhov wrote:
>> Hi Jeffy,
>>
>> On Thu, Mar 30, 2017 at 05:50:49PM +0800, Jeffy Chen wrote:
>>> Report wakeup events when process events.
>>>
>>> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
>>> ---
>>>
>>>   drivers/input/keyboard/cros_ec_keyb.c | 9 +++++++++
>>>   1 file changed, 9 insertions(+)
>>>
>>> diff --git a/drivers/input/keyboard/cros_ec_keyb.c b/drivers/input/keyboard/cros_ec_keyb.c
>>> index 6a250d6..a93d55f 100644
>>> --- a/drivers/input/keyboard/cros_ec_keyb.c
>>> +++ b/drivers/input/keyboard/cros_ec_keyb.c
>>> @@ -286,6 +286,9 @@ static int cros_ec_keyb_work(struct notifier_block *nb,
>>>   		return NOTIFY_DONE;
>>>   	}
>>>
>>> +	if (device_may_wakeup(ckdev->dev))
>>> +		pm_wakeup_event(ckdev->dev, 0);
>>> +
>>>   	return NOTIFY_OK;
>>>   }
>>>
>>> @@ -632,6 +635,12 @@ static int cros_ec_keyb_probe(struct platform_device *pdev)
>>>   		return err;
>>>   	}
>>>
>>> +	err = device_init_wakeup(dev, 1);
>>
>> In the other patch you are adding "wakeup-source" to the DT binding, but
>> here you mark all EC deices as wakeup sources. You need to use
>> device_property_read_bool(dev, "wakeup-source") and use the result in
>> call to device_init_wakeup().
>
> And please also update device tree binding doc for the driver.
>
oops, sorry, i thought that dts property is needed to enable a wakeup 
source...but obviously it's not, only gpio-keys requires that.

so the dts patch is not needed, will remove in next version, thanx.
>>
>>> +	if (err) {
>>> +		dev_err(dev, "cannot init wakeup: %d\n", err);
>>> +		return err;
>>> +	}
>>> +
>>>   	return 0;
>>>   }
>>>
>>
>> Thanks.
>>
>> --
>> Dmitry
>