From: Frank Rowand <frowand.list@gmail.com>
To: Rob Herring <robh+dt@kernel.org>, Stephen Boyd <stephen.boyd@linaro.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] of: make __of_attach_node() static
Date: Fri, 14 Apr 2017 20:59:23 -0700 [thread overview]
Message-ID: <58F19A9B.1060001@gmail.com> (raw)
In-Reply-To: <1492228520-12450-3-git-send-email-frowand.list@gmail.com>
Adding Stephen.
On 04/14/17 20:55, frowand.list@gmail.com wrote:
> From: Frank Rowand <frank.rowand@sony.com>
>
> __of_attach_node() is not used outside of drivers/of/dynamic.c. Make
> it static and remove it from drivers/of/of_private.h.
>
> Signed-off-by: Frank Rowand <frank.rowand@sony.com>
> ---
> drivers/of/dynamic.c | 2 +-
> drivers/of/of_private.h | 1 -
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/of/dynamic.c b/drivers/of/dynamic.c
> index c6fd3f32bfcb..74aafe594ad5 100644
> --- a/drivers/of/dynamic.c
> +++ b/drivers/of/dynamic.c
> @@ -216,7 +216,7 @@ int of_property_notify(int action, struct device_node *np,
> return of_reconfig_notify(action, &pr);
> }
>
> -void __of_attach_node(struct device_node *np)
> +static void __of_attach_node(struct device_node *np)
> {
> np->child = NULL;
> np->sibling = np->parent->child;
> diff --git a/drivers/of/of_private.h b/drivers/of/of_private.h
> index 18bbb4517e25..efcedcff7dba 100644
> --- a/drivers/of/of_private.h
> +++ b/drivers/of/of_private.h
> @@ -78,7 +78,6 @@ extern int __of_update_property(struct device_node *np,
> extern void __of_update_property_sysfs(struct device_node *np,
> struct property *newprop, struct property *oldprop);
>
> -extern void __of_attach_node(struct device_node *np);
> extern int __of_attach_node_sysfs(struct device_node *np);
> extern void __of_detach_node(struct device_node *np);
> extern void __of_detach_node_sysfs(struct device_node *np);
>
next prev parent reply other threads:[~2017-04-15 3:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-15 3:55 [PATCH 0/4] of: remove *phandle properties from expanded device tree frowand.list
2017-04-15 3:55 ` frowand.list-Re5JQEeQqe8AvxtiuMwx3w
2017-04-15 3:55 ` [PATCH 1/4] " frowand.list
2017-04-15 3:55 ` frowand.list-Re5JQEeQqe8AvxtiuMwx3w
2017-04-15 3:59 ` Frank Rowand
2017-04-15 3:59 ` Frank Rowand
2017-04-15 3:55 ` [PATCH 2/4] of: make __of_attach_node() static frowand.list
2017-04-15 3:59 ` Frank Rowand [this message]
2017-04-15 3:55 ` [PATCH 3/4] of: be consistent in form of file mode frowand.list
2017-04-15 3:59 ` Frank Rowand
2017-04-15 3:55 ` [PATCH 4/4] of: detect invalid phandle in overlay frowand.list
2017-04-15 3:59 ` Frank Rowand
2017-04-15 3:58 ` [PATCH 0/4] of: remove *phandle properties from expanded device tree Frank Rowand
2017-04-15 3:58 ` Frank Rowand
2017-04-18 21:08 ` Frank Rowand
2017-04-18 21:08 ` Frank Rowand
2017-04-19 13:38 ` Rob Herring
2017-04-19 13:38 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58F19A9B.1060001@gmail.com \
--to=frowand.list@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=stephen.boyd@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.