From: Ahmad Fatoum <a.fatoum@pengutronix.de> To: Etienne Carriere <etienne.carriere@linaro.org>, linux-kernel@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, Sudeep Holla <sudeep.holla@arm.com>, Cristian Marussi <cristian.marussi@arm.com>, Vincent Guittot <vincent.guittot@linaro.org>, devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>, Pengutronix Kernel Team <kernel@pengutronix.de> Subject: Re: [PATCH v8 1/2] dt-bindings: arm: Add OP-TEE transport for SCMI Date: Mon, 28 Feb 2022 17:01:39 +0100 [thread overview] Message-ID: <58a0e791-9573-99c2-0cc5-3920a1048113@pengutronix.de> (raw) In-Reply-To: <20211028140009.23331-1-etienne.carriere@linaro.org> Hello Etienne, On 28.10.21 16:00, Etienne Carriere wrote: > Introduce compatible "linaro,scmi-optee" for SCMI transport channel > based on an OP-TEE service invocation. The compatible mandates a > channel ID defined with property "linaro,optee-channel-id". I just found this thread via the compatible in the STM32MP131 patch set: https://lore.kernel.org/all/20220225133137.813919-1-gabriel.fernandez@foss.st.com/ Linux doesn't care whether PSCI is provided by TF-A, OP-TEE or something else, so there is just the arm,psci* compatible. What's different about SCMI that this is not possible? Why couldn't the existing binding and driver be used to communicate with OP-TEE as secure monitor as well? Cheers, Ahmad > > Cc: devicetree@vger.kernel.org > Cc: Rob Herring <robh+dt@kernel.org> > Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org> > --- > Changes since v6: > - Remove maxItems from linaro,optee-channel-id description > > No change since v5 > > Changes since v4: > - Fix sram node name in DTS example: s/-shm-/-sram-/ > > Changes since v3: > - Add description for linaro,optee-channel-id in patternProperties > specifying protocol can optionaly define a dedicated channel id. > - Fix DTS example (duplicated phandles issue, subnodes ordering) > - Fix typo in DTS example and description comments. > > Changes since v2: > - Define mandatory property linaro,optee-channel-id > - Rebased on yaml description file > > Changes since v1: > - Removed modification regarding mboxes property description. > --- > .../bindings/firmware/arm,scmi.yaml | 65 +++++++++++++++++++ > 1 file changed, 65 insertions(+) > > diff --git a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > index 5c4c6782e052..eae15df36eef 100644 > --- a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > +++ b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > @@ -38,6 +38,9 @@ properties: > The virtio transport only supports a single device. > items: > - const: arm,scmi-virtio > + - description: SCMI compliant firmware with OP-TEE transport > + items: > + - const: linaro,scmi-optee > > interrupts: > description: > @@ -83,6 +86,11 @@ properties: > description: > SMC id required when using smc or hvc transports > > + linaro,optee-channel-id: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + Channel specifier required when using OP-TEE transport. > + > protocol@11: > type: object > properties: > @@ -195,6 +203,12 @@ patternProperties: > minItems: 1 > maxItems: 2 > > + linaro,optee-channel-id: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + Channel specifier required when using OP-TEE transport and > + protocol has a dedicated communication channel. > + > required: > - reg > > @@ -226,6 +240,16 @@ else: > - arm,smc-id > - shmem > > + else: > + if: > + properties: > + compatible: > + contains: > + const: linaro,scmi-optee > + then: > + required: > + - linaro,optee-channel-id > + > examples: > - | > firmware { > @@ -340,7 +364,48 @@ examples: > reg = <0x11>; > #power-domain-cells = <1>; > }; > + }; > + }; > + > + - | > + firmware { > + scmi { > + compatible = "linaro,scmi-optee"; > + linaro,optee-channel-id = <0>; > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + scmi_dvfs1: protocol@13 { > + reg = <0x13>; > + linaro,optee-channel-id = <1>; > + shmem = <&cpu_optee_lpri0>; > + #clock-cells = <1>; > + }; > + > + scmi_clk0: protocol@14 { > + reg = <0x14>; > + #clock-cells = <1>; > + }; > + }; > + }; > > + soc { > + #address-cells = <2>; > + #size-cells = <2>; > + > + sram@51000000 { > + compatible = "mmio-sram"; > + reg = <0x0 0x51000000 0x0 0x10000>; > + > + #address-cells = <1>; > + #size-cells = <1>; > + ranges = <0 0x0 0x51000000 0x10000>; > + > + cpu_optee_lpri0: optee-sram-section@0 { > + compatible = "arm,scmi-shmem"; > + reg = <0x0 0x80>; > + }; > }; > }; > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
WARNING: multiple messages have this Message-ID (diff)
From: Ahmad Fatoum <a.fatoum@pengutronix.de> To: Etienne Carriere <etienne.carriere@linaro.org>, linux-kernel@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, Sudeep Holla <sudeep.holla@arm.com>, Cristian Marussi <cristian.marussi@arm.com>, Vincent Guittot <vincent.guittot@linaro.org>, devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>, Pengutronix Kernel Team <kernel@pengutronix.de> Subject: Re: [PATCH v8 1/2] dt-bindings: arm: Add OP-TEE transport for SCMI Date: Mon, 28 Feb 2022 17:01:39 +0100 [thread overview] Message-ID: <58a0e791-9573-99c2-0cc5-3920a1048113@pengutronix.de> (raw) In-Reply-To: <20211028140009.23331-1-etienne.carriere@linaro.org> Hello Etienne, On 28.10.21 16:00, Etienne Carriere wrote: > Introduce compatible "linaro,scmi-optee" for SCMI transport channel > based on an OP-TEE service invocation. The compatible mandates a > channel ID defined with property "linaro,optee-channel-id". I just found this thread via the compatible in the STM32MP131 patch set: https://lore.kernel.org/all/20220225133137.813919-1-gabriel.fernandez@foss.st.com/ Linux doesn't care whether PSCI is provided by TF-A, OP-TEE or something else, so there is just the arm,psci* compatible. What's different about SCMI that this is not possible? Why couldn't the existing binding and driver be used to communicate with OP-TEE as secure monitor as well? Cheers, Ahmad > > Cc: devicetree@vger.kernel.org > Cc: Rob Herring <robh+dt@kernel.org> > Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org> > --- > Changes since v6: > - Remove maxItems from linaro,optee-channel-id description > > No change since v5 > > Changes since v4: > - Fix sram node name in DTS example: s/-shm-/-sram-/ > > Changes since v3: > - Add description for linaro,optee-channel-id in patternProperties > specifying protocol can optionaly define a dedicated channel id. > - Fix DTS example (duplicated phandles issue, subnodes ordering) > - Fix typo in DTS example and description comments. > > Changes since v2: > - Define mandatory property linaro,optee-channel-id > - Rebased on yaml description file > > Changes since v1: > - Removed modification regarding mboxes property description. > --- > .../bindings/firmware/arm,scmi.yaml | 65 +++++++++++++++++++ > 1 file changed, 65 insertions(+) > > diff --git a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > index 5c4c6782e052..eae15df36eef 100644 > --- a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > +++ b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > @@ -38,6 +38,9 @@ properties: > The virtio transport only supports a single device. > items: > - const: arm,scmi-virtio > + - description: SCMI compliant firmware with OP-TEE transport > + items: > + - const: linaro,scmi-optee > > interrupts: > description: > @@ -83,6 +86,11 @@ properties: > description: > SMC id required when using smc or hvc transports > > + linaro,optee-channel-id: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + Channel specifier required when using OP-TEE transport. > + > protocol@11: > type: object > properties: > @@ -195,6 +203,12 @@ patternProperties: > minItems: 1 > maxItems: 2 > > + linaro,optee-channel-id: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + Channel specifier required when using OP-TEE transport and > + protocol has a dedicated communication channel. > + > required: > - reg > > @@ -226,6 +240,16 @@ else: > - arm,smc-id > - shmem > > + else: > + if: > + properties: > + compatible: > + contains: > + const: linaro,scmi-optee > + then: > + required: > + - linaro,optee-channel-id > + > examples: > - | > firmware { > @@ -340,7 +364,48 @@ examples: > reg = <0x11>; > #power-domain-cells = <1>; > }; > + }; > + }; > + > + - | > + firmware { > + scmi { > + compatible = "linaro,scmi-optee"; > + linaro,optee-channel-id = <0>; > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + scmi_dvfs1: protocol@13 { > + reg = <0x13>; > + linaro,optee-channel-id = <1>; > + shmem = <&cpu_optee_lpri0>; > + #clock-cells = <1>; > + }; > + > + scmi_clk0: protocol@14 { > + reg = <0x14>; > + #clock-cells = <1>; > + }; > + }; > + }; > > + soc { > + #address-cells = <2>; > + #size-cells = <2>; > + > + sram@51000000 { > + compatible = "mmio-sram"; > + reg = <0x0 0x51000000 0x0 0x10000>; > + > + #address-cells = <1>; > + #size-cells = <1>; > + ranges = <0 0x0 0x51000000 0x10000>; > + > + cpu_optee_lpri0: optee-sram-section@0 { > + compatible = "arm,scmi-shmem"; > + reg = <0x0 0x80>; > + }; > }; > }; > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-02-28 16:01 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-10-28 14:00 [PATCH v8 1/2] dt-bindings: arm: Add OP-TEE transport for SCMI Etienne Carriere 2021-10-28 14:00 ` Etienne Carriere 2021-10-28 14:00 ` [PATCH v8 2/2] firmware: arm_scmi: Add optee transport Etienne Carriere 2021-10-28 14:00 ` Etienne Carriere 2021-10-29 10:17 ` Cristian Marussi 2021-10-29 10:17 ` Cristian Marussi 2021-11-25 12:55 ` Sudeep Holla 2021-11-25 12:55 ` Sudeep Holla 2021-10-29 10:21 ` [PATCH v8 1/2] dt-bindings: arm: Add OP-TEE transport for SCMI Cristian Marussi 2021-10-29 10:21 ` Cristian Marussi 2021-11-02 13:21 ` Rob Herring 2021-11-02 13:21 ` Rob Herring 2021-11-25 12:25 ` Sudeep Holla 2021-11-25 12:25 ` Sudeep Holla 2021-11-25 12:41 ` Sudeep Holla 2021-11-25 12:41 ` Sudeep Holla 2022-02-28 16:01 ` Ahmad Fatoum [this message] 2022-02-28 16:01 ` Ahmad Fatoum 2022-03-01 14:05 ` Etienne Carriere 2022-03-01 14:05 ` Etienne Carriere 2022-03-01 14:11 ` Etienne Carriere 2022-03-01 14:11 ` Etienne Carriere 2022-03-08 9:53 ` Ahmad Fatoum 2022-03-08 9:53 ` Ahmad Fatoum 2022-03-01 15:12 ` Sudeep Holla 2022-03-01 15:12 ` Sudeep Holla 2022-03-08 9:51 ` Ahmad Fatoum 2022-03-08 9:51 ` Ahmad Fatoum 2022-03-08 10:18 ` Etienne Carriere 2022-03-08 10:18 ` Etienne Carriere 2022-03-16 11:18 ` Ahmad Fatoum 2022-03-16 11:18 ` Ahmad Fatoum
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=58a0e791-9573-99c2-0cc5-3920a1048113@pengutronix.de \ --to=a.fatoum@pengutronix.de \ --cc=cristian.marussi@arm.com \ --cc=devicetree@vger.kernel.org \ --cc=etienne.carriere@linaro.org \ --cc=kernel@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=robh+dt@kernel.org \ --cc=sudeep.holla@arm.com \ --cc=vincent.guittot@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.