* [PATCH 1/7] staging: sm750fb: Add braces around if statement.
[not found] <cover.1488045682.git.varshar186@gmail.com>
@ 2017-02-25 18:21 ` Varsha Rao
2017-02-25 18:22 ` [PATCH 2/7] staging: sm750fb: Fix line over 80 characters Varsha Rao
` (6 subsequent siblings)
7 siblings, 0 replies; 12+ messages in thread
From: Varsha Rao @ 2017-02-25 18:21 UTC (permalink / raw)
To: Sudip Mukherjee, Teddy Wang, Greg Kroah-Hartman; +Cc: outreachy-kernel
Added braces around if statement. This patch fixes the following
checkpatch issue:
CHECK: braces {} should be used on all arms of this statement
Signed-off-by: Varsha Rao <rvarsha016@gmail.com>
---
drivers/staging/sm750fb/ddk750_chip.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
index 10cf729..7948ca9 100644
--- a/drivers/staging/sm750fb/ddk750_chip.c
+++ b/drivers/staging/sm750fb/ddk750_chip.c
@@ -16,9 +16,9 @@ logical_chip_type_t sm750_get_chip_type(void)
void sm750_set_chip_type(unsigned short devId, u8 revId)
{
- if (devId == 0x718)
+ if (devId == 0x718) {
chip = SM718;
- else if (devId == 0x750) {
+ } else if (devId == 0x750) {
chip = SM750;
/* SM750 and SM750LE are different in their revision ID only. */
if (revId == SM750LE_REVISION_ID) {
--
2.9.3
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 2/7] staging: sm750fb: Fix line over 80 characters.
[not found] <cover.1488045682.git.varshar186@gmail.com>
2017-02-25 18:21 ` [PATCH 1/7] staging: sm750fb: Add braces around if statement Varsha Rao
@ 2017-02-25 18:22 ` Varsha Rao
2017-02-25 18:27 ` [PATCH 3/7] staging: sm750fb: Add identifier to function definition argument Varsha Rao
` (5 subsequent siblings)
7 siblings, 0 replies; 12+ messages in thread
From: Varsha Rao @ 2017-02-25 18:22 UTC (permalink / raw)
To: Sudip Mukherjee, Teddy Wang, Greg Kroah-Hartman; +Cc: outreachy-kernel
Line over 80 characters are split to fix the following checkpatch issue:
WARNING: line over 80 characters
Signed-off-by: Varsha Rao <rvarsha016@gmail.com>
---
drivers/staging/sm750fb/ddk750_chip.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
index 7948ca9..9e49298 100644
--- a/drivers/staging/sm750fb/ddk750_chip.c
+++ b/drivers/staging/sm750fb/ddk750_chip.c
@@ -69,11 +69,11 @@ static void set_chip_clock(unsigned int frequency)
pll.clockType = MXCLK_PLL;
/*
- * Call sm750_calc_pll_value() to fill the other fields of the PLL
- * structure. Sometimes, the chip cannot set up the exact
- * clock required by the User.
- * Return value of sm750_calc_pll_value gives the actual possible
- * clock.
+ * Call sm750_calc_pll_value() to fill the other fields
+ * of the PLL structure. Sometimes, the chip cannot set
+ * up the exact clock required by the User.
+ * Return value of sm750_calc_pll_value gives the actual
+ * possible clock.
*/
ulActualMxClk = sm750_calc_pll_value(frequency, &pll);
--
2.9.3
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 3/7] staging: sm750fb: Add identifier to function definition argument.
[not found] <cover.1488045682.git.varshar186@gmail.com>
2017-02-25 18:21 ` [PATCH 1/7] staging: sm750fb: Add braces around if statement Varsha Rao
2017-02-25 18:22 ` [PATCH 2/7] staging: sm750fb: Fix line over 80 characters Varsha Rao
@ 2017-02-25 18:27 ` Varsha Rao
2017-02-25 18:27 ` [PATCH 4/7] staging: sm750fb: Remove unnecessary blank lines Varsha Rao
` (4 subsequent siblings)
7 siblings, 0 replies; 12+ messages in thread
From: Varsha Rao @ 2017-02-25 18:27 UTC (permalink / raw)
To: Sudip Mukherjee, Teddy Wang, Greg Kroah-Hartman; +Cc: outreachy-kernel
Added pinit_param as the identifier to function definition argument
struct initchip_param and this patch fixes the checkpatch issue.
Signed-off-by: Varsha Rao <rvarsha016@gmail.com>
---
drivers/staging/sm750fb/ddk750_chip.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm750fb/ddk750_chip.h b/drivers/staging/sm750fb/ddk750_chip.h
index fbeb615..2c7a9b9 100644
--- a/drivers/staging/sm750fb/ddk750_chip.h
+++ b/drivers/staging/sm750fb/ddk750_chip.h
@@ -98,6 +98,6 @@ void sm750_set_chip_type(unsigned short devId, u8 revId);
unsigned int sm750_calc_pll_value(unsigned int request, struct pll_value *pll);
unsigned int sm750_format_pll_reg(struct pll_value *pPLL);
unsigned int ddk750_get_vm_size(void);
-int ddk750_init_hw(struct initchip_param *);
+int ddk750_init_hw(struct initchip_param *pinit_param);
#endif
--
2.9.3
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 4/7] staging: sm750fb: Remove unnecessary blank lines.
[not found] <cover.1488045682.git.varshar186@gmail.com>
` (2 preceding siblings ...)
2017-02-25 18:27 ` [PATCH 3/7] staging: sm750fb: Add identifier to function definition argument Varsha Rao
@ 2017-02-25 18:27 ` Varsha Rao
2017-02-25 18:31 ` [PATCH 5/7] staging: sm750fb: Added spaces around arithmetic operators Varsha Rao
` (3 subsequent siblings)
7 siblings, 0 replies; 12+ messages in thread
From: Varsha Rao @ 2017-02-25 18:27 UTC (permalink / raw)
To: Sudip Mukherjee, Teddy Wang, Greg Kroah-Hartman; +Cc: outreachy-kernel
Removed multiple blank lines, which are not required. This patch fixes
the following check patch issues:
CHECK: Please don't use multiple blank lines
Signed-off-by: Varsha Rao <rvarsha016@gmail.com>
---
drivers/staging/sm750fb/ddk750_display.h | 5 -----
drivers/staging/sm750fb/ddk750_dvi.c | 4 ----
drivers/staging/sm750fb/ddk750_mode.c | 5 -----
drivers/staging/sm750fb/ddk750_mode.h | 2 --
drivers/staging/sm750fb/ddk750_power.c | 5 -----
drivers/staging/sm750fb/ddk750_power.h | 1 -
drivers/staging/sm750fb/ddk750_reg.h | 4 ----
7 files changed, 26 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_display.h b/drivers/staging/sm750fb/ddk750_display.h
index 8abca88..e2a3f84 100644
--- a/drivers/staging/sm750fb/ddk750_display.h
+++ b/drivers/staging/sm750fb/ddk750_display.h
@@ -12,7 +12,6 @@
#define PNL_2_PRI ((0 << PNL_2_OFFSET) | PNL_2_USAGE)
#define PNL_2_SEC ((2 << PNL_2_OFFSET) | PNL_2_USAGE)
-
/*
* primary timing & plane enable bit
* 1: 80000[8] & 80000[2] on
@@ -24,7 +23,6 @@
#define PRI_TP_ON ((0x1 << PRI_TP_OFFSET) | PRI_TP_USAGE)
#define PRI_TP_OFF ((0x0 << PRI_TP_OFFSET) | PRI_TP_USAGE)
-
/*
* panel sequency status
* 80000[27:24]
@@ -66,7 +64,6 @@
#define CRT_2_PRI ((0x0 << CRT_2_OFFSET) | CRT_2_USAGE)
#define CRT_2_SEC ((0x2 << CRT_2_OFFSET) | CRT_2_USAGE)
-
/*
* DAC affect both DVI and DSUB
* 4[20]
@@ -87,8 +84,6 @@
#define DPMS_OFF ((3 << DPMS_OFFSET) | DPMS_USAGE)
#define DPMS_ON ((0 << DPMS_OFFSET) | DPMS_USAGE)
-
-
/*
* LCD1 means panel path TFT1 & panel path DVI (so enable DAC)
* CRT means crt path DSUB
diff --git a/drivers/staging/sm750fb/ddk750_dvi.c b/drivers/staging/sm750fb/ddk750_dvi.c
index 250c2f4..42c753f 100644
--- a/drivers/staging/sm750fb/ddk750_dvi.c
+++ b/drivers/staging/sm750fb/ddk750_dvi.c
@@ -5,7 +5,6 @@
#include "ddk750_dvi.h"
#include "ddk750_sii164.h"
-
/*
* This global variable contains all the supported driver and its corresponding
* function API. Please set the function pointer to NULL whenever the function
@@ -30,7 +29,6 @@ static dvi_ctrl_device_t g_dcftSupportedDviController[] = {
#endif
};
-
int dviInit(
unsigned char edgeSelect,
unsigned char busSelect,
@@ -56,5 +54,3 @@ int dviInit(
}
#endif
-
-
diff --git a/drivers/staging/sm750fb/ddk750_mode.c b/drivers/staging/sm750fb/ddk750_mode.c
index 1df7d57..45af806 100644
--- a/drivers/staging/sm750fb/ddk750_mode.c
+++ b/drivers/staging/sm750fb/ddk750_mode.c
@@ -71,8 +71,6 @@ static unsigned long displayControlAdjust_SM750LE(mode_parameter_t *pModeParam,
return dispControl;
}
-
-
/* only timing related registers will be programed */
static int programModeRegisters(mode_parameter_t *pModeParam,
struct pll_value *pll)
@@ -112,7 +110,6 @@ static int programModeRegisters(mode_parameter_t *pModeParam,
((pModeParam->vertical_sync_start - 1) &
CRT_VERTICAL_SYNC_START_MASK));
-
tmp = DISPLAY_CTRL_TIMING | DISPLAY_CTRL_PLANE;
if (pModeParam->vertical_sync_polarity)
tmp |= DISPLAY_CTRL_VSYNC_PHASE;
@@ -219,5 +216,3 @@ int ddk750_setModeTiming(mode_parameter_t *parm, clock_type_t clock)
programModeRegisters(parm, &pll);
return 0;
}
-
-
diff --git a/drivers/staging/sm750fb/ddk750_mode.h b/drivers/staging/sm750fb/ddk750_mode.h
index e846dc2..2183e66 100644
--- a/drivers/staging/sm750fb/ddk750_mode.h
+++ b/drivers/staging/sm750fb/ddk750_mode.h
@@ -9,7 +9,6 @@ typedef enum _spolarity_t {
}
spolarity_t;
-
typedef struct _mode_parameter_t {
/* Horizontal timing. */
unsigned long horizontal_total;
@@ -37,5 +36,4 @@ mode_parameter_t;
int ddk750_setModeTiming(mode_parameter_t *, clock_type_t);
-
#endif
diff --git a/drivers/staging/sm750fb/ddk750_power.c b/drivers/staging/sm750fb/ddk750_power.c
index 02ff620..222ae1a 100644
--- a/drivers/staging/sm750fb/ddk750_power.c
+++ b/drivers/staging/sm750fb/ddk750_power.c
@@ -24,7 +24,6 @@ static unsigned int get_power_mode(void)
return peek32(POWER_MODE_CTRL) & POWER_MODE_CTRL_MODE_MASK;
}
-
/*
* SM50x can operate in one of three modes: 0, 1 or Sleep.
* On hardware reset, power mode 0 is default.
@@ -80,8 +79,6 @@ void sm750_set_current_gate(unsigned int gate)
poke32(MODE0_GATE, gate);
}
-
-
/*
* This function enable/disable the 2D engine.
*/
@@ -145,5 +142,3 @@ void sm750_enable_i2c(unsigned int enable)
sm750_set_current_gate(gate);
}
-
-
diff --git a/drivers/staging/sm750fb/ddk750_power.h b/drivers/staging/sm750fb/ddk750_power.h
index 4274d74..ec0b99d 100644
--- a/drivers/staging/sm750fb/ddk750_power.h
+++ b/drivers/staging/sm750fb/ddk750_power.h
@@ -38,5 +38,4 @@ void sm750_enable_gpio(unsigned int enable);
*/
void sm750_enable_i2c(unsigned int enable);
-
#endif
diff --git a/drivers/staging/sm750fb/ddk750_reg.h b/drivers/staging/sm750fb/ddk750_reg.h
index 4ed6d8d..f9b989b 100644
--- a/drivers/staging/sm750fb/ddk750_reg.h
+++ b/drivers/staging/sm750fb/ddk750_reg.h
@@ -532,7 +532,6 @@
#define GPIO_INTERRUPT_STATUS_26 BIT(17)
#define GPIO_INTERRUPT_STATUS_25 BIT(16)
-
#define PANEL_DISPLAY_CTRL 0x080000
#define PANEL_DISPLAY_CTRL_RESERVED_MASK 0xc0f08000
#define PANEL_DISPLAY_CTRL_SELECT_SHIFT 28
@@ -1279,7 +1278,6 @@
#define I2C_DATA14 0x010052
#define I2C_DATA15 0x010053
-
#define ZV0_CAPTURE_CTRL 0x090000
#define ZV0_CAPTURE_CTRL_FIELD_INPUT BIT(27)
#define ZV0_CAPTURE_CTRL_SCAN BIT(26)
@@ -1445,7 +1443,6 @@
#define DEFAULT_I2C_SCL 30
#define DEFAULT_I2C_SDA 31
-
#define GPIO_DATA_SM750LE 0x020018
#define GPIO_DATA_SM750LE_1 BIT(1)
#define GPIO_DATA_SM750LE_0 BIT(0)
@@ -1454,5 +1451,4 @@
#define GPIO_DATA_DIRECTION_SM750LE_1 BIT(1)
#define GPIO_DATA_DIRECTION_SM750LE_0 BIT(0)
-
#endif
--
2.9.3
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 5/7] staging: sm750fb: Added spaces around arithmetic operators.
[not found] <cover.1488045682.git.varshar186@gmail.com>
` (3 preceding siblings ...)
2017-02-25 18:27 ` [PATCH 4/7] staging: sm750fb: Remove unnecessary blank lines Varsha Rao
@ 2017-02-25 18:31 ` Varsha Rao
2017-02-25 18:35 ` [PATCH 6/7] staging: sm750fb: Replace NULL comparison Varsha Rao
` (2 subsequent siblings)
7 siblings, 0 replies; 12+ messages in thread
From: Varsha Rao @ 2017-02-25 18:31 UTC (permalink / raw)
To: Sudip Mukherjee, Teddy Wang, Greg Kroah-Hartman; +Cc: outreachy-kernel
Added spaces around arithmetic operators (/, *), to fix the checkpatch
issue.
Signed-off-by: Varsha Rao <rvarsha016@gmail.com>
---
drivers/staging/sm750fb/sm750.h | 2 +-
drivers/staging/sm750fb/sm750_accel.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h
index 28f4b9b..306711e 100644
--- a/drivers/staging/sm750fb/sm750.h
+++ b/drivers/staging/sm750fb/sm750.h
@@ -177,7 +177,7 @@ struct lynxfb_par {
static inline unsigned long ps_to_hz(unsigned int psvalue)
{
- unsigned long long numerator = 1000*1000*1000*1000ULL;
+ unsigned long long numerator = 1000 * 1000 * 1000 * 1000ULL;
/* 10^12 / picosecond period gives frequency in Hz */
do_div(numerator, psvalue);
return (unsigned long)numerator;
diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c
index af0db57..57ae743 100644
--- a/drivers/staging/sm750fb/sm750_accel.c
+++ b/drivers/staging/sm750fb/sm750_accel.c
@@ -384,7 +384,7 @@ int sm750_hw_imageblit(struct lynx_accel *accel,
/* Write MONO data (line by line) to 2D Engine data port */
for (i = 0; i < height; i++) {
/* For each line, send the data in chunks of 4 bytes */
- for (j = 0; j < (ul4BytesPerScan/4); j++)
+ for (j = 0; j < (ul4BytesPerScan / 4); j++)
write_dpPort(accel, *(unsigned int *)(pSrcbuf + (j * 4)));
if (ulBytesRemain) {
--
2.9.3
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 6/7] staging: sm750fb: Replace NULL comparison.
[not found] <cover.1488045682.git.varshar186@gmail.com>
` (4 preceding siblings ...)
2017-02-25 18:31 ` [PATCH 5/7] staging: sm750fb: Added spaces around arithmetic operators Varsha Rao
@ 2017-02-25 18:35 ` Varsha Rao
2017-02-25 18:36 ` [PATCH 7/7] staging: sm750fb: Remove blank lines after { and before } braces Varsha Rao
[not found] ` <58b1cd6d.c525620a.a8728.d746@mx.google.com>
7 siblings, 0 replies; 12+ messages in thread
From: Varsha Rao @ 2017-02-25 18:35 UTC (permalink / raw)
To: Sudip Mukherjee, Teddy Wang, Greg Kroah-Hartman; +Cc: outreachy-kernel
Replaced NULL comparison with pCurrentDviCtrl->pfnInit. This patch fixes
the following checkpatch issue:
CHECK: Comparison to NULL could be written "pCurrentDviCtrl->pfnInit"
Signed-off-by: Varsha Rao <rvarsha016@gmail.com>
---
drivers/staging/sm750fb/ddk750_dvi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm750fb/ddk750_dvi.c b/drivers/staging/sm750fb/ddk750_dvi.c
index 42c753f..171ae06 100644
--- a/drivers/staging/sm750fb/ddk750_dvi.c
+++ b/drivers/staging/sm750fb/ddk750_dvi.c
@@ -45,7 +45,7 @@ int dviInit(
dvi_ctrl_device_t *pCurrentDviCtrl;
pCurrentDviCtrl = g_dcftSupportedDviController;
- if (pCurrentDviCtrl->pfnInit != NULL) {
+ if (pCurrentDviCtrl->pfnInit) {
return pCurrentDviCtrl->pfnInit(edgeSelect, busSelect, dualEdgeClkSelect, hsyncEnable,
vsyncEnable, deskewEnable, deskewSetting, continuousSyncEnable,
pllFilterEnable, pllFilterValue);
--
2.9.3
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 7/7] staging: sm750fb: Remove blank lines after { and before } braces.
[not found] <cover.1488045682.git.varshar186@gmail.com>
` (5 preceding siblings ...)
2017-02-25 18:35 ` [PATCH 6/7] staging: sm750fb: Replace NULL comparison Varsha Rao
@ 2017-02-25 18:36 ` Varsha Rao
2017-02-25 20:52 ` [Outreachy kernel] " Julia Lawall
[not found] ` <58b1cd6d.c525620a.a8728.d746@mx.google.com>
7 siblings, 1 reply; 12+ messages in thread
From: Varsha Rao @ 2017-02-25 18:36 UTC (permalink / raw)
To: Sudip Mukherjee, Teddy Wang, Greg Kroah-Hartman; +Cc: outreachy-kernel
Removed unnecessary blank lines after open braces and before closed
braces, to fix the check patch issue.
Signed-off-by: Varsha Rao <rvarsha016@gmail.com>
---
drivers/staging/sm750fb/sm750.c | 1 -
drivers/staging/sm750fb/sm750_accel.c | 2 --
drivers/staging/sm750fb/sm750_cursor.c | 4 ----
3 files changed, 7 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index 332a3ef..c618c56 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -806,7 +806,6 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int index)
}
for (i = 0; i < 3; i++) {
-
ret = fb_find_mode(var, info, g_fbmode[index],
pdb[i], cdb[i], NULL, 8);
diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c
index 57ae743..a842831 100644
--- a/drivers/staging/sm750fb/sm750_accel.c
+++ b/drivers/staging/sm750fb/sm750_accel.c
@@ -260,7 +260,6 @@ unsigned int rop2) /* ROP value */
return -1;
{
-
write_dpr(accel, DE_SOURCE,
((sx << DE_SOURCE_X_K1_SHIFT) & DE_SOURCE_X_K1_MASK) |
(sy & DE_SOURCE_Y_K2_MASK)); /* dpr0 */
@@ -275,7 +274,6 @@ unsigned int rop2) /* ROP value */
((nDirection == RIGHT_TO_LEFT) ? DE_CONTROL_DIRECTION : 0) |
DE_CONTROL_COMMAND_BITBLT | DE_CONTROL_STATUS;
write_dpr(accel, DE_CONTROL, de_ctrl); /* dpr0c */
-
}
return 0;
diff --git a/drivers/staging/sm750fb/sm750_cursor.c b/drivers/staging/sm750fb/sm750_cursor.c
index dbc8bb1..aa232c3 100644
--- a/drivers/staging/sm750fb/sm750_cursor.c
+++ b/drivers/staging/sm750fb/sm750_cursor.c
@@ -131,10 +131,7 @@ void sm750_hw_cursor_setData(struct lynx_cursor *cursor,
} else {
pbuffer += sizeof(u16);
}
-
}
-
-
}
@@ -178,6 +175,5 @@ void sm750_hw_cursor_setData2(struct lynx_cursor *cursor,
} else {
pbuffer += sizeof(u16);
}
-
}
}
--
2.9.3
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [Outreachy kernel] [PATCH 7/7] staging: sm750fb: Remove blank lines after { and before } braces.
2017-02-25 18:36 ` [PATCH 7/7] staging: sm750fb: Remove blank lines after { and before } braces Varsha Rao
@ 2017-02-25 20:52 ` Julia Lawall
2017-02-26 5:22 ` Varsha Rao
0 siblings, 1 reply; 12+ messages in thread
From: Julia Lawall @ 2017-02-25 20:52 UTC (permalink / raw)
To: Varsha Rao
Cc: Sudip Mukherjee, Teddy Wang, Greg Kroah-Hartman, outreachy-kernel
On Sun, 26 Feb 2017, Varsha Rao wrote:
> Removed unnecessary blank lines after open braces and before closed
> braces, to fix the check patch issue.
>
> Signed-off-by: Varsha Rao <rvarsha016@gmail.com>
> ---
> drivers/staging/sm750fb/sm750.c | 1 -
> drivers/staging/sm750fb/sm750_accel.c | 2 --
> drivers/staging/sm750fb/sm750_cursor.c | 4 ----
> 3 files changed, 7 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
> index 332a3ef..c618c56 100644
> --- a/drivers/staging/sm750fb/sm750.c
> +++ b/drivers/staging/sm750fb/sm750.c
> @@ -806,7 +806,6 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int index)
> }
>
> for (i = 0; i < 3; i++) {
> -
> ret = fb_find_mode(var, info, g_fbmode[index],
> pdb[i], cdb[i], NULL, 8);
>
> diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c
> index 57ae743..a842831 100644
> --- a/drivers/staging/sm750fb/sm750_accel.c
> +++ b/drivers/staging/sm750fb/sm750_accel.c
> @@ -260,7 +260,6 @@ unsigned int rop2) /* ROP value */
> return -1;
>
> {
> -
I wonder why this brace is here anyway? There is no if, etc branch, and
not even any variables being declared.
julia
> write_dpr(accel, DE_SOURCE,
> ((sx << DE_SOURCE_X_K1_SHIFT) & DE_SOURCE_X_K1_MASK) |
> (sy & DE_SOURCE_Y_K2_MASK)); /* dpr0 */
> @@ -275,7 +274,6 @@ unsigned int rop2) /* ROP value */
> ((nDirection == RIGHT_TO_LEFT) ? DE_CONTROL_DIRECTION : 0) |
> DE_CONTROL_COMMAND_BITBLT | DE_CONTROL_STATUS;
> write_dpr(accel, DE_CONTROL, de_ctrl); /* dpr0c */
> -
> }
>
> return 0;
> diff --git a/drivers/staging/sm750fb/sm750_cursor.c b/drivers/staging/sm750fb/sm750_cursor.c
> index dbc8bb1..aa232c3 100644
> --- a/drivers/staging/sm750fb/sm750_cursor.c
> +++ b/drivers/staging/sm750fb/sm750_cursor.c
> @@ -131,10 +131,7 @@ void sm750_hw_cursor_setData(struct lynx_cursor *cursor,
> } else {
> pbuffer += sizeof(u16);
> }
> -
> }
> -
> -
> }
>
>
> @@ -178,6 +175,5 @@ void sm750_hw_cursor_setData2(struct lynx_cursor *cursor,
> } else {
> pbuffer += sizeof(u16);
> }
> -
> }
> }
> --
> 2.9.3
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/58b1ce9b.19c2620a.af7bc.d941%40mx.google.com.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Outreachy kernel] [PATCH 6/7] staging: sm750fb: Replace NULL comparison.
[not found] ` <58b1cd6d.c525620a.a8728.d746@mx.google.com>
@ 2017-02-25 20:53 ` Julia Lawall
2017-02-26 5:25 ` Varsha Rao
0 siblings, 1 reply; 12+ messages in thread
From: Julia Lawall @ 2017-02-25 20:53 UTC (permalink / raw)
To: Varsha Rao
Cc: Sudip Mukherjee, Teddy Wang, Greg Kroah-Hartman, outreachy-kernel
On Sun, 26 Feb 2017, Varsha Rao wrote:
> Replaced NULL comparison with pCurrentDviCtrl->pfnInit. This patch fixes
> the following checkpatch issue:
This patch appears to have been sent twice?
julia
>
> CHECK: Comparison to NULL could be written "pCurrentDviCtrl->pfnInit"
>
> Signed-off-by: Varsha Rao <rvarsha016@gmail.com>
> ---
> drivers/staging/sm750fb/ddk750_dvi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/sm750fb/ddk750_dvi.c b/drivers/staging/sm750fb/ddk750_dvi.c
> index 42c753f..171ae06 100644
> --- a/drivers/staging/sm750fb/ddk750_dvi.c
> +++ b/drivers/staging/sm750fb/ddk750_dvi.c
> @@ -45,7 +45,7 @@ int dviInit(
> dvi_ctrl_device_t *pCurrentDviCtrl;
>
> pCurrentDviCtrl = g_dcftSupportedDviController;
> - if (pCurrentDviCtrl->pfnInit != NULL) {
> + if (pCurrentDviCtrl->pfnInit) {
> return pCurrentDviCtrl->pfnInit(edgeSelect, busSelect, dualEdgeClkSelect, hsyncEnable,
> vsyncEnable, deskewEnable, deskewSetting, continuousSyncEnable,
> pllFilterEnable, pllFilterValue);
> --
> 2.9.3
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/58b1cd6d.c525620a.a8728.d746%40mx.google.com.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Outreachy kernel] [PATCH 7/7] staging: sm750fb: Remove blank lines after { and before } braces.
2017-02-25 20:52 ` [Outreachy kernel] " Julia Lawall
@ 2017-02-26 5:22 ` Varsha Rao
0 siblings, 0 replies; 12+ messages in thread
From: Varsha Rao @ 2017-02-26 5:22 UTC (permalink / raw)
To: outreachy-kernel; +Cc: rvarsha016, sudipm.mukherjee, teddy.wang, gregkh
[-- Attachment #1.1: Type: text/plain, Size: 609 bytes --]
> >
> > diff --git a/drivers/staging/sm750fb/sm750_accel.c
> b/drivers/staging/sm750fb/sm750_accel.c
> > index 57ae743..a842831 100644
> > --- a/drivers/staging/sm750fb/sm750_accel.c
> > +++ b/drivers/staging/sm750fb/sm750_accel.c
> > @@ -260,7 +260,6 @@ unsigned int rop2) /* ROP value */
> > return -1;
> >
> > {
> > -
>
> I wonder why this brace is here anyway? There is no if, etc branch, and
> not even any variables being declared.
>
> Yeah it is not required. I will send a new patch for this and new
version patch for the current one.
Varsha
[-- Attachment #1.2: Type: text/html, Size: 894 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Outreachy kernel] [PATCH 6/7] staging: sm750fb: Replace NULL comparison.
2017-02-25 20:53 ` [Outreachy kernel] [PATCH 6/7] staging: sm750fb: Replace NULL comparison Julia Lawall
@ 2017-02-26 5:25 ` Varsha Rao
2017-02-26 6:26 ` Julia Lawall
0 siblings, 1 reply; 12+ messages in thread
From: Varsha Rao @ 2017-02-26 5:25 UTC (permalink / raw)
To: outreachy-kernel; +Cc: rvarsha016, sudipm.mukherjee, teddy.wang, gregkh
[-- Attachment #1.1: Type: text/plain, Size: 380 bytes --]
On Sunday, February 26, 2017 at 2:23:18 AM UTC+5:30, Julia Lawall wrote:
>
> On Sun, 26 Feb 2017, Varsha Rao wrote:
>
> > Replaced NULL comparison with pCurrentDviCtrl->pfnInit. This patch fixes
> > the following checkpatch issue:
>
> This patch appears to have been sent twice?
>
> It was out of order, hence I deleted the previous one and sent it
again.
varsha
[-- Attachment #1.2: Type: text/html, Size: 585 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Outreachy kernel] [PATCH 6/7] staging: sm750fb: Replace NULL comparison.
2017-02-26 5:25 ` Varsha Rao
@ 2017-02-26 6:26 ` Julia Lawall
0 siblings, 0 replies; 12+ messages in thread
From: Julia Lawall @ 2017-02-26 6:26 UTC (permalink / raw)
To: Varsha Rao; +Cc: outreachy-kernel, sudipm.mukherjee, teddy.wang, gregkh
[-- Attachment #1: Type: text/plain, Size: 1109 bytes --]
On Sat, 25 Feb 2017, Varsha Rao wrote:
>
>
> On Sunday, February 26, 2017 at 2:23:18 AM UTC+5:30, Julia Lawall wrote:
> On Sun, 26 Feb 2017, Varsha Rao wrote:
>
> > Replaced NULL comparison with pCurrentDviCtrl->pfnInit. This
> patch fixes
> > the following checkpatch issue:
>
> This patch appears to have been sent twice?
>
> It was out of order, hence I deleted the previous one and sent it again.
You can't delete mail - you send it and it arrives. Sending it twice is
more confusing than helpful.
julia
>
> varsha
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/3910855f-4359-4013-8faf-
> df751d5367cd%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
>
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2017-02-26 6:26 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <cover.1488045682.git.varshar186@gmail.com>
2017-02-25 18:21 ` [PATCH 1/7] staging: sm750fb: Add braces around if statement Varsha Rao
2017-02-25 18:22 ` [PATCH 2/7] staging: sm750fb: Fix line over 80 characters Varsha Rao
2017-02-25 18:27 ` [PATCH 3/7] staging: sm750fb: Add identifier to function definition argument Varsha Rao
2017-02-25 18:27 ` [PATCH 4/7] staging: sm750fb: Remove unnecessary blank lines Varsha Rao
2017-02-25 18:31 ` [PATCH 5/7] staging: sm750fb: Added spaces around arithmetic operators Varsha Rao
2017-02-25 18:35 ` [PATCH 6/7] staging: sm750fb: Replace NULL comparison Varsha Rao
2017-02-25 18:36 ` [PATCH 7/7] staging: sm750fb: Remove blank lines after { and before } braces Varsha Rao
2017-02-25 20:52 ` [Outreachy kernel] " Julia Lawall
2017-02-26 5:22 ` Varsha Rao
[not found] ` <58b1cd6d.c525620a.a8728.d746@mx.google.com>
2017-02-25 20:53 ` [Outreachy kernel] [PATCH 6/7] staging: sm750fb: Replace NULL comparison Julia Lawall
2017-02-26 5:25 ` Varsha Rao
2017-02-26 6:26 ` Julia Lawall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.