All of lore.kernel.org
 help / color / mirror / Atom feed
* [merged] hfs-fix-fix-hfs_readdir.patch removed from -mm tree
@ 2017-02-27 20:29 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2017-02-27 20:29 UTC (permalink / raw)
  To: dan.carpenter, slava, viro, mm-commits


The patch titled
     Subject: hfs: fix fix hfs_readdir()
has been removed from the -mm tree.  Its filename was
     hfs-fix-fix-hfs_readdir.patch

This patch was dropped because it was merged into mainline or a subsystem tree

------------------------------------------------------
From: Dan Carpenter <dan.carpenter@oracle.com>
Subject: hfs: fix fix hfs_readdir()

I was looking through static analysis warnings and there is a bug here
that goes all the way back to the start of git.  Basically we're copying
the pointer and nearby garbage instead of the data the fd.key pointer is
pointing to.

Link: http://lkml.kernel.org/r/20170118111320.GA23725@mwanda
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Vyacheslav Dubeyko <slava@dubeyko.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 fs/hfs/dir.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN fs/hfs/dir.c~hfs-fix-fix-hfs_readdir fs/hfs/dir.c
--- a/fs/hfs/dir.c~hfs-fix-fix-hfs_readdir
+++ a/fs/hfs/dir.c
@@ -169,7 +169,7 @@ static int hfs_readdir(struct file *file
 	 * Can be done after the list insertion; exclusion with
 	 * hfs_delete_cat() is provided by directory lock.
 	 */
-	memcpy(&rd->key, &fd.key, sizeof(struct hfs_cat_key));
+	memcpy(&rd->key, &fd.key->cat, sizeof(struct hfs_cat_key));
 out:
 	hfs_find_exit(&fd);
 	return err;
_

Patches currently in -mm which might be from dan.carpenter@oracle.com are



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2017-02-27 20:31 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-27 20:29 [merged] hfs-fix-fix-hfs_readdir.patch removed from -mm tree akpm

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.