* [PATCH 0/9] staging: fbtft: Fix checkpatch warning
@ 2016-08-25 15:22 Anson Jacob
2016-08-25 15:23 ` [PATCH 1/9] staging: fbtft: fb_s6d02a1.c: " Anson Jacob
` (8 more replies)
0 siblings, 9 replies; 10+ messages in thread
From: Anson Jacob @ 2016-08-25 15:22 UTC (permalink / raw)
To: gregkh, noralf, thomas.petazzoni; +Cc: devel, linux-kernel
Fix checkpatch.pl warning:
Block comments use * on subsequent lines
Block comments use a trailing */ on a separate line
Anson Jacob (9):
staging: fbtft: fb_s6d02a1.c: Fix checkpatch warning
staging: fbtft: fb_s6d1121.c: Fix checkpatch warning
staging: fbtft: fb_ssd1289: Fix checkpatch warning
staging: fbtft: fb_ssd1306: Fix checkpatch warning
staging: fbtft: fb_ssd1331: Fix checkpatch warning
staging: fbtft: fb_st7735r: Fix checkpatch warning
staging: fbtft: fbtft-bus: Fix checkpatch warning
staging: fbtft: fbtft_device: Fix checkpatch warning
staging: fbtft: fb_tls8204: Fix checkpatch warning
drivers/staging/fbtft/fb_s6d02a1.c | 14 +++++----
drivers/staging/fbtft/fb_s6d1121.c | 8 ++---
drivers/staging/fbtft/fb_ssd1289.c | 8 ++---
drivers/staging/fbtft/fb_ssd1306.c | 23 ++++++++-------
drivers/staging/fbtft/fb_ssd1331.c | 40 ++++++++++++-------------
drivers/staging/fbtft/fb_st7735r.c | 43 ++++++++++++++++-----------
drivers/staging/fbtft/fb_tls8204.c | 57 ++++++++++++++++++------------------
drivers/staging/fbtft/fbtft-bus.c | 3 +-
drivers/staging/fbtft/fbtft_device.c | 8 +++--
9 files changed, 110 insertions(+), 94 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/9] staging: fbtft: fb_s6d02a1.c: Fix checkpatch warning
2016-08-25 15:22 [PATCH 0/9] staging: fbtft: Fix checkpatch warning Anson Jacob
@ 2016-08-25 15:23 ` Anson Jacob
2016-08-25 15:23 ` [PATCH 2/9] staging: fbtft: fb_s6d1121.c: " Anson Jacob
` (7 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Anson Jacob @ 2016-08-25 15:23 UTC (permalink / raw)
To: gregkh, noralf, thomas.petazzoni; +Cc: devel, linux-kernel
Fix checkpatch.pl warning:
Block comments use * on subsequent lines
Block comments use a trailing */ on a separate line
Signed-off-by: Anson Jacob <ansonjacob.aj@gmail.com>
---
drivers/staging/fbtft/fb_s6d02a1.c | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/fbtft/fb_s6d02a1.c b/drivers/staging/fbtft/fb_s6d02a1.c
index 3113355..774b0ff 100644
--- a/drivers/staging/fbtft/fb_s6d02a1.c
+++ b/drivers/staging/fbtft/fb_s6d02a1.c
@@ -113,12 +113,14 @@ static void set_addr_win(struct fbtft_par *par, int xs, int ys, int xe, int ye)
#define MV BIT(5)
static int set_var(struct fbtft_par *par)
{
- /* Memory data access control (0x36h)
- RGB/BGR:
- 1. Mode selection pin SRGB
- RGB H/W pin for color filter setting: 0=RGB, 1=BGR
- 2. MADCTL RGB bit
- RGB-BGR ORDER color filter panel: 0=RGB, 1=BGR */
+ /*
+ * Memory data access control (0x36h)
+ * RGB/BGR:
+ * 1. Mode selection pin SRGB
+ * RGB H/W pin for color filter setting: 0=RGB, 1=BGR
+ * 2. MADCTL RGB bit
+ * RGB-BGR ORDER color filter panel: 0=RGB, 1=BGR
+ */
switch (par->info->var.rotate) {
case 0:
write_reg(par, MIPI_DCS_SET_ADDRESS_MODE,
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 2/9] staging: fbtft: fb_s6d1121.c: Fix checkpatch warning
2016-08-25 15:22 [PATCH 0/9] staging: fbtft: Fix checkpatch warning Anson Jacob
2016-08-25 15:23 ` [PATCH 1/9] staging: fbtft: fb_s6d02a1.c: " Anson Jacob
@ 2016-08-25 15:23 ` Anson Jacob
2016-08-25 15:23 ` [PATCH 3/9] staging: fbtft: fb_ssd1289: " Anson Jacob
` (6 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Anson Jacob @ 2016-08-25 15:23 UTC (permalink / raw)
To: gregkh, noralf, thomas.petazzoni; +Cc: devel, linux-kernel
Fix checkpatch.pl warning:
Block comments use * on subsequent lines
Signed-off-by: Anson Jacob <ansonjacob.aj@gmail.com>
---
drivers/staging/fbtft/fb_s6d1121.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/fbtft/fb_s6d1121.c b/drivers/staging/fbtft/fb_s6d1121.c
index d6ae76b..9b1d70b 100644
--- a/drivers/staging/fbtft/fb_s6d1121.c
+++ b/drivers/staging/fbtft/fb_s6d1121.c
@@ -125,10 +125,10 @@ static int set_var(struct fbtft_par *par)
}
/*
- Gamma string format:
- PKP0 PKP1 PKP2 PKP3 PKP4 PKP5 PKP6 PKP7 PKP8 PKP9 PKP10 PKP11 VRP0 VRP1
- PKN0 PKN1 PKN2 PKN3 PKN4 PKN5 PKN6 PKN7 PRN8 PRN9 PRN10 PRN11 VRN0 VRN1
-*/
+ * Gamma string format:
+ * PKP0 PKP1 PKP2 PKP3 PKP4 PKP5 PKP6 PKP7 PKP8 PKP9 PKP10 PKP11 VRP0 VRP1
+ * PKN0 PKN1 PKN2 PKN3 PKN4 PKN5 PKN6 PKN7 PRN8 PRN9 PRN10 PRN11 VRN0 VRN1
+ */
#define CURVE(num, idx) curves[num * par->gamma.num_values + idx]
static int set_gamma(struct fbtft_par *par, unsigned long *curves)
{
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 3/9] staging: fbtft: fb_ssd1289: Fix checkpatch warning
2016-08-25 15:22 [PATCH 0/9] staging: fbtft: Fix checkpatch warning Anson Jacob
2016-08-25 15:23 ` [PATCH 1/9] staging: fbtft: fb_s6d02a1.c: " Anson Jacob
2016-08-25 15:23 ` [PATCH 2/9] staging: fbtft: fb_s6d1121.c: " Anson Jacob
@ 2016-08-25 15:23 ` Anson Jacob
2016-08-25 15:23 ` [PATCH 4/9] staging: fbtft: fb_ssd1306: " Anson Jacob
` (5 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Anson Jacob @ 2016-08-25 15:23 UTC (permalink / raw)
To: gregkh, noralf, thomas.petazzoni; +Cc: devel, linux-kernel
Fix checkpatch.pl warning:
Block comments use * on subsequent lines
Signed-off-by: Anson Jacob <ansonjacob.aj@gmail.com>
---
drivers/staging/fbtft/fb_ssd1289.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/fbtft/fb_ssd1289.c b/drivers/staging/fbtft/fb_ssd1289.c
index 5d5f280..25f9fbe 100644
--- a/drivers/staging/fbtft/fb_ssd1289.c
+++ b/drivers/staging/fbtft/fb_ssd1289.c
@@ -131,10 +131,10 @@ static int set_var(struct fbtft_par *par)
}
/*
- Gamma string format:
- VRP0 VRP1 PRP0 PRP1 PKP0 PKP1 PKP2 PKP3 PKP4 PKP5
- VRN0 VRN1 PRN0 PRN1 PKN0 PKN1 PKN2 PKN3 PKN4 PKN5
-*/
+ * Gamma string format:
+ * VRP0 VRP1 PRP0 PRP1 PKP0 PKP1 PKP2 PKP3 PKP4 PKP5
+ * VRN0 VRN1 PRN0 PRN1 PKN0 PKN1 PKN2 PKN3 PKN4 PKN5
+ */
#define CURVE(num, idx) curves[num * par->gamma.num_values + idx]
static int set_gamma(struct fbtft_par *par, unsigned long *curves)
{
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 4/9] staging: fbtft: fb_ssd1306: Fix checkpatch warning
2016-08-25 15:22 [PATCH 0/9] staging: fbtft: Fix checkpatch warning Anson Jacob
` (2 preceding siblings ...)
2016-08-25 15:23 ` [PATCH 3/9] staging: fbtft: fb_ssd1289: " Anson Jacob
@ 2016-08-25 15:23 ` Anson Jacob
2016-08-25 15:25 ` [PATCH 5/9] staging: fbtft: fb_ssd1331: " Anson Jacob
` (4 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Anson Jacob @ 2016-08-25 15:23 UTC (permalink / raw)
To: gregkh, noralf, thomas.petazzoni; +Cc: devel, linux-kernel
Fix checkpatch.pl warning:
Block comments use * on subsequent lines
Block comments use a trailing */ on a separate line
Signed-off-by: Anson Jacob <ansonjacob.aj@gmail.com>
---
drivers/staging/fbtft/fb_ssd1306.c | 23 ++++++++++++-----------
1 file changed, 12 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/fbtft/fb_ssd1306.c b/drivers/staging/fbtft/fb_ssd1306.c
index e0b34a4..80fc570 100644
--- a/drivers/staging/fbtft/fb_ssd1306.c
+++ b/drivers/staging/fbtft/fb_ssd1306.c
@@ -27,15 +27,15 @@
#define HEIGHT 64
/*
- write_reg() caveat:
-
- This doesn't work because D/C has to be LOW for both values:
- write_reg(par, val1, val2);
-
- Do it like this:
- write_reg(par, val1);
- write_reg(par, val2);
-*/
+ * write_reg() caveat:
+ *
+ * This doesn't work because D/C has to be LOW for both values:
+ * write_reg(par, val1, val2);
+ *
+ * Do it like this:
+ * write_reg(par, val1);
+ * write_reg(par, val2);
+ */
/* Init sequence taken from the Adafruit SSD1306 Arduino library */
static int init_display(struct fbtft_par *par)
@@ -113,8 +113,9 @@ static int init_display(struct fbtft_par *par)
write_reg(par, 0xA4);
/* Set Normal Display
- 0 in RAM: OFF in display panel
- 1 in RAM: ON in display panel */
+ * 0 in RAM: OFF in display panel
+ * 1 in RAM: ON in display panel
+ */
write_reg(par, 0xA6);
/* Set Display ON */
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 5/9] staging: fbtft: fb_ssd1331: Fix checkpatch warning
2016-08-25 15:22 [PATCH 0/9] staging: fbtft: Fix checkpatch warning Anson Jacob
` (3 preceding siblings ...)
2016-08-25 15:23 ` [PATCH 4/9] staging: fbtft: fb_ssd1306: " Anson Jacob
@ 2016-08-25 15:25 ` Anson Jacob
2016-08-25 15:26 ` [PATCH 6/9] staging: fbtft: fb_st7735r: " Anson Jacob
` (3 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Anson Jacob @ 2016-08-25 15:25 UTC (permalink / raw)
To: gregkh, noralf, thomas.petazzoni; +Cc: devel, linux-kernel
Fix checkpatch.pl warning:
Block comments use * on subsequent lines
Signed-off-by: Anson Jacob <ansonjacob.aj@gmail.com>
---
drivers/staging/fbtft/fb_ssd1331.c | 40 +++++++++++++++++++-------------------
1 file changed, 20 insertions(+), 20 deletions(-)
diff --git a/drivers/staging/fbtft/fb_ssd1331.c b/drivers/staging/fbtft/fb_ssd1331.c
index bd294f8..1d74ac1 100644
--- a/drivers/staging/fbtft/fb_ssd1331.c
+++ b/drivers/staging/fbtft/fb_ssd1331.c
@@ -102,26 +102,26 @@ static void write_reg8_bus8(struct fbtft_par *par, int len, ...)
}
/*
- Grayscale Lookup Table
- GS1 - GS63
- The driver Gamma curve contains the relative values between the entries
- in the Lookup table.
-
- From datasheet:
- 8.8 Gray Scale Decoder
-
- there are total 180 Gamma Settings (Setting 0 to Setting 180)
- available for the Gray Scale table.
-
- The gray scale is defined in incremental way, with reference
- to the length of previous table entry:
- Setting of GS1 has to be >= 0
- Setting of GS2 has to be > Setting of GS1 +1
- Setting of GS3 has to be > Setting of GS2 +1
- :
- Setting of GS63 has to be > Setting of GS62 +1
-
-*/
+ * Grayscale Lookup Table
+ * GS1 - GS63
+ * The driver Gamma curve contains the relative values between the entries
+ * in the Lookup table.
+ *
+ * From datasheet:
+ * 8.8 Gray Scale Decoder
+ *
+ * there are total 180 Gamma Settings (Setting 0 to Setting 180)
+ * available for the Gray Scale table.
+ *
+ * The gray scale is defined in incremental way, with reference
+ * to the length of previous table entry:
+ * Setting of GS1 has to be >= 0
+ * Setting of GS2 has to be > Setting of GS1 +1
+ * Setting of GS3 has to be > Setting of GS2 +1
+ * :
+ * Setting of GS63 has to be > Setting of GS62 +1
+ *
+ */
static int set_gamma(struct fbtft_par *par, unsigned long *curves)
{
unsigned long tmp[GAMMA_NUM * GAMMA_LEN];
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 6/9] staging: fbtft: fb_st7735r: Fix checkpatch warning
2016-08-25 15:22 [PATCH 0/9] staging: fbtft: Fix checkpatch warning Anson Jacob
` (4 preceding siblings ...)
2016-08-25 15:25 ` [PATCH 5/9] staging: fbtft: fb_ssd1331: " Anson Jacob
@ 2016-08-25 15:26 ` Anson Jacob
2016-08-25 15:27 ` [PATCH 7/9] staging: fbtft: fbtft-bus: " Anson Jacob
` (2 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Anson Jacob @ 2016-08-25 15:26 UTC (permalink / raw)
To: gregkh, noralf, thomas.petazzoni; +Cc: devel, linux-kernel
Fix checkpatch.pl warning:
Block comments use * on subsequent lines
Block comments use a trailing */ on a separate line
Signed-off-by: Anson Jacob <ansonjacob.aj@gmail.com>
---
drivers/staging/fbtft/fb_st7735r.c | 43 +++++++++++++++++++++++---------------
1 file changed, 26 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/fbtft/fb_st7735r.c b/drivers/staging/fbtft/fb_st7735r.c
index c5e51fe..6670f2b 100644
--- a/drivers/staging/fbtft/fb_st7735r.c
+++ b/drivers/staging/fbtft/fb_st7735r.c
@@ -33,35 +33,43 @@ static int default_init_sequence[] = {
-2, 500, /* delay */
/* FRMCTR1 - frame rate control: normal mode
- frame rate = fosc / (1 x 2 + 40) * (LINE + 2C + 2D) */
+ * frame rate = fosc / (1 x 2 + 40) * (LINE + 2C + 2D)
+ */
-1, 0xB1, 0x01, 0x2C, 0x2D,
/* FRMCTR2 - frame rate control: idle mode
- frame rate = fosc / (1 x 2 + 40) * (LINE + 2C + 2D) */
+ * frame rate = fosc / (1 x 2 + 40) * (LINE + 2C + 2D)
+ */
-1, 0xB2, 0x01, 0x2C, 0x2D,
/* FRMCTR3 - frame rate control - partial mode
- dot inversion mode, line inversion mode */
+ * dot inversion mode, line inversion mode
+ */
-1, 0xB3, 0x01, 0x2C, 0x2D, 0x01, 0x2C, 0x2D,
/* INVCTR - display inversion control
- no inversion */
+ * no inversion
+ */
-1, 0xB4, 0x07,
/* PWCTR1 - Power Control
- -4.6V, AUTO mode */
+ * -4.6V, AUTO mode
+ */
-1, 0xC0, 0xA2, 0x02, 0x84,
/* PWCTR2 - Power Control
- VGH25 = 2.4C VGSEL = -10 VGH = 3 * AVDD */
+ * VGH25 = 2.4C VGSEL = -10 VGH = 3 * AVDD
+ */
-1, 0xC1, 0xC5,
/* PWCTR3 - Power Control
- Opamp current small, Boost frequency */
+ * Opamp current small, Boost frequency
+ */
-1, 0xC2, 0x0A, 0x00,
/* PWCTR4 - Power Control
- BCLK/2, Opamp current small & Medium low */
+ * BCLK/2, Opamp current small & Medium low
+ */
-1, 0xC3, 0x8A, 0x2A,
/* PWCTR5 - Power Control */
@@ -101,11 +109,12 @@ static void set_addr_win(struct fbtft_par *par, int xs, int ys, int xe, int ye)
static int set_var(struct fbtft_par *par)
{
/* MADCTL - Memory data access control
- RGB/BGR:
- 1. Mode selection pin SRGB
- RGB H/W pin for color filter setting: 0=RGB, 1=BGR
- 2. MADCTL RGB bit
- RGB-BGR ORDER color filter panel: 0=RGB, 1=BGR */
+ * RGB/BGR:
+ * 1. Mode selection pin SRGB
+ * RGB H/W pin for color filter setting: 0=RGB, 1=BGR
+ * 2. MADCTL RGB bit
+ * RGB-BGR ORDER color filter panel: 0=RGB, 1=BGR
+ */
switch (par->info->var.rotate) {
case 0:
write_reg(par, MIPI_DCS_SET_ADDRESS_MODE,
@@ -129,10 +138,10 @@ static int set_var(struct fbtft_par *par)
}
/*
- Gamma string format:
- VRF0P VOS0P PK0P PK1P PK2P PK3P PK4P PK5P PK6P PK7P PK8P PK9P SELV0P SELV1P SELV62P SELV63P
- VRF0N VOS0N PK0N PK1N PK2N PK3N PK4N PK5N PK6N PK7N PK8N PK9N SELV0N SELV1N SELV62N SELV63N
-*/
+ * Gamma string format:
+ * VRF0P VOS0P PK0P PK1P PK2P PK3P PK4P PK5P PK6P PK7P PK8P PK9P SELV0P SELV1P SELV62P SELV63P
+ * VRF0N VOS0N PK0N PK1N PK2N PK3N PK4N PK5N PK6N PK7N PK8N PK9N SELV0N SELV1N SELV62N SELV63N
+ */
#define CURVE(num, idx) curves[num * par->gamma.num_values + idx]
static int set_gamma(struct fbtft_par *par, unsigned long *curves)
{
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 7/9] staging: fbtft: fbtft-bus: Fix checkpatch warning
2016-08-25 15:22 [PATCH 0/9] staging: fbtft: Fix checkpatch warning Anson Jacob
` (5 preceding siblings ...)
2016-08-25 15:26 ` [PATCH 6/9] staging: fbtft: fb_st7735r: " Anson Jacob
@ 2016-08-25 15:27 ` Anson Jacob
2016-08-25 15:31 ` [PATCH 8/9] staging: fbtft: fbtft_device: " Anson Jacob
2016-08-25 15:32 ` [PATCH 9/9] staging: fbtft: fb_tls8204: " Anson Jacob
8 siblings, 0 replies; 10+ messages in thread
From: Anson Jacob @ 2016-08-25 15:27 UTC (permalink / raw)
To: gregkh, noralf, thomas.petazzoni; +Cc: devel, linux-kernel
Fix checkpatch.pl warning:
Block comments use * on subsequent lines
Block comments use a trailing */ on a separate line
Signed-off-by: Anson Jacob <ansonjacob.aj@gmail.com>
---
drivers/staging/fbtft/fbtft-bus.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/fbtft/fbtft-bus.c b/drivers/staging/fbtft/fbtft-bus.c
index 83505bc..ec45043 100644
--- a/drivers/staging/fbtft/fbtft-bus.c
+++ b/drivers/staging/fbtft/fbtft-bus.c
@@ -92,7 +92,8 @@ void fbtft_write_reg8_bus9(struct fbtft_par *par, int len, ...)
if (par->spi && (par->spi->bits_per_word == 8)) {
/* we're emulating 9-bit, pad start of buffer with no-ops
- (assuming here that zero is a no-op) */
+ * (assuming here that zero is a no-op)
+ */
pad = (len % 4) ? 4 - (len % 4) : 0;
for (i = 0; i < pad; i++)
*buf++ = 0x000;
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 8/9] staging: fbtft: fbtft_device: Fix checkpatch warning
2016-08-25 15:22 [PATCH 0/9] staging: fbtft: Fix checkpatch warning Anson Jacob
` (6 preceding siblings ...)
2016-08-25 15:27 ` [PATCH 7/9] staging: fbtft: fbtft-bus: " Anson Jacob
@ 2016-08-25 15:31 ` Anson Jacob
2016-08-25 15:32 ` [PATCH 9/9] staging: fbtft: fb_tls8204: " Anson Jacob
8 siblings, 0 replies; 10+ messages in thread
From: Anson Jacob @ 2016-08-25 15:31 UTC (permalink / raw)
To: gregkh, noralf, thomas.petazzoni; +Cc: devel, linux-kernel
Fix checkpatch.pl warning:
Block comments use * on subsequent lines
Block comments use a trailing */ on a separate line
Signed-off-by: Anson Jacob <ansonjacob.aj@gmail.com>
---
drivers/staging/fbtft/fbtft_device.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft_device.c b/drivers/staging/fbtft/fbtft_device.c
index 4d1f1e9..924abd3 100644
--- a/drivers/staging/fbtft/fbtft_device.c
+++ b/drivers/staging/fbtft/fbtft_device.c
@@ -1215,7 +1215,8 @@ static struct fbtft_device_display displays[] = {
}
}, {
/* This should be the last item.
- Used with the custom argument */
+ * Used with the custom argument
+ */
.name = "",
.spi = &(struct spi_board_info) {
.modalias = "",
@@ -1306,8 +1307,9 @@ static struct fbtft_gpio fbtft_device_param_gpios[MAX_GPIOS + 1] = { };
static void fbtft_device_pdev_release(struct device *dev)
{
/* Needed to silence this message:
-Device 'xxx' does not have a release() function, it is broken and must be fixed
-*/
+ * Device 'xxx' does not have a release() function,
+ * it is broken and must be fixed
+ */
}
static int spi_device_found(struct device *dev, void *data)
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 9/9] staging: fbtft: fb_tls8204: Fix checkpatch warning
2016-08-25 15:22 [PATCH 0/9] staging: fbtft: Fix checkpatch warning Anson Jacob
` (7 preceding siblings ...)
2016-08-25 15:31 ` [PATCH 8/9] staging: fbtft: fbtft_device: " Anson Jacob
@ 2016-08-25 15:32 ` Anson Jacob
8 siblings, 0 replies; 10+ messages in thread
From: Anson Jacob @ 2016-08-25 15:32 UTC (permalink / raw)
To: gregkh, noralf, thomas.petazzoni; +Cc: devel, linux-kernel
Fix checkpatch.pl warning:
Block comments use * on subsequent lines
Block comments use a trailing */ on a separate line
Signed-off-by: Anson Jacob <ansonjacob.aj@gmail.com>
---
drivers/staging/fbtft/fb_tls8204.c | 57 +++++++++++++++++++-------------------
1 file changed, 29 insertions(+), 28 deletions(-)
diff --git a/drivers/staging/fbtft/fb_tls8204.c b/drivers/staging/fbtft/fb_tls8204.c
index 545f7cb..ea2ddac 100644
--- a/drivers/staging/fbtft/fb_tls8204.c
+++ b/drivers/staging/fbtft/fb_tls8204.c
@@ -44,21 +44,21 @@ static int init_display(struct fbtft_par *par)
par->fbtftops.reset(par);
/* Enter extended command mode */
- write_reg(par, 0x21); /* 5:1 1
- 2:0 PD - Powerdown control: chip is active
- 1:0 V - Entry mode: horizontal addressing
- 0:1 H - Extended instruction set control:
- extended
- */
+ write_reg(par, 0x21); /* 5:1 1
+ * 2:0 PD - Powerdown control: chip is active
+ * 1:0 V - Entry mode: horizontal addressing
+ * 0:1 H - Extended instruction set control:
+ * extended
+ */
/* H=1 Bias system */
- write_reg(par, 0x10 | (bs & 0x7)); /*
- 4:1 1
- 3:0 0
- 2:x BS2 - Bias System
- 1:x BS1
- 0:x BS0
- */
+ write_reg(par, 0x10 | (bs & 0x7));
+ /* 4:1 1
+ * 3:0 0
+ * 2:x BS2 - Bias System
+ * 1:x BS1
+ * 0:x BS0
+ */
/* Set the address of the first display line. */
write_reg(par, 0x04 | (64 >> 6));
@@ -68,12 +68,12 @@ static int init_display(struct fbtft_par *par)
write_reg(par, 0x20);
/* H=0 Display control */
- write_reg(par, 0x08 | 4); /*
- 3:1 1
- 2:1 D - DE: 10=normal mode
- 1:0 0
- 0:0 E
- */
+ write_reg(par, 0x08 | 4);
+ /* 3:1 1
+ * 2:1 D - DE: 10=normal mode
+ * 1:0 0
+ * 0:0 E
+ */
return 0;
}
@@ -81,15 +81,15 @@ static int init_display(struct fbtft_par *par)
static void set_addr_win(struct fbtft_par *par, int xs, int ys, int xe, int ye)
{
/* H=0 Set X address of RAM */
- write_reg(par, 0x80); /* 7:1 1
- 6-0: X[6:0] - 0x00
- */
+ write_reg(par, 0x80); /* 7:1 1
+ * 6-0: X[6:0] - 0x00
+ */
/* H=0 Set Y address of RAM */
- write_reg(par, 0x40); /* 7:0 0
- 6:1 1
- 2-0: Y[2:0] - 0x0
- */
+ write_reg(par, 0x40); /* 7:0 0
+ * 6:1 1
+ * 2-0: Y[2:0] - 0x0
+ */
}
static int write_vmem(struct fbtft_par *par, size_t offset, size_t len)
@@ -100,8 +100,9 @@ static int write_vmem(struct fbtft_par *par, size_t offset, size_t len)
for (y = 0; y < HEIGHT / 8; y++) {
u8 *buf = par->txbuf.buf;
- /* The display is 102x68 but the LCD is 84x48. Set
- the write pointer at the start of each row. */
+ /* The display is 102x68 but the LCD is 84x48.
+ * Set the write pointer at the start of each row.
+ */
gpio_set_value(par->gpio.dc, 0);
write_reg(par, 0x80 | 0);
write_reg(par, 0x40 | y);
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
end of thread, other threads:[~2016-08-25 16:34 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-25 15:22 [PATCH 0/9] staging: fbtft: Fix checkpatch warning Anson Jacob
2016-08-25 15:23 ` [PATCH 1/9] staging: fbtft: fb_s6d02a1.c: " Anson Jacob
2016-08-25 15:23 ` [PATCH 2/9] staging: fbtft: fb_s6d1121.c: " Anson Jacob
2016-08-25 15:23 ` [PATCH 3/9] staging: fbtft: fb_ssd1289: " Anson Jacob
2016-08-25 15:23 ` [PATCH 4/9] staging: fbtft: fb_ssd1306: " Anson Jacob
2016-08-25 15:25 ` [PATCH 5/9] staging: fbtft: fb_ssd1331: " Anson Jacob
2016-08-25 15:26 ` [PATCH 6/9] staging: fbtft: fb_st7735r: " Anson Jacob
2016-08-25 15:27 ` [PATCH 7/9] staging: fbtft: fbtft-bus: " Anson Jacob
2016-08-25 15:31 ` [PATCH 8/9] staging: fbtft: fbtft_device: " Anson Jacob
2016-08-25 15:32 ` [PATCH 9/9] staging: fbtft: fb_tls8204: " Anson Jacob
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.