* [PATCH V3 0/1] oeqa/runtime/cases/selftest.py: rename to _selftest.py
@ 2018-06-12 9:08 Chen Qi
2018-06-12 9:08 ` [PATCH 1/1] " Chen Qi
2018-06-22 1:33 ` [PATCH V3 0/1] " ChenQi
0 siblings, 2 replies; 3+ messages in thread
From: Chen Qi @ 2018-06-12 9:08 UTC (permalink / raw)
To: openembedded-core
Changes in V3:
* Also rename selftest.json to _selftest.json to avoid runtime_test.py failure in oe-selftest.
* Fixed a typo (sato -> full-cmdline)
Changes in V2:
* Fix to depend on _selftest.Selftest.test_install_package.
The following changes since commit fe6e6231441188c3ffe52ef5811a8f30d29ea952:
local.conf.sample: update libsdl mentions to libsdl2 (2018-06-07 08:53:19 +0100)
are available in the git repository at:
git://git.pokylinux.org/poky-contrib ChenQi/rename_selftest
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=ChenQi/rename_selftest
Chen Qi (1):
oeqa/runtime/cases/selftest.py: rename to _selftest.py
.../lib/oeqa/runtime/cases/{selftest.json => _selftest.json} | 0
meta-selftest/lib/oeqa/runtime/cases/{selftest.py => _selftest.py} | 2 +-
meta/lib/oeqa/selftest/cases/runtime_test.py | 4 ++--
3 files changed, 3 insertions(+), 3 deletions(-)
rename meta-selftest/lib/oeqa/runtime/cases/{selftest.json => _selftest.json} (100%)
rename meta-selftest/lib/oeqa/runtime/cases/{selftest.py => _selftest.py} (94%)
--
1.9.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/1] oeqa/runtime/cases/selftest.py: rename to _selftest.py
2018-06-12 9:08 [PATCH V3 0/1] oeqa/runtime/cases/selftest.py: rename to _selftest.py Chen Qi
@ 2018-06-12 9:08 ` Chen Qi
2018-06-22 1:33 ` [PATCH V3 0/1] " ChenQi
1 sibling, 0 replies; 3+ messages in thread
From: Chen Qi @ 2018-06-12 9:08 UTC (permalink / raw)
To: openembedded-core
This test modules is designed to be invoked only by selftest. It's
not meant to be tested by normal runtime test. So it should be renamed
with '_' prefix, so that it will not be automatically loaded by normal
runtime tests when 'auto' is in TEST_SUITES.
The failure message is as below.
RESULTS - selftest.Selftest.test_install_package - Testcase -1: FAILED
Change selftest/cases/runtime_test.py to use '_selftest' accordingly.
Rename selftest.json to _selftest.json accordingly.
Also, fix a typo in runtime_test.py.
Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
---
.../lib/oeqa/runtime/cases/{selftest.json => _selftest.json} | 0
meta-selftest/lib/oeqa/runtime/cases/{selftest.py => _selftest.py} | 2 +-
meta/lib/oeqa/selftest/cases/runtime_test.py | 4 ++--
3 files changed, 3 insertions(+), 3 deletions(-)
rename meta-selftest/lib/oeqa/runtime/cases/{selftest.json => _selftest.json} (100%)
rename meta-selftest/lib/oeqa/runtime/cases/{selftest.py => _selftest.py} (94%)
diff --git a/meta-selftest/lib/oeqa/runtime/cases/selftest.json b/meta-selftest/lib/oeqa/runtime/cases/_selftest.json
similarity index 100%
rename from meta-selftest/lib/oeqa/runtime/cases/selftest.json
rename to meta-selftest/lib/oeqa/runtime/cases/_selftest.json
diff --git a/meta-selftest/lib/oeqa/runtime/cases/selftest.py b/meta-selftest/lib/oeqa/runtime/cases/_selftest.py
similarity index 94%
rename from meta-selftest/lib/oeqa/runtime/cases/selftest.py
rename to meta-selftest/lib/oeqa/runtime/cases/_selftest.py
index 19de740..e6c05ef 100644
--- a/meta-selftest/lib/oeqa/runtime/cases/selftest.py
+++ b/meta-selftest/lib/oeqa/runtime/cases/_selftest.py
@@ -17,7 +17,7 @@ class Selftest(OERuntimeTestCase):
(status, output) = self.target.run("socat -V")
self.assertEqual(status, 0, msg="socat is not installed")
- @OETestDepends(['selftest.Selftest.test_install_package'])
+ @OETestDepends(['_selftest.Selftest.test_install_package'])
def test_verify_uninstall(self):
"""
Summary: Check basic package installation functionality.
diff --git a/meta/lib/oeqa/selftest/cases/runtime_test.py b/meta/lib/oeqa/selftest/cases/runtime_test.py
index 30fd9b2..3bd0ca6 100644
--- a/meta/lib/oeqa/selftest/cases/runtime_test.py
+++ b/meta/lib/oeqa/selftest/cases/runtime_test.py
@@ -122,10 +122,10 @@ class TestImage(OESelftestTestCase):
self.skipTest('core-image-full-cmdline not buildable for poky-tiny')
features = 'INHERIT += "testimage"\n'
- features += 'TEST_SUITES = "ping ssh selftest"\n'
+ features += 'TEST_SUITES = "ping ssh _selftest"\n'
self.write_config(features)
- # Build core-image-sato and testimage
+ # Build core-image-full-cmdline and testimage
bitbake('core-image-full-cmdline socat')
bitbake('-c testimage core-image-full-cmdline')
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH V3 0/1] oeqa/runtime/cases/selftest.py: rename to _selftest.py
2018-06-12 9:08 [PATCH V3 0/1] oeqa/runtime/cases/selftest.py: rename to _selftest.py Chen Qi
2018-06-12 9:08 ` [PATCH 1/1] " Chen Qi
@ 2018-06-22 1:33 ` ChenQi
1 sibling, 0 replies; 3+ messages in thread
From: ChenQi @ 2018-06-22 1:33 UTC (permalink / raw)
To: openembedded-core
ping
I've tested this patch with `oe-selftest -r runtime_test', and the
result is correct.
Best Regards,
Chen Qi
On 06/12/2018 05:08 PM, Chen Qi wrote:
> Changes in V3:
> * Also rename selftest.json to _selftest.json to avoid runtime_test.py failure in oe-selftest.
> * Fixed a typo (sato -> full-cmdline)
>
> Changes in V2:
> * Fix to depend on _selftest.Selftest.test_install_package.
>
>
> The following changes since commit fe6e6231441188c3ffe52ef5811a8f30d29ea952:
>
> local.conf.sample: update libsdl mentions to libsdl2 (2018-06-07 08:53:19 +0100)
>
> are available in the git repository at:
>
> git://git.pokylinux.org/poky-contrib ChenQi/rename_selftest
> http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=ChenQi/rename_selftest
>
> Chen Qi (1):
> oeqa/runtime/cases/selftest.py: rename to _selftest.py
>
> .../lib/oeqa/runtime/cases/{selftest.json => _selftest.json} | 0
> meta-selftest/lib/oeqa/runtime/cases/{selftest.py => _selftest.py} | 2 +-
> meta/lib/oeqa/selftest/cases/runtime_test.py | 4 ++--
> 3 files changed, 3 insertions(+), 3 deletions(-)
> rename meta-selftest/lib/oeqa/runtime/cases/{selftest.json => _selftest.json} (100%)
> rename meta-selftest/lib/oeqa/runtime/cases/{selftest.py => _selftest.py} (94%)
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-06-22 1:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-12 9:08 [PATCH V3 0/1] oeqa/runtime/cases/selftest.py: rename to _selftest.py Chen Qi
2018-06-12 9:08 ` [PATCH 1/1] " Chen Qi
2018-06-22 1:33 ` [PATCH V3 0/1] " ChenQi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.