* [PATCH]: remove extra-verbosity from git-clone (http)
@ 2007-02-15 17:10 Fernando Herrera
2007-03-19 23:04 ` Chris Wright
0 siblings, 1 reply; 5+ messages in thread
From: Fernando Herrera @ 2007-02-15 17:10 UTC (permalink / raw)
To: git
[-- Attachment #1: Type: text/plain, Size: 300 bytes --]
Hi,
the attached patch removes the extra verbosity when cloning a http
repository. I noticed this after some git upgrade in fedora. Please,
consider applying it, getting tons of "got XXX", "walk XXX" lines by
default is a little bit annoying.
Salu2
PS: Thanks for this so great piece os software!
[-- Attachment #2: git-clone-http-noverbose.patch --]
[-- Type: text/x-patch, Size: 373 bytes --]
--- git-clone.sh.orig 2007-02-15 19:03:51.000000000 +0200
+++ git-clone.sh 2007-02-15 19:04:06.000000000 +0200
@@ -59,7 +59,7 @@
else
tname=$name
fi
- git-http-fetch -v -a -w "$tname" "$name" "$1/" || exit 1
+ git-http-fetch -a -w "$tname" "$name" "$1/" || exit 1
done <"$clone_tmp/refs"
rm -fr "$clone_tmp"
http_fetch "$1/HEAD" "$GIT_DIR/REMOTE_HEAD" ||
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH]: remove extra-verbosity from git-clone (http)
2007-02-15 17:10 [PATCH]: remove extra-verbosity from git-clone (http) Fernando Herrera
@ 2007-03-19 23:04 ` Chris Wright
2007-03-19 23:45 ` Junio C Hamano
0 siblings, 1 reply; 5+ messages in thread
From: Chris Wright @ 2007-03-19 23:04 UTC (permalink / raw)
To: Junio C Hamano; +Cc: Fernando Herrera, git
* Fernando Herrera (fherrera@onirica.com) wrote:
> the attached patch removes the extra verbosity when cloning a http
> repository. I noticed this after some git upgrade in fedora. Please,
> consider applying it, getting tons of "got XXX", "walk XXX" lines by
> default is a little bit annoying.
>
> Salu2
>
> PS: Thanks for this so great piece os software!
>
> --- git-clone.sh.orig 2007-02-15 19:03:51.000000000 +0200
> +++ git-clone.sh 2007-02-15 19:04:06.000000000 +0200
> @@ -59,7 +59,7 @@
> else
> tname=$name
> fi
> - git-http-fetch -v -a -w "$tname" "$name" "$1/" || exit 1
> + git-http-fetch -a -w "$tname" "$name" "$1/" || exit 1
> done <"$clone_tmp/refs"
> rm -fr "$clone_tmp"
> http_fetch "$1/HEAD" "$GIT_DIR/REMOTE_HEAD" ||
Was there any problem with this patch from Fernando? I don't care much
either way (I simply never use http fetch myself ;-). Just doing some
old bugzilla cleanup and noticed this still was neither picked up nor
replied to. So, in case it just fell through the cracks...
thanks,
-chris
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH]: remove extra-verbosity from git-clone (http)
2007-03-19 23:04 ` Chris Wright
@ 2007-03-19 23:45 ` Junio C Hamano
2007-03-20 2:18 ` Chris Wright
0 siblings, 1 reply; 5+ messages in thread
From: Junio C Hamano @ 2007-03-19 23:45 UTC (permalink / raw)
To: Chris Wright; +Cc: Fernando Herrera, git
Chris Wright <chrisw@sous-sol.org> writes:
> * Fernando Herrera (fherrera@onirica.com) wrote:
>> the attached patch removes the extra verbosity when cloning a http
>> repository. I noticed this after some git upgrade in fedora. Please,
>> consider applying it, getting tons of "got XXX", "walk XXX" lines by
>> default is a little bit annoying.
>>
>> Salu2
>>
>> PS: Thanks for this so great piece os software!
>>
>> --- git-clone.sh.orig 2007-02-15 19:03:51.000000000 +0200
>> +++ git-clone.sh 2007-02-15 19:04:06.000000000 +0200
>> @@ -59,7 +59,7 @@
>> else
>> tname=$name
>> fi
>> - git-http-fetch -v -a -w "$tname" "$name" "$1/" || exit 1
>> + git-http-fetch -a -w "$tname" "$name" "$1/" || exit 1
>> done <"$clone_tmp/refs"
>> rm -fr "$clone_tmp"
>> http_fetch "$1/HEAD" "$GIT_DIR/REMOTE_HEAD" ||
>
> Was there any problem with this patch from Fernando? I don't care much
> either way (I simply never use http fetch myself ;-). Just doing some
> old bugzilla cleanup and noticed this still was neither picked up nor
> replied to. So, in case it just fell through the cracks...
I saw it. The -v option used not to be there, but we added it
with an explicit purpose of not boring people fetching over http
connection (which used to be slow especially before packfiles
were introduced). I do not care much either way, but I suspect
there actually are people who want to see that "assuring look"
of something happening. I dunno.
I am certainly *not* opposed to have an explicit option or a
per-user configuration to make it not pass -v to http-fetch. I
am just wondering if we want to change the default. Especially
people new to git may wonder what is happening without _any_
feedback if we turned it off by default.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH]: remove extra-verbosity from git-clone (http)
2007-03-19 23:45 ` Junio C Hamano
@ 2007-03-20 2:18 ` Chris Wright
2007-03-20 6:46 ` Junio C Hamano
0 siblings, 1 reply; 5+ messages in thread
From: Chris Wright @ 2007-03-20 2:18 UTC (permalink / raw)
To: Junio C Hamano; +Cc: Chris Wright, Fernando Herrera, git
* Junio C Hamano (junkio@cox.net) wrote:
> I saw it. The -v option used not to be there, but we added it
> with an explicit purpose of not boring people fetching over http
> connection (which used to be slow especially before packfiles
> were introduced). I do not care much either way, but I suspect
> there actually are people who want to see that "assuring look"
> of something happening. I dunno.
Actually, I very much agree now that I've actually tried it
myself when testing the simple patch below.
> I am certainly *not* opposed to have an explicit option or a
> per-user configuration to make it not pass -v to http-fetch. I
> am just wondering if we want to change the default. Especially
> people new to git may wonder what is happening without _any_
> feedback if we turned it off by default.
Well, there's enough to go on already. So how about this simple change
for those few that are bothered by the verbose output? Works in my
basic testing.
thanks,
-chris
--
Subject: [PATCH] make git clone -q suppress the noise with http fetch
We already have -q in git clone. So for those who care to suppress
the noise during an http based clone, make -q actually do a quiet
http fetch.
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
Cc: Fernando Herrera <fherrera@onirica.com>
---
git-clone.sh | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/git-clone.sh b/git-clone.sh
index 1bd54de..ab6c5c0 100755
--- a/git-clone.sh
+++ b/git-clone.sh
@@ -42,6 +42,7 @@ clone_dumb_http () {
http_fetch "$1/info/refs" "$clone_tmp/refs" ||
die "Cannot get remote repository information.
Perhaps git-update-server-info needs to be run there?"
+ test "z$quiet" = z && v=-v || v=
while read sha1 refname
do
name=`expr "z$refname" : 'zrefs/\(.*\)'` &&
@@ -59,7 +60,7 @@ Perhaps git-update-server-info needs to be run there?"
else
tname=$name
fi
- git-http-fetch -v -a -w "$tname" "$name" "$1/" || exit 1
+ git-http-fetch $v -a -w "$tname" "$name" "$1/" || exit 1
done <"$clone_tmp/refs"
rm -fr "$clone_tmp"
http_fetch "$1/HEAD" "$GIT_DIR/REMOTE_HEAD" ||
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH]: remove extra-verbosity from git-clone (http)
2007-03-20 2:18 ` Chris Wright
@ 2007-03-20 6:46 ` Junio C Hamano
0 siblings, 0 replies; 5+ messages in thread
From: Junio C Hamano @ 2007-03-20 6:46 UTC (permalink / raw)
To: Chris Wright; +Cc: Fernando Herrera, git
Sounds sane. Thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2007-03-20 6:46 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-15 17:10 [PATCH]: remove extra-verbosity from git-clone (http) Fernando Herrera
2007-03-19 23:04 ` Chris Wright
2007-03-19 23:45 ` Junio C Hamano
2007-03-20 2:18 ` Chris Wright
2007-03-20 6:46 ` Junio C Hamano
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.