From: Joe Perches <joe@perches.com> To: Randy Li <randy.li@rock-chips.com>, linux-media@vger.kernel.org Cc: Randy Li <ayaka@soulik.info>, hverkuil@xs4all.nl, maxime.ripard@bootlin.com, joro@8bytes.org, linux-kernel@vger.kernel.org, jernej.skrabec@gmail.com, nicolas@ndufresne.ca, paul.kocialkowski@bootlin.com, linux-rockchip@lists.infradead.org, thomas.petazzoni@bootlin.com, mchehab@kernel.org, ezequiel@collabora.com, linux-arm-kernel@lists.infradead.org, posciak@chromium.org, groeck@chromium.org Subject: Re: [PATCH v2 2/6] staging: video: rockchip: add v4l2 decoder Date: Thu, 07 Mar 2019 18:33:37 -0800 [thread overview] Message-ID: <58d834c0b0aeeb7e551e101a696ab8faf9d41b61.camel@perches.com> (raw) In-Reply-To: <20190307100316.925-3-randy.li@rock-chips.com> On Thu, 2019-03-07 at 18:03 +0800, Randy Li wrote: > It is based on the vendor driver sent to mail list before. trivial notes: > diff --git a/drivers/staging/rockchip-mpp/mpp_debug.h b/drivers/staging/rockchip-mpp/mpp_debug.h [] > +#define mpp_debug_func(type, fmt, args...) \ > + do { \ > + if (unlikely(debug & type)) { \ > + pr_info("%s:%d: " fmt, \ > + __func__, __LINE__, ##args); \ > + } \ > + } while (0) > +#define mpp_debug(type, fmt, args...) \ > + do { \ > + if (unlikely(debug & type)) { \ > + pr_info(fmt, ##args); \ > + } \ > + } while (0) > + It's generally better to emit debug messages at KERN_DEBUG > +#define mpp_debug_enter() \ > + do { \ > + if (unlikely(debug & DEBUG_FUNCTION)) { \ > + pr_info("%s:%d: enter\n", \ > + __func__, __LINE__); \ > + } \ > + } while (0) > + > +#define mpp_debug_leave() \ > + do { \ > + if (unlikely(debug & DEBUG_FUNCTION)) { \ > + pr_info("%s:%d: leave\n", \ > + __func__, __LINE__); \ > + } \ > + } while (0) I suggest removal of these macros and uses. There's not much value in enter/leave markings as the generic ftrace facility does this already. > + > +#define mpp_err(fmt, args...) \ > + pr_err("%s:%d: " fmt, __func__, __LINE__, ##args) __func__, __LINE__ markings generally have little value.
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com> To: Randy Li <randy.li@rock-chips.com>, linux-media@vger.kernel.org Cc: paul.kocialkowski@bootlin.com, maxime.ripard@bootlin.com, joro@8bytes.org, Randy Li <ayaka@soulik.info>, linux-kernel@vger.kernel.org, jernej.skrabec@gmail.com, nicolas@ndufresne.ca, hverkuil@xs4all.nl, linux-rockchip@lists.infradead.org, posciak@chromium.org, thomas.petazzoni@bootlin.com, groeck@chromium.org, mchehab@kernel.org, ezequiel@collabora.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 2/6] staging: video: rockchip: add v4l2 decoder Date: Thu, 07 Mar 2019 18:33:37 -0800 [thread overview] Message-ID: <58d834c0b0aeeb7e551e101a696ab8faf9d41b61.camel@perches.com> (raw) In-Reply-To: <20190307100316.925-3-randy.li@rock-chips.com> On Thu, 2019-03-07 at 18:03 +0800, Randy Li wrote: > It is based on the vendor driver sent to mail list before. trivial notes: > diff --git a/drivers/staging/rockchip-mpp/mpp_debug.h b/drivers/staging/rockchip-mpp/mpp_debug.h [] > +#define mpp_debug_func(type, fmt, args...) \ > + do { \ > + if (unlikely(debug & type)) { \ > + pr_info("%s:%d: " fmt, \ > + __func__, __LINE__, ##args); \ > + } \ > + } while (0) > +#define mpp_debug(type, fmt, args...) \ > + do { \ > + if (unlikely(debug & type)) { \ > + pr_info(fmt, ##args); \ > + } \ > + } while (0) > + It's generally better to emit debug messages at KERN_DEBUG > +#define mpp_debug_enter() \ > + do { \ > + if (unlikely(debug & DEBUG_FUNCTION)) { \ > + pr_info("%s:%d: enter\n", \ > + __func__, __LINE__); \ > + } \ > + } while (0) > + > +#define mpp_debug_leave() \ > + do { \ > + if (unlikely(debug & DEBUG_FUNCTION)) { \ > + pr_info("%s:%d: leave\n", \ > + __func__, __LINE__); \ > + } \ > + } while (0) I suggest removal of these macros and uses. There's not much value in enter/leave markings as the generic ftrace facility does this already. > + > +#define mpp_err(fmt, args...) \ > + pr_err("%s:%d: " fmt, __func__, __LINE__, ##args) __func__, __LINE__ markings generally have little value. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-03-08 2:33 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-07 10:03 [PATCH v2 0/6] [WIP]: rockchip mpp for v4l2 video deocder Randy Li 2019-03-07 10:03 ` Randy Li 2019-03-07 10:03 ` Randy Li 2019-03-07 10:03 ` [PATCH v2 1/6] arm64: dts: rockchip: add power domain to iommu Randy Li 2019-03-07 10:03 ` Randy Li 2019-03-07 10:03 ` Randy Li 2019-03-07 10:03 ` [PATCH v2 2/6] staging: video: rockchip: add v4l2 decoder Randy Li 2019-03-07 10:03 ` Randy Li 2019-03-08 2:33 ` Joe Perches [this message] 2019-03-08 2:33 ` Joe Perches 2019-03-07 10:03 ` [PATCH v2 3/6] [TEST]: rockchip: mpp: support qptable Randy Li 2019-03-07 10:03 ` Randy Li 2019-03-07 10:03 ` Randy Li 2019-03-07 10:03 ` [PATCH v2 4/6] staging: video: rockchip: add video codec Randy Li 2019-03-07 10:03 ` Randy Li 2019-03-07 10:03 ` Randy Li 2019-03-07 17:11 ` [PATCH v2 0/6] [WIP]: rockchip mpp for v4l2 video deocder Nicolas Dufresne 2019-03-07 17:11 ` Nicolas Dufresne
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=58d834c0b0aeeb7e551e101a696ab8faf9d41b61.camel@perches.com \ --to=joe@perches.com \ --cc=ayaka@soulik.info \ --cc=ezequiel@collabora.com \ --cc=groeck@chromium.org \ --cc=hverkuil@xs4all.nl \ --cc=jernej.skrabec@gmail.com \ --cc=joro@8bytes.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=linux-rockchip@lists.infradead.org \ --cc=maxime.ripard@bootlin.com \ --cc=mchehab@kernel.org \ --cc=nicolas@ndufresne.ca \ --cc=paul.kocialkowski@bootlin.com \ --cc=posciak@chromium.org \ --cc=randy.li@rock-chips.com \ --cc=thomas.petazzoni@bootlin.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.