[PATCH 1/1] SIM detection: Fixing the logical error in using the number of slot and number of application

[PATCH 1/1] SIM detection: Fixing the logical error in using the number of slot and number of application

[Eswaran Vinothkumar]

[-- Attachment #1: Type: text/plain, Size: 1251 bytes --]

From d1ec66c643f005d558c403a68c7df04b0819aa79 Mon Sep 17 00:00:00 2001
From: "Eswaran Vinothkumar (BEG-PT/PJ-IOT1)"
<Vinothkumar.Eswaran@de.bosch.com>
Date: Mon, 12 Mar 2018 14:46:28 +0100
Subject: [PATCH] sim detection: Fix to take the right slot and application
number

---
drivers/qmimodem/sim.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/qmimodem/sim.c b/drivers/qmimodem/sim.c
index 71c7e04..99c6d68 100644
--- a/drivers/qmimodem/sim.c
+++ b/drivers/qmimodem/sim.c
@@ -557,7 +557,7 @@ static enum get_card_status_result handle_get_card_status_result(
                                    index = GUINT16_FROM_LE(status->index_gw_pri);
-                                   if ((index & 0xff) == i && (index >> 8) == n) {
+                                  if ((index & 0xff) == n && (index >> 8) == i) {
                                               if (get_card_status(slot, info1, info2,
                                                                                               sim_stat))
                                                           res = GET_CARD_STATUS_RESULT_TEMP_ERROR;
--
2.7.4

Mit freundlichen Grüßen / Best regards

Vinothkumar Eswaran
BEG-PT/PJ-IOT-EL


[-- Attachment #2: attachment.html --]
[-- Type: text/html, Size: 7737 bytes --]

Re: [PATCH 1/1] SIM detection: Fixing the logical error in using the number of slot and number of application

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 593 bytes --]

Hi,

On 03/12/2018 09:07 AM, Eswaran Vinothkumar (BEG/PJ-IOT-EL) wrote:
>  From d1ec66c643f005d558c403a68c7df04b0819aa79 Mon Sep 17 00:00:00 2001
> 
> From: "Eswaran Vinothkumar (BEG-PT/PJ-IOT1)"
> 
> <Vinothkumar.Eswaran@de.bosch.com>
> 
> Date: Mon, 12 Mar 2018 14:46:28 +0100
> 
> Subject: [PATCH] sim detection: Fix to take the right slot and application
> 
> number
> 
> ---
> 
> drivers/qmimodem/sim.c | 2 +-
> 
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 

I can't apply this patch..

Could you please use git send-email and resubmit?

Regards,
-Denis

[PATCH 1/1] SIM detection: Fixing the logical error in using the number of slot and number of application

[Christophe Ronco]

[-- Attachment #1: Type: text/plain, Size: 486 bytes --]

Hi,

I have a Japanese SIM card which is not detected because of this issue.
So I would like to see this patch included.

Here is a version of the patch using git send-email.
I don't know how to say that Eswaran Vinothkumar is the author.
I hope you can fix that.

Best Regards,

Christophe

Christophe Ronco (1):
  qmi: use right slot and application during SIM detection

 drivers/qmimodem/sim.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.7.4

[PATCH 1/1] qmi: use right slot and application during SIM detection

[Christophe Ronco]

[-- Attachment #1: Type: text/plain, Size: 803 bytes --]

Use right slot and application to get card status, PIN status and PIN
retries. Without this patch, SIMs where selected application and slot
numbers are different are not detected.
---
 drivers/qmimodem/sim.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/qmimodem/sim.c b/drivers/qmimodem/sim.c
index 9aa943b..1ac5068 100644
--- a/drivers/qmimodem/sim.c
+++ b/drivers/qmimodem/sim.c
@@ -564,7 +564,7 @@ static enum get_card_status_result handle_get_card_status_result(
 
 			index = GUINT16_FROM_LE(status->index_gw_pri);
 
-			if ((index & 0xff) == i && (index >> 8) == n) {
+			if ((index & 0xff) == n && (index >> 8) == i) {
 				if (get_card_status(slot, info1, info2,
 								sim_stat))
 					res = GET_CARD_STATUS_RESULT_TEMP_ERROR;
-- 
2.7.4

Re: [PATCH 1/1] qmi: use right slot and application during SIM detection

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 395 bytes --]

Hi Christophe,

On 04/19/2018 03:31 AM, Christophe Ronco wrote:
> Use right slot and application to get card status, PIN status and PIN
> retries. Without this patch, SIMs where selected application and slot
> numbers are different are not detected.
> ---
>   drivers/qmimodem/sim.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 

Applied, thanks.

Regards,
-Denis