+ fix-print-order-in-show_free_areas.patch added to -mm tree

+ fix-print-order-in-show_free_areas.patch added to -mm tree

[akpm]

The patch titled
     Subject: mmpage_alloc.c: fix print order in show_free_areas()
has been added to the -mm tree.  Its filename is
     fix-print-order-in-show_free_areas.patch

This patch should soon appear at
    http://ozlabs.org/~akpm/mmots/broken-out/fix-print-order-in-show_free_areas.patch
and later at
    http://ozlabs.org/~akpm/mmotm/broken-out/fix-print-order-in-show_free_areas.patch

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/SubmitChecklist when testing your code ***

The -mm tree is included into linux-next and is updated
there every 3-4 working days

------------------------------------------------------
From: Alexander Polakov <apolyakov@beget.ru>
Subject: mmpage_alloc.c: fix print order in show_free_areas()

Fixes: 11fb998986a72a ("mm: move most file-based accounting to the node")
Link: http://lkml.kernel.org/r/1490377730.30219.2.camel@beget.ru
Signed-off-by: Alexander Polyakov <apolyakov@beget.com>
Cc: Mel Gorman <mgorman@techsingularity.net>
Cc: Vlastimil Babka <vbabka@suse.cz>
Cc: Michal Hocko <mhocko@suse.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 mm/page_alloc.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN mm/page_alloc.c~fix-print-order-in-show_free_areas mm/page_alloc.c
--- a/mm/page_alloc.c~fix-print-order-in-show_free_areas
+++ a/mm/page_alloc.c
@@ -4519,13 +4519,13 @@ void show_free_areas(unsigned int filter
 			K(node_page_state(pgdat, NR_FILE_MAPPED)),
 			K(node_page_state(pgdat, NR_FILE_DIRTY)),
 			K(node_page_state(pgdat, NR_WRITEBACK)),
+			K(node_page_state(pgdat, NR_SHMEM)),
 #ifdef CONFIG_TRANSPARENT_HUGEPAGE
 			K(node_page_state(pgdat, NR_SHMEM_THPS) * HPAGE_PMD_NR),
 			K(node_page_state(pgdat, NR_SHMEM_PMDMAPPED)
 					* HPAGE_PMD_NR),
 			K(node_page_state(pgdat, NR_ANON_THPS) * HPAGE_PMD_NR),
 #endif
-			K(node_page_state(pgdat, NR_SHMEM)),
 			K(node_page_state(pgdat, NR_WRITEBACK_TEMP)),
 			K(node_page_state(pgdat, NR_UNSTABLE_NFS)),
 			node_page_state(pgdat, NR_PAGES_SCANNED),
_

Patches currently in -mm which might be from apolyakov@beget.ru are

fix-print-order-in-show_free_areas.patch

Re: + fix-print-order-in-show_free_areas.patch added to -mm tree

[Michal Hocko]

JFTR. Joe, has already noticed this
http://lkml.kernel.org/r/2aaf6f1701ee78582743d91359018689d5826e82.1489628459.git.joe@perches.com
and I have requested to split out the fix from the rest of the
whitespace noise
http://lkml.kernel.org/r/20170316105733.GC30508@dhcp22.suse.cz
but Joe hasn't really followed up and I didn't get to do it myself.

On Mon 03-04-17 15:11:17, Andrew Morton wrote:
> From: Alexander Polakov <apolyakov@beget.ru>
> Subject: mmpage_alloc.c: fix print order in show_free_areas()
> 
> Fixes: 11fb998986a72a ("mm: move most file-based accounting to the node")
> Link: http://lkml.kernel.org/r/1490377730.30219.2.camel@beget.ru
> Signed-off-by: Alexander Polyakov <apolyakov@beget.com>
> Cc: Mel Gorman <mgorman@techsingularity.net>
> Cc: Vlastimil Babka <vbabka@suse.cz>
> Cc: Michal Hocko <mhocko@suse.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

Even though this cannot cause any crash or misbehaving it is still
confusing enough to be worth backporting to stable

Cc: stable # 4.8+
Acked-by: Michal Hocko <mhocko@suse.com>

Thanks!

> ---
> 
>  mm/page_alloc.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff -puN mm/page_alloc.c~fix-print-order-in-show_free_areas mm/page_alloc.c
> --- a/mm/page_alloc.c~fix-print-order-in-show_free_areas
> +++ a/mm/page_alloc.c
> @@ -4519,13 +4519,13 @@ void show_free_areas(unsigned int filter
>  			K(node_page_state(pgdat, NR_FILE_MAPPED)),
>  			K(node_page_state(pgdat, NR_FILE_DIRTY)),
>  			K(node_page_state(pgdat, NR_WRITEBACK)),
> +			K(node_page_state(pgdat, NR_SHMEM)),
>  #ifdef CONFIG_TRANSPARENT_HUGEPAGE
>  			K(node_page_state(pgdat, NR_SHMEM_THPS) * HPAGE_PMD_NR),
>  			K(node_page_state(pgdat, NR_SHMEM_PMDMAPPED)
>  					* HPAGE_PMD_NR),
>  			K(node_page_state(pgdat, NR_ANON_THPS) * HPAGE_PMD_NR),
>  #endif
> -			K(node_page_state(pgdat, NR_SHMEM)),
>  			K(node_page_state(pgdat, NR_WRITEBACK_TEMP)),
>  			K(node_page_state(pgdat, NR_UNSTABLE_NFS)),
>  			node_page_state(pgdat, NR_PAGES_SCANNED),
> _
> 
> Patches currently in -mm which might be from apolyakov@beget.ru are
> 
> fix-print-order-in-show_free_areas.patch
> 

-- 
Michal Hocko
SUSE Labs

Re: + fix-print-order-in-show_free_areas.patch added to -mm tree

[Michal Hocko]

JFTR. Joe, has already noticed this
http://lkml.kernel.org/r/2aaf6f1701ee78582743d91359018689d5826e82.1489628459.git.joe@perches.com
and I have requested to split out the fix from the rest of the
whitespace noise
http://lkml.kernel.org/r/20170316105733.GC30508@dhcp22.suse.cz
but Joe hasn't really followed up and I didn't get to do it myself.

On Mon 03-04-17 15:11:17, Andrew Morton wrote:
> From: Alexander Polakov <apolyakov@beget.ru>
> Subject: mmpage_alloc.c: fix print order in show_free_areas()
> 
> Fixes: 11fb998986a72a ("mm: move most file-based accounting to the node")
> Link: http://lkml.kernel.org/r/1490377730.30219.2.camel@beget.ru
> Signed-off-by: Alexander Polyakov <apolyakov@beget.com>
> Cc: Mel Gorman <mgorman@techsingularity.net>
> Cc: Vlastimil Babka <vbabka@suse.cz>
> Cc: Michal Hocko <mhocko@suse.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

Even though this cannot cause any crash or misbehaving it is still
confusing enough to be worth backporting to stable

Cc: stable # 4.8+
Acked-by: Michal Hocko <mhocko@suse.com>

Thanks!

> ---
> 
>  mm/page_alloc.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff -puN mm/page_alloc.c~fix-print-order-in-show_free_areas mm/page_alloc.c
> --- a/mm/page_alloc.c~fix-print-order-in-show_free_areas
> +++ a/mm/page_alloc.c
> @@ -4519,13 +4519,13 @@ void show_free_areas(unsigned int filter
>  			K(node_page_state(pgdat, NR_FILE_MAPPED)),
>  			K(node_page_state(pgdat, NR_FILE_DIRTY)),
>  			K(node_page_state(pgdat, NR_WRITEBACK)),
> +			K(node_page_state(pgdat, NR_SHMEM)),
>  #ifdef CONFIG_TRANSPARENT_HUGEPAGE
>  			K(node_page_state(pgdat, NR_SHMEM_THPS) * HPAGE_PMD_NR),
>  			K(node_page_state(pgdat, NR_SHMEM_PMDMAPPED)
>  					* HPAGE_PMD_NR),
>  			K(node_page_state(pgdat, NR_ANON_THPS) * HPAGE_PMD_NR),
>  #endif
> -			K(node_page_state(pgdat, NR_SHMEM)),
>  			K(node_page_state(pgdat, NR_WRITEBACK_TEMP)),
>  			K(node_page_state(pgdat, NR_UNSTABLE_NFS)),
>  			node_page_state(pgdat, NR_PAGES_SCANNED),
> _
> 
> Patches currently in -mm which might be from apolyakov@beget.ru are
> 
> fix-print-order-in-show_free_areas.patch
> 

-- 
Michal Hocko
SUSE Labs

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>