All of lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t v2] tests/kms_color: check degamma and gamma props in CTM subtests
@ 2022-11-07 19:52 Melissa Wen
  2022-11-07 20:31 ` Alex Hung
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Melissa Wen @ 2022-11-07 19:52 UTC (permalink / raw)
  To: igt-dev; +Cc: Petri Latvala, kernel-dev

Some CTM subtests generate and set degamma/gamma LUTs without checking
if these properties are supported by the driver. Therefore, if degamma
and gamma are used in the subtest, check the color properties before
generate and set LUTs. If these properties are not supported, these
subtests will skip instead of failing.

v2:
- remove unnecessary set_luts check (Alex Hung)

Signed-off-by: Melissa Wen <mwen@igalia.com>
---
 tests/kms_color.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/tests/kms_color.c b/tests/kms_color.c
index e4dc2465..1902cd0c 100644
--- a/tests/kms_color.c
+++ b/tests/kms_color.c
@@ -472,9 +472,6 @@ static bool test_pipe_ctm(data_t *data,
 
 	igt_require(igt_pipe_obj_has_prop(primary->pipe, IGT_CRTC_CTM));
 
-	degamma_linear = generate_table(data->degamma_lut_size, 1.0);
-	gamma_linear = generate_table(data->gamma_lut_size, 1.0);
-
 	igt_output_set_pipe(output, primary->pipe->pipe);
 	igt_output_override_mode(output, mode);
 
@@ -502,6 +499,12 @@ static bool test_pipe_ctm(data_t *data,
 	 * rounding issues and inaccuracies leading to crc mismatch.
 	 */
 	if (memcmp(before, after, sizeof(color_t))) {
+		igt_require(igt_pipe_obj_has_prop(primary->pipe, IGT_CRTC_DEGAMMA_LUT));
+		igt_require(igt_pipe_obj_has_prop(primary->pipe, IGT_CRTC_GAMMA_LUT));
+
+		degamma_linear = generate_table(data->degamma_lut_size, 1.0);
+		gamma_linear = generate_table(data->gamma_lut_size, 1.0);
+
 		set_degamma(data, primary->pipe, degamma_linear);
 		set_gamma(data, primary->pipe, gamma_linear);
 	} else {
-- 
2.35.1

^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-11-08 19:52 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-07 19:52 [igt-dev] [PATCH i-g-t v2] tests/kms_color: check degamma and gamma props in CTM subtests Melissa Wen
2022-11-07 20:31 ` Alex Hung
2022-11-08 19:52   ` Melissa Wen
2022-11-07 22:07 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_color: check degamma and gamma props in CTM subtests (rev2) Patchwork
2022-11-08  3:47 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.