* usb: typec: pi3usb30532: Keep orientation when setting mux to safe mode
@ 2019-03-04 1:14 Guenter Roeck
0 siblings, 0 replies; 7+ messages in thread
From: Guenter Roeck @ 2019-03-04 1:14 UTC (permalink / raw)
To: Hans de Goede, Greg Kroah-Hartman, Heikki Krogerus; +Cc: linux-usb
On 2/22/19 11:22 AM, Hans de Goede wrote:
> Keep the orientation value when setting the mux to safe mode, this
> fixes the orientation getting reset when switching alt-modes.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/usb/typec/mux/pi3usb30532.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/mux/pi3usb30532.c b/drivers/usb/typec/mux/pi3usb30532.c
> index 64eb5983e17a..9294e85fd34b 100644
> --- a/drivers/usb/typec/mux/pi3usb30532.c
> +++ b/drivers/usb/typec/mux/pi3usb30532.c
> @@ -84,7 +84,8 @@ static int pi3usb30532_mux_set(struct typec_mux *mux, int state)
>
> switch (state) {
> case TYPEC_STATE_SAFE:
> - new_conf = PI3USB30532_CONF_OPEN;
> + new_conf = (new_conf & PI3USB30532_CONF_SWAP) |
> + PI3USB30532_CONF_OPEN;
> break;
> case TYPEC_STATE_USB:
> new_conf = (new_conf & PI3USB30532_CONF_SWAP) |
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* usb: typec: pi3usb30532: Keep orientation when setting mux to safe mode
@ 2019-03-19 13:38 Heikki Krogerus
0 siblings, 0 replies; 7+ messages in thread
From: Heikki Krogerus @ 2019-03-19 13:38 UTC (permalink / raw)
To: Hans de Goede; +Cc: Greg Kroah-Hartman, Guenter Roeck, linux-usb
On Fri, Mar 15, 2019 at 04:36:13PM +0200, Heikki Krogerus wrote:
> On Fri, Feb 22, 2019 at 08:22:39PM +0100, Hans de Goede wrote:
> > Keep the orientation value when setting the mux to safe mode, this
> > fixes the orientation getting reset when switching alt-modes.
> >
> > Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>
> Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Also applied to my typec-next branch:
https://github.com/krohei/linux/commit/4002f81b327b4537dead79ed6117dcb8065d2dca
> > ---
> > drivers/usb/typec/mux/pi3usb30532.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/usb/typec/mux/pi3usb30532.c b/drivers/usb/typec/mux/pi3usb30532.c
> > index 64eb5983e17a..9294e85fd34b 100644
> > --- a/drivers/usb/typec/mux/pi3usb30532.c
> > +++ b/drivers/usb/typec/mux/pi3usb30532.c
> > @@ -84,7 +84,8 @@ static int pi3usb30532_mux_set(struct typec_mux *mux, int state)
> >
> > switch (state) {
> > case TYPEC_STATE_SAFE:
> > - new_conf = PI3USB30532_CONF_OPEN;
> > + new_conf = (new_conf & PI3USB30532_CONF_SWAP) |
> > + PI3USB30532_CONF_OPEN;
> > break;
> > case TYPEC_STATE_USB:
> > new_conf = (new_conf & PI3USB30532_CONF_SWAP) |
> > --
> > 2.20.1
thanks,
^ permalink raw reply [flat|nested] 7+ messages in thread
* usb: typec: pi3usb30532: Keep orientation when setting mux to safe mode
@ 2019-03-15 14:36 Heikki Krogerus
0 siblings, 0 replies; 7+ messages in thread
From: Heikki Krogerus @ 2019-03-15 14:36 UTC (permalink / raw)
To: Hans de Goede; +Cc: Greg Kroah-Hartman, Guenter Roeck, linux-usb
On Fri, Feb 22, 2019 at 08:22:39PM +0100, Hans de Goede wrote:
> Keep the orientation value when setting the mux to safe mode, this
> fixes the orientation getting reset when switching alt-modes.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/typec/mux/pi3usb30532.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/mux/pi3usb30532.c b/drivers/usb/typec/mux/pi3usb30532.c
> index 64eb5983e17a..9294e85fd34b 100644
> --- a/drivers/usb/typec/mux/pi3usb30532.c
> +++ b/drivers/usb/typec/mux/pi3usb30532.c
> @@ -84,7 +84,8 @@ static int pi3usb30532_mux_set(struct typec_mux *mux, int state)
>
> switch (state) {
> case TYPEC_STATE_SAFE:
> - new_conf = PI3USB30532_CONF_OPEN;
> + new_conf = (new_conf & PI3USB30532_CONF_SWAP) |
> + PI3USB30532_CONF_OPEN;
> break;
> case TYPEC_STATE_USB:
> new_conf = (new_conf & PI3USB30532_CONF_SWAP) |
> --
> 2.20.1
thanks,
^ permalink raw reply [flat|nested] 7+ messages in thread
* usb: typec: pi3usb30532: Keep orientation when setting mux to safe mode
@ 2019-02-27 8:50 Heikki Krogerus
0 siblings, 0 replies; 7+ messages in thread
From: Heikki Krogerus @ 2019-02-27 8:50 UTC (permalink / raw)
To: Hans de Goede; +Cc: Greg Kroah-Hartman, Guenter Roeck, linux-usb
On Mon, Feb 25, 2019 at 07:52:10PM +0100, Hans de Goede wrote:
> Hi,
>
> On 25-02-19 16:50, Heikki Krogerus wrote:
> > On Fri, Feb 22, 2019 at 08:22:39PM +0100, Hans de Goede wrote:
> > > Keep the orientation value when setting the mux to safe mode, this
> > > fixes the orientation getting reset when switching alt-modes.
> > >
> > > Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> >
> > Should this be also a fix?
>
> This only comes into play when switching alt-modes, so more
> or less the same as with the displayport altmode fix:
>
> "There are no users if this yet, until we've agreement
> on the DT bindings and code merged for adding alt-modes
> to an usb-connector node, nothing will be using this code,
> so I see little use in adding a Cc: stable or some such."
Agree,
thanks,
^ permalink raw reply [flat|nested] 7+ messages in thread
* usb: typec: pi3usb30532: Keep orientation when setting mux to safe mode
@ 2019-02-25 18:52 Hans de Goede
0 siblings, 0 replies; 7+ messages in thread
From: Hans de Goede @ 2019-02-25 18:52 UTC (permalink / raw)
To: Heikki Krogerus; +Cc: Greg Kroah-Hartman, Guenter Roeck, linux-usb
Hi,
On 25-02-19 16:50, Heikki Krogerus wrote:
> On Fri, Feb 22, 2019 at 08:22:39PM +0100, Hans de Goede wrote:
>> Keep the orientation value when setting the mux to safe mode, this
>> fixes the orientation getting reset when switching alt-modes.
>>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>
> Should this be also a fix?
This only comes into play when switching alt-modes, so more
or less the same as with the displayport altmode fix:
"There are no users if this yet, until we've agreement
on the DT bindings and code merged for adding alt-modes
to an usb-connector node, nothing will be using this code,
so I see little use in adding a Cc: stable or some such."
Regards,
Hans
>
>> ---
>> drivers/usb/typec/mux/pi3usb30532.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/typec/mux/pi3usb30532.c b/drivers/usb/typec/mux/pi3usb30532.c
>> index 64eb5983e17a..9294e85fd34b 100644
>> --- a/drivers/usb/typec/mux/pi3usb30532.c
>> +++ b/drivers/usb/typec/mux/pi3usb30532.c
>> @@ -84,7 +84,8 @@ static int pi3usb30532_mux_set(struct typec_mux *mux, int state)
>>
>> switch (state) {
>> case TYPEC_STATE_SAFE:
>> - new_conf = PI3USB30532_CONF_OPEN;
>> + new_conf = (new_conf & PI3USB30532_CONF_SWAP) |
>> + PI3USB30532_CONF_OPEN;
>> break;
>> case TYPEC_STATE_USB:
>> new_conf = (new_conf & PI3USB30532_CONF_SWAP) |
>> --
>> 2.20.1
>
> thanks,
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* usb: typec: pi3usb30532: Keep orientation when setting mux to safe mode
@ 2019-02-25 15:50 Heikki Krogerus
0 siblings, 0 replies; 7+ messages in thread
From: Heikki Krogerus @ 2019-02-25 15:50 UTC (permalink / raw)
To: Hans de Goede; +Cc: Greg Kroah-Hartman, Guenter Roeck, linux-usb
On Fri, Feb 22, 2019 at 08:22:39PM +0100, Hans de Goede wrote:
> Keep the orientation value when setting the mux to safe mode, this
> fixes the orientation getting reset when switching alt-modes.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Should this be also a fix?
> ---
> drivers/usb/typec/mux/pi3usb30532.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/mux/pi3usb30532.c b/drivers/usb/typec/mux/pi3usb30532.c
> index 64eb5983e17a..9294e85fd34b 100644
> --- a/drivers/usb/typec/mux/pi3usb30532.c
> +++ b/drivers/usb/typec/mux/pi3usb30532.c
> @@ -84,7 +84,8 @@ static int pi3usb30532_mux_set(struct typec_mux *mux, int state)
>
> switch (state) {
> case TYPEC_STATE_SAFE:
> - new_conf = PI3USB30532_CONF_OPEN;
> + new_conf = (new_conf & PI3USB30532_CONF_SWAP) |
> + PI3USB30532_CONF_OPEN;
> break;
> case TYPEC_STATE_USB:
> new_conf = (new_conf & PI3USB30532_CONF_SWAP) |
> --
> 2.20.1
thanks,
^ permalink raw reply [flat|nested] 7+ messages in thread
* usb: typec: pi3usb30532: Keep orientation when setting mux to safe mode
@ 2019-02-22 19:22 Hans de Goede
0 siblings, 0 replies; 7+ messages in thread
From: Hans de Goede @ 2019-02-22 19:22 UTC (permalink / raw)
To: Greg Kroah-Hartman, Guenter Roeck, Heikki Krogerus
Cc: Hans de Goede, linux-usb
Keep the orientation value when setting the mux to safe mode, this
fixes the orientation getting reset when switching alt-modes.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
drivers/usb/typec/mux/pi3usb30532.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/typec/mux/pi3usb30532.c b/drivers/usb/typec/mux/pi3usb30532.c
index 64eb5983e17a..9294e85fd34b 100644
--- a/drivers/usb/typec/mux/pi3usb30532.c
+++ b/drivers/usb/typec/mux/pi3usb30532.c
@@ -84,7 +84,8 @@ static int pi3usb30532_mux_set(struct typec_mux *mux, int state)
switch (state) {
case TYPEC_STATE_SAFE:
- new_conf = PI3USB30532_CONF_OPEN;
+ new_conf = (new_conf & PI3USB30532_CONF_SWAP) |
+ PI3USB30532_CONF_OPEN;
break;
case TYPEC_STATE_USB:
new_conf = (new_conf & PI3USB30532_CONF_SWAP) |
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-03-19 13:38 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-04 1:14 usb: typec: pi3usb30532: Keep orientation when setting mux to safe mode Guenter Roeck
-- strict thread matches above, loose matches on Subject: below --
2019-03-19 13:38 Heikki Krogerus
2019-03-15 14:36 Heikki Krogerus
2019-02-27 8:50 Heikki Krogerus
2019-02-25 18:52 Hans de Goede
2019-02-25 15:50 Heikki Krogerus
2019-02-22 19:22 Hans de Goede
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.