* [PATCH] thermal: intel_pch_thermal: Add PCI ids for Lewisburg PCH.
@ 2020-01-15 18:44 Andres Freund
2020-01-16 8:08 ` Daniel Lezcano
2020-01-16 13:53 ` Srinivas Pandruvada
0 siblings, 2 replies; 14+ messages in thread
From: Andres Freund @ 2020-01-15 18:44 UTC (permalink / raw)
To: Tushar Dave, Srinivas Pandruvada, Zhang Rui
Cc: linux-pm, linux-kernel, Andres Freund
I noticed that I couldn't read the PCH temperature on my workstation
(C620 series chipset, w/ 2x Xeon Gold 5215 CPUs) directly, but had to go
through IPMI. Looking at the data sheet, it looks to me like the
existing intel PCH thermal driver should work without changes for
Lewisburg.
I suspect there's some other PCI id's missing. But I hope somebody at
Intel would have an easier time figuring that out than I...
Signed-off-by: Andres Freund <andres@anarazel.de>
---
drivers/thermal/intel/intel_pch_thermal.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/thermal/intel/intel_pch_thermal.c b/drivers/thermal/intel/intel_pch_thermal.c
index 4f0bb8f502e1..1f3ff0d489ef 100644
--- a/drivers/thermal/intel/intel_pch_thermal.c
+++ b/drivers/thermal/intel/intel_pch_thermal.c
@@ -23,6 +23,7 @@
#define PCH_THERMAL_DID_SKL_H 0xA131 /* Skylake PCH 100 series */
#define PCH_THERMAL_DID_CNL 0x9Df9 /* CNL PCH */
#define PCH_THERMAL_DID_CNL_H 0xA379 /* CNL-H PCH */
+#define PCH_THERMAL_DID_LWB 0xA1B1 /* Lewisburg PCH */
/* Wildcat Point-LP PCH Thermal registers */
#define WPT_TEMP 0x0000 /* Temperature */
@@ -272,6 +273,7 @@ enum board_ids {
board_wpt,
board_skl,
board_cnl,
+ board_lwb,
};
static const struct board_info {
@@ -294,6 +296,10 @@ static const struct board_info {
.name = "pch_cannonlake",
.ops = &pch_dev_ops_wpt,
},
+ [board_lwb] = {
+ .name = "pch_lewisburg",
+ .ops = &pch_dev_ops_wpt,
+ },
};
static int intel_pch_thermal_probe(struct pci_dev *pdev,
@@ -398,6 +404,8 @@ static const struct pci_device_id intel_pch_thermal_id[] = {
.driver_data = board_cnl, },
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCH_THERMAL_DID_CNL_H),
.driver_data = board_cnl, },
+ { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCH_THERMAL_DID_LWB),
+ .driver_data = board_lwb, },
{ 0, },
};
MODULE_DEVICE_TABLE(pci, intel_pch_thermal_id);
--
2.25.0.rc1
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH] thermal: intel_pch_thermal: Add PCI ids for Lewisburg PCH.
2020-01-15 18:44 [PATCH] thermal: intel_pch_thermal: Add PCI ids for Lewisburg PCH Andres Freund
@ 2020-01-16 8:08 ` Daniel Lezcano
2020-01-16 13:53 ` Srinivas Pandruvada
1 sibling, 0 replies; 14+ messages in thread
From: Daniel Lezcano @ 2020-01-16 8:08 UTC (permalink / raw)
To: Andres Freund, Tushar Dave, Srinivas Pandruvada, Zhang Rui
Cc: linux-pm, linux-kernel
Rui,
are you fine with this patch?
On 15/01/2020 19:44, Andres Freund wrote:
> I noticed that I couldn't read the PCH temperature on my workstation
> (C620 series chipset, w/ 2x Xeon Gold 5215 CPUs) directly, but had to go
> through IPMI. Looking at the data sheet, it looks to me like the
> existing intel PCH thermal driver should work without changes for
> Lewisburg.
>
> I suspect there's some other PCI id's missing. But I hope somebody at
> Intel would have an easier time figuring that out than I...
>
> Signed-off-by: Andres Freund <andres@anarazel.de>
> ---
> drivers/thermal/intel/intel_pch_thermal.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/thermal/intel/intel_pch_thermal.c b/drivers/thermal/intel/intel_pch_thermal.c
> index 4f0bb8f502e1..1f3ff0d489ef 100644
> --- a/drivers/thermal/intel/intel_pch_thermal.c
> +++ b/drivers/thermal/intel/intel_pch_thermal.c
> @@ -23,6 +23,7 @@
> #define PCH_THERMAL_DID_SKL_H 0xA131 /* Skylake PCH 100 series */
> #define PCH_THERMAL_DID_CNL 0x9Df9 /* CNL PCH */
> #define PCH_THERMAL_DID_CNL_H 0xA379 /* CNL-H PCH */
> +#define PCH_THERMAL_DID_LWB 0xA1B1 /* Lewisburg PCH */
>
> /* Wildcat Point-LP PCH Thermal registers */
> #define WPT_TEMP 0x0000 /* Temperature */
> @@ -272,6 +273,7 @@ enum board_ids {
> board_wpt,
> board_skl,
> board_cnl,
> + board_lwb,
> };
>
> static const struct board_info {
> @@ -294,6 +296,10 @@ static const struct board_info {
> .name = "pch_cannonlake",
> .ops = &pch_dev_ops_wpt,
> },
> + [board_lwb] = {
> + .name = "pch_lewisburg",
> + .ops = &pch_dev_ops_wpt,
> + },
> };
>
> static int intel_pch_thermal_probe(struct pci_dev *pdev,
> @@ -398,6 +404,8 @@ static const struct pci_device_id intel_pch_thermal_id[] = {
> .driver_data = board_cnl, },
> { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCH_THERMAL_DID_CNL_H),
> .driver_data = board_cnl, },
> + { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCH_THERMAL_DID_LWB),
> + .driver_data = board_lwb, },
> { 0, },
> };
> MODULE_DEVICE_TABLE(pci, intel_pch_thermal_id);
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH] thermal: intel_pch_thermal: Add PCI ids for Lewisburg PCH.
2020-01-15 18:44 [PATCH] thermal: intel_pch_thermal: Add PCI ids for Lewisburg PCH Andres Freund
2020-01-16 8:08 ` Daniel Lezcano
@ 2020-01-16 13:53 ` Srinivas Pandruvada
2020-01-16 18:42 ` Andres Freund
1 sibling, 1 reply; 14+ messages in thread
From: Srinivas Pandruvada @ 2020-01-16 13:53 UTC (permalink / raw)
To: Andres Freund, Tushar Dave, Zhang Rui; +Cc: linux-pm, linux-kernel
On Wed, 2020-01-15 at 10:44 -0800, Andres Freund wrote:
> I noticed that I couldn't read the PCH temperature on my workstation
> (C620 series chipset, w/ 2x Xeon Gold 5215 CPUs) directly, but had to
> go
> through IPMI. Looking at the data sheet, it looks to me like the
> existing intel PCH thermal driver should work without changes for
> Lewisburg.
Does the temperature reading match with what you read via IPMI?
The patch looks fine to me otherwise.
Thanks,
Srinivas
>
> I suspect there's some other PCI id's missing. But I hope somebody at
> Intel would have an easier time figuring that out than I...
>
> Signed-off-by: Andres Freund <andres@anarazel.de>
> ---
> drivers/thermal/intel/intel_pch_thermal.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/thermal/intel/intel_pch_thermal.c
> b/drivers/thermal/intel/intel_pch_thermal.c
> index 4f0bb8f502e1..1f3ff0d489ef 100644
> --- a/drivers/thermal/intel/intel_pch_thermal.c
> +++ b/drivers/thermal/intel/intel_pch_thermal.c
> @@ -23,6 +23,7 @@
> #define PCH_THERMAL_DID_SKL_H 0xA131 /* Skylake PCH 100
> series */
> #define PCH_THERMAL_DID_CNL 0x9Df9 /* CNL PCH */
> #define PCH_THERMAL_DID_CNL_H 0xA379 /* CNL-H PCH */
> +#define PCH_THERMAL_DID_LWB 0xA1B1 /* Lewisburg PCH */
>
> /* Wildcat Point-LP PCH Thermal registers */
> #define WPT_TEMP 0x0000 /* Temperature */
> @@ -272,6 +273,7 @@ enum board_ids {
> board_wpt,
> board_skl,
> board_cnl,
> + board_lwb,
> };
>
> static const struct board_info {
> @@ -294,6 +296,10 @@ static const struct board_info {
> .name = "pch_cannonlake",
> .ops = &pch_dev_ops_wpt,
> },
> + [board_lwb] = {
> + .name = "pch_lewisburg",
> + .ops = &pch_dev_ops_wpt,
> + },
> };
>
> static int intel_pch_thermal_probe(struct pci_dev *pdev,
> @@ -398,6 +404,8 @@ static const struct pci_device_id
> intel_pch_thermal_id[] = {
> .driver_data = board_cnl, },
> { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCH_THERMAL_DID_CNL_H),
> .driver_data = board_cnl, },
> + { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCH_THERMAL_DID_LWB),
> + .driver_data = board_lwb, },
> { 0, },
> };
> MODULE_DEVICE_TABLE(pci, intel_pch_thermal_id);
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH] thermal: intel_pch_thermal: Add PCI ids for Lewisburg PCH.
2020-01-16 13:53 ` Srinivas Pandruvada
@ 2020-01-16 18:42 ` Andres Freund
2020-01-16 19:41 ` Srinivas Pandruvada
0 siblings, 1 reply; 14+ messages in thread
From: Andres Freund @ 2020-01-16 18:42 UTC (permalink / raw)
To: Srinivas Pandruvada; +Cc: Tushar Dave, Zhang Rui, linux-pm, linux-kernel
Hi,
On 2020-01-16 05:53:13 -0800, Srinivas Pandruvada wrote:
> On Wed, 2020-01-15 at 10:44 -0800, Andres Freund wrote:
> > I noticed that I couldn't read the PCH temperature on my workstation
> > (C620 series chipset, w/ 2x Xeon Gold 5215 CPUs) directly, but had to
> > go
> > through IPMI. Looking at the data sheet, it looks to me like the
> > existing intel PCH thermal driver should work without changes for
> > Lewisburg.
> Does the temperature reading match with what you read via IPMI?
It does:
root@awork3:~# ipmitool sdr|grep ^PCH
PCH Temp | 58 degrees C | ok
andres@awork3:~$ cat /sys/class/thermal/thermal_zone0/type
pch_lewisburg
andres@awork3:~$ cat /sys/class/thermal/thermal_zone0/temp
58000
And if I generate some load, it rises for both:
root@awork3:~# ipmitool sdr|grep ^PCH
PCH Temp | 60 degrees C | ok
andres@awork3:~$ cat /sys/class/thermal/thermal_zone0/temp
60000
Regards,
Andres
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] thermal: intel_pch_thermal: Add PCI ids for Lewisburg PCH.
2020-01-16 18:42 ` Andres Freund
@ 2020-01-16 19:41 ` Srinivas Pandruvada
2020-10-28 20:21 ` Andres Freund
0 siblings, 1 reply; 14+ messages in thread
From: Srinivas Pandruvada @ 2020-01-16 19:41 UTC (permalink / raw)
To: Andres Freund; +Cc: Tushar Dave, Zhang Rui, linux-pm, linux-kernel
On Thu, 2020-01-16 at 10:42 -0800, Andres Freund wrote:
> Hi,
>
> On 2020-01-16 05:53:13 -0800, Srinivas Pandruvada wrote:
> > On Wed, 2020-01-15 at 10:44 -0800, Andres Freund wrote:
> > > I noticed that I couldn't read the PCH temperature on my
> > > workstation
> > > (C620 series chipset, w/ 2x Xeon Gold 5215 CPUs) directly, but
> > > had to
> > > go
> > > through IPMI. Looking at the data sheet, it looks to me like the
> > > existing intel PCH thermal driver should work without changes for
> > > Lewisburg.
> > Does the temperature reading match with what you read via IPMI?
>
> It does:
>
> root@awork3:~# ipmitool sdr|grep ^PCH
> PCH Temp | 58 degrees C | ok
>
> andres@awork3:~$ cat /sys/class/thermal/thermal_zone0/type
> pch_lewisburg
> andres@awork3:~$ cat /sys/class/thermal/thermal_zone0/temp
> 58000
>
> And if I generate some load, it rises for both:
> root@awork3:~# ipmitool sdr|grep ^PCH
> PCH Temp | 60 degrees C | ok
> andres@awork3:~$ cat /sys/class/thermal/thermal_zone0/temp
> 60000
>
Thanks for the test.
Rui can add his ACK.
Thanks,
Srinivas
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] thermal: intel_pch_thermal: Add PCI ids for Lewisburg PCH.
2020-01-16 19:41 ` Srinivas Pandruvada
@ 2020-10-28 20:21 ` Andres Freund
2020-11-12 11:29 ` Daniel Lezcano
2020-11-12 11:34 ` Daniel Lezcano
0 siblings, 2 replies; 14+ messages in thread
From: Andres Freund @ 2020-10-28 20:21 UTC (permalink / raw)
To: Srinivas Pandruvada; +Cc: Tushar Dave, Zhang Rui, linux-pm, linux-kernel
Hi,
On 2020-01-16 11:41:34 -0800, Srinivas Pandruvada wrote:
> On Thu, 2020-01-16 at 10:42 -0800, Andres Freund wrote:
> > Hi,
> >
> > On 2020-01-16 05:53:13 -0800, Srinivas Pandruvada wrote:
> > > On Wed, 2020-01-15 at 10:44 -0800, Andres Freund wrote:
> > > > I noticed that I couldn't read the PCH temperature on my
> > > > workstation
> > > > (C620 series chipset, w/ 2x Xeon Gold 5215 CPUs) directly, but
> > > > had to
> > > > go
> > > > through IPMI. Looking at the data sheet, it looks to me like the
> > > > existing intel PCH thermal driver should work without changes for
> > > > Lewisburg.
> > > Does the temperature reading match with what you read via IPMI?
> >
> > It does:
> >
> > root@awork3:~# ipmitool sdr|grep ^PCH
> > PCH Temp | 58 degrees C | ok
> >
> > andres@awork3:~$ cat /sys/class/thermal/thermal_zone0/type
> > pch_lewisburg
> > andres@awork3:~$ cat /sys/class/thermal/thermal_zone0/temp
> > 58000
> >
> > And if I generate some load, it rises for both:
> > root@awork3:~# ipmitool sdr|grep ^PCH
> > PCH Temp | 60 degrees C | ok
> > andres@awork3:~$ cat /sys/class/thermal/thermal_zone0/temp
> > 60000
> >
> Thanks for the test.
>
> Rui can add his ACK.
Ping? Looks like this got lost somewhere?
Greetings,
Andres Freund
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] thermal: intel_pch_thermal: Add PCI ids for Lewisburg PCH.
2020-10-28 20:21 ` Andres Freund
@ 2020-11-12 11:29 ` Daniel Lezcano
2020-11-12 11:34 ` Daniel Lezcano
1 sibling, 0 replies; 14+ messages in thread
From: Daniel Lezcano @ 2020-11-12 11:29 UTC (permalink / raw)
To: Andres Freund, Srinivas Pandruvada
Cc: Tushar Dave, Zhang Rui, linux-pm, linux-kernel
On 28/10/2020 21:21, Andres Freund wrote:
> Hi,
>
> On 2020-01-16 11:41:34 -0800, Srinivas Pandruvada wrote:
>> On Thu, 2020-01-16 at 10:42 -0800, Andres Freund wrote:
>>> Hi,
>>>
>>> On 2020-01-16 05:53:13 -0800, Srinivas Pandruvada wrote:
>>>> On Wed, 2020-01-15 at 10:44 -0800, Andres Freund wrote:
>>>>> I noticed that I couldn't read the PCH temperature on my
>>>>> workstation
>>>>> (C620 series chipset, w/ 2x Xeon Gold 5215 CPUs) directly, but
>>>>> had to
>>>>> go
>>>>> through IPMI. Looking at the data sheet, it looks to me like the
>>>>> existing intel PCH thermal driver should work without changes for
>>>>> Lewisburg.
>>>> Does the temperature reading match with what you read via IPMI?
>>>
>>> It does:
>>>
>>> root@awork3:~# ipmitool sdr|grep ^PCH
>>> PCH Temp | 58 degrees C | ok
>>>
>>> andres@awork3:~$ cat /sys/class/thermal/thermal_zone0/type
>>> pch_lewisburg
>>> andres@awork3:~$ cat /sys/class/thermal/thermal_zone0/temp
>>> 58000
>>>
>>> And if I generate some load, it rises for both:
>>> root@awork3:~# ipmitool sdr|grep ^PCH
>>> PCH Temp | 60 degrees C | ok
>>> andres@awork3:~$ cat /sys/class/thermal/thermal_zone0/temp
>>> 60000
>>>
>> Thanks for the test.
>>
>> Rui can add his ACK.
>
> Ping? Looks like this got lost somewhere?
Waiting for Rui's ack :)
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] thermal: intel_pch_thermal: Add PCI ids for Lewisburg PCH.
2020-10-28 20:21 ` Andres Freund
2020-11-12 11:29 ` Daniel Lezcano
@ 2020-11-12 11:34 ` Daniel Lezcano
2020-11-13 20:49 ` Andres Freund
2020-11-13 20:50 ` [PATCH] " Andres Freund
1 sibling, 2 replies; 14+ messages in thread
From: Daniel Lezcano @ 2020-11-12 11:34 UTC (permalink / raw)
To: Andres Freund, Srinivas Pandruvada
Cc: Tushar Dave, Zhang Rui, linux-pm, linux-kernel
On 28/10/2020 21:21, Andres Freund wrote:
> Hi,
>
> On 2020-01-16 11:41:34 -0800, Srinivas Pandruvada wrote:
>> On Thu, 2020-01-16 at 10:42 -0800, Andres Freund wrote:
>>> Hi,
>>>
>>> On 2020-01-16 05:53:13 -0800, Srinivas Pandruvada wrote:
>>>> On Wed, 2020-01-15 at 10:44 -0800, Andres Freund wrote:
>>>>> I noticed that I couldn't read the PCH temperature on my
>>>>> workstation
>>>>> (C620 series chipset, w/ 2x Xeon Gold 5215 CPUs) directly, but
>>>>> had to
>>>>> go
>>>>> through IPMI. Looking at the data sheet, it looks to me like the
>>>>> existing intel PCH thermal driver should work without changes for
>>>>> Lewisburg.
>>>> Does the temperature reading match with what you read via IPMI?
>>>
>>> It does:
>>>
>>> root@awork3:~# ipmitool sdr|grep ^PCH
>>> PCH Temp | 58 degrees C | ok
>>>
>>> andres@awork3:~$ cat /sys/class/thermal/thermal_zone0/type
>>> pch_lewisburg
>>> andres@awork3:~$ cat /sys/class/thermal/thermal_zone0/temp
>>> 58000
>>>
>>> And if I generate some load, it rises for both:
>>> root@awork3:~# ipmitool sdr|grep ^PCH
>>> PCH Temp | 60 degrees C | ok
>>> andres@awork3:~$ cat /sys/class/thermal/thermal_zone0/temp
>>> 60000
>>>
>> Thanks for the test.
>>
>> Rui can add his ACK.
>
> Ping? Looks like this got lost somewhere?
It does no longer apply, is it possible to do a respin ?
Thanks
-- Daniel
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH] thermal: intel_pch_thermal: Add PCI ids for Lewisburg PCH.
2020-11-12 11:34 ` Daniel Lezcano
@ 2020-11-13 20:49 ` Andres Freund
2020-11-14 18:41 ` Pandruvada, Srinivas
` (2 more replies)
2020-11-13 20:50 ` [PATCH] " Andres Freund
1 sibling, 3 replies; 14+ messages in thread
From: Andres Freund @ 2020-11-13 20:49 UTC (permalink / raw)
To: Daniel Lezcano
Cc: Andres Freund, Srinivas Pandruvada, Tushar Dave, Zhang Rui,
linux-pm, linux-kernel
I noticed that I couldn't read the PCH temperature on my workstation
(C620 series chipset, w/ 2x Xeon Gold 5215 CPUs) directly, but had to go
through IPMI. Looking at the data sheet, it looks to me like the
existing intel PCH thermal driver should work without changes for
Lewisburg.
I suspect there's some other PCI IDs missing. But I hope somebody at
Intel would have an easier time figuring that out than I...
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: Tushar Dave <tushar.n.dave@intel.com>
Cc: Zhang Rui <rui.zhang@intel.com>
Cc: linux-pm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Link: https://lore.kernel.org/lkml/20200115184415.1726953-1-andres@anarazel.de/
Signed-off-by: Andres Freund <andres@anarazel.de>
---
drivers/thermal/intel/intel_pch_thermal.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/thermal/intel/intel_pch_thermal.c b/drivers/thermal/intel/intel_pch_thermal.c
index 3b813ebb6ca1..7785e05f46f0 100644
--- a/drivers/thermal/intel/intel_pch_thermal.c
+++ b/drivers/thermal/intel/intel_pch_thermal.c
@@ -26,6 +26,7 @@
#define PCH_THERMAL_DID_CNL_H 0xA379 /* CNL-H PCH */
#define PCH_THERMAL_DID_CNL_LP 0x02F9 /* CNL-LP PCH */
#define PCH_THERMAL_DID_CML_H 0X06F9 /* CML-H PCH */
+#define PCH_THERMAL_DID_LWB 0xA1B1 /* Lewisburg PCH */
/* Wildcat Point-LP PCH Thermal registers */
#define WPT_TEMP 0x0000 /* Temperature */
@@ -276,6 +277,7 @@ enum board_ids {
board_skl,
board_cnl,
board_cml,
+ board_lwb,
};
static const struct board_info {
@@ -301,7 +303,11 @@ static const struct board_info {
[board_cml] = {
.name = "pch_cometlake",
.ops = &pch_dev_ops_wpt,
- }
+ },
+ [board_lwb] = {
+ .name = "pch_lewisburg",
+ .ops = &pch_dev_ops_wpt,
+ },
};
static int intel_pch_thermal_probe(struct pci_dev *pdev,
@@ -415,6 +421,8 @@ static const struct pci_device_id intel_pch_thermal_id[] = {
.driver_data = board_cnl, },
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCH_THERMAL_DID_CML_H),
.driver_data = board_cml, },
+ { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCH_THERMAL_DID_LWB),
+ .driver_data = board_lwb, },
{ 0, },
};
MODULE_DEVICE_TABLE(pci, intel_pch_thermal_id);
--
2.28.0.651.g306ee63a70
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH] thermal: intel_pch_thermal: Add PCI ids for Lewisburg PCH.
2020-11-13 20:49 ` Andres Freund
@ 2020-11-14 18:41 ` Pandruvada, Srinivas
2020-11-16 9:28 ` Daniel Lezcano
2020-11-24 9:36 ` [thermal: thermal/next] " thermal-bot for Andres Freund
2 siblings, 0 replies; 14+ messages in thread
From: Pandruvada, Srinivas @ 2020-11-14 18:41 UTC (permalink / raw)
To: daniel.lezcano, andres; +Cc: Zhang, Rui, linux-pm, linux-kernel
On Fri, 2020-11-13 at 12:49 -0800, Andres Freund wrote:
> I noticed that I couldn't read the PCH temperature on my workstation
> (C620 series chipset, w/ 2x Xeon Gold 5215 CPUs) directly, but had to
> go
> through IPMI. Looking at the data sheet, it looks to me like the
> existing intel PCH thermal driver should work without changes for
> Lewisburg.
>
> I suspect there's some other PCI IDs missing. But I hope somebody at
> Intel would have an easier time figuring that out than I...
>
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> Cc: Tushar Dave <tushar.n.dave@intel.com>
> Cc: Zhang Rui <rui.zhang@intel.com>
> Cc: linux-pm@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Link:
> https://lore.kernel.org/lkml/20200115184415.1726953-1-andres@anarazel.de/
> Signed-off-by: Andres Freund <andres@anarazel.de>
Reviewed-by: Pandruvada, Srinivas <srinivas.pandruvada@linux.intel.com>
> ---
> drivers/thermal/intel/intel_pch_thermal.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/intel/intel_pch_thermal.c
> b/drivers/thermal/intel/intel_pch_thermal.c
> index 3b813ebb6ca1..7785e05f46f0 100644
> --- a/drivers/thermal/intel/intel_pch_thermal.c
> +++ b/drivers/thermal/intel/intel_pch_thermal.c
> @@ -26,6 +26,7 @@
> #define PCH_THERMAL_DID_CNL_H 0xA379 /* CNL-H PCH */
> #define PCH_THERMAL_DID_CNL_LP 0x02F9 /* CNL-LP PCH */
> #define PCH_THERMAL_DID_CML_H 0X06F9 /* CML-H PCH */
> +#define PCH_THERMAL_DID_LWB 0xA1B1 /* Lewisburg PCH */
>
> /* Wildcat Point-LP PCH Thermal registers */
> #define WPT_TEMP 0x0000 /* Temperature */
> @@ -276,6 +277,7 @@ enum board_ids {
> board_skl,
> board_cnl,
> board_cml,
> + board_lwb,
> };
>
> static const struct board_info {
> @@ -301,7 +303,11 @@ static const struct board_info {
> [board_cml] = {
> .name = "pch_cometlake",
> .ops = &pch_dev_ops_wpt,
> - }
> + },
> + [board_lwb] = {
> + .name = "pch_lewisburg",
> + .ops = &pch_dev_ops_wpt,
> + },
> };
>
> static int intel_pch_thermal_probe(struct pci_dev *pdev,
> @@ -415,6 +421,8 @@ static const struct pci_device_id
> intel_pch_thermal_id[] = {
> .driver_data = board_cnl, },
> { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCH_THERMAL_DID_CML_H),
> .driver_data = board_cml, },
> + { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCH_THERMAL_DID_LWB),
> + .driver_data = board_lwb, },
> { 0, },
> };
> MODULE_DEVICE_TABLE(pci, intel_pch_thermal_id);
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH] thermal: intel_pch_thermal: Add PCI ids for Lewisburg PCH.
2020-11-13 20:49 ` Andres Freund
2020-11-14 18:41 ` Pandruvada, Srinivas
@ 2020-11-16 9:28 ` Daniel Lezcano
2020-11-21 0:46 ` Andres Freund
2020-11-24 9:36 ` [thermal: thermal/next] " thermal-bot for Andres Freund
2 siblings, 1 reply; 14+ messages in thread
From: Daniel Lezcano @ 2020-11-16 9:28 UTC (permalink / raw)
To: Andres Freund
Cc: Srinivas Pandruvada, Tushar Dave, Zhang Rui, linux-pm, linux-kernel
On 13/11/2020 21:49, Andres Freund wrote:
> I noticed that I couldn't read the PCH temperature on my workstation
> (C620 series chipset, w/ 2x Xeon Gold 5215 CPUs) directly, but had to go
> through IPMI. Looking at the data sheet, it looks to me like the
> existing intel PCH thermal driver should work without changes for
> Lewisburg.
>
> I suspect there's some other PCI IDs missing. But I hope somebody at
> Intel would have an easier time figuring that out than I...
>
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> Cc: Tushar Dave <tushar.n.dave@intel.com>
> Cc: Zhang Rui <rui.zhang@intel.com>
> Cc: linux-pm@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Link: https://lore.kernel.org/lkml/20200115184415.1726953-1-andres@anarazel.de/
> Signed-off-by: Andres Freund <andres@anarazel.de>
> ---
Applied, thanks
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] thermal: intel_pch_thermal: Add PCI ids for Lewisburg PCH.
2020-11-16 9:28 ` Daniel Lezcano
@ 2020-11-21 0:46 ` Andres Freund
0 siblings, 0 replies; 14+ messages in thread
From: Andres Freund @ 2020-11-21 0:46 UTC (permalink / raw)
To: Daniel Lezcano
Cc: Srinivas Pandruvada, Tushar Dave, Zhang Rui, linux-pm, linux-kernel
Hi,
On 2020-11-16 10:28:04 +0100, Daniel Lezcano wrote:
> On 13/11/2020 21:49, Andres Freund wrote:
> > I noticed that I couldn't read the PCH temperature on my workstation
> > (C620 series chipset, w/ 2x Xeon Gold 5215 CPUs) directly, but had to go
> > through IPMI. Looking at the data sheet, it looks to me like the
> > existing intel PCH thermal driver should work without changes for
> > Lewisburg.
> >
> > I suspect there's some other PCI IDs missing. But I hope somebody at
> > Intel would have an easier time figuring that out than I...
> >
> > Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> > Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> > Cc: Tushar Dave <tushar.n.dave@intel.com>
> > Cc: Zhang Rui <rui.zhang@intel.com>
> > Cc: linux-pm@vger.kernel.org
> > Cc: linux-kernel@vger.kernel.org
> > Link: https://lore.kernel.org/lkml/20200115184415.1726953-1-andres@anarazel.de/
> > Signed-off-by: Andres Freund <andres@anarazel.de>
> > ---
>
> Applied, thanks
Thanks for review and applying.
Greetings,
Andres Freund
^ permalink raw reply [flat|nested] 14+ messages in thread
* [thermal: thermal/next] thermal: intel_pch_thermal: Add PCI ids for Lewisburg PCH.
2020-11-13 20:49 ` Andres Freund
2020-11-14 18:41 ` Pandruvada, Srinivas
2020-11-16 9:28 ` Daniel Lezcano
@ 2020-11-24 9:36 ` thermal-bot for Andres Freund
2 siblings, 0 replies; 14+ messages in thread
From: thermal-bot for Andres Freund @ 2020-11-24 9:36 UTC (permalink / raw)
To: linux-pm
Cc: Daniel Lezcano, Srinivas Pandruvada, Tushar Dave, Zhang Rui,
linux-pm, linux-kernel, Andres Freund, amitk
The following commit has been merged into the thermal/next branch of thermal:
Commit-ID: e78acf7efebff9184ad4add02b62a1f486a8cde8
Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git//e78acf7efebff9184ad4add02b62a1f486a8cde8
Author: Andres Freund <andres@anarazel.de>
AuthorDate: Fri, 13 Nov 2020 12:49:16 -08:00
Committer: Daniel Lezcano <daniel.lezcano@linaro.org>
CommitterDate: Sat, 14 Nov 2020 19:44:39 +01:00
thermal: intel_pch_thermal: Add PCI ids for Lewisburg PCH.
I noticed that I couldn't read the PCH temperature on my workstation
(C620 series chipset, w/ 2x Xeon Gold 5215 CPUs) directly, but had to go
through IPMI. Looking at the data sheet, it looks to me like the
existing intel PCH thermal driver should work without changes for
Lewisburg.
I suspect there's some other PCI IDs missing. But I hope somebody at
Intel would have an easier time figuring that out than I...
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: Tushar Dave <tushar.n.dave@intel.com>
Cc: Zhang Rui <rui.zhang@intel.com>
Cc: linux-pm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Link: https://lore.kernel.org/lkml/20200115184415.1726953-1-andres@anarazel.de/
Signed-off-by: Andres Freund <andres@anarazel.de>
Reviewed-by: Pandruvada, Srinivas <srinivas.pandruvada@linux.intel.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20201113204916.1144907-1-andres@anarazel.de
---
drivers/thermal/intel/intel_pch_thermal.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/thermal/intel/intel_pch_thermal.c b/drivers/thermal/intel/intel_pch_thermal.c
index 0a9e445..32e1b28 100644
--- a/drivers/thermal/intel/intel_pch_thermal.c
+++ b/drivers/thermal/intel/intel_pch_thermal.c
@@ -28,6 +28,7 @@
#define PCH_THERMAL_DID_CNL_H 0xA379 /* CNL-H PCH */
#define PCH_THERMAL_DID_CNL_LP 0x02F9 /* CNL-LP PCH */
#define PCH_THERMAL_DID_CML_H 0X06F9 /* CML-H PCH */
+#define PCH_THERMAL_DID_LWB 0xA1B1 /* Lewisburg PCH */
/* Wildcat Point-LP PCH Thermal registers */
#define WPT_TEMP 0x0000 /* Temperature */
@@ -340,6 +341,7 @@ enum board_ids {
board_skl,
board_cnl,
board_cml,
+ board_lwb,
};
static const struct board_info {
@@ -365,7 +367,11 @@ static const struct board_info {
[board_cml] = {
.name = "pch_cometlake",
.ops = &pch_dev_ops_wpt,
- }
+ },
+ [board_lwb] = {
+ .name = "pch_lewisburg",
+ .ops = &pch_dev_ops_wpt,
+ },
};
static int intel_pch_thermal_probe(struct pci_dev *pdev,
@@ -479,6 +485,8 @@ static const struct pci_device_id intel_pch_thermal_id[] = {
.driver_data = board_cnl, },
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCH_THERMAL_DID_CML_H),
.driver_data = board_cml, },
+ { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCH_THERMAL_DID_LWB),
+ .driver_data = board_lwb, },
{ 0, },
};
MODULE_DEVICE_TABLE(pci, intel_pch_thermal_id);
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH] thermal: intel_pch_thermal: Add PCI ids for Lewisburg PCH.
2020-11-12 11:34 ` Daniel Lezcano
2020-11-13 20:49 ` Andres Freund
@ 2020-11-13 20:50 ` Andres Freund
1 sibling, 0 replies; 14+ messages in thread
From: Andres Freund @ 2020-11-13 20:50 UTC (permalink / raw)
To: Daniel Lezcano
Cc: Srinivas Pandruvada, Tushar Dave, Zhang Rui, linux-pm, linux-kernel
Hi,
On 2020-11-12 12:34:08 +0100, Daniel Lezcano wrote:
> It does no longer apply, is it possible to do a respin ?
Yep, sent.
Thanks,
- Andres
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2020-11-24 9:36 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-15 18:44 [PATCH] thermal: intel_pch_thermal: Add PCI ids for Lewisburg PCH Andres Freund
2020-01-16 8:08 ` Daniel Lezcano
2020-01-16 13:53 ` Srinivas Pandruvada
2020-01-16 18:42 ` Andres Freund
2020-01-16 19:41 ` Srinivas Pandruvada
2020-10-28 20:21 ` Andres Freund
2020-11-12 11:29 ` Daniel Lezcano
2020-11-12 11:34 ` Daniel Lezcano
2020-11-13 20:49 ` Andres Freund
2020-11-14 18:41 ` Pandruvada, Srinivas
2020-11-16 9:28 ` Daniel Lezcano
2020-11-21 0:46 ` Andres Freund
2020-11-24 9:36 ` [thermal: thermal/next] " thermal-bot for Andres Freund
2020-11-13 20:50 ` [PATCH] " Andres Freund
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.